path: root/sc/qa/unit/ucalc.cxx
AgeCommit message (Collapse)AuthorFilesLines
2017-05-03it's raining drawing layersprivate/hcvcastro/undo-row-commentEike Rathke1-0/+15
Change-Id: Ieee5cb5792535185ef09c3775072ed739fb0e4b0
2017-05-03sprinkle some drawing layers over test casesEike Rathke1-13/+36
... so things actually work like intended and creation of caption objects doesn't silently fail. Well, it does SAL_WARN or OSL_ENSURE but that's never displayed unless a test fails. Change-Id: Ibf4cc075cc3d6dadbe8f6208b2949310124b5749
2017-05-03less ugly ClosingClipboardSource()Eike Rathke1-2/+2
Change-Id: Ie53837e4dd5f779255eac25e090b23e49c3786ce
2017-05-03do not test for different caption pointers ...Eike Rathke1-1/+3
... if it's not guaranteed they may not be identical. Change-Id: Ieb4b0eb07a1b1832df65dde3c2e5a92b5121a162
2017-05-03this should be GetOrCreateCaption()Eike Rathke1-1/+1
... as the caption object has to be created after the note was pasted from a clipboard where the caption was forgotten.. Change-Id: I9b04f0146a7609ac44973dc181fa2ab6b11295b9
2017-05-03unit test for copying note from clipboard after closing orig doc, tdf#104967Eike Rathke1-0/+36
Change-Id: I165363eecbb37561d8265638415e0f5f069878d7
2017-05-03this should had been GetNote() and GetCaption()Eike Rathke1-2/+2
Not creating if there wasn't. Change-Id: I3e7a0d167e604b13674d24de18bd2bc7d3b36aa0
2017-05-03move ScDocShell de-/init related to getNewDocShell() and closeDocShell()Eike Rathke1-8/+19
In preparation for being able to handle two documents. Conflicts: sc/qa/unit/ucalc.cxx Change-Id: Ie7ea65136bcd6719031af6b1034d002058bfd81a
2017-05-03unit test for cell merge with note caption undo, tdf#105667Eike Rathke1-0/+21
Change-Id: Ib49e0f35aa554025634c8496fbb80d87dbc86d89
2017-04-12tdf#106252 Engineering notation for Precision as shownLaurent Balland-Poirier1-26/+79
with more tests Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> (cherry picked from commit 5f2db66ad0de6fbbae309850516e17eaa17934cb) Change-Id: Ifc77b847af4eaaa3c85e904e46c2663b6d768241 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Jenkins <> (cherry picked from commit 3c68b6520e743e8ed9afa908a461f766952e030f)
2017-04-12Tests for "Precision as shown" following tdf#105657 tdf#106052Laurent Balland-Poirier1-0/+103
I was unabled to add these test svl/qa/unit/svl.cxx because they required ScDocument::RoundValueAsShown() Found that other formats are not supported by "Precision as shown" option: - engineering tdf#106252 - thousand tdf#106253 Change-Id: Iaf98c404cabec0f5c69f94f2bf863351487fe9d7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> (cherry picked from commit 7496f7d3cae8a932dc43ede8a30a99289366a264) Reviewed-on: (cherry picked from commit e9d13f703f212b317682c35877571903da18b4af)
2016-11-04unit test for tdf#103684, calculate status bar function across sheetsEike Rathke1-0/+30
Change-Id: I8205cf56628b6b4d4b5d655386df994a9c02a1ad
2016-10-21CppunitTest_sc_ucalc: fix loplugin:cppunitassertequals warningsMiklos Vajna1-13/+13
Change-Id: Ie29cc49b98cb06f9b6a30b27d0c53f9393c28b67 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins <>
2016-10-20unit test for tdf#97968, Cut&Paste grouped references adjustmentEike Rathke1-0/+148
Change-Id: Id644012454d992c01ebcce6fe35d1dcdd1bc4d53
2016-10-12convert SC_MATVAL constants to typed_flags_setNoel Grandin1-8/+8
Change-Id: I973c5253b385a5495bec38201655e3dbcb9a6f81
2016-10-11loplugin:constantfunctionNoel Grandin1-1/+0
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-10-07Write test case for it.Kohei Yoshida1-0/+35
Change-Id: I63f8b5d490686f838c0618d670bb21a957690866
2016-10-07unit test for tdf#101562Eike Rathke1-0/+17
Change-Id: I4cf35e541875e89928d43b1f7e8392908c3ffb0b
2016-09-27OOPS, we were actually testing the wrong methodMarkus Mohrhard1-0/+13
Change-Id: I29adf81d3da56d7150e5182025d931ee62598e63
2016-09-23convert formula error codes to scoped enumNoel Grandin1-5/+5
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2016-09-18make sure that we are not trying to load the filter lib in ucalcMarkus Mohrhard1-0/+2
This casues crashes on exit as the ucalc lib loads the filter lib which is linked against the sclo lib. The sclo lib is statically linked into the ucalc code so that this causes the symbols to be two times in the program. Change-Id: I93e5a9b4dffa7c4b797ffef91b91f5f29f65348e
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke1-2/+2
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2016-08-21coverity#1371453 try silence Wrapper object use after freeCaolán McNamara1-4/+4
Change-Id: I707debb1dab694b3de2942e1c8b9a1bd7ec2d283
2016-08-19loplugin:countusersofdefaultparams in scNoel Grandin1-1/+1
Change-Id: I4052af7a19616d33c3c5fda9650d8fc4dff32256
2016-08-03Resolves: tdf#69539 UI rename CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERTEike Rathke1-1/+1
... with same syntax but different semantics that was even more confusing. Change-Id: Ibe1efcd5c4e82c9ce8d9fe8ed0f85e86dac327f7
2016-08-03UI rename DURATION to PDURATION, DURATION_ADD to DURATION, tdf#50488 relatedEike Rathke1-1/+1
Change-Id: I7ba783b59a711fc9c9d6bbe68dcf8c3c1a0d409d
2016-07-11loplugin:staticcallStephan Bergmann1-1/+1
Change-Id: Ie3f403560ddd9fcdf560b2705bf6b70be28d7d45
2016-07-11Add test for empty Calc doc defaultsslideon1-0/+72
Checking boolean values of many properties for an empty Calc doc. Change-Id: I54ab4975e65600db4362d94f421f40f794643938 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2016-07-04typo: emtpy → emptyChristian Lohmaier1-1/+1
Change-Id: I60cdcdc7fc38c175243c071f34295efa8739b717
2016-06-27tdf#100641 change UI name of EFFECTIVE to EFFECTEike Rathke1-1/+1
... to be the same as in other implementations and ODFF and OOXML. Change-Id: I754283b97e91c5e0f992d878096cf964a1244e04
2016-06-23Related: tdf#100460 GetNotesInRange doesn't count last cell in rangeCaolán McNamara1-0/+6
e.g. open document from tdf#100460 and select select A20:A21 and right click and there is a hide comment entry. Shrink the selection to just A20 (which has the comment in it) and the right click menu has no hide comment entry in it. std::for_each(it, itEnd means it < itEnd but here we want the rows indicated by nStartRow <= nEndRow so we need to increment itEnd by one to get the right range Change-Id: I48e8c0748f520671e09f04b16961bf9729960317
2016-05-25Convert SC_MF to scoped enumNoel Grandin1-1/+1
Change-Id: I3089006b502e33710bfb2564f051ebf2892ad08a Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-05-07nuke the old ucalc perf testingMarkus Mohrhard1-325/+0
We now have the real perf tests and converting this test seems quite complicated as it uses a lot of private symbols. If we really need these tests again we need to write them through some exported symbols. Change-Id: Idfb568e026d63d6784400c08a82c9a7a40039e00 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2016-05-04tdf#97831 [part] Add Excel 2016 functions to CalcWinfried Donkers1-0/+2
Functions MINIFS and MAXIFS Change-Id: I4bd2e8b82f8377af81f4373d0c33ac286588b8df Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2016-05-03tdf#97831 [part] Add Excel 2016 functions to CalcWinfried Donkers1-0/+2
Functions IFS and SWITCH. Change-Id: Ic43d42a933bcac883e9aa2213dd4ddeddf45abf0 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2016-04-26tdf#97831 [part] Add Excel 2016-Office 365 functions to CalcWinfried Donkers1-0/+2
Functions CONCAT and TEXTJOIN. Change-Id: I38092f77df719d11f6746ac10fe14dc53b7e93e7 Reviewed-on: Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-8/+8
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-04-22Avoid reserved identifiersStephan Bergmann1-2/+2
Change-Id: I782784f34975d708fdf179d098ce6654aad7a976
2016-04-05Resolves: #i126901# CSV import: values with + or - followed by...Damjan Jovanovic1-1/+3
thousand separator and 3 digits (eg. +,123) are imported as a number Do not allow numbers parsed from CVS files when "Detect special numbers" is off, to contain thousand separators before digits, even if after a +/- sign (eg. -,123 or +,789). Treat these as strings instead. Also added unit tests for this. Patch by: me (cherry picked from commit 10458a24f4e6cc311e65fb80ce576fed39937be2) Change-Id: Ic946fc6a11326861f238157ddb651bc5a5b28edd
2016-03-24loplugin:constantparam in scNoel Grandin1-15/+15
Change-Id: I8608a6cb47972e9b838cc5ea431863348758ded0
2016-03-23loplugin:constantparam in scNoel Grandin1-7/+7
Change-Id: I437367b8c6960db730a69c020ba82792a9170d01
2016-03-22tdf#84938 replace #define with scoped typed_flagsJochen Nitschke1-1/+2
'RangeType' becomes 'Type', goes into ScRangeData and is strongly typed now. This revealed a misuse of RangeType in vbanames.cxx where the uno equivalent was expected, but it had no impact because both values were 0. Change-Id: I0b4764d1411c709a1faa243ec70afeb160410990 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Noel Grandin <>
2016-03-21unit test for copying cells within named range, tdf#93127Eike Rathke1-0/+21
Change-Id: I7bf6cd1c328e1d6eda5b67f05ec4870efe001b68
2016-03-19adjust sheet references when copying sheet-local named expressionsEike Rathke1-12/+44
... so references to the local sheet point to the new scope's local sheet and not to the originating sheet. Change-Id: I7f33f4e9b379ec01d6c2587e92ffe851892fc32d
2016-03-18unit test for other-sheet-local names, tdf#96915Eike Rathke1-0/+26
Change-Id: Iee3edb4603830a4912cda5c1f16029560be04857
2016-03-12fix memory leak in ucalcMarkus Mohrhard1-4/+3
Change-Id: Iad38472638438eb52e9e46be0a284adbb8ccb689 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2016-03-12fix memory leak in ucalc testMarkus Mohrhard1-3/+3
Change-Id: I5b0f12020eed953b73f1f1b2f867b33172073487 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2016-03-12tdf#84938 Change defines to typed_flagsJochen Nitschke1-1/+1
Put defines into an enum class and use typed_flags template from o3tl to give them flag operators. There were some shift operations to apply flags from start references to end references, these went into a helper in address.hxx to hide them. A marco with shift operations in address.cxx was rewritten in two helpers without shifts. One shift remained in ScRange::Format with a comment. The other flag untypical operator was a minus 1 in a helper for ScRefFinder::ToggleRel, which iteratates through all possible combinations for absolute references. This is used to make referecnces absolute via SHIFT+F4. A replacement would be too complex. Change-Id: I4850f1623e01e56c60ac2260b95fc5cad8b6fd71 Signed-off-by: Jochen Nitschke <> Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Eike Rathke <> Tested-by: Eike Rathke <>
2016-03-05tdf#98264, use DOUBLE_ASSERT_EQUAL for double comparisonAleksas Pantechovskis1-11/+11
Change-Id: I590dcf408163e2470ee387f0394f6daa1145da49 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>
2016-03-05tdf#98264, replace CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUALAleksas Pantechovskis1-215/+235
Change-Id: Ieae48c6a2b611d853f2320e27d5836d8c5dbedfb Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Markus Mohrhard <>