summaryrefslogtreecommitdiff
path: root/sc/inc
AgeCommit message (Collapse)AuthorFilesLines
2014-12-18resolved fdo#87237 propagate error values through matrix comparisonsEike Rathke1-1/+1
Apparently introduced with 8e8b43a03e77dd251876c1de0ac06eeeb09192cd the comparison results were stored as boolean values, effectively discarding any infinite double values and error values encoded as NaN values. (cherry picked from commit 3c405ff82fcc9f8f044833420485c54658064636) Change-Id: I1fb6f46894a0bee02a37e28b7e6cc84f8c051f28
2014-12-08we need the SdrPage for deleting the notes, fdo#86166Markus Mohrhard1-0/+1
The SdrPage that contains the shapes for the note captions is deleted before the notes. Prevent that case by deleting the notes before deleting the SdrPage. Change-Id: I13727cea7df0b033fb386a6a8e20dcadec743335
2014-12-03fdo#86762 re-establish listeners to move cell broadcastersEike Rathke4-4/+20
... for UpdateReferenceOnSort=false (cherry picked from commit 6c2111f17089eb667bf526561d7667d17825e822) Conflicts: sc/source/core/data/table3.cxx fdo#86762 broadcast also empty cells after sort (cherry picked from commit 08793e08c7e9cefe594c49130f782725e386c463) Conflicts: sc/inc/column.hxx sc/source/core/data/column.cxx sc/source/core/data/document.cxx sc/source/core/data/table2.cxx sc/source/ui/docshell/dbdocfun.cxx fdo#86762 re-establish listeners on moved broadcasters ... also in SortReorderByColumn() similar to SortReorderByRow() (cherry picked from commit e119f3883513aeaa49f332362620e955dc8b453f) Conflicts: sc/source/core/data/table3.cxx e275a754c530d6039ed14304900dd71416f36e46 7665dcc90d70fcf3b08bef0adb9ab6aaff1cdcdf Change-Id: Id90288660e317d6e47ee01ee3b5ff9058cfa18df Reviewed-on: https://gerrit.libreoffice.org/13275 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-26fix fdo#79441 again and keep references to other sheets during sortEike Rathke1-0/+6
... also if other references are not updated. References to other sheets are never to be treated as relative during sort, they are always absolute, even if they have relative row/column part references. Broken again during the big sort mess. Even if there was a unit test, which didn't help as it got disabled / adapted to the change.. (cherry picked from commit f0e7364603c9566bc158303c515c3274ccba62ca) Backported. Change-Id: Ic0e61c5e1cb0728e20725c29e450ab0eb55c3305 Reviewed-on: https://gerrit.libreoffice.org/13118 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-11-20fdo#83765 do not update references in SortReorderByColumn() if disabledEike Rathke1-5/+7
Similar to SortReorderByRow() (cherry picked from commit 115a4b7ca36f65d93070d2e81048320d202e87a3) Conflicts: sc/inc/column.hxx Change-Id: I11dd710c00a56a5f56aeb048fa2258631555a220
2014-10-17fdo#81633: Add a hidden configuration option to toggle ref update on sort.Kohei Yoshida5-3/+15
This option is defaulted to off for 4.3 for back-compatibility. Reviewed-on: https://gerrit.libreoffice.org/11902 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Conflicts: sc/inc/inputopt.hxx sc/qa/unit/ucalc.cxx sc/source/core/tool/inputopt.cxx Change-Id: I5ac686e96742df40f7d8ba5ffec23806db2988a6
2014-09-09fix indentationMarkus Mohrhard1-4/+2
Change-Id: I0ca8c236fe1f9ede0a3fea6de0a76aaf712e3ff1
2014-08-23correct references after sort, fdo#79441cp-4.2-8Eike Rathke1-0/+8
5c6ee09126631342939ae8766fe36083d8c011e3 introduced a different algorithm for reference handling during sort. Unfortunately that clashed with the SC_CLONECELL_ADJUST3DREL introduced a little earlier resulting in relative 3D references effectively being "adjusted" twice. Furthermore, in-sort-range range references to one row (or column) were not adapted to the move at all if the formula within the range listened only to ranges and not a single cell. Added collecting and adjusting area listeners for this. Last but not least, external (relative) references need to be treated the same as internal 3D references, making them point to the same location after the sort. (cherry picked from commit 69adec3ec051ff94f600ab899506ca9d645a8b56) Conflicts: sc/inc/types.hxx sc/source/core/data/bcaslot.cxx Plus necessary parts of 27182231acd3a0c9898a8dba78b76dc8a827b4c0 related to bcaslot changes. Change-Id: I492768b525f95f1c43d1c6e7a63a36cce093fa5a Reviewed-on: https://gerrit.libreoffice.org/10930 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-08-21fdo#80501: Ensure that we notify each listener only once.Kohei Yoshida2-5/+1
Change-Id: If2ce4643ff58c7c2ba326d749698dd5196a108dc (cherry picked from commit b2ee0235e88dc4da715b5766295ed88f27974fbd) Reviewed-on: https://gerrit.libreoffice.org/10647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-08-21fdo#79578: Properly update formulas upon change in db collection.Kohei Yoshida4-11/+10
Update it to handle formula groups correctly. (cherry picked from commit 300845922eec7a28bc1da337acd21f138685d759) Conflicts: sc/source/ui/docshell/dbdocfun.cxx sc/source/ui/docshell/docfunc.cxx sc/source/ui/docshell/docsh5.cxx sc/source/ui/undo/undocell.cxx sc/source/ui/undo/undodat.cxx sc/source/ui/unoobj/nameuno.cxx sc/source/ui/view/viewfunc.cxx sc/source/ui/view/dbfunc.cxx Change-Id: I009a7fcf3d3fb17ef6951c50534ca6bc1fffc259 Reviewed-on: https://gerrit.libreoffice.org/10605 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-08-21fdo#81617: Split formula groups at sort range boundaries.Kohei Yoshida1-0/+1
Otherwise, partially sorting a range may crash, or at best incorrectly update formula references. Change-Id: Iefcb86d205d83ccc5b684048bfd9aadabf6e13eb (cherry picked from commit a3fc7f20089062afa4f778e70ba8be84032a30a7) Reviewed-on: https://gerrit.libreoffice.org/10583 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-07-18bnc#885548: Adjust xlsx export of revisions to get it to work in Excel.Kohei Yoshida1-0/+1
(cherry picked from commit fa44673e154ed4fb0b518b8850e2f6e4b9069531) Conflicts: sc/source/filter/inc/XclExpChangeTrack.hxx sc/source/filter/xcl97/XclExpChangeTrack.cxx sc/inc/cellvalue.hxx sc/source/core/data/cellvalue.cxx Change-Id: I0058d9ddfea545390e615a3030171a366e333c85
2014-07-18bnc#885548: Initial work on importing revisions from xlsx.Kohei Yoshida1-1/+1
Change-Id: Ie0528490d024093cbabf38541fe70be96a9caa2e (cherry picked from commit b92fdaa1a40bd54d279b4ac2faf19bf15468cc2f)
2014-07-14Preserve the "end of list" flag for xls round-tripping.Kohei Yoshida1-10/+16
This "end of list" flag determines whether the row insertion was an automatic insertion at the bottom. Calc doesn't use this at the moment but Excel uses it to differentiate a normal row insertion from an automatic one. (cherry picked from commit adf0d7b1fb8eed88f4fcd6d31662ae6f59d00812) Conflicts: sc/inc/chgtrack.hxx sc/source/filter/xcl97/XclExpChangeTrack.cxx Change-Id: I6b28669d816c54d1dc1e4c106918ba688415788d
2014-07-14fdo#81309: Adjust references during sort.Kohei Yoshida11-23/+210
(cherry picked from commit 5c6ee09126631342939ae8766fe36083d8c011e3) Conflicts: sc/inc/sortparam.hxx sc/source/ui/docshell/dbdocfun.cxx sc/source/ui/undo/undodat.cxx sc/inc/formulacell.hxx sc/qa/unit/filters-test.cxx sc/qa/unit/ucalc.cxx sc/source/core/data/documen3.cxx sc/source/ui/docshell/dbdocfun.cxx Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-14resolved fdo#79441 keep 3D references intact during sortEike Rathke1-1/+1
Change-Id: I9e96d8e7cb99a3c280dd24495eefb9efd6d10888 (cherry picked from commit e463de2a56453a0d2cb0b5b58e96f7639f37cdd1) Reviewed-on: https://gerrit.libreoffice.org/10240 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-02bnc#812796: Correctly handle static value array for OOXML charts.Kohei Yoshida1-0/+4
We need to pass the role of the data sequence in order to avoid unreliable guess work when importing static value array. Also, not all Excel's scatter plots have real numeric X values; some have textural X values in which case Excel switch to generating 1, 2, 3, ... as X values. When importing to our chart implementation, using "categories" role in such cases instead of "values-x" results in a more faithful chart rendering. (cherry picked from commit 6c4e21a234f12e1310ba06f9859e08b424acf8bf) Conflicts: chart2/source/inc/InternalDataProvider.hxx chart2/source/tools/InternalDataProvider.cxx Conflicts: chart2/source/inc/InternalDataProvider.hxx dbaccess/source/core/inc/DatabaseDataProvider.hxx dbaccess/source/core/misc/DatabaseDataProvider.cxx sc/source/filter/inc/excelchartconverter.hxx Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida3-2/+11
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Conflicts: xmloff/source/chart/SchXMLExport.cxx sd/source/ui/view/sdview3.cxx chart2/source/controller/chartapiwrapper/WrappedNumberFormatProperty.cxx chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx chart2/source/controller/main/ChartTransferable.cxx chart2/source/controller/main/ChartTransferable.hxx chart2/source/model/main/Axis.cxx chart2/source/model/template/ChartTypeTemplate.cxx chart2/source/tools/AxisHelper.cxx chart2/source/view/main/ChartView.cxx comphelper/source/container/embeddedobjectcontainer.cxx dbaccess/source/ui/browser/dbexchange.cxx dbaccess/source/ui/inc/JoinExchange.hxx dbaccess/source/ui/inc/TableRowExchange.hxx dbaccess/source/ui/inc/dbexchange.hxx dbaccess/source/ui/querydesign/JoinExchange.cxx dbaccess/source/ui/tabledesign/TableRowExchange.cxx embeddedobj/source/commonembedding/persistence.cxx embeddedobj/source/inc/commonembobj.hxx include/comphelper/embeddedobjectcontainer.hxx include/svtools/embedtransfer.hxx include/svtools/stringtransfer.hxx include/svtools/transfer.hxx include/svx/dbaexchange.hxx include/svx/dbaobjectex.hxx include/svx/fmview.hxx include/svx/galmisc.hxx include/svx/svdobj.hxx include/svx/svdoole2.hxx include/svx/svdxcgv.hxx include/svx/view3d.hxx include/svx/xmlexchg.hxx include/xmloff/xmlexp.hxx reportdesign/source/ui/dlg/GroupExchange.cxx reportdesign/source/ui/dlg/GroupExchange.hxx reportdesign/source/ui/inc/dlgedclip.hxx reportdesign/source/ui/report/dlgedclip.cxx sc/inc/column.hxx sc/source/ui/app/drwtrans.cxx sc/source/ui/app/lnktrans.cxx sc/source/ui/app/seltrans.cxx sc/source/ui/app/transobj.cxx sc/source/ui/inc/drwtrans.hxx sc/source/ui/inc/lnktrans.hxx sc/source/ui/inc/seltrans.hxx sc/source/ui/inc/transobj.hxx sc/source/ui/inc/viewfunc.hxx sc/source/ui/view/viewfun5.cxx sc/source/ui/view/viewfun7.cxx sd/source/ui/app/sdxfer.cxx sd/source/ui/dlg/sdtreelb.cxx sd/source/ui/inc/TabControl.hxx sd/source/ui/inc/View.hxx sd/source/ui/inc/sdtreelb.hxx sd/source/ui/inc/sdxfer.hxx sd/source/ui/view/sdview2.cxx sd/source/ui/view/tabcontr.cxx sfx2/source/doc/objxtor.cxx svtools/source/misc/embedtransfer.cxx svtools/source/misc/stringtransfer.cxx svtools/source/misc/transfer.cxx svtools/source/misc/transfer2.cxx svx/source/engine3d/view3d.cxx svx/source/fmcomp/dbaexchange.cxx svx/source/fmcomp/dbaobjectex.cxx svx/source/fmcomp/xmlexchg.cxx svx/source/form/fmexch.cxx svx/source/form/fmview.cxx svx/source/gallery2/galmisc.cxx svx/source/inc/fmexch.hxx svx/source/svdraw/svdoole2.cxx svx/source/svdraw/svdxcgv.cxx svx/source/tbxctrls/colrctrl.cxx sw/source/core/uibase/dochdl/swdtflvr.cxx sw/source/core/uibase/inc/swdtflvr.hxx sw/source/core/undo/unins.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-12fdo#77506: More reliable way to determine label strings.Kohei Yoshida1-0/+2
Not beautiful, but doable. (cherry picked from commit a2a1a59a448420a858724371c4a339f75ebe8c1e) Conflicts: sc/source/ui/unoobj/chart2uno.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: I6f3b00d620e7d7d19cc05ec4239deeb14d0d5201
2014-06-10Try not to use ScDocument as a "anything can go in" storage place.Kohei Yoshida1-11/+0
There are things that shouldn't be stored in ScDocument believe it or not. Change-Id: I6a06327549851fae0fdc0defbc716285d8456aa2
2014-06-10Integrate branch of IAccessible2Steve Yin5-1/+43
Conflicts: everything Change-Id: I3d8cf956f511a0d953a1cefe83b6ef987806da25
2014-06-02fdo#79011: Properly implement the search results dialog as modeless.Kohei Yoshida1-0/+1
It's unfortunate that adding a modeless dialog is such a pain. But we still need to implemenet this properly else we'll leak at best, or end up with tons of weird bugs at worst. (cherry picked from commit 81c492ef18b04cc283561018d69818cbca7f83ef) Conflicts: sc/inc/sc.hrc sc/sdi/cellsh.sdi sc/sdi/scalc.sdi sc/source/ui/view/cellsh1.cxx sc/source/ui/view/tabvwsh.cxx Reviewed-on: https://gerrit.libreoffice.org/9451 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Conflicts: sc/source/ui/view/cellsh1.cxx Change-Id: Ie03260f288fad76f994d0ca6a8b1feeade299ffd
2014-05-21cp#1000072: Improve on-load updates of external links.Kohei Yoshida7-13/+67
* Load all linked external sources up front, rather than on-demand after the cache purge. * Try to pre-populate updated caches rather than leaving them blank and wait until it gets filled during formula calculation. * Disable polling of stale doc shell instances while the update is on-going. This improves the update performance especially when the update takes a long time. * Only close one doc shell instance at a time, even when there are multiple stale doc shell instances that need to be closed, to prevent too long of a pause. * Show progress bar during the update to give the user some visual feedback of the progress. * Skip loading of styles for the linked external document shells. We don't need them. For now, this is ODS only. * Minor performance improvement of ODS import. Conflicts: include/sfx2/sfxmodelfactory.hxx sc/inc/sc.hrc sc/inc/xmlwrap.hxx sc/source/core/data/documen8.cxx sc/source/filter/xml/xmlimprt.cxx sc/source/filter/xml/xmlwrap.cxx sc/source/ui/docshell/docsh.cxx sfx2/source/doc/objxtor.cxx Change-Id: I80aa71fa27e4960e9256253369aa898dd542c9b5
2014-05-09resolve fdo#77509 memory corruption / crash in ConsolidateEike Rathke1-4/+3
Regression introduced with c81dec478ab0618f2acd2580654a93d3a7185444 memcpy some sizeof(OUString) is doomed to fail. Change-Id: I81dc9cc7eaf02607ed05b4d284a7e5e462eeeb0a (cherry picked from commit e891afeccba8f20f8bdaeacb20f2215cfcb1abfd) Reviewed-on: https://gerrit.libreoffice.org/9282 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-05-09fdo#78062: Broadcast only on non-empty cells within deleted range.Kohei Yoshida1-0/+8
We don't want to broadcast over the whole selected range, which may be the whole sheet which is well over 1 billion cells ! (cherry picked from commit af7df25bcc8bc95462e2b3bf8c003d035111a479) Conflicts: sc/source/ui/inc/undobase.hxx sc/source/ui/undo/undobase.cxx Change-Id: I7c139ce5efe09312cf824e35f0efe551184032eb Reviewed-on: https://gerrit.libreoffice.org/9240 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-09fdo#77990: Intern strings for hybrid strings during import.Kohei Yoshida2-2/+2
Change-Id: I269497cac645e486ac08bb2b011df1b5b23dc021 (cherry picked from commit 1899bd0c3b8a16ede2de0125e762b23ba013d81f) Reviewed-on: https://gerrit.libreoffice.org/9264 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-09fdo#78054: Initialize drawing layer when the document contains notes.Kohei Yoshida1-4/+5
Don't be fooled even when the document doesn't have a drawing layer initialized. Sometimes a note creates caption on demand later, but if the drawing layer isn't there the caption will not get created, which ultimately causes this crash. (cherry picked from commit fe451fb94a33c914c0a7c1265c013d9704af850a) Conflicts: sc/inc/document.hxx Change-Id: I37f4902fa84de91c9f793dc352127d9345a725e3 Reviewed-on: https://gerrit.libreoffice.org/9254 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-09fdo#78079: Re-work sort by column to get it to do the right thing.Kohei Yoshida6-15/+74
Also fixed reference update problem. (cherry picked from commit 3c4fb52d8fc89fe43983991ed2339295b2e0ef8c) Conflicts: sc/inc/column.hxx Change-Id: I06e6115ef969a011fdd5c92d5eb1927fb7ae789b Reviewed-on: https://gerrit.libreoffice.org/9220 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-09fdo#77806: Use the common block position set for start and end listening.Kohei Yoshida1-2/+5
Else an invalid iterator may result, which would eventually leads to a crash. Change-Id: Ie909de61244d661c72a3450cc69b29fbb218a248 (cherry picked from commit 7fbe0f56192f7e106c560646d37fbb93b69b0446) Reviewed-on: https://gerrit.libreoffice.org/9225 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-02Implement "fill single edit" mode and map it to Ctrl-' by default.Kohei Yoshida2-1/+2
Excel does this apparently, and lots of people want it. Conflicts: sc/inc/scmod.hxx sc/sdi/scalc.sdi Change-Id: Ia741ebb84526197d28caa323d36709e38b8f1323
2014-05-01add undo action for conditional formatting, cp#1000050, fdo#77381Markus Mohrhard1-1/+3
Conflicts: sc/inc/globstr.hrc sc/source/ui/src/globstr.src Change-Id: I11db1e5824077135c4352ae43cc0e8d139244268
2014-05-01fdo#75058: Optimize autofilter item filling for non-tree items.Kohei Yoshida1-1/+4
(cherry picked from commit 878a5dabff4669fb606a461e11eaf286d0c8b07f) (cherry picked from commit 0b03f7ed575838f90e6b1ebec3538a3a214f81fb) Conflicts: sc/source/ui/cctrl/checklistmenu.cxx sc/source/ui/inc/checklistmenu.hxx Change-Id: I1b3ae601726401a0e70fb1a05b9a90c43773794c Reviewed-on: https://gerrit.libreoffice.org/9211 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-05-01fdo#77728: Don't forget to start listening after the named range update.Kohei Yoshida2-2/+4
Change-Id: I7a4160db0dd2b9ac2c98402bb6110c548e879b3d (cherry picked from commit 36e0d770928f71c932db5dea9f04645f65222ea6) Reviewed-on: https://gerrit.libreoffice.org/9156 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-04-30fdo#76611: Wrap reference addresses at max boundaries.Kohei Yoshida1-0/+2
When importing shared formula tokens. Change-Id: I7e1a05a78c3a93330476516e0459cffb668e3f66 (cherry picked from commit c6c286f14468d341f5fd88edc39a37175a1b6caa) Reviewed-on: https://gerrit.libreoffice.org/9167 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-04-30fdo#72741, fdo#76607: Backport of Calc sort rework.Kohei Yoshida6-5/+170
This change requires mdds 0.10.3 as the baseline. Conflicts: configure.ac sc/inc/fstalgorithm.hxx sc/source/core/data/column.cxx sc/source/core/data/table3.cxx sc/source/ui/docshell/dbdocfun.cxx Change-Id: Ia6d2bf1ee17e96c30b6d5310f5c49e5a4404e094 Reviewed-on: https://gerrit.libreoffice.org/9144 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-04-22missing header includeMarkus Mohrhard1-0/+2
Change-Id: I5bb1f1f5a457d4d390318fc793b15df078423c8c
2014-04-22fdo#75665: Truncate string when clipped on screen.Kohei Yoshida1-0/+9
This improves performance of text layouting by HarfBuzz for very long strings. HarfBuzz's layout algorithm appears to be more expensive than ICU's. (cherry picked from commit 087a79db1272858f107656c5ca3c6efb45680986) (cherry picked from commit 6fa4d31d6a7e363285f22d4c0012521d10073652) (cherry picked from commit 8e50a6c7b1cb9481cce42c71ff07e921fb4292d0) (cherry picked from commit 21fc47e115530780ad45ae64e8076dc5e9fedb5e) Conflicts: sc/inc/scopetools.hxx sc/source/core/tool/scopetools.cxx sc/source/ui/view/output2.cxx Change-Id: Ic9738b7b8f0f1a29c51c83b147763118939b90ef Reviewed-on: https://gerrit.libreoffice.org/9057 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-04-16fdo#76409: Write output cell string to <text:p> element when saving to ods.Kohei Yoshida1-0/+3
The change was made by accident. Change-Id: Ife2461b0fca6e3ea5a65d72d985d1e0976737b5a (cherry picked from commit a0752fa4246dc71b64907c679657a1af3cb617e1) Reviewed-on: https://gerrit.libreoffice.org/9014 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-04-16fdo#76294: Properly intern string literals in formula on xls import.Kohei Yoshida1-1/+4
(cherry picked from commit b09426b83c12b0cd27cd909602251cb076ffa4ba) (cherry picked from commit 625c595fc30d2e6153735dc2ed2359ff4f8a1e3a) (cherry picked from commit 6bb7fa8df523d3ae7b9945009fb1034f28cb0a0a) Conflicts: formula/source/core/api/token.cxx include/formula/tokenarray.hxx sc/source/filter/excel/excform.cxx sc/source/filter/excel/excform8.cxx sc/source/filter/excel/frmbase.cxx sc/source/filter/inc/XclImpChangeTrack.hxx sc/source/filter/inc/lotform.hxx sc/source/filter/inc/qproform.hxx sc/source/filter/lotus/lotform.cxx sc/source/filter/lotus/lotimpop.cxx sc/source/filter/lotus/op.cxx reportdesign/source/ui/inc/Formula.hxx Change-Id: Icf962a4363887f323da6d2bdf935a027df3319fa Reviewed-on: https://gerrit.libreoffice.org/9008 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-04-16fdo#77209: Share string pool with clip documents.Kohei Yoshida1-0/+1
We do the same with undo documents, and it will only make sense to do the same with clip documents as well. Also, put the sharing part into a common method (for ease of tracking). (cherry picked from commit 8f403051968298fbabd61de82fbb6a77762c83cc) Conflicts: sc/inc/document.hxx Change-Id: I342b22d95374ee06d16318a66ffea0ac5b42621c Reviewed-on: https://gerrit.libreoffice.org/9005 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-04-16fdo#75741: Re-implement CompileNameFormula for formula groups.Kohei Yoshida5-4/+53
(cherry picked from commit 355baf573425165cbc1c789a6271eb29940e1f76) (cherry picked from commit 615f6aa293a6da90da94e6e78828198ffbc0ca5e) Conflicts: sc/inc/document.hxx sc/source/core/data/column4.cxx sc/source/core/data/document10.cxx sc/source/core/data/table7.cxx sc/source/ui/docshell/docfunc.cxx sc/source/ui/undo/undocell.cxx sc/source/ui/unoobj/nameuno.cxx Change-Id: I57e1e464ac5f7abc10ce5ea5752e036ddb6cf6d7 Reviewed-on: https://gerrit.libreoffice.org/8889 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2014-03-26fdo#74322: Handle moving of named ranges correctly.Kohei Yoshida1-0/+2
But named ranges are adjusted if and only if the references are absolute. Change-Id: I6c5287b413884b045f1a798c6c6683aa17863f24 (cherry picked from commit 003a27a14d5cf65fe0b528b6d6015e37a64dbb8e) Reviewed-on: https://gerrit.libreoffice.org/8756 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-03-26fdo#76470: Avoid joining new formula cells individually.Kohei Yoshida3-0/+7
Instead, insert the formula cells in the group first, then only try to join the top and bottom cells afterward. Otherwise the grouping would get messed up and a problem would ensue. (cherry picked from commit 474b2ea601f7fa2f1fbeae0f169ff5b8abc965be) Conflicts: sc/inc/column.hxx Change-Id: I4fdd5326c029032a636d8225b5fb16cbde427c7d Reviewed-on: https://gerrit.libreoffice.org/8716 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-25Disable kernel pre-compilation for now.Kohei Yoshida1-0/+4
Change-Id: I8ba765a4d89618f301572c5fd9931f86d87af10d (cherry picked from commit 5d4f525da7f560f85c2ce18f1ca1570d3cc53a50) (cherry picked from commit e0d936ef7b7fd6b57cdd5ccadddcbd84bd4bb359) Reviewed-on: https://gerrit.libreoffice.org/8680 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-25fdo#71491: Adjust reference during undo of drag-n-drop of cell range.Kohei Yoshida13-9/+136
Also with this commit, the signature of SvtListener::Notify() changes, by dropping the first argument which nobody uses. This change was necessary in order to call it directly without needing to pass any broadcaster instance. (cherry picked from commit 88955714d345d8584e86ae34bf5f5d1f3f4af9f7) (cherry picked from commit 99809b246c5dd2be548668032fac4f3c65fb962a) (cherry picked from commit 8b368d808e90561a9b34658e6b811a8fad83088f) (cherry picked from commit 83ee6b640eaf86f9aef6f42a4dd9c8a930cf9135) Conflicts: sc/inc/table.hxx sc/source/core/data/table2.cxx sc/source/ui/undo/undoblk.cxx svl/source/notify/broadcast.cxx Change-Id: I6a1e97f0fb1e070d1d8f7db614690b04c9e8024e Reviewed-on: https://gerrit.libreoffice.org/8600 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-03-25fdo#75977: Clear sheet deleted flags for affected references when undoing.Kohei Yoshida5-5/+35
This will allow formula cells to restore deleted references when they get recalculated. With this change, SetDirty() that previosly took no argument has been renamed to SetAllFormulasDirty(), and it now takes one argument that stores context information. (cherry picked from commit 18909ddb30db7ca9416ee2bfb0503753e877f002) Conflicts: sc/inc/document.hxx sc/source/ui/docshell/docsh5.cxx sc/source/ui/view/spelldialog.cxx Change-Id: If0de5dc1737a2722b6d61a87644b10a4f921edc5 Reviewed-on: https://gerrit.libreoffice.org/8564 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-25Various fixes (memory leak & crash) in the OpenCL interpreter code.Kohei Yoshida3-6/+14
Pre-compiling of OpenCL kernel is disabled with this change. (cherry picked from commit b981c089a9194f33b46272e3f4efa117241ea533) (cherry picked from commit e253d46af3b47afd0006084bec89b02473ee457a) (cherry picked from commit 0d7f89b021f1354a0fa607862296b11c9fd8a4dd) (cherry picked from commit 5325137783825c498ed4236080ed7fe51cdec09a) (cherry picked from commit 20ed6886ade81ee015a22b2eb3aeff64691971bf) (cherry picked from commit 7a0ed3a406bd14bb2b52c383282daf4777ba76e0) Conflicts: sc/source/core/data/formulacell.cxx Change-Id: Iae97f4f877c329f443c7d222c6a2016678af2387 Reviewed-on: https://gerrit.libreoffice.org/8496 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-03-25fdo#67104 Use correct command for show gridMaxim Monastirsky1-2/+1
Not sure why .uno:ViewGridLines & SID_SCGRIDSHOW were introduced (in "merge sidebar feature" and related commits). Reviewed-on: https://gerrit.libreoffice.org/8459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit c3403ac888c2e62edaf8befe7982f5f8cc95c16f) Conflicts: sc/sdi/scalc.sdi sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx Change-Id: I90bdfaef86adcbfa44129b8f7f9df61ca7f35114 Reviewed-on: https://gerrit.libreoffice.org/8463 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-03-07Fix incorrect group calc state check.Kohei Yoshida1-0/+3
And the code in the else block is pretty dangerous as it passes an empty token array to the group interpreter whose effect is entirely unpredictable. Also, declare the destructor of CompiledFormula class to be virtual as it serves as a base class for DynamicKernel. Change-Id: I4e191550a4437ad6ebac55fcdeee4f3654722ff1 (cherry picked from commit 95637452609260c97d8e5aaa7500531bb458a8bc) Reviewed-on: https://gerrit.libreoffice.org/8468 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-07Build fix for OSX.Kohei Yoshida1-0/+2
Change-Id: I63613c40a5a947625c449fcd52ca129af116c900
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-07 16:00:52 +0000