summaryrefslogtreecommitdiff
path: root/sax
AgeCommit message (Collapse)AuthorFilesLines
2014-10-23FastSerializer: Use faster TokenValue struct when possibleMatúš Kukan3-13/+58
Saves another ~100m pcycles for 650k calls in startElementInternal() Change-Id: I190326edc7feffb900e91fa7e5c3530b5b267f59
2014-10-23FastSerializer: Simplify cache to be fixed sized bufferMatúš Kukan1-33/+13
This makes writeBytes(), which is called a lot, simpler and thus faster. E.g. for ~15m calls, this saves ~110m pcycles. Change-Id: I29d01a1a8651f668aff574e0f015cd2f018eb1cd
2014-10-23This was OString already; use it that wayMatúš Kukan1-5/+4
Change-Id: Ia2268ce8a1e2111adb609c515e5bfa824afa66ce
2014-10-23FastSerializer: Have own fast cache buffer implementation for XOutputStreamMatúš Kukan3-22/+115
Previously comphelper::OSequenceOutputStream was used. Change-Id: I4dc38c8c62422e59efa1071312497364cdf5be3c
2014-10-23FastSerializer: avoid some more OStringsMatúš Kukan4-12/+14
Change-Id: I2d5dbe9adccdd231cc16a1f83a90a4adeb965c64
2014-10-23FastSerializer: Use FastAttributeList directly to write faster.Matúš Kukan4-63/+42
Change-Id: I28085d4e060bcf052e6aa97a0822a4d653d7c066
2014-10-23fastparser: avoid allocating un-used FastTokenLookup class.Michael Meeks2-20/+12
This contained an rtl_Sequence complete with horror internal allocator, caught red-handed serializing threaded loading to no good purpose. Change-Id: I837b2c17e4f70fd6a49bed33ad74a7d79f98f35c
2014-10-23FastSerializer: Remove throw specs; this is not UNO implementationMatúš Kukan2-43/+27
Change-Id: I462f8ed89de48174ed7aa6e008709963bec50649
2014-10-23FastSerializer: Avoid sequences where possibleMatúš Kukan2-42/+44
Change-Id: I359ca9d3b766b71904e4199ebfbdbd5b203775cc
2014-10-23FastSerializer: Remove escapeXml() creating OUString(Buffer)Matúš Kukan3-35/+40
Instead directly write the content. Change-Id: I7b6db925348b879a013acbd2a76a80d590f721c0
2014-10-23FastSerializer: Have OString version of write() too.Matúš Kukan3-18/+20
And remove characters() member function. Change-Id: Ifcedbb6d969b7b057ff378d2fbce09c2dde5ac18
2014-10-23FastSerializer: check for valid output stream in one place is enoughMatúš Kukan2-19/+1
Change-Id: Id89fb1f0444331c2858a9795ae81dcdb875d3d2b
2014-10-23FastSerializer: Do not keep whole sequence in memory; write in chunksMatúš Kukan2-4/+17
Change-Id: Ibca65a2b8397358ac4013c8e5b53389ac6949e4d
2014-10-23FastSerializer: We already know the attribute valueMatúš Kukan1-1/+1
Change-Id: I6996e15f99b94b50c1903092d7424a96339ccfaf
2014-10-23FastSerializer: Buffer output and write it only at the endMatúš Kukan2-3/+14
Use OSequenceOutputStream class to concatenate strings in a Sequence<sal_Int8> buffer. And write data to file only at the end. The design is a bit fragile, since all FSHelpers need to be destroyed before calling FilterBase::commitStorage(). Otherwise data is not written. Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-3/+1
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-10Revert "This was OString already; use it that way"Stephan Bergmann1-4/+5
This reverts commit 9a25d12534f91c13400a63e265fb5aa14c6aca66, there's another use of DebugAttributes.find(rAttrName) in that function where rAttrName is of type OUString.
2014-10-10This was OString already; use it that wayMatúš Kukan1-5/+4
Change-Id: Ia2268ce8a1e2111adb609c515e5bfa824afa66ce
2014-10-02coverity#1158274 Uncaught exceptionCaolán McNamara1-10/+21
Change-Id: Icfbe30efa3ebd63620a900e345e4b4a74070b021
2014-10-02fix indentCaolán McNamara1-17/+17
Change-Id: Ife7b28fcb67051c41831ef9eb566c3a2c148033d
2014-10-02consistent capitalization in both exceptionsCaolán McNamara1-1/+1
Change-Id: I495a92c24847de265f04abb3670532270b5d6034
2014-10-02coverity#1242946 Unused valueCaolán McNamara1-1/+0
Change-Id: I5a5f0e96f8dc7443901ea7de568a21924137e139
2014-09-24Unused FastSaxSerializer::maSavedMarkStack memberMatúš Kukan1-1/+0
Change-Id: Ib665b3870f3d4b00c70d3f928452639464adca69
2014-09-22sax: Tabify makefiles to be more consistentMatúš Kukan4-29/+29
Change-Id: I4db1feea9db351917dd082bd22b9fc1cd5a6a9c0
2014-09-19Remove unused XFastTokenHandler functionsMatúš Kukan1-12/+0
Change-Id: I0d8072f1194aa837932dcffd6dc6a3761bbdc74e
2014-09-19Use FastSaxParser directlyMatúš Kukan2-8/+7
Change-Id: I2f21438a0ccc6bc096f3257c48e088c4114d9f45
2014-09-18fastparser: Use dummy token handler in unit test instead of an oox one.Matúš Kukan2-4/+37
Change-Id: I4562156858982857a17e8837106c4c946f175be7
2014-09-18Better to throw than crash, if token handler is not set.Matúš Kukan1-0/+3
Change-Id: If6b2d39b487b5f673d5b6b2945a6e7d08777594e
2014-08-30Use plain bool parameter hereMatúš Kukan1-9/+8
Change-Id: Ic948889a0fac32adc48a7a4fb1e7f82ce8b08ba4
2014-08-07Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happyStephan Bergmann3-12/+3
Change-Id: I2d4e4be562cc752e7545792b148d5ed0cf551f25
2014-07-11fdo#81214 - tolerate exceptions thrown inside XFastParser callbacks.Michael Meeks1-6/+5
Not an ideal solution; ideally we should not throw the exceptions, and stop the parser as soon as something bad like this happens; but hopefully exception throwing is reasonable exceptional. Change-Id: If619592533b2929c671e2b03eb8a83480bd92c54
2014-07-03FastSaxSerializer: update documentationMiklos Vajna1-4/+4
Change-Id: I5e374c426a4741a88d43848392fc83e2368dbf92
2014-07-03fdo#80748: Fix for file corruption due to framePrRohit Deshmukh1-1/+3
-For framePr Unit test is there in ooxmlexport.cxx -http://opengrok.libreoffice.org/xref/core/sw/qa/extras/ooxmlexport/ooxmlexport.cxx#3578 Change-Id: Ic1fd4c7a863d8ab57c6495e20bff6863eb941688 Reviewed-on: https://gerrit.libreoffice.org/10045 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-06-30Use a new fast parser instance for each XML fragment.Kohei Yoshida1-0/+3
Otherwise a crash ensues when the threaded XML parsing kicks in. Change-Id: Ic41e5a29bbb860d7b63b70f2f0d8896264d9d53e
2014-06-30Check for empty() before calling top().Kohei Yoshida1-0/+3
Else it might crash sometimes. Change-Id: I6a24fff83c3d36346debae5c0f2b8c0646a15c01
2014-06-30Don't go further and pop the stack if it's empty.Kohei Yoshida1-0/+6
Change-Id: I27bd30ca65cf0066cd022b4b060757913ea01fed
2014-06-13loplugin:staticcallStephan Bergmann1-2/+2
Change-Id: If21a079134f659a91f0b0ce400aef56bd095effe
2014-06-04DeInitVCL at end of testsStephan Bergmann1-0/+1
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-02fdo#68849: Add header guards to all include filesJens Carl1-0/+6
added header guards for directories basebmp/, chart2/, cppuhelper/, include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/ Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6 Reviewed-on: https://gerrit.libreoffice.org/9615 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-01fdo#68849: Add header guards to all include filesJens Carl1-0/+5
Added header guards to files in directories sal/, sal/, and scripting/ Change-Id: Ieb7f224f2d27bd671618c516f47f5b7f08c1d294 Reviewed-on: https://gerrit.libreoffice.org/9582 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29remove more unnecesary OUString constructor useNoel Grandin1-4/+4
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27css already means ::com::sun::starThomas Arnhold1-1/+1
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
2014-05-26coverity#982640 Missing break in switchCaolán McNamara1-0/+1
Change-Id: If2a14edafb72844061dcdd1ee3507d7a215220f1
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold2-4/+4
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14various loplugin:passsequencebyrefNoel Grandin1-2/+2
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin3-4/+4
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-10coverity#707979 Uninitialized pointer fieldCaolán McNamara1-0/+3
Change-Id: Id41ba6ab2c6f0a43f439c2b45d20d7d76a3cbe82
2014-04-24Avoid possible memory leaks in case of exceptionsTakeshi Abe2-20/+13
Change-Id: I047fd88a89900153089a55b6af123f11fb8bde55
2014-04-14typo: attribut -> attributeThomas Arnhold1-2/+2
2014-04-14typo: choosen -> chosenThomas Arnhold1-1/+1