summaryrefslogtreecommitdiff
path: root/salhelper
AgeCommit message (Collapse)AuthorFilesLines
2016-11-18includes should be at the top of the fileNoel Grandin1-9/+9
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14CppunitTest_desktop_lib: fix loplugin:cppunitassertequals warningsMiklos Vajna1-44/+44
And also address a few new warnings in sal, plus silence such warnings in salhelper till we can't print typeids out of the box. Change-Id: I38049146710b6885f6a874bf74eedbc38b4d4651 Reviewed-on: https://gerrit.libreoffice.org/29809 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann1-1/+1
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-2/+2
Change-Id: Ie9914a13b46de54897a031e40b6176455b7831fb
2016-02-17use consistent #define checks for the Windows platformNoel Grandin1-2/+2
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock2-6/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15loplugin:unusedmethods unused return value in rscNoel Grandin1-11/+7
Change-Id: I6301aed80083c21e26851817220de6e135eb4da7
2015-11-115th step to remove tools/rtti.hxxOliver Specht2-2/+0
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann4-29/+29
Change-Id: If341fc7d18bb6f07d76dd259f5dd77b447c93566
2015-11-01Remove some stdio.h includes from salhelper moduleJulien Nabet2-2/+0
Change-Id: Ibd95d7b3b01e7003c5d4edb831534b19313e1c37
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-3/+3
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-18boost->stdCaolán McNamara1-4/+4
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-06If we want this to crash intentionally, use abort() thenTor Lillqvist1-6/+6
free(NULL) does not crash, it is defined to do nothing. Did I not know that in 2010? Change-Id: Ia6c4817ea87b646d643a19daabfe7850c5416cc8
2015-06-23Revert "Typo: iff->if"Julien Nabet1-1/+1
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet1-1/+1
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin3-3/+3
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-01-20Some more loplugin:cstylecast: salhelperStephan Bergmann1-2/+2
Change-Id: I1e6168297ac4405c3f300aecc9074a4f15e6654c
2014-12-19Remove unused */qa/checkapi/Stephan Bergmann1-30/+0
...superseded by CppunitTest_odk_checkapi Change-Id: I5df89a1a12f496984deab153f0ba2734323c1293
2014-10-01fdo#82577: Handle TimeNoel Grandin1-4/+4
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-25set names on a bunch more threads...Michael Stahl1-0/+2
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-13salhelper: work around spurious warning C4189Michael Stahl1-0/+11
Change-Id: If919ca6da332bb94419a25253a5d6dec7243def9
2014-06-06fixincludeguards: fix include guardsThomas Arnhold2-4/+4
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-05various: remove SAL_THROW macroNoel Grandin1-5/+2
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold1-2/+2
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-28prefer makefile-gmake-modeTakeshi Abe2-2/+2
Change-Id: I9cc9bfbddd3a90e00eee3e674994e5d6207f9034
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann1-1/+1
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2-3/+3
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-02-26Remove visual noise from salhelperAlexander Wilms1-11/+11
Change-Id: Id01f525478558f2d280bfda7c970f4e16faaff44 Reviewed-on: https://gerrit.libreoffice.org/8298 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21Replace deprecated std::auto_ptr with boost::scoped_ptrTakeshi Abe1-3/+1
Change-Id: I674b7ee507258555b667657a13db6fda9b8d8372
2014-02-17salhelper: sal_Bool -> boolStephan Bergmann1-14/+14
Change-Id: Ibbfc597ec23dbc7605b2fbd02623ed4c62e4cd5c
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin2-4/+4
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-09-22gbuild: make the versioned library the linktarget on UnixesMichael Stahl1-1/+1
If there is a SOVERSION then the versioned library is a real file and the unversioned one just a symlink; better to have the real file be the target. - add gb_Library_UDK_MAJORVER variable for SOVERSION - remove version parameter of gb_Library_set_soversion_script; instead hardcode the SOVERSION since it must be included in the file name in gb_Library_FILENAMES anyway - store the unversioned symlink in the ILIBTARGET variable - via new gb_Library_get_workdir_target_versionlink function - removed gb_Helper_install call that resulted in both versioned and unversioned libs in instdir Change-Id: I2c6f1698f0e39fdb2c07964d43ed9485cbca0b30
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2-42/+8
2013-04-24Don't point to inc directories that don't exist any longerTor Lillqvist1-5/+0
Change-Id: If783897a60a545baf3968c5eeccf80a1e186bc51
2013-04-24move URE headers to include/David Tardon14-1324/+0
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d Reviewed-on: https://gerrit.libreoffice.org/3499 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks3-72/+12
2013-04-13simplify makefilesDavid Tardon1-6/+4
Change-Id: I11ea8814d36cdc6d6838ec80b0bbb272d3116b2d
2013-04-13simplify generation of *_allheaders.hxxDavid Tardon2-18/+5
There are some differences in the generated headers: cppu_allheaders.hxx now explicitly includes #include <com/sun/star/uno/Any.h> #include <com/sun/star/uno/Any.hxx> #include <com/sun/star/uno/genfunc.h> #include <com/sun/star/uno/genfunc.hxx> #include <com/sun/star/uno/Reference.h> #include <com/sun/star/uno/Reference.hxx> #include <com/sun/star/uno/Sequence.h> #include <com/sun/star/uno/Sequence.hxx> #include <com/sun/star/uno/Type.h> #include <com/sun/star/uno/Type.hxx> sal_allheaders.hxx now does not (explicitly) include #include <cppunittester/protectorfactory.hxx> #include <internal/rtllifecycle.h> #include <osl/detail/android-bootstrap.h> #include <osl/detail/component-mapping.h> #include <osl/detail/file.h> #include <osl/detail/ios-bootstrap.h> #include <pch/precompiled_sal.hxx> Change-Id: Ide3c708ac66f23b360b8e130790f8fa8f1911082
2013-04-13install SDK headers from filelistsDavid Tardon3-4/+6
... which allows us to drop gb_ZipPackage. Change-Id: Ib19f774c63d9b83ec07e99f963533eee431cc53a
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks1-2/+0
2013-03-04doubled namespacesThomas Arnhold1-2/+0
Change-Id: I0f6a34a459c1492a69afa3ef6bcbaa8ed7639a22
2013-03-03coverity#983108: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: Ief22e3cbb826ab0ceca5d199c1bfd21b46e87358
2013-03-03coverity#983107: fix memory leakMarkus Mohrhard1-0/+1
Change-Id: I602510657d72455485e42e66b8ddf68413035232
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-27salhelper: new ZipPackage_salhelper_odk_headersMichael Stahl4-14/+18
Change-Id: I83172bd105496dd1af8090a01ebfac864958e20c
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl2-0/+4
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-16Get rid of GetVersionInfo and checkdllTor Lillqvist1-1/+0
With gbuildification neither was actually used anyway, as far as I could see. Change-Id: I00d914e6571aed3110226f91ac1685a838031c65
2012-12-07Proper indentationStephan Bergmann1-2/+6
Change-Id: I4f85be9a33be6d9a3c756f2422eb7574beac1e1d
2012-12-04API CHANGE: remove long-deprecated Semaphore & related stuff.Thorsten Behrens4-397/+0
osl::semaphore was not portable & thusly long-deprecated. Also killing further unused clients of that code in salhelper. Change-Id: Ie1c1924e06e8ce3be33fd1dc2c6933f2de8b5217
2012-10-10try and make mingw32 buildCaolán McNamara3-68/+1
Change-Id: I64c884b6d14c7112a88c7741ef7688108ec80ffe