summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2013-11-20Windows: Require at least Windows XP SP2Thomas Arnhold7-10/+4
* Windows XP SP2 is 0x0502, see http://msdn.microsoft.com/en-us/library/aa383745.aspx * If a module changes the Windows SDK version setting, this is done module wide now. So the overall behavior is as before. This seems to be the best compromise for now. * We need at least SP2 because of the bluetooth stuff used in sd/source/ui/remotecontrol. * Now, we require at least Internet Explorer 7.0. IE6 has been outdated for a long time. * Leave StdAfx.h file definitions, as those are Microsoft project specific precompiled header files. * All local definitions of WINVER are removed, because the global WINVER setting makes them obsolete now. To the relation of the three macros: Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION automatically to the same value as _WIN32_WINNT. WINVER and NTDDI_VERSION can be set idenpendently each for itself. Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb Reviewed-on: https://gerrit.libreoffice.org/6496 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20remove RTL_CONSTASCII_STRINGPARAM in OString constructorNoel Grandin1-1/+1
Convert code like: OString aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX")); to: OString aKeyName("NDX"); which compiles down to the same code Change-Id: I1780264cae4484fc78f0586b0750c09f2dce135f
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::appendNoel Grandin1-2/+2
Convert code like: aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") ); to: aOStringBuf.append( " is missing )" ); which compiles down to the same code. Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii callsNoel Grandin2-5/+5
Convert code like: aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" )); to: aStrBuf.append( "ln(x)" ); which compiles down to the same code. Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin1-1/+1
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-3/+3
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-17bugs.freedesktop.org -> bugs.libreoffice.orgAndras Timar1-1/+1
Change-Id: I56c1190c93333636981acf2dd271515170a8a904
2013-11-14Use rtl::StaticStephan Bergmann1-120/+97
Change-Id: I391e027b2567c4239c1d02e132c6508b3f49d381
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-114/+0
Change-Id: I6197f2f9c3359ebe6c3c639f15c3e19d66434f3e
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-14/+0
Change-Id: I5dd8f718cb96c4442e2fce08a8dc4130e934c68d
2013-11-14-Werror,-Wunused-member-functionStephan Bergmann1-3/+2
Change-Id: Id218a6123037bf624044a6297edaede924bd4a9a
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin3-6/+6
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-12document the use of the strtmpl.cxx and remove unnecessary macro usageNoel Grandin2-22/+29
Document the "calling" macros for the strtmpl.cxx template file. And remove unnecessary use of those macros in the calling file. Change-Id: I20e0dd74150773363b9fb557884b84692ce22f11 Reviewed-on: https://gerrit.libreoffice.org/6504 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-2/+2
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-07Name threads for debug purposeArnaud Versini1-0/+2
Change-Id: Id99ba394b898b7da0057d4a145ce8dce46122782 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07fdo#42783: remove CPU variable from environmentMichael Stahl1-1/+1
Replace uses with CPUNAME instead, and get rid of the horrible postgresql patch that worked around environment leakage. Change-Id: I38ccabfc438360524a272901bb9332ea708e274c
2013-11-05windows: remove _CRTIMP and _NTSDK definitionsThomas Arnhold1-6/+0
Those have no effects with current windows SDKs. Change-Id: I6fb2f8045fe1fc0ed4beef51dde487b7a7dfdc28
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin1-6/+6
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin4-10/+7
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28Related: fdo#69641 convert OSL_ASSERT into assertCaolán McNamara1-6/+6
Change-Id: I63c32289c7ac6a428c8c50e49650fbac98c8c5e3
2013-10-28windows: warning 4706 is disabled globally in com_MSC_defs.mkThomas Arnhold1-4/+1
So there is no need to do this locally, too. Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist4-6/+6
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-17fdo#70319 "exponent followed by at least on digit" also for special case 0.0Stephan Bergmann2-0/+10
Change-Id: I07e7917417b8a22cf6d64f2b7a447f9084b9fa2d
2013-10-14resolved fdo#70319 exponent must be followed by at least one digitEike Rathke2-0/+18
Change-Id: Icdd22fa0f1efcdd18cfea7cb48e1cbf2cf8d3533
2013-10-13lo_dlcall_argc_argv() is unusedTor Lillqvist1-12/+0
Change-Id: I318bb78b148564f64373dcb87bfb458c10f87489
2013-10-10sal: fix osl_setCommandArgs() on WNTMichael Stahl1-3/+6
... was missing from 1acaa577b67158c060d2f57414f7aea86504a489. Change-Id: I9098f4587f1c201328abbbcfb34d42f09d2e8203
2013-10-10Adapt to C90Stephan Bergmann1-1/+3
Change-Id: I491ca9ccfc5622afcec163e75792aa03a3a24a4f
2013-10-10sal: add special handling of argc==0 to osl_setCommandArgs()Michael Stahl2-7/+20
... to set up a fake command line. This is used from pyuno, when invoked from the "python" executable as "import uno". On WNT there is an API to get the actual command line, so just use that even in the "fake" case; on UNX just fake something up. Just for the record the whole osl_setCommandArgs() is called exactly once assumption should work out _unless_ there is a program that uses SAL_MAIN _and_ does a python-level "import uno" _before_ it wants to create a python-based UNO service (via pyuno_loader::CreateInstance), since pyuno already takes care to call Runtime::initialize() at most once. Change-Id: Ifd23de733ea3e6b694d46ab039b6aa4fd3e7fc1b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-10Remove support for undocumented SOLAR_USER_RTL_TEXTENCODING env varStephan Bergmann2-17/+2
...introduced in 2001 with a Sun-internal bug ID as 3b1d10acc297db493b1f4e1999f6ba71f72db7f1 and 54007bb90c30469a5357c56056b8fdba3a233e24 "#84715# osl_getThreadTextEncoding first defaults to contents of environment variable SOLAR_USER_RTL_TEXTENCODING." Change-Id: I991b4777c27a24419bf066cf41b3c4545d0fa681
2013-10-09Fail fast at least in debug buildsStephan Bergmann1-1/+1
Change-Id: I266d5cf5b98827617f7ed65c94a772e28808f386
2013-10-09pyuno: set up fake command line in getComponentContext()Michael Stahl1-1/+1
Easy to trigger the assert in osl_getCommandArgCount(), just run instdir/*/program/python and "import unohelper". Avoid that by setting up a fake command line, hopefully nobody expects to be able to give relevant args to python... Change-Id: I0df6c23d6ecbb3c2bce81a9d5bcecdcb1729ddbb
2013-10-09Use SAL_WARN_IF() instead of assert() so that our Python unit tests don't failTor Lillqvist1-1/+1
In some (all?) Python unit tests (or subsequentchecks?) osl_getCommandArgCount() gets called even if osl_setCommandArgs() hasn't been called, sigh. Change-Id: I53ba20806da3168182fd2011397fd29e549869dc
2013-10-09Use assertions to ensure proper use of the osl command line arg APITor Lillqvist1-6/+2
Stephan says: I don't buy that argument of making things less fragile; IMO it's that "defensive programming" approach gone wrong, where you add complexity to mitigate a problem's effects in one place, instead of fixing the problem itself in the real place. [...] The better robustification is probably to turn the OSL_TRACE in osl_getCommandArgCount (sal/osl/unx/process_impl.cxx) into something stronger like SAL_WARN, assert, or std::abort Change-Id: I3ba6684b4921eb67c2f4534e29e33056e8a891b3
2013-10-09Revert "Don't ignore -env: command line parameters in some cases"Tor Lillqvist1-10/+1
This was the wrong way to fix the problem. The root cause was a static initialiser in the OpenCL code, and that code should not even have been built for iOS. This reverts commit 261f1439e5516f6d60317a675d261af330a9a74c.
2013-10-08CID#982700 silence coverityCaolán McNamara1-2/+6
Change-Id: I01fddeeca503ebc045c2f0e53c5917e6218e9d6e
2013-10-08Don't ignore -env: command line parameters in some casesTor Lillqvist1-1/+10
Happened at least in the experimental iOS app. Change-Id: I725dde2f40ae9e64406e7a1b1dd5dc0da0a9ebd4
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-9/+0
Change-Id: I5740a22f0d768b9b1d7449f54b859bcb40401367
2013-10-02-Werror,-Wunused-functionStephan Bergmann1-15/+0
Change-Id: I1b966095f764a197c4c5e823fa41b9914cb34ebe
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-18/+0
Change-Id: I000ed6edb236dbb8e93ad2fb445dfec7294ea3fc
2013-10-02-Werror,-Wunused-const-variableStephan Bergmann1-2/+0
Change-Id: I6c359f8ce52218413671fcdc06021b283b25cf6a
2013-10-02-Werror,-Wunused-functionStephan Bergmann1-8/+0
Change-Id: I4e3097f58a8b91a61369d3b93931bff44444990a
2013-10-01sal: require sun4u or newer hardware / SPARCv8plus / SPARCv9 CPUMichael Stahl2-284/+12
Drop implementation of osl_incrementInterlockedCount / osl_decrementInterlockedCount for antique 32-bit SPARC without cas instruction (sun4, sun4c, sun4d, sun4m). Apparently only NetBSD and OpenBSD even support such ancient hardware at all, the Debian SPARC port already requires sun4u hardware. Change-Id: Ic254622ae80ad65c9f545013b68d82665474402c
2013-09-30API CHANGE: Remove osl_getEthernetAddress and osl/util.h .Arnaud Versini7-375/+149
Also move osl/util.c on Unix systems to osl/system.c. Change-Id: Ifff79d9f4f89ecbb4e0e1652b40ab46b7d569adf Reviewed-on: https://gerrit.libreoffice.org/6065 Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-09-30Clean up rtl/character.hxxStephan Bergmann1-32/+19
It is probably best to base the functions on Unicode code points instead of scalar values, now that they are also used from sal/rtl/strtmpl.cxx with UTF-16 code units and with arbitrary bytes (with values assumed to be a superset of ASCII, though). Rename compareAsciiIgnoreCase to compareIgnoreAsciiCase. Also, the corresponding tools::INetMIME functions can be removed completely; no need to keep them around as deprecated. Change-Id: I8d322177f4909e70a946e8186e3e0f7fa6d9a43e
2013-09-30Introduce ASCII case conversion and use more/rtl/character.hxx.Arnaud Versini1-50/+19
Also remove all others implementations. Change-Id: I1dc108a9103f087bd8ce591dff2ac5dd254746f8 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-09-28General cleanup in sal module for all and unix.Arnaud Versini18-519/+10
Remove useless comments and header, and de duplicate a small declaration. Change-Id: I0d4475cbbd61ea964f8e586cf0e1f68eb91c4948 Reviewed-on: https://gerrit.libreoffice.org/6016 Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org> Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-09-26malloc returns void*; must be cast to real ptr typeDavid Tardon1-1/+1
Change-Id: Ic19707b99b1a53005ac319887219fc52b3e60e89
2013-09-26typo fixes in commentsAndras Timar1-1/+1
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-22sal: rename "cppunit/cppunittester" executableMichael Stahl2-23/+5
... and put it in OOO layer since it's used by the smoketest instset. It was in subdirectory for hysteric reasons, to pick up libraries from module local output directories in the dmake build system. Change-Id: I73b66672b17ede52c03071eb2ddee1a23c059ea9
2013-09-22gbuild: remove libraries from OUTDIR and WORKDIRMichael Stahl1-0/+4
Refactor everything to find and link libraries directly in INSTDIR. - add gb_LinkTarget_get_linksearchpath_for_layer, and use it to set up -L paths for T_LDFLAGS in such a way that only allowed libraries can be linked against; i.e. it's not possible to link URE linktargets against OOO or not-installed libraries - gb_Library_get_target is now same as the gb_LinkTarget_get_target (TODO: this needs cleanup) - since a pattern rule won't work for linking libraries in INSTDIR, add a separate per-file rule for every INSTDIR lib - pattern rule can't find link target in the clean target any more so add a LINKTARGET variable - disable gb_Library_add_auxtarget, no auxtargets need to be copied - tweak the call to gb_Library_Library_platform to pass in a path in sdk/lib for the versioned URE libs - fix the Library clean target - add LAYER parameter to gb_LinkTarget_LinkTarget - adjust platform link commands - MSVC link command now uses explicit -manifestfile and -pdb parameters to keep misc. files out of INSTDIR - remove gb_Helper_OUTDIR_FOR_BUILDLIBDIR - adjust Extension, CppunitTest, JunitTest, PythonTest, Gallery, various CustomTargets to search INSTDIR - remove SDK library symlinks and import libs from odk/Package_lib - on Mac OS X, put .dylib symlinks into sdk/lib even though those are not packaged and would be created by the SDK configury; we need these to be somewhere for linking anyway - add a (unfortunately cyclic) dependency on Package ure_install to sal Change-Id: I70d88742f8c8232ad7b9521416275c67b64fe6cf