summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2015-07-06Clarify treatment of double slashes in rtl::Uri::convertRelToAbsStephan Bergmann1-1/+5
Change-Id: I71d0ded04b35472f14e4764a47212c73ac500814
2015-07-04Fix typosAndrea Gelmini2-2/+2
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1 Reviewed-on: https://gerrit.libreoffice.org/16710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30Coverity 1308555, 1308562, 1308600: Drop some SAL_THROW_EXTERN_CStephan Bergmann1-7/+6
...from most rtl/bootstrap.h functions. They are effectively only called from C++ code (there is no plain C UNO binding), so it should be fine to let std exceptions (like bad_alloc or length_error) propagate from their implementations to call sites. (The exception is rtl_bootstrap_args_close, which is typically called from C++ dtors, so should not throw anyway.) This would strictly speaking be an [API CHANGE], but it should make no practical difference whether a process terminates abruptly because an exception cannot pass through a SAL_THROW_EXTERN_C() nothrow specification or because legacy client code does not expect exceptions to be thrown from functions from which SAL_THROW_EXTERN_C() has now been removed. Change-Id: I08e8479e9c5731e46021aadd6a725c1793024d10
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann4-20/+14
Change-Id: Ia304622214c47d35387dd0393db8e9afa55118f2
2015-06-26Add optimized OUString += literal overloadStephan Bergmann3-0/+33
Change-Id: Ib34196185f90204a71598f2c659c3fddce7a0e4d
2015-06-25Revert "Revert "Generalize OUStringLiteral1""Stephan Bergmann1-0/+14
This reverts commit 5cba714b4d03ed54debf71534ad8c8edc383a01e, now including a workaround for <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53658> "internal compiler error -- segmentation fault." Change-Id: I31f6d9ddcb0b884134703df2b9dc1800ba0a84be
2015-06-25Do not forget to actually set newStr to an empty stringStephan Bergmann2-3/+22
Change-Id: I745b09d8a248f08afdd3387f4cfcf69d71ec3c39
2015-06-24Revert "Generalize OUStringLiteral1"Stephan Bergmann1-14/+0
This reverts commit 4d4f3512db0cf0bf47c2ba1b39c3813842903ef7, at least "gcc version 4.8.3 20140627 [gcc-4_8-branch revision 212064] (SUSE Linux)" fails with "include/rtl/stringutils.hxx:175:49: internal compiler error: Segmentation fault."
2015-06-24Generalize OUStringLiteral1Stephan Bergmann1-0/+14
...by making all places that accept a string literal via ConstCharArrayDetector also accept an OUStringLiteral1 via ConstCharArrayDetector (which required some tweaking of the ConstCharArrayDetector internals). That removes the need for special-purpose OUStringLiteral1 overloads, and will allow OUStringLiteral1 to be used in more places. Change-Id: I370de8480e02f8423cde5677dd38479b81bccdb2
2015-06-23Revert "Typo: iff->if"Julien Nabet1-1/+1
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet1-1/+1
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-23Implement full set of OUString::replaceFirst/All literal overloadsStephan Bergmann3-0/+118
Change-Id: I5f525d91ce24d1d2653a6855f1c4fffc039ae398
2015-06-23typoStephan Bergmann1-1/+1
Change-Id: I80e32c8198a153a16e6a91921dff025bf5bd3170
2015-06-23Make test code unaffected by upcoming loplugin:stringconstant improvementsStephan Bergmann1-51/+23
Change-Id: If375073001690e1ce2f8d18a3f128358f22aa98b
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe4-14/+14
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:unreadVariableNoel Grandin1-1/+0
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15cppcheck:redundantAssignmentNoel Grandin4-25/+17
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-13TyposJulien Nabet2-2/+2
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann15-60/+60
Change-Id: Ibd373cddb1e25f05528e627349953b5f7d115330
2015-06-02-fsanitize=nonnull-attribute in memcpy callStephan Bergmann1-1/+1
Change-Id: If1f852ce4ef3419d663d4e2f4bdb4a57cc61e799
2015-06-02-fsanitize=nonnull-attribute in memcpy callStephan Bergmann1-1/+1
Change-Id: Ic2fc0752f2bce2d565ca58b1c804bfd601b80875
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann11-36/+36
Change-Id: Iad01e628b692a6dcf882696908de0ef1f24c04c4
2015-05-29loplugin:redundantcast: Work around OS X memchr bugStephan Bergmann1-2/+2
...where in C++ memchr does not have exactly the two overloads void const * memchr(void const *, int, size_t) void * memchr(void *, int, size_t) but rather the C void * memchr(void const *, int, size_t) shining through (see bugreport.apple.com issue 21128245 "non-conforming memchr in C++"), which gets in the way of the upcoming improved redundant const_cast check in loplugin:redundantcast. Change-Id: I7001e74e03429ef23682d52da28fca435130d775
2015-05-18loplugin:staticmethodsStephan Bergmann1-0/+1
Change-Id: Ie225e9816a626e2581b8309f59519ab99e1af04a
2015-05-11sal: don't build cppunittester if cross-compilingMichael Stahl1-2/+1
Change-Id: I4e2d884b2f87572dc22fece897e384bdaa7506cc
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann3-6/+6
Change-Id: Ia7902a4bf2ec9bc995dfa065fe9e2eb092613683
2015-05-10cppcheck: help out unusedScopedObject false positiveCaolán McNamara1-4/+4
Change-Id: I0df7a930ff970c26fbbb03d9333108ee3cae7ad4
2015-05-09coverity#1297235 Uncaught exceptionCaolán McNamara1-65/+74
Change-Id: I6b135f6d47352c1fbb729788848913402b7bb742
2015-05-08Use bool instead of intStephan Bergmann1-38/+38
Change-Id: Ib5920745f9f464493b7b134f871e090726d17d0c
2015-05-01Actually, let's just delete the now commented-out SAL_INFO linesTor Lillqvist1-10/+0
(It was I who added them in the first place.) Next time somebody (falsely?) suspects a problem with mutex use and really needs tracing, it's trivial to add temporary SAL_DEBUGs. Change-Id: I3db02be777a728fbf4a1d1962f0ccfa16c630f15
2015-05-01Let's disable these too then for consistencyTor Lillqvist1-2/+2
Change-Id: I17d17b1cad83a55f9a2c0db80e272c419529b45a
2015-05-01sal: disable some over-eager SAL_INFOMichael Stahl1-3/+3
These call malloc so often that valgrind forgets where the things i'm looking for were freed, because the address has already been re-used. Change-Id: I8e1a0f739a774972d3afe750250ee79262c79b85
2015-04-30provide a way to execute single test case from test suiteMarkus Mohrhard1-2/+31
CPPUNIT_TEST_NAME is the environment variable that needs to be set and contain the name of the tests. The test names need to be fully qualified to be recognized. Examples: CPPUNIT_TEST_NAME="ScFiltersTest::testOutlineODS ScFiltersTest::testRangeNameXLS" make CppunitTest_sc_subsequent_filters_test CPPUNIT_TEST_NAME="ScFiltersTest" make CppunitTest_sc_subsequent_filters_test Change-Id: I78a8a076638e19c918ca1c411086bb353f5100a2 Reviewed-on: https://gerrit.libreoffice.org/15579 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist1-6/+0
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-27More loplugin:simplifyboolStephan Bergmann5-61/+61
Change-Id: I9414d9167213c0156fb97559a8af5e55a4e1c1de
2015-04-23cppcheck: uselessAssignmentArgCaolán McNamara1-1/+0
Change-Id: I94be63174d996069fc5ec9c93d14ccd5a39cb029
2015-04-23cppcheck: redundantAssignmentCaolán McNamara1-4/+1
Change-Id: Ib296edde6e1f3996cbfe46c77810bb5c3da6db73
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann3-0/+3
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-21cppcheck: redundantCopyCaolán McNamara1-3/+3
Change-Id: I209b55a6ef962d4a350327e56c4d16c8180a21e0
2015-04-20Clean up new rtl/surrogates.hStephan Bergmann3-24/+23
Change-Id: Iec781bdbbf216cb14c9ba5be5955123273d7699c
2015-04-20duplicate surrogate codeCaolán McNamara4-53/+3
Change-Id: I9fad024e4b5c8a4ca272f2387df07351198cf5dc
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin28-65/+65
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-10Update @since tags LO 4.5 -> 5.0Stephan Bergmann1-1/+1
Change-Id: Idb2e46fcaa080d6763d2e3ed963f7673a2353eb2
2015-04-09WaE: VarDecl, use "bool" instead of "sal_Bool"Tor Lillqvist1-2/+2
Change-Id: I0b868edad579f9ccf46f6d9f6015086557e528da
2015-04-09Change from <osl/diagnose.h> to <sal/log.hxx> and add more loggingTor Lillqvist1-23/+25
Change-Id: Iee8c093f5aa8306c3e5336d6dd5e801df6df87a4
2015-04-08tdf#43157: remove osl/diagnose.h dependency from sal/osl/unx/socket.cxxJorge Cunha Mendes1-93/+100
Change-Id: I2becc1cbb875270e2a1e8ed6b7cb0f9b6bdbf2f9 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-08-Werror=maybe-uninitializedStephan Bergmann1-0/+1
Change-Id: I7d3c36e564b3a5286ebd32527575472313119587
2015-04-08tdf#88169: Do not return ..._INFO_SRCBUFFERTOSMALL when ..._FLAGS_FLUSHStephan Bergmann1-79/+84
...in accordance with <http://www.openoffice.org/udk/cpp/man/spec/textconversion.html> Change-Id: I62013f89c421722770123db8a5794e63d3572e6b
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 09:47:59 +0000