summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2017-05-17Fix integer typesStephan Bergmann2-5/+5
Change-Id: Ia2dc32929da789622ed98764944d4e412a296639 Reviewed-on: https://gerrit.libreoffice.org/37723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17BOOL -> boolStephan Bergmann2-8/+8
Change-Id: Ie1ee8b93753e03326d2a121dcd18a1b6a7038ce3 Reviewed-on: https://gerrit.libreoffice.org/37722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17wchar_t -> sal_UnicodeStephan Bergmann1-12/+19
Change-Id: I8e4f11225e5020159cfd373bd6c0526541d7cc65 Reviewed-on: https://gerrit.libreoffice.org/37721 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17Remove unused VALIDATEPATH_ALLOW_WILDCARDSStephan Bergmann2-6/+1
Change-Id: Ia006d66df7bf90e6b4da327cd1bcb06968cc72f6 Reviewed-on: https://gerrit.libreoffice.org/37720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17BOOL -> boolStephan Bergmann1-12/+12
Change-Id: I0cb5f19369ec5f61660a598288fd23700f5d4159 Reviewed-on: https://gerrit.libreoffice.org/37719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17Remove IsValidFilePath lppError parameter; always nullStephan Bergmann3-11/+6
Change-Id: Ia13c62cdd8ff8b930f82d32310f10fa5279cae81 Reviewed-on: https://gerrit.libreoffice.org/37718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17Remove osl_getFileURLFromSystemPath_Stephan Bergmann3-13/+2
Change-Id: I8dd11b2f4cc9f4f1f622181fe478a4c180eb2af0 Reviewed-on: https://gerrit.libreoffice.org/37717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-05-17Add some unit tests for rtl_math_StringFormat_GEike Rathke1-0/+33
Change-Id: I010c35905789d2c5f60f7f1c4d9ad4caf60146ee
2017-05-16Extend loplugin:comparisonwithconstant beyond integral typesStephan Bergmann12-43/+43
Change-Id: Id3a8fd5d8b9975d3ae49af0648b39454310495fa
2017-05-16Try to fix loplugin:comparisonwithconstant's rewrite-with-macros issueStephan Bergmann9-34/+34
...that had plagued 2e293a731c1559c9869dfcb32491bc600fc18e4e "new loplugin/rewriter comparisonwithconstant" (in sal/osl/unx/pipe.cxx), and auto-rewrite the remaining occurrences in sal (that the mentioned commit had failed to address, for whatever reason) Change-Id: I3dc3bae8dd92ba8bf576f6e06e7c9ee21f883661
2017-05-15coverity#1408971 Mixing enum typesCaolán McNamara1-14/+11
Change-Id: I30c46f2bd8a0ae059722f60a3103e5c7883d6a2d Reviewed-on: https://gerrit.libreoffice.org/37630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-14osl: cleanup file_url.cxxChris Sherlock1-108/+94
Change-Id: I636b0a7765be8e6e96e90ff5a004dc452048541a
2017-05-14osl: osl_File.cxx unit test formatting cleanupChris Sherlock1-31/+80
Change-Id: I0e0386834e9cf76cd3c606ae01175aec9cf7e4f1
2017-05-13osl: osl_File.cxx indent fixesChris Sherlock1-51/+51
Change-Id: I4bd6fc88950e8e6fd5648f4a76201c135352e406
2017-05-13osl: final cleanup of sal_File.cxx unit testChris Sherlock1-2152/+2149
Change-Id: I00201c5456904a537e349fa5e30be223b744fc5e
2017-05-13osl: osl_File.cxx header cleanupChris Sherlock1-2/+1
Change-Id: I9c76e2ef0ee7f28a51c0011ceb7e9e2f45f15ea7
2017-05-13osl: osl_File.cxx qa test - remove osl namespace prefixesChris Sherlock1-658/+653
Change-Id: Iacb82eff69ce5690ad0a054953835863c57dcce0
2017-05-13osl: osl_File.cxx qa file cleanupChris Sherlock1-403/+410
Change-Id: I4973cc0c8445f67cd2b3f6a9d158d6592c190447
2017-05-13osl: file test - space between C comment token and start of commentChris Sherlock1-214/+214
Change-Id: Idf44ed079f04b16f2e8d718358567cfafecbe388
2017-05-13osl: remove commented code from file testChris Sherlock1-31/+0
Change-Id: I85c41a6821e675874e9dae2ab4bfad35b7aebc59
2017-05-13osl: remove extraneous comment cruft from test sourceChris Sherlock1-59/+53
Change-Id: I1a7b5fc62359cd24593fadea1185db7e48c22961
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke12-12/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-07osl: remove comment cruft, whitespace cleanup of thread.cxxChris Sherlock2-92/+11
Change-Id: I4941e02b011b8e630b00d8a14703651d1f956563
2017-05-07osl: remove comment cruft, whitespace cleanup of process.cxxChris Sherlock2-68/+8
Change-Id: I9609306dfe70595e67ee6100ce236e849e7a3eca
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03Work around GCC 7 mis-featureStephan Bergmann1-0/+7
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80354> "Poor support to silence -Wformat-truncation=1" Change-Id: I486f8a3a12896df3d9506f53bca44a318e23c991
2017-05-03remove empty commentsNoel Grandin1-4/+1
found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:salunicodeliteral: salStephan Bergmann5-25/+25
Change-Id: I1b7c3f8de5b09c96e27aa9124096b00638afb3f3
2017-04-28loplugin:cppunitassertequals: salStephan Bergmann10-343/+673
Change-Id: I6ba9a18a1d227461e023259662635e3008ad7c9b
2017-04-27sal: cppunittester: verify that CPPUNIT_TEST_NAME contains a testMichael Stahl1-3/+13
Fail the test if CPPUNIT_TEST_NAME does not contain at least one existing test, which is much better than silently reporting OK(0). Change-Id: If2137764b24aa52dc35fe2368ee8fe38cb7dbece
2017-04-26loplugin:redundantcast (clang-cl)Stephan Bergmann2-5/+5
Change-Id: I5164bc1bfa1aaae0f648e0384227d92c8b2ff7a3
2017-04-26loplugin:useuniqueptr (clang-cl)Stephan Bergmann1-11/+12
Change-Id: I491fb1fdcc3f5f64e4adb7276217bbdc13a1fa19
2017-04-26-Werror,-Wunused-macros (clang-cl)Stephan Bergmann1-1/+0
Change-Id: I64fa44caecd3f86bd23dc625e72c134659610b1a
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock3-0/+3
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24clang-tidy readability-simplify-boolean-expr in oox..salNoel Grandin3-23/+4
Change-Id: I1e14e5b15d2dd9e35477f8189cbecf0b443b9381 Reviewed-on: https://gerrit.libreoffice.org/36875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky16-279/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21Make HASHID work whenever there is std::hash<pthread_t>Stephan Bergmann1-2/+10
Change-Id: I78aecfc7c0ea4ad4467417015bf41b809dbcda83
2017-04-20Simplify PTHREAD_VALUEStephan Bergmann2-8/+3
The distinction between MACOSX and other had been introduced with ed8110e101db5a8ea4dde43a3ec38fe40e6fe7e2 "Avoid reinterpret_cast to same type" to work around a GCC 4.6 bug that is fixed since GCC 4.7. Change-Id: I7948721d311de2622c1e08e2ee17b5ccc304b51b
2017-04-20Avoid loplugin:redundantcast on macOSStephan Bergmann2-2/+2
Change-Id: I5e9f2552f83e72d1f6eb1a12df19c0fdfa012e31
2017-04-16try to fix werror + pch build on linuxMarkus Mohrhard1-0/+2
This should fix RandomConfig tb run #396 Change-Id: Idd7984e3c4225b08db50b2451112135aaf2e1890 Reviewed-on: https://gerrit.libreoffice.org/36584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-13Removed duplicated includesAndrea Gelmini2-10/+0
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12clang-tidy: readability-else-after-returnNoel Grandin26-376/+297
run it against sal,cppu,cppuhelper I had to run this multiple times to catch all the cases in each module, and it requires some hand-tweaking of the resulting output - clang-tidy is not very good about cleaning up trailing spaces, and aligning things nicely. Change-Id: I00336345f5f036e12422b98d66526509380c497a Reviewed-on: https://gerrit.libreoffice.org/36194 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: salStephan Bergmann1-1/+1
Change-Id: I7caadbc06b2266800666151de75d799c42148aca
2017-04-04ofz#770 JOHAB_73 table starts at 0xA not 0x2Caolán McNamara1-1/+1
the start value is out by one row Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3 Reviewed-on: https://gerrit.libreoffice.org/34992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann12-113/+107
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30remove type decorations on char literalsJochen Nitschke6-12/+12
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30loplugin:loopvartoosmallStephan Bergmann1-1/+1
Change-Id: If714cafd9f2786610a03b1f5f6466a9ea06e46e6
2017-03-30loplugin:redundantcastStephan Bergmann1-1/+1
(only triggers on macOS, as on Linux unistd.h declares lseek with a return type of intermediary __off_t/__off64_t typedefs) Change-Id: I967e472a050ad624a6411947b10c962ac8f66bed
2017-03-25Fix typosAndrea Gelmini6-8/+8
Change-Id: I5fc62060e7d01c6b492a0e91323f753cc676bf71 Reviewed-on: https://gerrit.libreoffice.org/35639 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24Various loplugin warnings (clang-cl)Stephan Bergmann1-5/+5
Change-Id: I7969250f330d2df02c4ea909115b3028fdc36223
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 20:32:57 +0000