summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2015-10-16tdf#94888: Accessing Sharepoint r/o share through UNC path does not workGiuseppe Castagno1-0/+1
Added a Windows API missing error. The error added: ERROR_CANT_ACCESS_FILE returned when a file cannot be accessed by the system. Mapped to existent osl_File_E_.... for compatibility. Change-Id: Ia68cdf761a62db8960b143a69ccfa3e12fc6eac5 Reviewed-on: https://gerrit.libreoffice.org/19270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit b49a2f7373e950efc3fe11b89309313ac69c1e1f) Reviewed-on: https://gerrit.libreoffice.org/19374 Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-28Better fail with E_EXIST if rename(3) failsStephan Bergmann1-1/+1
...it leads to better handling of the failure downstream, if e.g. this is an attempt to copy a file from the presets to an existing file of a previously partly generated UserInstallation, and the presets and the UserInstallation are on different drives and rename(3) fails with EXDEV. (Without this fix, removing the UserInstallation's registrymodifications.xcu caused restarting soffice to fail with "User installation could not be completed" in this case; regression introduced with 6edbcc1b231feb02f304ff646c323b5df051d9a4 "cid#1242936 handle rename failure.") Change-Id: I409698c4e2e6cc6ccd8b2be80a393c9657b5125d (cherry picked from commit d2a7abebf210cacf9ea357dd8b4a0772be7308df) Reviewed-on: https://gerrit.libreoffice.org/18898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-25tdf#93569 - restore ACT_ABORT distinction.Michael Meeks1-1/+1
In order to handle signals, we need to have ACT_ABORT in place and distinct from ACT_SYSTEM. cf. if (Signals[i].Action != ACT_SYSTEM) during setup. Change-Id: I8c69d48244ba462f2e2385a530cbbf4740ccee9a Reviewed-on: https://gerrit.libreoffice.org/17893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-15tdf#60381: Accessing Sharepoint share using UNC path does not work.Giuseppe Castagno1-0/+2
Added two Windows API missing errors. The errors added: ERROR_FILE_CHECKED_OUT returned when trying to access a file that is locked by another user. ERROR_INVALID_NAME returned when trying to access a local file with the wrong chars in the path or file name. Mapped to existent osl_File_E_.... for compatibility. Change-Id: I0bea1ff2727729c569b0a2cb6befd0d38289b8a2 Reviewed-on: https://gerrit.libreoffice.org/17412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> (cherry picked from commit b7ae14655f8969069b882ae0bd43d79a4c92f357) Reviewed-on: https://gerrit.libreoffice.org/17650 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-25Do not forget to actually set newStr to an empty stringStephan Bergmann2-2/+14
(cherry picked from commit f7a7a9dd84d1cd8b49d59e1fb1853ea7e9f40edf) Conflicts: sal/qa/rtl/strings/test_strings_replace.cxx sal/rtl/ustring.cxx Change-Id: I745b09d8a248f08afdd3387f4cfcf69d71ec3c39
2015-05-18loplugin:staticmethodsStephan Bergmann1-0/+1
Change-Id: Ie225e9816a626e2581b8309f59519ab99e1af04a
2015-05-11sal: don't build cppunittester if cross-compilingMichael Stahl1-2/+1
Change-Id: I4e2d884b2f87572dc22fece897e384bdaa7506cc
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann3-6/+6
Change-Id: Ia7902a4bf2ec9bc995dfa065fe9e2eb092613683
2015-05-10cppcheck: help out unusedScopedObject false positiveCaolán McNamara1-4/+4
Change-Id: I0df7a930ff970c26fbbb03d9333108ee3cae7ad4
2015-05-09coverity#1297235 Uncaught exceptionCaolán McNamara1-65/+74
Change-Id: I6b135f6d47352c1fbb729788848913402b7bb742
2015-05-08Use bool instead of intStephan Bergmann1-38/+38
Change-Id: Ib5920745f9f464493b7b134f871e090726d17d0c
2015-05-01Actually, let's just delete the now commented-out SAL_INFO linesTor Lillqvist1-10/+0
(It was I who added them in the first place.) Next time somebody (falsely?) suspects a problem with mutex use and really needs tracing, it's trivial to add temporary SAL_DEBUGs. Change-Id: I3db02be777a728fbf4a1d1962f0ccfa16c630f15
2015-05-01Let's disable these too then for consistencyTor Lillqvist1-2/+2
Change-Id: I17d17b1cad83a55f9a2c0db80e272c419529b45a
2015-05-01sal: disable some over-eager SAL_INFOMichael Stahl1-3/+3
These call malloc so often that valgrind forgets where the things i'm looking for were freed, because the address has already been re-used. Change-Id: I8e1a0f739a774972d3afe750250ee79262c79b85
2015-04-30provide a way to execute single test case from test suiteMarkus Mohrhard1-2/+31
CPPUNIT_TEST_NAME is the environment variable that needs to be set and contain the name of the tests. The test names need to be fully qualified to be recognized. Examples: CPPUNIT_TEST_NAME="ScFiltersTest::testOutlineODS ScFiltersTest::testRangeNameXLS" make CppunitTest_sc_subsequent_filters_test CPPUNIT_TEST_NAME="ScFiltersTest" make CppunitTest_sc_subsequent_filters_test Change-Id: I78a8a076638e19c918ca1c411086bb353f5100a2 Reviewed-on: https://gerrit.libreoffice.org/15579 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist1-6/+0
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-27More loplugin:simplifyboolStephan Bergmann5-61/+61
Change-Id: I9414d9167213c0156fb97559a8af5e55a4e1c1de
2015-04-23cppcheck: uselessAssignmentArgCaolán McNamara1-1/+0
Change-Id: I94be63174d996069fc5ec9c93d14ccd5a39cb029
2015-04-23cppcheck: redundantAssignmentCaolán McNamara1-4/+1
Change-Id: Ib296edde6e1f3996cbfe46c77810bb5c3da6db73
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann3-0/+3
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-21cppcheck: redundantCopyCaolán McNamara1-3/+3
Change-Id: I209b55a6ef962d4a350327e56c4d16c8180a21e0
2015-04-20Clean up new rtl/surrogates.hStephan Bergmann3-24/+23
Change-Id: Iec781bdbbf216cb14c9ba5be5955123273d7699c
2015-04-20duplicate surrogate codeCaolán McNamara4-53/+3
Change-Id: I9fad024e4b5c8a4ca272f2387df07351198cf5dc
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin28-65/+65
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-10Update @since tags LO 4.5 -> 5.0Stephan Bergmann1-1/+1
Change-Id: Idb2e46fcaa080d6763d2e3ed963f7673a2353eb2
2015-04-09WaE: VarDecl, use "bool" instead of "sal_Bool"Tor Lillqvist1-2/+2
Change-Id: I0b868edad579f9ccf46f6d9f6015086557e528da
2015-04-09Change from <osl/diagnose.h> to <sal/log.hxx> and add more loggingTor Lillqvist1-23/+25
Change-Id: Iee8c093f5aa8306c3e5336d6dd5e801df6df87a4
2015-04-08tdf#43157: remove osl/diagnose.h dependency from sal/osl/unx/socket.cxxJorge Cunha Mendes1-93/+100
Change-Id: I2becc1cbb875270e2a1e8ed6b7cb0f9b6bdbf2f9 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-08-Werror=maybe-uninitializedStephan Bergmann1-0/+1
Change-Id: I7d3c36e564b3a5286ebd32527575472313119587
2015-04-08tdf#88169: Do not return ..._INFO_SRCBUFFERTOSMALL when ..._FLAGS_FLUSHStephan Bergmann1-79/+84
...in accordance with <http://www.openoffice.org/udk/cpp/man/spec/textconversion.html> Change-Id: I62013f89c421722770123db8a5794e63d3572e6b
2015-04-04Typo: creat->createJulien Nabet3-11/+11
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
2015-04-02Move osl::LibreOfficeKit stuff to comphelper for nowTor Lillqvist2-22/+0
Let's see where it actually will be needed. Sal is a "picky" place for new API, even inside LIBO_INTERNAL_ONLY. Change-Id: Ia0c5ee8cfc6ee526c5ad34d2f8aab0b14b5f805b
2015-04-01Add API to check whether being used through LibreOfficeKitTor Lillqvist2-1/+24
LibreOffice code, when used in a program through LibreOfficeKit, needs to be aware of that in certain crucial spots, to avoid behaviour and functionality that makes no sense in a LibreOfficeKit scenario. As LibreOfficeKit uses a normal LibreOffice installation to perform its job, this can't be a compile-time choice. Also, none of the existing run-time "headlessness" modes fully match what is needed. Change-Id: Iaccf7f958c549f019b508854800519f54dcadb11
2015-03-31Use OUString::unacquiredStephan Bergmann1-1/+1
found with git grep -E '\* *\<reinterpret_cast\>[^>]+\<OUString\>' Change-Id: I9306d4ad8e3b1664f54cb7df86f2d79bfd3c6cb9
2015-03-31loplugin:redundantcastStephan Bergmann1-1/+1
Change-Id: I6c405287266572598a86b534552ed2f7bdff7fa2
2015-03-31V597: introduce a rtl_secureZeroMemoryCaolán McNamara4-3/+23
Change-Id: Id28046eb318cd3b2ed0b813fd266617547cf6ee2
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2-2/+2
Change-Id: Ic03728b2824eb59b9b6351a88ec355bfb93154cb
2015-03-30Return value 0 from connect() is not an error, errno is not setTor Lillqvist1-1/+0
No need to SAL_WARN it, it is a common non-exceptional case (when attempting to start a second LO instance). Change-Id: I26f2939d2f5b97ddfcc9e912e578b706567b3912
2015-03-30Bootstrap.initVCL is not used by our Android app any moreTor Lillqvist1-15/+0
Change-Id: Id1e58547cf2b0786d7a2ca29eae8bbcdd644fdd5
2015-03-29Minor simplificationTor Lillqvist1-5/+2
Change-Id: Idcf9158d0446107ec783fd8691078791d7b25e31
2015-03-29loplugin:cstylecastStephan Bergmann1-3/+3
Change-Id: Iec37e09d0da181f6af268fa0c8c43a2e1fef5dbe
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann37-239/+239
Change-Id: I5e370445affbcd32b05588111f74590bf24f39d6
2015-03-27loplugin:staticfunctionNoel Grandin3-5/+5
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann5-5/+5
Change-Id: I03e43d219a65aa270f73a91896e0e7a567d424bc
2015-03-24loplugin:constantfunction: variousNoel Grandin1-9/+6
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-23Sanitize a few SAL_INFOsTor Lillqvist1-4/+2
Change-Id: Ib5e7e9250f90a9282c25446b606166499fc9d369
2015-03-19CppCheck cleaning : scope reduction and printf formatMichaël Lefèvre1-8/+8
Change-Id: I43ba76194ee135ffe2398267ed810cca116a1e43 Reviewed-on: https://gerrit.libreoffice.org/14854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-03-16tdf#89361 Remove remnants of Gopher supportAdolfo Jayme Barrientos1-1/+0
Change-Id: Ib2038a43b0d49a525199329a2c79d5779f5322fa Reviewed-on: https://gerrit.libreoffice.org/14471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-03-13CppCheck cleaning : avoid static string comparisonMichaël Lefèvre1-5/+2
Change-Id: I6a7375901fcec63892041aec8cc2d55ce7789724 Reviewed-on: https://gerrit.libreoffice.org/14848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-12sal: add comment re: V718 'CreateThread' should not be called from 'DllMain'Michael Stahl1-0/+6
Change-Id: I6e444e6c3dd4f5e158fe9b649b97ccb5ca32c3a7
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 05:42:38 +0000