summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2013-02-22silence warning.Michael Meeks1-1/+1
Change-Id: Ibf82038c15c9ecf6de502bae1dd21e2393cafe09
2013-02-22Fix misspellings detected by https://github.com/lyda/misspell-checkTor Lillqvist20-42/+42
Just as a test to check the usefulness of that tool. It needs some improvement before really usable. Change-Id: I875e79c1992ed5f3b695736b0d49938ad0ba2d55
2013-02-22s/the the/the/Tor Lillqvist4-4/+4
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-21remove un-conditional 20 second sleep on-start for now.Michael Meeks1-0/+2
Change-Id: I37ff2164b1f0fcdc4f3fad41f344b0d73105a2c1
2013-02-21android: finally starting and rendering at least something again.Michael Meeks1-0/+1
Only renders on very-first-start after install (oddly). We initialize vcl in it's own thread to avoid problems. Thanks to tml for fixing a linking issue. Change-Id: I960d11c6098681356fea0634970545aa9af9bacb
2013-02-21Revert "Clean up remains of NativeActivity-based Android app support"Michael Meeks9-20/+971
This reverts commit cecc926070ee3d2ad6296fc5e0cfcde8642bb140. Conflicts: sal/android/lo-bootstrap.c sal/inc/osl/detail/android-bootstrap.h
2013-02-21Fix type unkown -> unknownJulien Nabet1-1/+1
Change-Id: I8d55d5ae5ae38ae2b252859b5400e36301f19ef0
2013-02-19fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan2-6/+12
- replaced osl_trace with sal_info - added new log areas to log-area.dox Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591 Reviewed-on: https://gerrit.libreoffice.org/2010 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-02-18added i18n sectionEike Rathke1-1/+6
Change-Id: I98a22066c711b56494f327ef40f45c37472ec888
2013-02-16Remove mis-optimizationStephan Bergmann1-2/+1
Assume thread t1 creates OUString s, then spawns thread t2, then t2 acquires s, then t2 signals via a channel that does not necessarily involve memory synchronization (e.g., writes a byte into a pipe which t1 reads), then t1 releases s and can still see a refCount of 1 instead of 2. Change-Id: I31047a1a6cc8fccc401a87849f5c3cee3642d803
2013-02-15prevent out-of-bounds buffer writes in EnumLocalesParamsEike Rathke1-12/+27
osl_getTextEncodingFromLocale() In case of the Language code being longer than 2 characters the string written to the struct EnumLocalesParams member was not 0-terminated if a Country code was also given (consecutive fields in the struct) unless the struct was packed in 4-byte alignment and luckily contained a 0 as the 4th byte. The locale could not had been matched in these cases. In case of a sufficiently long language or country argument the entire EnumLocalesParams struct could had been overflown. Change-Id: I1ec67ad0b3d12b0fa944d7e759bb5cb701842e39
2013-02-14rhbz#908674: Adapt rtl::Allocator::construct to C++11Stephan Bergmann1-0/+12
...otherwise, at least with some --with-system-boost versions and C++11 compilers, like with Fedora's boost-1.50.0-4.fc18.x86_64 and gcc-c++-4.7.2-8.fc18.x86_64, using this to copy-construct an instance of boost::unordered::detail::ptr_node<std::pair<rtl::OUString,Bootstrap_Impl*>> in the call to p_bootstrap_map->insert(...) in rtl_bootstrap_args_open (sal/rtl/source/bootstrap.cxx) would memcopy the ptr_node and fail to call rtl_uString_acquire, leading to memory corruption later on when rtl_uString_release is called one time too often. It is not entirely clear to me whether this is a shortcoming of the given Boost version, but this patch solves the problem and brings rtl::Allocator::construct in line with the (changed) Allocator requirements of C++11 anyway. The problem potentially lurks with every use of rtl::Allocator, but only showed now begining with LO 4.0 where e5111574fd904b38a3980ca4ea3d21cfcb22dea6 "Revert 'sb140: sb140: #i116981# clean up memory upon exit'" re-introduced code into rtl_bootstrap_args_open that inserts into a boost::unordered_map that uses rtl::Allocator. Change-Id: I3be22f59a8eb49d31458480c27f3ce15803c7fd4
2013-02-13sax: convert some legacy assertionsMichael Stahl1-0/+1
Change-Id: I3b4f1caa2c2d7a0fd88ea53bf05d01b2c7cc115a
2013-02-10embeddedobj: log some exceptionsMichael Stahl1-0/+5
Change-Id: I2e565bc6e57f7bf59fdd6eb5fc577e0b3d58b9f6
2013-02-08Some cppcheck cleaningJulien Nabet2-6/+2
Change-Id: I1dc8415569f7133d57c495e47f038e98d50d64d7
2013-02-07improve comments of isEmpty()Chr. Rossmanith4-7/+20
Change-Id: I6542470c2d4b27de25e263651e25baf85c7d018d
2013-02-06O(U)String::valueOf don't duplicate codeDavid Ostrovsky2-8/+2
Change-Id: I586fca181f63999a8f2d19d600b69f6788fd61d9 Reviewed-on: https://gerrit.libreoffice.org/1992 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-02-06add method isEmpty() to OUStringBufferChr. Rossmanith1-0/+13
Change-Id: Ia11d97eebbb08e8058a5f919ed3db3029ce39a78 Reviewed-on: https://gerrit.libreoffice.org/2017 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-05New log area (for previous commit)Stephan Bergmann1-0/+1
Change-Id: I9cc1fdfa7acad6c233b68eb23dea39c58d4cecaa
2013-02-05testOUBoolean should test with OUString, not OStringLionel Elie Mamane1-1/+1
Change-Id: I103ca7d72e6bae6c20605719451579dd156504ce
2013-02-04Use SAL_STRINGIFYStephan Bergmann1-6/+2
Change-Id: Ibdb7d143e02301fdd8d04cf1c59421dcd98dac2f
2013-02-04remove sal_Bool from boolean() docs tooLuboš Luňák2-4/+4
2013-02-04OK for boolean() to take true bool argumentStephan Bergmann3-4/+28
...instead of sal_Bool; this would cause C4800 performance warnings with MSVC, but we disable them anyway. Also, added unit tests that are actually executed. Change-Id: Ib405132565918be72d93b3fc24180edcb6e565c7
2013-02-04Strings: boolean() as a replacement for valueOf(sal_Bool)David Ostrovsky4-12/+44
valueOf(?) has been superseded by number(?). O(U)String::valueOf(sal_Bool) has been deprecated without providing an alternative method. Use boolean() method as a replacement for it. Change-Id: I7eb74574fa8f1a3cf007cb0cbc32e681007ffb92 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-02-04add OUString::toUInt64()David Ostrovsky4-70/+117
Change-Id: I2051e161219d424d2c2b69faf6f939cfe21fa5f7 Reviewed-on: https://gerrit.libreoffice.org/1980 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-31Add vcl.atsui and vcl.coretextTor Lillqvist1-0/+2
Change-Id: I9c9db51f04db5a0d073bd7493c198e8413299633
2013-01-31fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan1-0/+1
- replaced OSL_TRACE with SAL_INFO Change-Id: I4d63df493e85bc095b8a11e3842b0d69c5217c96 Reviewed-on: https://gerrit.libreoffice.org/1804 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30Introduce SAL_OVERRIDEMiklos Vajna1-0/+13
Change-Id: I3675b627d5e9ca19b2c4fb69fef12d0dabf94a43
2013-01-30osl::{File,Directory}::getURL() had curiously been missingStephan Bergmann1-0/+18
Change-Id: I0af83e7aeaf681440d4bbb50d8b00390f8464b1a
2013-01-30make SAL_WNODEPRECATED_DECLARATIONS_PUSH work also with ClangLuboš Luňák1-1/+1
Clang claims to be GCC version older than the one tested for. Change-Id: Ia9886915f62f886810e091f66d8e5710047e2e2f
2013-01-30Get rid of STAR_RESOURCEPATHStephan Bergmann1-0/+1
...the only remaining use was for CppunitTest to find the .res files in $(OUTDIR)/bin/. Get that solved by delivering the .res files also to $(OUTDIR)/unittest/install/program/resource/ (new gb_ResTarget_get_unittest_target). Change-Id: I370e7cab4223256356c7511b88ae63d9c0dbf215
2013-01-29Strip SRCDIR from the logging outputTor Lillqvist2-2/+7
Change-Id: I6069102f6b9df72a63a840758158f672fdd6c621
2013-01-28cleanups for number() string functionLuboš Luňák6-245/+248
- add sal_uInt64 valueOf helper to handle its full value range - group deprecated valueOf() together - forward to the number() taking the largest type instead of repeating the same code every time - various doc improvements: - add missing @since - do not refer to non-existent number() overloads in docs - "use number" - "huh, of course I use a number?" - "code your own" - my own function? why? - + or += operators are not, strictly speaking, replacements for valueOf() Change-Id: Ib138a06c4ac4365cfffc534e6ab115d55180a70d
2013-01-28consolidate the float number testsLuboš Luňák1-25/+2
And remove some unneeded ones (the float actually didn't have the necessary precision on 32bit anyway). Change-Id: I52dd387fd319dd6a5b44333a71d012ebaaecbf18
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl5-1/+12
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-26Remove redundant braces around for loopsStephan Bergmann1-8/+8
...that had once been workarounds for compilers that did not yet support the C++98 scoping rules for declarations in for-init-statements. Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-23OSQLParser::RuleIDToRule should not silently change s_aReverseRuleIDLookupLionel Elie Mamane1-0/+1
Change-Id: I2b408a23162b1200bbcd530be7acb42435388b04
2013-01-22refer more explicitly to sal/inc/sal/log-areas.dox for adding new areasLuboš Luňák1-1/+2
Change-Id: If9eecbf69a4486dcd84d475719aa66f480faea0b
2013-01-21Revert "avoid -Wsign-promo warnings"Stephan Bergmann2-48/+0
This reverts commit 1efe9a15f86a7a9dc08b57fd1dd12336522ba515, which is obsoleted by 488823a140217e393298bc83e75084041a85ed45 "Remove -Wsign-promo."
2013-01-19Use default visibility for exception types even when DISABLE_DYNLOADINGTor Lillqvist1-4/+8
Otherwise the dlsym() lookup of the typeinfos in the C++/UNO bridge won't work. And it has to, because at least for iOS on ARM the dynamically created typeinfos don't match those the compiler-generated code tries to catch, so otherwise exceptions thrown across the bridge don't get caught. (Fascinating, I am able to talk about this stuff as if I understood it.) Change-Id: Ie0d4632743e18719782f55904fb76f45c944f20c
2013-01-19microoptimization for "" OUString ctorLuboš Luňák2-4/+16
Now 'OUString()' and '""' should be exactly the same, and thus the latter better :). Change-Id: If42b2ca5889967aaa8ccdaf531b45c75c12d54fd
2013-01-18avoid warning about a comparison being always trueLuboš Luňák2-0/+4
Change-Id: Ie0bd47a16af56b7d3ae070d5b82ec46ed21834c0
2013-01-18avoid -Wsign-promo warningsLuboš Luňák2-0/+48
I actually find the warning to be obsolete nonsense (the manpage talks about cfront), but at least for now. Change-Id: I4390b1779f6f8de062afd441f6855cb760adf93d
2013-01-18long and long long can be the same size (and thus also sal_Int64)Luboš Luňák3-1/+2
Change-Id: I3961ec27d23915b038c3a803dc71e7d937ca331c
2013-01-18Create OUString and OString number(*) methods.Noel Grandin4-12/+382
API CHANGE: Adds new methods (several overloads) OString::number() OUString::number() and marks all of the existing fromValue() methods as deprecated. The purpose of this change is to clean up call sites by hiding the necessary casts. The casts are necessary because of overload resolution rules which are somewhat vague about which methods to choose when using integer types. See mailing list discussion here: http://nabble.documentfoundation.org/replacing-OUString-valueOf-static-cast-lt-sal-Int32-gt-td4027989.html Subject: "replacing OUString::valueOf(static_cast<sal_Int32>) ??" Change-Id: Id3d150a6525eb0334e41e2ec6640bb06cd790b43 Reviewed-on: https://gerrit.libreoffice.org/1625 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-16fdo#58415: Don't ignore osl_getFileURLFromSystemPath failureStephan Bergmann1-5/+15
...in osl_getFileStatus et al, it would leave the relevant status string member unchanged (i.e., a null pointer) but would mark it as valid, so that later code to retrieve the allegedly valid string member would crash upon the null pointer. Change-Id: Ia8528f5dc27d94f3d14a2c416955a041b87863d3
2013-01-14Remove obsolete typesconfigStephan Bergmann2-446/+0
Change-Id: Ic3fd543351637c610621814bb8c8f4fa3cab64fc
2013-01-14Simplify codeStephan Bergmann1-29/+12
Change-Id: Ib35cba4544726c1653d36072f3499dffec3cced3
2013-01-11Fix workaround for thead-unsafe getenv againStephan Bergmann1-12/+24
...from d19c40f45dc8e8bcd9db4c6b83bdcf6367f6fbe7 "Work around some potential problems with thread-unsafe getenv" that had been broken with 60628799633ffde502cb105b98d3f254f93115aa "Notice if SAL_LOG is changed while the process is running." Change-Id: Ibd6dbc9921ae1f8dee114380f01a076b0770788c
2013-01-11Further socket callback clean-upStephan Bergmann3-16/+0
Change-Id: Ifcbb87cff50584934f214634c1b6f1d0a43ae8f3