summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini6-12/+12
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11improve SOLARIS guardRichard PALO1-1/+1
Change-Id: Ic5edb7c0977b6c589329cd80616aa320d6cc929b Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-11-11SOLARIS can use/should use posix_madvise under certain conditions.Richard PALO1-1/+1
Change-Id: Idc40752b4beee932b5912e6df9fe6acb15571201 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-11-10fix spelling implemenation -> implementationNoel Grandin2-4/+4
Change-Id: I5ac499df1f4063a80a5d41f60778106a7b96940d
2014-11-06Early return missingStephan Bergmann1-0/+2
Change-Id: I0d4f9b14f2a41a3acb08ba1b6c13fdf1174021e7
2014-11-06sal: it is impossible to have non-ASCII char hereMichael Stahl1-4/+1
...because rtl_ImplGetFastUTF8UnicodeLen has already checked that. Change-Id: I17f2b80f374073934a8f0b1a97099d4dec89ce4e
2014-11-06sal: do not ignore conversion flags for RTL_TEXTENCODING_ASCII_USMichael Stahl1-7/+12
Keep the fast path fast, fall back to the text encoder in case there's a fly in the ointment. Change-Id: I94507856a7f3170f770adb741aa1e282d0d2400c
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann2-15/+22
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin2-22/+15
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05markup with event type not checker typeCaolán McNamara3-0/+7
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-10-31cid#1202756 Clarify with assert that ave == 0 cannot happenStephan Bergmann1-0/+1
...so (highbit(ave) - 1) will never be negative and never cause undefined shift by negative value. Change-Id: I86703f03d30d48c74d2e814c182b9edb85d18186
2014-10-31cid#1202755 Clarify with assert that new_size == 0 cannot happenStephan Bergmann1-0/+2
...so arena->m_hash_shfit will never be negative and never cause undefined shift by negative value. Change-Id: Ifc3d28d53bae38bc8deea72473c81f1d043dc18e
2014-10-31cid#982172 Silently ignore F_SETFD FD_CLOEXEC failuresStephan Bergmann1-2/+2
...there should not be any legitimate reason these fcntl calls can fail, anyway. Change-Id: Ib5cbe5b40ff42656fe3bad2ac50dcf6faeca0e9d
2014-10-31cid#982171 Warn about rename failure in error clean-up codeStephan Bergmann1-1/+8
Change-Id: I02e81d526c07297a5bc3664cc475302a552187eb
2014-10-31Simplify by using OStringStephan Bergmann1-21/+7
Change-Id: Ia46417525e655a5a80f9e70f25f65e4916e4c8d8
2014-10-31cid#1242936 handle rename failureStephan Bergmann1-3/+18
Change-Id: I92ce690a6f8183ce77c8ed53bd2fcb45d39d756e
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30osl/unx: Remove ifdefery for ancient NetBSD < 3.0Riccardo Magliocchetti1-11/+0
Change-Id: I808da98a3b825eb2213dbcb6d435baa58bf54a9d Reviewed-on: https://gerrit.libreoffice.org/12151 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin6-9/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29fix spellingNoel Grandin1-1/+1
Change-Id: I08a5fb662a4a5d756b72340cb9328fc1dc1fe9fe
2014-10-28coverity#982593 experiment with silencing Infinite loopCaolán McNamara1-0/+2
etc. Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516
2014-10-24And $(ENABLE_CRASHDUMP) is "TRUE" or "", never "YES"Stephan Bergmann1-2/+1
Change-Id: I626bd8d29a7efe967608efbb21fda87e5692c0c8
2014-10-24The if(xmlout&&stackout&&checksumout) stack-walking can take obscenely longStephan Bergmann1-1/+1
...in sal/osl/unx/signal.c ReportCrash, so do not implicitly burden that on every --enable-dbgutil --disable-crashdump build. Change-Id: I2d03ea2715697bf7960ca7e9e55c72489ce24bae
2014-10-16MAC_OS_X_VERSION_MIN_REQUIRED is always >= 1080 nowTor Lillqvist1-2/+2
Change-Id: I40d03ab9acb67ab72b9047017452f069ce88fd4b
2014-10-16MAC_OS_X_VERSION_MAX_ALLOWED is always >= 1080 nowTor Lillqvist2-62/+0
Change-Id: Ieae67cbf917cdf4bca2b0d6c1697eddc6137dbe2
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann2-8/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15cppunittester: make tracking down temp file leaks easierMichael Stahl1-0/+3
Temp files created before first test method don't see LO_TESTNAME Change-Id: Iff74abf574f5151980f463646f11c1b32ad0c241
2014-10-14Remove spurious cpu_countStephan Bergmann1-17/+0
Change-Id: Ic90e806d279f8180d78f78597dbc549264338295
2014-10-14sal: cleanup unit tests whitespace.Michael Meeks1-79/+49
Change-Id: If067f755b99480b7b7bd0bd3bb7a71a447794273
2014-10-10coverity#1240258 Operands don't affect resultCaolán McNamara1-12/+17
try and silence coverity#1240258 Operands don't affect result and coverity#1240255 Operands don't affect result Change-Id: If53ff385585567e9b46372f45420c4321811bca0
2014-10-10coverity#1240260 Operands don't affect resultCaolán McNamara1-4/+2
see can we silence these false positives coverity#1240259 Operands don't affect result coverity#1240254 Operands don't affect result coverity#1240264 Operands don't affect result coverity#1240267 Operands don't affect result Change-Id: Ieca40474c231e33a516b70f7693346ac73babd61
2014-10-09More specificStephan Bergmann1-50/+41
Change-Id: I7e6490c5b50a236a5f070e98d4501e7dd5a90307
2014-10-09disable environment equality test under valgrindCaolán McNamara2-0/+20
Change-Id: I9e0e06331f134fe89c9942f93b7546b0e67bb821
2014-10-08Document how rtl::Uri::convertRelToAbs normalizes an absolute URL's pathStephan Bergmann1-1/+2
Change-Id: Ibf4f2d46bfbb977f0ba27110d86d7b7f1173631c
2014-10-03fix buildCaolán McNamara1-2/+2
Change-Id: I997dfa3b1fe651db56ad2a6a24ec0cb6d5044550
2014-10-03fix clang 3.5 buildNoel Grandin1-2/+2
Change-Id: I86fe850b4b7bc8fc4c44717ca813772114ca70ff
2014-10-03coverity#1241327 Dereference after null checkCaolán McNamara1-17/+15
Change-Id: I214884e9ee1d49dcc4db71f8744513468b912691
2014-10-03coverity#1241080 Dereference after null checkCaolán McNamara1-3/+2
Change-Id: I82113fcd4182f9557ba0e7258498b5d4e798bf03
2014-10-03Fix unbalanced new/free() -> new/deleteMatthew J. Francis1-1/+1
(Spotted while valgrinding an unrelated issue) Change-Id: I2eab4c08e251d79f427fd01442c4dce20d7d89f0 Reviewed-on: https://gerrit.libreoffice.org/11785 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02remove checks of __GCC_MINOR__ that are always true in GCC 4.6 or laterMichael Stahl2-3/+3
Change-Id: I4412a0c1e4dee94cd717f24b8df5e257d895f721
2014-10-01We require OS X SDK 10.8 or newer nowTor Lillqvist1-1/+1
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
2014-10-01Blind fix for AndroidStephan Bergmann1-2/+2
Change-Id: If997720635f99726e14c00132308529f96e639c8
2014-10-01sal: work around spurious Apple clang warning about pointer cast to intMichael Stahl1-1/+1
Change-Id: I4e4281ac8767c9a6b6b85bc759f28bcf074d8e39
2014-10-01Use sal/log.hxxStephan Bergmann1-41/+75
Change-Id: I54fd66b8788171884c6d3d6e7645871615d48080
2014-10-01sal/osl/unx/thread.c -> .cxxStephan Bergmann2-14/+13
Change-Id: I6cb46a51dda3fda51a3b6413656da15fc5bdb04d
2014-10-01fdo#82577: Handle TimeNoel Grandin1-1/+1
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30Get rid of some auto_ptrStephan Bergmann1-6/+4
Change-Id: Icd477e433f0c294c823c64147d49fb4ac6bfb447
2014-09-29Pretend the app-specific "Documents" directory is the home directory on iOSTor Lillqvist1-0/+19
Change-Id: If8fda4b27adb2f83cbdfdbb20d90ced77e467a54
2014-09-24fdo#39625 Delete unused cppunittestsTobias Madl3-1035/+0
As discussed with Stephan Bergmann, these files, which contained unused cppunittests, could be removed. Change-Id: I91844b96967e3c3e0e8367452f2dda420f479ffe Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-17The URE unorc is now set up in instsetoo_native/CustomTarget_setup.mkTor Lillqvist1-1/+0
So no need to expand it at configure time in ure/source/unorc, and no need to handle the related builddir!=srcdir complications. Change-Id: Ifa34d25fab9ad2da13ed039bf6c5921b0fb58703
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-10 15:27:41 +0000