Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d
Reviewed-on: https://gerrit.libreoffice.org/3499
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: Icce3ffd29398a3488e7704562a4e9064f106b393
|
|
|
|
This reverts commit dd47994722eaead16099145e593fbf878072d52b.
|
|
Change-Id: I1151dafcef91abdb2ce08abe3547a49fe3f4a67c
Reviewed-on: https://gerrit.libreoffice.org/3509
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Change-Id: I37635f9bd86d194b303705a58d81502d7d586692
|
|
* RTL_CONTEXT_foo is originally intended to be used for performance
measurement, but mostly unused right now
* however its macros are sprinkled all over the codebase and might
provide good help for ad-hoc debugging, and prevent SAL_INFO
duplication
* if there is no performance logging, these macros are now forwarded to
SAL_INFO with logarea "logfile" or "$AREA.logfile"
Change-Id: I495c8924e5b55124f7eac68eccda074d0740c117
Reviewed-on: https://gerrit.libreoffice.org/3421
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I1ec2aa4d0ed0940e7c0a26a18c78f2df4693d278
|
|
Change-Id: If32923e35ef97f42d5203975362e5c76948ff327
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
|
|
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
|
|
Change-Id: Icc53c25400acb46070fead08f7602295599fc6c8
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, with slight modifications
to sal/inc/rtl/character.hxx:
* Replaced "#pragma once" with explicit include guard for now.
* Missing includes.
* Cosmetic clean-up.
Change-Id: I94d01cd4e766f92c70f941839a67101fa2c97654
|
|
Since we no longer support the old Apple SDK using gcc-4.0.1, we can
remove the cruft to work around its problems. Woohoo.
Change-Id: Idf275e76449443f1f0314e75dab993f213a77eb7
|
|
...and fixing two call-sites.
Change-Id: I8ed8cb189bd5034130b49b2f57156568e6b24716
|
|
...inspired by comments to <https://gerrit.libreoffice.org/#/c/3068/>
"String::AppendAscii cleanup in dbaccess," but it quickly becomes apparent that
lots of code rely on s[s.getLength()] == 0, so live with a weakened precondition
check for now.
Change-Id: Ifad96c706b14433df4a084ab8054b32433b8b5b6
|
|
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
|
|
Change-Id: I1c5b66888baac8aa1bc99c06579e0ef3638a4877
|
|
Change-Id: Ic908cb5cc9169ab1baae2c1c52070adfb9afba39
|
|
...which must be included first thing everywhere anyway.
Change-Id: Idbbf941b526f48a89d6398e19404b1ff0e23a6b4
|
|
Change-Id: I3a41036ec03cdaefea94b19dbedf59e5a5e37dc8
|
|
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html
Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
|
|
Change-Id: I9181cad5bfa93f9e8b3d944b2b50a3ccc0b42595
|
|
Change-Id: Idd62c2768a03f7aab8ff11165425f8c383653f38
|
|
Change-Id: I46ccba35be6695dba14721303b5eb52f69fc3dfa
|
|
Change-Id: Ibac7f624f1a1dcce653dff4bec573be457d70075
Reviewed-on: https://gerrit.libreoffice.org/2125
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
|
|
Change-Id: Id4c5907b2431130018bff434049d9e85ae689793
Reviewed-on: https://gerrit.libreoffice.org/2365
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Niko Rönkkö <ronkko@iki.fi>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: Iba2ee6f72c5d3fe35a22a6b2a6b42866fd8fb6fd
|
|
Change-Id: Ic511a4a399ae2d75de6050ac8e3f77ee13ec8275
|
|
Changed all occurrences of 'charcter' found by git grep. All of them
were used in comments only, so it should not break anything.
Change-Id: Ief2c00d929ae7972c55a4920fc0eaa8d6b18ab82
Reviewed-on: https://gerrit.libreoffice.org/2372
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
...otherwise, at least with some --with-system-boost versions and C++11
compilers, like with Fedora's boost-1.50.0-4.fc18.x86_64 and
gcc-c++-4.7.2-8.fc18.x86_64, using this to copy-construct an instance of
boost::unordered::detail::ptr_node<std::pair<rtl::OUString,Bootstrap_Impl*>> in
the call to p_bootstrap_map->insert(...) in rtl_bootstrap_args_open
(sal/rtl/source/bootstrap.cxx) would memcopy the ptr_node and fail to call
rtl_uString_acquire, leading to memory corruption later on when
rtl_uString_release is called one time too often.
It is not entirely clear to me whether this is a shortcoming of the given Boost
version, but this patch solves the problem and brings rtl::Allocator::construct
in line with the (changed) Allocator requirements of C++11 anyway.
The problem potentially lurks with every use of rtl::Allocator, but only showed
now begining with LO 4.0 where e5111574fd904b38a3980ca4ea3d21cfcb22dea6 "Revert
'sb140: sb140: #i116981# clean up memory upon exit'" re-introduced code into
rtl_bootstrap_args_open that inserts into a boost::unordered_map that uses
rtl::Allocator.
Change-Id: I3be22f59a8eb49d31458480c27f3ce15803c7fd4
|
|
Change-Id: I6542470c2d4b27de25e263651e25baf85c7d018d
|
|
Change-Id: I586fca181f63999a8f2d19d600b69f6788fd61d9
Reviewed-on: https://gerrit.libreoffice.org/1992
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
Change-Id: Ia11d97eebbb08e8058a5f919ed3db3029ce39a78
Reviewed-on: https://gerrit.libreoffice.org/2017
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
...instead of sal_Bool; this would cause C4800 performance warnings with MSVC,
but we disable them anyway.
Also, added unit tests that are actually executed.
Change-Id: Ib405132565918be72d93b3fc24180edcb6e565c7
|
|
valueOf(?) has been superseded by number(?).
O(U)String::valueOf(sal_Bool) has been deprecated without providing an
alternative method. Use boolean() method as a replacement for it.
Change-Id: I7eb74574fa8f1a3cf007cb0cbc32e681007ffb92
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I2051e161219d424d2c2b69faf6f939cfe21fa5f7
Reviewed-on: https://gerrit.libreoffice.org/1980
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
- add sal_uInt64 valueOf helper to handle its full value range
- group deprecated valueOf() together
- forward to the number() taking the largest type instead of repeating
the same code every time
- various doc improvements:
- add missing @since
- do not refer to non-existent number() overloads in docs
- "use number" - "huh, of course I use a number?"
- "code your own" - my own function? why?
- + or += operators are not, strictly speaking, replacements for valueOf()
Change-Id: Ib138a06c4ac4365cfffc534e6ab115d55180a70d
|
|
This reverts commit 1efe9a15f86a7a9dc08b57fd1dd12336522ba515, which is obsoleted
by 488823a140217e393298bc83e75084041a85ed45 "Remove -Wsign-promo."
|
|
Now 'OUString()' and '""' should be exactly the same, and thus the latter better :).
Change-Id: If42b2ca5889967aaa8ccdaf531b45c75c12d54fd
|
|
Change-Id: Ie0bd47a16af56b7d3ae070d5b82ec46ed21834c0
|
|
I actually find the warning to be obsolete nonsense (the manpage talks
about cfront), but at least for now.
Change-Id: I4390b1779f6f8de062afd441f6855cb760adf93d
|
|
Change-Id: I3961ec27d23915b038c3a803dc71e7d937ca331c
|
|
API CHANGE: Adds new methods (several overloads)
OString::number()
OUString::number()
and marks all of the existing fromValue() methods as deprecated.
The purpose of this change is to clean up call sites
by hiding the necessary casts.
The casts are necessary because of overload resolution rules which are
somewhat vague about which methods to choose when using integer types.
See mailing list discussion here:
http://nabble.documentfoundation.org/replacing-OUString-valueOf-static-cast-lt-sal-Int32-gt-td4027989.html
Subject: "replacing OUString::valueOf(static_cast<sal_Int32>) ??"
Change-Id: Id3d150a6525eb0334e41e2ec6640bb06cd790b43
Reviewed-on: https://gerrit.libreoffice.org/1625
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
|
|
with """
newFromLiteral doesn't cheat, it's broken
This reverts commit 8b9b779e9fc1de7186217b7be75ef02bb66e2da9.
|
|
don't call rtl_uString_newFromLiteral when literal has zero length as
that cheats and doesn't assign a buffer. what we really want to do
is assign a buffer with initial capacity ( but no content )
Change-Id: I9d642c453dee747aca6365abb15408c05f86bb52
|
|
|
|
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, adapted some function
definitions in sal/osl/all/compat.cxx to avoid "must return a value" warnings.
Change-Id: Iac156b004464018225bbfda24f0a234f9ebcb19f
|
|
Change-Id: Id5ca706aa3fd1831990db2310933c6b94ca376cb
|