path: root/rsc
AgeCommit message (Collapse)AuthorFilesLines
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann1-10/+10
Change-Id: I1e62523e08e6f1e7ec926b1a5e7c45d7c688f781
2015-05-02Bin empty eval statementMatúš Kukan1-3/+0
Change-Id: I52755c373f86490ba3e8910e71e3fab88b1ca38c
2015-04-30Gradually typed LinkStephan Bergmann2-2/+2
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29Clean up tools/link.hxxStephan Bergmann1-0/+3
Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
2015-04-29Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann1-9/+5
...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
2015-04-29cppcheck: invalidPrintfArgType_uintCaolán McNamara1-1/+1
Change-Id: I5a0b5a4ff60c508f8ea11d613022ee7799900098
2015-04-24loplugin:simplifyboolStephan Bergmann1-3/+3
Change-Id: I86cec7670db8594a7563e86c6645c480d3f8702c
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-20rsc crash on WIN64 due to LP64Norbert Thiebaud4-30/+30
rsc stash stuff in a 'value' filed that was defined as 'long' saddly it stash also pointer there... which on WIN64 truncate 64 bits pointers in 32 bits scalar. That went unnoticed for years because on every other platform sizeof(long) = sizeof(void*) Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7 Reviewed-on: Tested-by: Jenkins <> Reviewed-by: Norbert Thiebaud <>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-2/+2
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann1-1/+1
Change-Id: I5be4952b732eab9a32aeaee7eb45a68698be4ad2
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann16-71/+71
Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
2015-03-27loplugin:staticfunctionNoel Grandin5-6/+6
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2-6/+6
Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
2015-03-26tdf#39440 cppcheck cleanliness, Fixing basic cpp errorsVarun1-1/+1
Initialized a non-initialized integer variable which is widely used in if else Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2015-03-24loplugin:constantfunction: rscNoel Grandin5-22/+0
Change-Id: I574bac6b25c9f36ff3d545420ea49d99a9c79b05
2015-03-05Explicitly default the copy ctorStephan Bergmann1-1/+1
(better than making it implicitly declared, as defining it defaulted is deprecated for that case because of the user-declared copy assignment op) Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
2015-03-02V805: Decreased performanceCaolán McNamara1-1/+1
Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
2015-03-02remove executable bit from c / h / cxx / hxx / l filesMichael Stahl3-0/+0
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
2015-03-01wrong length value for string lengthMarkus Mohrhard1-1/+1
Change-Id: Ic8b41ec4bb6b46177b02f533b936ab678207f926
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin19-111/+108
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-09Werror: data lost during conversion from size_t to intDavid Ostrovsky3-8/+9
Change-Id: Iee080b89cf0588c8076ef4c0334d36a7aefce44d Reviewed-on: Tested-by: Michael Stahl <> Reviewed-by: Michael Stahl <>
2015-01-26coverity#1266502 Useless callCaolán McNamara1-6/+0
Change-Id: I443cc28b81508b32c49ba795583ed304729d3fa0
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin1-5/+5
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin1-5/+5
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: rscStephan Bergmann14-183/+178
Change-Id: If62d142481cb3520042a040325bdd9167ae178e7
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin4-11/+0
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin1-2/+2
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin2-3/+6
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara5-10/+10
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02Remove unnecessary comphelper::string::getTokenStephan Bergmann2-5/+4
Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
2014-12-31various other apparently unnecessary rsc stuffCaolán McNamara4-42/+0
Change-Id: I745695a92023e7a14ee547ca6bef5981dd329d19
2014-12-31drop dateformatter resource loadingCaolán McNamara3-93/+0
Change-Id: Ie94c7502b0a82ca406b8d76e18def7bab8233a00
2014-12-31drop timeformatter resource loadingCaolán McNamara3-78/+0
Change-Id: I11de468ab65aa4dec761fbcc1e9416528c332dd5
2014-12-31TimeFields not loaded from resource files anymoreCaolán McNamara3-25/+0
Change-Id: Idf69d375eff4bfff7115e59530b37200ee79f086
2014-12-28splitters no longer loaded from resource filesCaolán McNamara3-23/+0
Change-Id: I84ee0c754118882734301bf1d34c15ba640a3889
2014-12-22HelpButtons no longer loaded from .rsc filesCaolán McNamara1-9/+0
Change-Id: I0fe82e319ac44a189e93fabd932e3e0a891598d2
2014-12-19fdo#39440 rsc: reduce scope of local variablesMichael Weghorn4-22/+10
This addresses some cppcheck warnings. Change-Id: I69454a75c8ce4aecf9e68f5887f38f8bf6fe6dca Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-11-21document coverity#983096 Resource leakCaolán McNamara1-0/+1
Change-Id: If5a60dac2329432b30a7b5528e0fca05d4369b1a
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-2/+2
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <>
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin2-4/+6
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Noel Grandin <>
2014-11-03coverity#982297 EBCDIC-related cleanupCaolán McNamara2-3/+2
Change-Id: I8da7911c342ffe114d7b25b996602aabed7aa1ed
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin2-5/+8
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-28sal_Int16 as the underlying type of WindowBorderStyleTakeshi Abe1-1/+1
because g++ 4.7.2 generates [-Werror=type-limits] as follows: > [build CXX] vcl/source/window/settings.cxx > [build CXX] vcl/source/window/paint.cxx > [build CXX] vcl/source/window/resource.cxx > [build CXX] vcl/source/window/accel.cxx > [build CXX] vcl/source/window/accmgr.cxx > [build CXX] vcl/source/window/brdwin.cxx > [build CXX] vcl/source/window/accessibility.cxx > [build CXX] vcl/source/window/legacyaccessibility.cxx > [build CXX] vcl/source/window/clipping.cxx > [build CXX] vcl/source/window/stacking.cxx > [build CXX] vcl/source/window/debug.cxx > [build CXX] vcl/source/window/globalization.cxx > [build CXX] vcl/source/window/btndlg.cxx > [build CXX] vcl/source/window/builder.cxx > [build CXX] vcl/source/window/cmdevt.cxx > [build CXX] vcl/source/window/cursor.cxx > [build CXX] vcl/source/window/debugevent.cxx > [build CXX] vcl/source/window/decoview.cxx > In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0, > from /home/tabe/core/include/vcl/keycodes.hxx:23, > from /home/tabe/core/include/vcl/keycod.hxx:26, > from /home/tabe/core/vcl/inc/svdata.hxx:35, > from /home/tabe/core/vcl/source/window/brdwin.cxx:21: > /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]': > /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here > /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > cc1plus: all warnings being treated as errors > make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [vcl.all] Error 2 > tabe@thunk:~/build$ Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin2-4/+7
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Noel Grandin <>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin2-19/+21
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin1-1/+3
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin2-4/+5
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin2-12/+13
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin2-24/+26
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>