summaryrefslogtreecommitdiff
path: root/rsc/inc
AgeCommit message (Collapse)AuthorFilesLines
2015-04-30Gradually typed LinkStephan Bergmann1-1/+1
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29Clean up tools/link.hxxStephan Bergmann1-0/+3
Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
2015-04-24loplugin:simplifyboolStephan Bergmann1-3/+3
Change-Id: I86cec7670db8594a7563e86c6645c480d3f8702c
2015-04-20rsc crash on WIN64 due to LP64Norbert Thiebaud1-3/+3
rsc stash stuff in a 'value' filed that was defined as 'long' saddly it stash also pointer there... which on WIN64 truncate 64 bits pointers in 32 bits scalar. That went unnoticed for years because on every other platform sizeof(long) = sizeof(void*) Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7 Reviewed-on: https://gerrit.libreoffice.org/15394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-2/+2
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-27loplugin:staticfunctionNoel Grandin5-6/+6
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-05Explicitly default the copy ctorStephan Bergmann1-1/+1
(better than making it implicitly declared, as defining it defaulted is deprecated for that case because of the user-declared copy assignment op) Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin5-27/+24
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin1-5/+5
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin1-5/+5
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: rscStephan Bergmann4-13/+13
Change-Id: If62d142481cb3520042a040325bdd9167ae178e7
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin3-9/+0
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-06fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin1-0/+3
Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara2-5/+5
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-31various other apparently unnecessary rsc stuffCaolán McNamara1-10/+0
Change-Id: I745695a92023e7a14ee547ca6bef5981dd329d19
2014-12-31drop dateformatter resource loadingCaolán McNamara1-3/+0
Change-Id: Ie94c7502b0a82ca406b8d76e18def7bab8233a00
2014-12-31drop timeformatter resource loadingCaolán McNamara1-3/+0
Change-Id: I11de468ab65aa4dec761fbcc1e9416528c332dd5
2014-12-31TimeFields not loaded from resource files anymoreCaolán McNamara1-1/+0
Change-Id: Idf69d375eff4bfff7115e59530b37200ee79f086
2014-12-28splitters no longer loaded from resource filesCaolán McNamara1-1/+0
Change-Id: I84ee0c754118882734301bf1d34c15ba640a3889
2014-11-05fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin1-0/+2
Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin1-0/+3
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28sal_Int16 as the underlying type of WindowBorderStyleTakeshi Abe1-1/+1
because g++ 4.7.2 generates [-Werror=type-limits] as follows: > [build CXX] vcl/source/window/settings.cxx > [build CXX] vcl/source/window/paint.cxx > [build CXX] vcl/source/window/resource.cxx > [build CXX] vcl/source/window/accel.cxx > [build CXX] vcl/source/window/accmgr.cxx > [build CXX] vcl/source/window/brdwin.cxx > [build CXX] vcl/source/window/accessibility.cxx > [build CXX] vcl/source/window/legacyaccessibility.cxx > [build CXX] vcl/source/window/clipping.cxx > [build CXX] vcl/source/window/stacking.cxx > [build CXX] vcl/source/window/debug.cxx > [build CXX] vcl/source/window/globalization.cxx > [build CXX] vcl/source/window/btndlg.cxx > [build CXX] vcl/source/window/builder.cxx > [build CXX] vcl/source/window/cmdevt.cxx > [build CXX] vcl/source/window/cursor.cxx > [build CXX] vcl/source/window/debugevent.cxx > [build CXX] vcl/source/window/decoview.cxx > In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0, > from /home/tabe/core/include/vcl/keycodes.hxx:23, > from /home/tabe/core/include/vcl/keycod.hxx:26, > from /home/tabe/core/vcl/inc/svdata.hxx:35, > from /home/tabe/core/vcl/source/window/brdwin.cxx:21: > /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]': > /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here > /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > cc1plus: all warnings being treated as errors > make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [vcl.all] Error 2 > tabe@thunk:~/build$ Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin1-1/+4
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-0/+2
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin1-1/+3
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin1-0/+1
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-0/+1
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin1-0/+2
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin3-9/+9
Change-Id: I20eb45dda584c1c3a2e5d72425e49627fb7c3866
2014-09-06FloatingWindows are no longer loaded from resource filesCaolán McNamara1-2/+0
Change-Id: I2705bbb4db52779e0065400f09604384fd9cf151
2014-08-26ModalDialogs no longer loaded from resource filesCaolán McNamara1-1/+0
Change-Id: I2d208c7cc5ff9bf26bff5ab2aa40e0bf57373342
2014-08-25MessBox not loaded from resource files anymoreCaolán McNamara1-5/+0
Change-Id: I12378a1c80e1070763cd2bd0539d74f4cc270a30
2014-08-16RSC_TRISTATEBOX is no longer usedCaolán McNamara1-1/+0
Change-Id: Ib3f43db131cf5562ad011538873c2ee51839665c
2014-08-16RSC_MULTILINEEDIT no longer usedCaolán McNamara1-1/+0
Change-Id: If56233b5226cec9516d5e2f8992e1b0beae733bf
2014-08-16RSC_MENUBUTTON is not in use anymoreCaolán McNamara1-1/+0
Change-Id: I853b6b1cfcd4847603d9920a47298d1b9105b46f
2014-08-15drop TabControl resource loaderCaolán McNamara1-3/+0
Change-Id: Idb909c205dfadaadeb8b98ce08fe2f4286cfce26
2014-08-11various ids not loaded from .res anymoreCaolán McNamara1-2/+0
Change-Id: Id2fab3e4b7a8feed3107e66d02cdf2a278ae9ef7
2014-07-02callcatcher: rsc loaded fixedbitmap is no moreCaolán McNamara1-1/+0
Change-Id: Ie111d9ed3534eb8892400d638eac4b38b3904646
2014-06-15callcatcher: update unused codeCaolán McNamara1-2/+0
and strip away some stuff in rsc that should now be dead Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
2014-06-11cut out the rsc loading support for stuff thats now .ui onlyCaolán McNamara1-3/+0
Change-Id: I54880de44ee10d4f71c8a514f905e8e00774fde7
2014-06-01fdo#68849: Add header guards to all include filesJens Carl2-1/+7
Added header guards to files in directories l10ntools/, lotuswordpro/, and rsc/ Change-Id: I9c034d4bb5c92d78378bda4658d43a8b603d5281 Reviewed-on: https://gerrit.libreoffice.org/9581 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold20-58/+58
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-16Some trivial -fsanitize=undefined adaptionsStephan Bergmann1-1/+1
Change-Id: I60f6e2b5f041919319cb6b72684b8b7b8504560c
2014-04-14remove outdated RS6000 checksThomas Arnhold1-5/+1
2014-04-04coverity#707972 Uninitialized scalar fieldCaolán McNamara1-1/+4
Change-Id: Ib013d4075b2cf55cf02afd77dab6f76c6b9ac70e
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann5-7/+7
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann10-169/+169
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-14callcatcher: update unused codeCaolán McNamara1-1/+0
Change-Id: If4615e5bcb012321c554f75cd936dbf9b0dbf8ab
2014-03-13CurrencyFields cannot be loaded from .src anymoreCaolán McNamara1-2/+0
Change-Id: I3ccdb71e39a13dc8c697d3a52dc693cff10c614d
2014-03-13MetricBoxes cannot be loaded from .src anymoreCaolán McNamara1-1/+0
Change-Id: Id7b44402975ed75171f4475aa64ebd2a3d6bd687
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 02:16:14 +0000