summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)AuthorFilesLines
2016-04-18cppcheck: silence known condition warning in reportdesignJochen Nitschke1-23/+19
Change-Id: I6debdd6fce7296e8a8827eab7a99fe96ef176d12 Reviewed-on: https://gerrit.libreoffice.org/24202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann2-4/+4
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann2-3/+3
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin2-3/+2
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke2-2/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin4-8/+8
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in reportdesignNoel Grandin15-26/+26
Change-Id: I6e024c3043e1fa9f618e96088581ade3c3a00c3c
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke3-3/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann3-9/+10
Change-Id: I93e7c254f8777c2dfbb192b306c991387d9cc641
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke3-7/+1
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke13-31/+30
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04coverity#705112 Using invalid iteratorCaolán McNamara1-2/+2
Change-Id: I95a4646e7ecff90babd8c140fdfa5f6fc47ce399
2016-04-03coverity#1358027 silence Using invalid iteratorCaolán McNamara1-2/+2
Change-Id: Id4306122a7d51491392996b8914e1411e9a4ed0f
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-1/+1
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke2-2/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin11-20/+21
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin8-34/+30
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-29Avoid reserved identifiersStephan Bergmann2-28/+28
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29Use const_iterator when possible (reportdesign)Julien Nabet17-107/+107
Change-Id: I2695fdf64670f4df844c1362a84af83f48fc29be Reviewed-on: https://gerrit.libreoffice.org/23575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-23loplugin:constantparam in reportdesignNoel Grandin9-22/+13
Change-Id: Ic1bba5e63359894115b3d1e293a5d9efdab041e1
2016-03-18loplugin:constantparam in formulaNoel Grandin1-1/+1
Change-Id: I3adeed435b62ae60b5d0d4b763dceced5675cd85 Reviewed-on: https://gerrit.libreoffice.org/23330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in svxNoel Grandin1-1/+1
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80 Reviewed-on: https://gerrit.libreoffice.org/23303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin3-6/+4
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard2-2/+2
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10loplugin:constantparam in formulaNoel Grandin1-1/+1
Change-Id: I18246d34d27f1b12dfd107166b31ef16d9632462
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin2-67/+67
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in reportdesignNoel Grandin5-18/+16
Change-Id: Ic98927f6d671b266479c3bbbc2a237c815bc2423
2016-03-07drop now-needless depsDavid Tardon2-8/+0
Change-Id: I2ef0b873a58710de399889cee3abf6b6ecf4fb1e
2016-03-07expand src templatesDavid Tardon8-13/+15
Change-Id: Id35caa8b8ed0c2f7e4d868f5c87a2a0f331cb352
2016-03-07loplugin:unuseddefaultparamsNoel Grandin4-15/+11
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07expand src templates only used in a single placeDavid Tardon1-11/+33
Change-Id: Ic18e4c0a1617f0284b7ffcfb8859cdced4949471
2016-03-04loplugin:unuseddefaultparam in oox/reportdesign/sdNoel Grandin2-7/+3
Change-Id: Ia26cf182ddc7c903d86bf74a8175858adb88121c
2016-03-03loplugin:unuseddefaultparams in formulaNoel Grandin2-2/+2
Change-Id: I7f0baa2709db24e8299f0e1c19c0703aee1cbf4f
2016-03-02loplugin:unuseddefaultparam in reportdesignNoel Grandin4-7/+6
Change-Id: I7663ed82da85794ed8409f03e21940cd26786c5a
2016-02-25use SearchOptions2Eike Rathke1-8/+9
Change-Id: I4d3820d097d520fdf7cce8b41d734dd4e2e8866f
2016-02-25loplugin:unuseddefaultparams in xmloff/Noel Grandin1-8/+8
Change-Id: Ia504a4e96a4ebc8404fe6881e0f77fba29cd00ae
2016-02-24convert PropertyOrigin to scoped enumNoel Grandin1-12/+12
Change-Id: I26c9929be8aad02030722508334e66f5028ffb37
2016-02-22reportdesign: -Werror=unused-but-set-variableMiklos Vajna1-4/+0
Change-Id: I52784fb331dfdb80c8c9bdb56b9542bca5aaa412
2016-02-22loplugin:write only fieldsNoel Grandin2-14/+4
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-17Fix missing iterator include on MSVC 14.0David Ostrovsky2-0/+2
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586 Reviewed-on: https://gerrit.libreoffice.org/22448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin2-28/+0
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock48-102/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock3-3/+0
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock2-2/+2
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock1-1/+1
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-06vcl: split exception types from input typesChris Sherlock2-8/+9
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke1-3/+3
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock2-3/+3
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-03reportdesign: reformat thatMichael Stahl1-32/+33
Change-Id: Iec06e09d0051ab53bbded0759abb041ff764abef
2016-02-03reportbuilder: tdf#92720: add loext namespaceMichael Stahl1-0/+7
... to allow export of paragraphs in shapes. (regression from 6acc6c011d3afd6834efeee1b2efe43652a86f2e) Change-Id: I2c23e686a2cfcd997d3393b0f9fb4cdcab7252b7