summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)AuthorFilesLines
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin7-7/+7
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin7-8/+8
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl12-13/+13
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-08Revert "Don't assume that the ZOrder property of shapes is an enumeration"David Tardon1-2/+2
This reverts commit 66c7dbbf7dfba8cfab63f8d1df72ace87e5bf7ca. See https://gerrit.libreoffice.org/#/c/13554/ . Conflicts: include/xmloff/shapeexport.hxx reportdesign/source/filter/xml/xmlExport.cxx sc/source/filter/xml/xmlexprt.cxx xmloff/source/draw/shapeexport.cxx Change-Id: I14fed9ad043a756a9e2d390c76fa907c349c3a2e
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin4-24/+2
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-07drop crashrep unused since start of LibreOfficeCaolán McNamara1-2/+2
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f Reviewed-on: https://gerrit.libreoffice.org/13733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin1-1/+1
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06fdo#84938: convert SEF_EXPORT_ #defines to 'enum class'Noel Grandin1-1/+1
Change-Id: I7165d0f1b6b4af4de5e5b39a21f36d726a1b0e30
2015-01-06fdo#84938: convert EXPORT_ #defines to 'enum class'Noel Grandin2-20/+20
Change-Id: I2ed239fa073b5fa8fb56c1af9d4b0bac89acfacf
2015-01-06fdo#84938: convert IMPORT_ constants to 'enum class'Noel Grandin2-9/+9
Change-Id: Idaa8f07c62b3ba93c27ca5fe286720254baac10d
2015-01-06fdo#84938: convert TEXT_PROP_MAP #defines to 'enum class'Noel Grandin2-3/+3
Change-Id: Ia8c5913c60e3d509a906965d813c8d1380396dc6
2015-01-05fdo#67343 Arrange Help button in a secondary groupAdolfo Jayme Barrientos6-89/+75
This helps de-clutter action button groups and eases visual scanning. This patch also contains little layout tweaks where needed to separate the Help button from its neighbors when the dialog is too small. Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce Reviewed-on: https://gerrit.libreoffice.org/13427 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05java: remove more dead codeNoel Grandin1-2/+2
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-02Fix simple typos.Andrea Gelmini1-1/+1
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara1-1/+1
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19Don't assume that the ZOrder property of shapes is an enumerationLionel Elie Mamane1-2/+2
...at least when we can easily not assume it. shapes = shapes of the same XShapes an enumeration = it is the sequence 0, 1, 2, 3, ..., XShapes->getCount()-1 We replace the ZOrder property by the index of the XShape in the XShapes (the same XShapes that is passed to seekShapes()... when that is easy to find. Else, use ZOrder and hope for the best. ZOrders are not always an enumeration. For example, in documents (forms) created by the Base forms wizard, it is not the case. The wrong assumptions was leading to the following bugs in the Base form wizard: - Only the first two controls in the form were successfully saved. The others were just dropped. - Whereas the labels had the proper style (background and text colour) applied while creating the document, these were not saved successfully Change-Id: I15b9a3ef3b16eafa9698332e35d82d51d51627f8
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn4-6/+6
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-18reportdesign: Use appropriate OUString functions on string constantsStephan Bergmann7-32/+37
Change-Id: Ia9cfa61c05b4014a504a419ea0367b5ffd5668ce
2014-12-18comphelper: Use appropriate OUString functions on string constantsStephan Bergmann2-10/+10
Change-Id: Id1d5c3cf2f76dbb33606cec1c0f17d4a1f282247
2014-12-18LEM TODO noteLionel Elie Mamane1-0/+1
Change-Id: If082f723383da72eac75ca660203aea2a33a7526
2014-12-18fdo#76780 don't limit PositionY to available widthLionel Elie Mamane1-1/+0
Change-Id: I3a429d0a6f771f6bfde2331ddc8544c92d8147f7
2014-12-15reportdesign: Use appropriate OUString functions on string constantsStephan Bergmann3-8/+8
Change-Id: I4baeb6ed5a3f16c3c1f0a2715cb011ef2555fc90
2014-12-12reportdesign: avoid assertion on duplicate properties ...Michael Stahl1-1/+14
... from XMLAutoStylePoolProperties that happens when opening bugdoc from fdo#87044. Change-Id: I7002cf5176cd326f57b50fb6030ffb89160c237b
2014-12-09changed timers to idleJennifer Liebel2-7/+7
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-08Remove more unnecessary header includes and use forward declaration.Kohei Yoshida1-0/+1
Change-Id: I88d0fb0e7c20d4b1414516e3bd2f961811b2eb8c
2014-12-05fdo#85112: reportdesign: fix SolarMutex assertionMichael Stahl1-0/+2
A bit tricky, but all of the UNO wrappers for SdrObjects etc. in svx use the SolarMutex for locking, so it's reasonable to expect that reportdesign code also has to lock SolarMutex when it manipulates these. Change-Id: I3cade8f53d7655e249b82673c87238d5a17256cb
2014-12-05Slightly less verbose adaptation to boost-1.56.0Thorsten Behrens1-2/+1
This fixes up 45dfbdca6a9afba1a6aef21623ec025ded635a4d Change-Id: I754fec5c94d51cbae69ad1155f57b0bb53788ba5
2014-12-04impl. Clone for all subclasses of SdrPageDavid Tardon2-2/+13
Change-Id: Ie370161e51ff83cb605bc57d317ff945404e5611
2014-12-04ooo#93212 avoid slicing during construction of SdrPageDavid Tardon2-1/+5
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b
2014-12-01WaE: -Werror=switchCaolán McNamara1-36/+38
Change-Id: Ib29d9c377bad2ba6dfb771b74cc97dcffe768dcb
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl3-4/+4
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin1-1/+1
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl4-1/+10
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-3/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini5-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-7/+4
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-1/+1
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna3-5/+5
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos1-1/+0
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann4-8/+8
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin4-8/+8
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05changed some timer to idleJennifer Liebel1-21/+16
Change-Id: Ifd5e2d87732d3e537c7754e52be24ef768ecb8d9
2014-11-05markup with event type not checker typeCaolán McNamara4-5/+5
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin11-64/+49
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#735452 Logically dead codeCaolán McNamara1-3/+1
Change-Id: If50b62e63160c4a26fe97b6fc59494339a566188
2014-11-03I think this should be Left()David Tardon1-1/+1
Change-Id: I8588809ce636107b4e9a51c5a1f4bc7af3f23f0d
2014-11-03coverity#1242514 arguments in wrong orderDavid Tardon1-1/+1
Change-Id: Icc6d4f0375106b670dd1efd04395f3c163bdd65d
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#704245 Logically dead codeCaolán McNamara1-21/+8
since commit 7599f68cee9141cd16ca7697872b5f83c6ae9ad9 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Wed Apr 22 11:01:27 2009 +0000 CWS-TOOLING: integrate CWS dba32a Change-Id: I85c45344ca31d50bd99c12b8c9dc29478aadb067