summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)AuthorFilesLines
2014-11-18java: make fields final where possibleNoel Grandin1-1/+1
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl4-1/+10
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-3/+3
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini5-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-7/+4
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-1/+1
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09SfxTabDialog ctors: take an OUStringMiklos Vajna3-5/+5
Change-Id: I91b9b2ffd19b2412ac01dd12429d6460b4c4812c
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos1-1/+0
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann4-8/+8
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin4-8/+8
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05changed some timer to idleJennifer Liebel1-21/+16
Change-Id: Ifd5e2d87732d3e537c7754e52be24ef768ecb8d9
2014-11-05markup with event type not checker typeCaolán McNamara4-5/+5
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin11-64/+49
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#735452 Logically dead codeCaolán McNamara1-3/+1
Change-Id: If50b62e63160c4a26fe97b6fc59494339a566188
2014-11-03I think this should be Left()David Tardon1-1/+1
Change-Id: I8588809ce636107b4e9a51c5a1f4bc7af3f23f0d
2014-11-03coverity#1242514 arguments in wrong orderDavid Tardon1-1/+1
Change-Id: Icc6d4f0375106b670dd1efd04395f3c163bdd65d
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#704245 Logically dead codeCaolán McNamara1-21/+8
since commit 7599f68cee9141cd16ca7697872b5f83c6ae9ad9 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Wed Apr 22 11:01:27 2009 +0000 CWS-TOOLING: integrate CWS dba32a Change-Id: I85c45344ca31d50bd99c12b8c9dc29478aadb067
2014-10-29ref-counting vcl::Window subclassesNoel Grandin1-1/+1
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-25coverity#705111 Using invalid iteratorCaolán McNamara1-1/+1
Change-Id: I613849da7d38c18b30e35534365e7bcb93aeedac
2014-10-24coverity#1224975 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I89cc31ae5b7c598f16eb3f52d0e4cbce0acf4bc4
2014-10-24coverity#704660 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: I9361477855b6d3fa18f0b1e433a5d21683327814
2014-10-24coverity#704656 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: Ib70eace7de922983528bdd57ba7cc029647a7090
2014-10-24coverity#704655 Unchecked dynamic_castCaolán McNamara1-4/+4
Change-Id: I04ef0f1067dedf613c29b49082620b097def9198
2014-10-24coverity#704654 Unchecked dynamic_castCaolán McNamara1-8/+8
Change-Id: I1ed0dc64ebb0243bdd4a03636158538854ac8253
2014-10-24loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky20-70/+70
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky20-42/+42
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin2-2/+2
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23loplugin: cstylecastNoel Grandin3-5/+5
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin1-1/+1
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-1/+1
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17coverity#1247639 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I5d91a6b7e4a539ea64b42d747a5fc142b36306dc
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon20-42/+42
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13WaE: unused variable 'aNullShadowCol'Tor Lillqvist1-1/+0
Change-Id: I3907306b53f77874597ac2b727fad9f3a3a3c333
2014-10-13Resolves: fdo#84930 format page background in report-builder crashCaolán McNamara1-18/+80
another regression from one of... commit 7d9bb549d498d6beed2c4050c402d09643febdfa Author: Armin Le Grand <alg@apache.org> Date: Mon Jun 2 15:00:50 2014 +0000 Related: #i124638# Second step of DrawingLayer FillAttributes... for Writer objects, now added support for Paragraph and PageStyle (including Header and Footer) for direct attributes and style attributes commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c Author: Armin Le Grand <alg@apache.org> Date: Thu Apr 17 16:44:58 2014 +0000 i#124638 support for DrawingLayre FillStyle for GraphicFrames and ... ... EmbeddedObjectFrames in Writer commit 6e61ecd09679a66060f932835622821d39e92f01 Author: Armin Le Grand <alg@apache.org> Date: Wed Mar 19 16:17:02 2014 +0000 This is something of a horror, and this is a suboptimal fix, but it appears to work. Change-Id: Iee7e6fdb40ca2e32beaa8e4bfea31872b8e0642e
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin1-3/+3
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca20-70/+70
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-01fdo#82577: Handle TimeNoel Grandin2-2/+2
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30reportdesign: std::auto_ptr -> std::unique_ptrStephan Bergmann24-95/+50
Change-Id: If387245dd587d4191589fcf93c02f1ca12654456
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin2-2/+2
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30fdo#82577: Handle RegionNoel Grandin3-3/+3
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-26formula: std::auto_ptr -> std::unique_ptrStephan Bergmann2-10/+3
Change-Id: I7b4784abf5177e22a9df33c5d4faccfd39801b11
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin6-8/+8
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-23fdo#82577: Handle WindowNoel Grandin40-77/+77
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin4-14/+14
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15reportdesign: sal_Bool -> boolStephan Bergmann6-7/+7
Change-Id: Ia53a94f5a814d3852d4b9606c331ba19ce95a608
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann4-38/+38
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann2-3/+3
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 17:27:35 +0000