summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)AuthorFilesLines
2016-02-06do not include boost/utility.hppMichael Stahl4-4/+4
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. (cherry picked from commit 7aa9f045387a95d0b1a516f917fbcd23e0578902) Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2016-02-06remove some unnecessary typedefs around uno::ReferenceNoel Grandin2-4/+1
Not very useful these days, since we have the css:: prefix to reduce verbosity. Found with a search like: git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;' | grep -v 'std::' Reviewed-on: https://gerrit.libreoffice.org/16730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 89c77994d4638c86635c70535fab6508e2f3d900) Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd
2016-02-06Fix typosAndrea Gelmini2-2/+2
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 69c88a32aad2cafde197e98557868ad069795d60)
2016-02-06Drop duplicate #includesTakeshi Abe1-1/+0
Change-Id: I4db77ea1de42676d9d2df70db3f2e1665a3fd983 Reviewed-on: https://gerrit.libreoffice.org/16419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 0655f98565c78c055ed10631fd57aa73604946b6)
2016-02-06remove unnecessary check for null when calling deleteNoel Grandin1-2/+1
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763 (cherry picked from commit 4729774b244db7a175077ed0c70aa48be62bc60e)
2016-02-05Let JUnit take care of exceptionsNoel Grandin1-101/+57
Inspired by commit 4dd0ac62855c5b9382cac004c7eebb9bed983a2b Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960 Reviewed-on: https://gerrit.libreoffice.org/16094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 275f0c7b250d448a8e2658ee2f26d4010628237b)
2016-02-05loplugin:loopvartoosmallNoel Grandin1-1/+1
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac (cherry picked from commit 6ef9f7e2025a2334034e9c8f7b3422220add4742)
2016-02-05convert PARENTCLIPMODE constants to scoped enumNoel Grandin4-4/+4
Change-Id: I36a53112e75fca9208b2f91e224a7c671695509b (cherry picked from commit f3331f7694e74f349375c223ce7ed84838e92d89)
2016-02-05convert SCROLL constants to scoped enumNoel Grandin1-1/+1
(cherry picked from commit 204d147b8a887d17e6457f795e8b8f4d632213ae) Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
2016-02-05convert INVALIDATE constants to scoped enumNoel Grandin10-26/+23
fixing a bug in Window::ImplMoveAllInvalidateRegions, and improving the IDL docs for XWindowPeer Change-Id: Idb774ac913945db2ac7c492c11cf86c370624c3d (cherry picked from commit bb7ce3137dbe12d67f393b95a437b18e3a63f8e7)
2016-02-05loplugin:constantfunctionNoel Grandin1-16/+4
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448 (cherry picked from commit 24600dcf3118cb01d57c31518d36be870f73e79c)
2016-02-05convert SWIB constants to scoped enumNoel Grandin1-3/+3
Change-Id: If64368f22e748cc646a726cb962e60ad29a66df9 Reviewed-on: https://gerrit.libreoffice.org/15840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit cf991bf352d64021e872ab1f8d82cb0f3cea37f3)
2016-01-08tdf#92203 OReportDefinition should implement XDocumentEventListener interfaceMaxim Monastirsky2-7/+50
... since 252b0c4364690e00b45175693d35eb64a07324b4 Change-Id: I4101dac0078df7cb06f4d33da2a722cfbafb5608 Reviewed-on: https://gerrit.libreoffice.org/20875 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit d48370043b3759c79340c162048c5f2b4da394b9)
2015-12-21fix missing BaseURL when loading embedded objectsMichael Stahl2-0/+6
When the object is edited in the UI, the m_xClient is set to a SfxInPlaceClient and the DocumentBaseURL is retrieved from it. But if the object is not edited, it will be loaded during export via the API and without a m_xClient; in this case the DocumentBaseURL must have been set previously to be available during import. There appears to be no way to get the URL of the document via the API while it is being imported; SfxBaseModel's m_sURL is unfortunately only initialized from SfxObjectShell::FinishedLoading(). During ODF import, the SvXMLEmbeddedObjectHelper creates the embedded object, so let's make it pass in the parent's BaseURL. The "DefaultParentBaseURL" parameter already exists but was unused previously. (cherry picked from commit b0fc09daf1086423a9bd457d9a2c043e7ff41451) (cherry picked from commit 4118f8f4c20ae711b95ab3052656bde673aa8852) sw: loading embedded ODF objects requires unordf component (cherry picked from commit b3b7982f4690f4ac0f0e9680970ba544157c36dc) Change-Id: I3d1ed29b3a2c0e77ec606a1d09f7bc07e7860733 Reviewed-on: https://gerrit.libreoffice.org/20761 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit fe4c7f20c272cf7a984d0db79199fe74bd31fc86)
2015-08-06rendercontext: Mass fix of using the wrong size.Jan Holesovsky2-2/+2
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6 Reviewed-on: https://gerrit.libreoffice.org/16421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06coverity#1307698 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: I1229b4cdfcc741899b3ae8694e7db5d7e506ce0c (cherry picked from commit e915c1cc1e406e4a4183f373a268490373b1b761)
2015-08-06tdf#89830: Ambiguous naming of character backgroundZolnai Tamás3-2/+15
Use 'Highlighting' also on Character Dialog. (cherry picked from commit 3588a04f438b001cb64aa1fd86b28869f2c4e70b) Options: Background -> Highlighting (cherry picked from commit b47151f5d1e287425511b45c5474e10eb0ba3a9d) Search By Format: Background -> Highlighting (cherry picked from commit 16d202f29cafbdc8d0648b830d2209f5c61c878f) Make this string localizable (cherry picked from commit a676ad5ec8348a6c8074e3a8d42590e8fd189cf5) Change-Id: Ifa48799bb9e415d17f4e323008fac57270bae34b Reviewed-on: https://gerrit.libreoffice.org/16322 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-08-06more untranslatable UI stringsAndras Timar1-1/+1
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef (cherry picked from commit 814867c75cd175594b8e60125f248ecbb6647644)
2015-08-06Resolves: tdf#91672 Crash in base report - right click in page header sectionCaolán McNamara1-0/+1
Change-Id: Ie7f9abc16e07c9ef44916e0cebe67486f3583449 (cherry picked from commit 43cc6fa1fa704ff53e56e8fe34e673c6733c9b4e)
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin1-1/+1
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin1-2/+2
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-28tdf#91577 - CRASH: when "Report Builder" closedNoel Grandin1-1/+1
audited commit 6d0c89123f353aed80d3a8a08ef5cd1ffaa1eea9 "vclwidget: fix more places that should be wrapping in VclPtr" and fixed up the one place that needed it. Change-Id: Iedb56353e6a967367f38fa847efb950acc869a93
2015-05-26tdf#91577 - fix unique_ptr conversion bugs in reportdesign.Michael Meeks2-5/+7
Change-Id: Icc94ce266d567e7aad5afb5eacf0e85699ef4107
2015-05-26Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks2-4/+4
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin1-3/+3
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-19remove the last of the OUString #defines in header filesNoel Grandin1-1/+1
Change-Id: Id9e8ce7987e055e83b52c7024413570f262e6e8d
2015-05-18fix Wundefined-bool-conversionTomaž Vajngerl1-1/+1
Change-Id: I99e57e3f4b3f5b9fa21cdf6bfbda4b15ce83eaac
2015-05-18refactor remaining reportdesign classes to use RenderContextTomaž Vajngerl4-59/+70
Change-Id: I23d7a2153bfc0446a972651a892eba8f6dc2bc54
2015-05-15refactor ViewsWindow of reportdesign to use RenderContextTomaž Vajngerl1-15/+16
Change-Id: I0c1c2df38894f250aa2bec6ab6532ccaca090fa9
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin4-28/+26
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11refactor TreeListBox to use RenderContextTomaž Vajngerl1-3/+2
Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
2015-05-10Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann5-8/+8
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann1-1/+1
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-09coverity#1297234 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I6ce09d3a7c77c5501608a2d1b0812c3c22ef16af
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann2-2/+3
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-07Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann2-0/+2
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-06convert DEFAULTFONT_ constants to scoped enumNoel Grandin1-3/+3
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06Use various typed ToolBox::Set*Hdl LinksStephan Bergmann6-13/+8
Change-Id: Iddfd36ae0de86fdd2d4febb2c05d1fe0c02801f0
2015-05-05remove unused #include awt/InvalidateStyle.hppMichael Stahl3-3/+0
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
2015-05-05loplugin:staticmethodsNoel Grandin17-52/+52
Change-Id: I5d02ba0db00e11af3c17eaf77ce19c635a52077f
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann2-4/+2
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann3-8/+5
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-02Audit LoseFocus - forms, reportdesign, sc, starmath, svtools.Michael Meeks1-1/+2
Change-Id: If7068e59c88e8c3c3bafc70f64899a26d739e331
2015-04-30Gradually typed LinkStephan Bergmann2-4/+4
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of initial :: for the svx namespaceTor Lillqvist7-26/+26
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist2-3/+3
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist1-1/+1
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-29convert SDRMOUSE constants to scoped enumNoel Grandin1-7/+7
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29convert SDRINSERT constants to scoped enumNoel Grandin1-1/+1
Change-Id: I6335e00cae161cea7ece922ecfa845c205626cd9
2015-04-29convert CTF_ constants to scoped enumNoel Grandin1-2/+2
Change-Id: I1c8149e9fccde761bb2a5fd2cf3cddcd2d9748dd