summaryrefslogtreecommitdiff
path: root/registry
AgeCommit message (Collapse)AuthorFilesLines
2015-08-23tdf#39440 cppcheck: redundantAssignmentMichael Weghorn1-4/+2
This addresses some of cppcheck's "redundantAssignment" warnings ("Variable '<varName>' is reassigned a value before the old one has been used"). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-21Force #defined constants to sal_uInt32 to reduce conversion warningsMatteo Casalin1-38/+38
Change-Id: I3968bcd55ab4d0ff6215f76be242acc17cf5ccab
2015-08-20new loplugin automemNoel Grandin2-49/+20
find places where we should be using std::unique_ptr Change-Id: I5b9defe778fdc4738ecea381215396874db59e66
2015-07-23inline a handful of use-once #definesNoel Grandin3-43/+30
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
2015-07-16loplugin:simplifyboolStephan Bergmann1-1/+1
Change-Id: Ic0115e76076e84cc132a9fc9b0ce6a90cd9f639c
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-03Make RegistryTypeWriter non-copyableStephan Bergmann2-33/+3
(and note the operator == vs. = typo) Change-Id: I9c25149967ed9b80f5e8f014de0dfee2e8f485d8
2015-07-03Remove RegistryTypeWriter_Api indirectionStephan Bergmann2-123/+62
Change-Id: I313adfb72272a631299efb3d2464873853a126be
2015-07-03Remove unused functionsStephan Bergmann2-87/+1
Change-Id: Ic4058c133a676646bc0c5d1e52207471bb78a1cb
2015-07-03Make RegistryTypeReader non-copyableStephan Bergmann2-25/+3
(and note the operator == vs. = typo) Change-Id: I4567927f3f702f8e74b168becce4002e84d5c7a0
2015-07-03Remove RegistryTypeReader_Api indirectionStephan Bergmann2-176/+96
Change-Id: I43710d057043a258ec9ab94bca0703434098e6c9
2015-07-03Remove unused functionsStephan Bergmann2-128/+1
Change-Id: Ib615ff7eb12232b0b83664af134744d96754ffd8
2015-07-03No need for a C API hereStephan Bergmann6-22/+14
Change-Id: Ie453a7c97a762932884c5c41b13607a170368107
2015-07-03Move module-private includes from include/registry/ to registry/Stephan Bergmann12-8/+963
Change-Id: I72bdd6627a191a65d5c3b479c100e30442a8bb9e
2015-07-02loplugin:unusedmethods registry,storeNoel Grandin1-3/+0
Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-5/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-05-28new clang plugin: loopvartoosmallNoel Grandin1-2/+2
Idea from bubli - look for loops where the index variable is of such size that it cannot cover the range revealed by examining the length part of the condition. So far, I have only run the plugin up till the VCL module. Also the plugin deliberately excludes anything more complicated than a straightforward incrementing for loop. Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2-8/+8
Change-Id: I07d9567da23094836134a54afce660500bf1b3f5
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann2-0/+2
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin3-3/+3
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-09loplugin:salboolNoel Grandin1-5/+5
Change-Id: Id4194f4d5bb6fcf064985fddc6f7344a4d34ca04
2015-04-09fix windows and android buildsNoel Grandin1-39/+11
more 'extern C' fallout from my conversion of enum to scoped enum Change-Id: I4c9aabbfbd255775a8f3edc2b7c8c62647f539eb
2015-04-09fix android buildNoel Grandin1-1/+1
since after my converting stuff in include/registry/types.h to use 'enum class', it can obviously no longer be "extern C", so drop the "extern C" and rename the file to reflect that. Change-Id: Ia30f5731316525e48531c4785ab7471a428bcf6f
2015-04-09convert RTReferenceType to scoped enumNoel Grandin5-19/+19
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
2015-04-09convert RTMethodMode to scoped enumNoel Grandin5-12/+12
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
2015-04-09convert RT_ACCESS fields to scoped enumNoel Grandin5-68/+68
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
2015-04-09convert RegError to scoped enumNoel Grandin7-329/+329
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
2015-04-09convert RegValueType to scoped enumNoel Grandin7-130/+130
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
2015-04-09remove reg keytype constants and related codeNoel Grandin5-57/+0
since we no longer support the RG_LINKTYPE stuff Change-Id: If388ecfa0c475471b99b26155ad554ec702ca734
2015-04-09convert REG_ constants to scoped enumNoel Grandin8-23/+22
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann6-96/+96
Change-Id: I192bc9653d8492a850a5e259e15782bd3bb24922
2015-03-27loplugin:staticfunctionNoel Grandin1-2/+2
Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2-5/+5
Change-Id: I32d7a1d4fed6ef5c56f485cd92464f2d0960e5fd
2015-03-19loplugin:constantfunction: registryNoel Grandin3-36/+0
Change-Id: I0556481aee672451221aa72a8a90d465f3670313
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin8-29/+29
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07loplugin:deletedspecialStephan Bergmann1-2/+4
Change-Id: I52253f6b925a943edc2984ce4d9462bd1edb5f51
2015-01-28Some more loplugin:cstylecast clean-upStephan Bergmann4-19/+19
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
2015-01-25loplugin:unreffunStephan Bergmann1-2/+0
Change-Id: Id7e0ddf60e32a27cb3922ae6c64feeec40f8e079
2015-01-25coverity#1266504 Useless callCaolán McNamara1-2/+0
Change-Id: I11a2760799937393bfa1a91c1d454ccb3c4027e4
2015-01-20Some more loplugin:cstylecast: registryStephan Bergmann2-2/+2
Change-Id: I5cfb42729b5d3d97076058edb108965f248f86af
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann3-57/+57
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara1-2/+2
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn2-10/+4
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24Bin commented-out unreachable 'break' statementsTor Lillqvist1-2/+0
Change-Id: If0f47a78bbffec5c2ebd33c552d0d8a300b48eb1
2014-11-21Silence unhelpful cid#1215304 untrusted loop bound warningsStephan Bergmann1-0/+4
Change-Id: If4db6a631ad6b24ca6ecfef81a0a20b766ed6324
2014-11-18Fix memchr checksStephan Bergmann1-2/+5
(thanks caolan for spotting) Change-Id: I17093b4173b9a2fca2760240375bcb14313224ef
2014-11-17Remove dead codeStephan Bergmann1-46/+0
Change-Id: I1edce9e336650cc3317de8883e08fb6536c58c70
2014-11-17cid#1213388 etc.: Make reflread.cxx more robustStephan Bergmann1-209/+348
incl. revert of and proper fix for 8f69c7a11bf31f7134caf4e03fbcd4c6ef86382d "coverity#1213373 Use of untrusted scalar value," the data is tainted after all Change-Id: I19e4d544ccf6d02afe8d6e441cae6bbdadb8a6be
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl3-0/+3
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05