summaryrefslogtreecommitdiff
path: root/registry
AgeCommit message (Collapse)AuthorFilesLines
2017-12-05loplugin:useuniqueptr extend to check local varsNoel Grandin2-7/+4
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2489000d3fd66319a8355fd4e37cfdfda47296d0) Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 (cherry picked from commit e540ccfb5eb43bd4a3d6920074dce8436720ba8e)
2016-10-07tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl1-1/+0
Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
2016-09-19convert storeAccessMode to scoped enumNoel Grandin2-31/+31
Change-Id: I67705cdff0440487019a2992571147d648be1bfc
2016-09-12loplugin:constantparam in package..stocNoel Grandin1-1/+1
Change-Id: I04b6d14d3dd8d55ccc4d4eb9313bc37959690672 Reviewed-on: https://gerrit.libreoffice.org/28824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09loplugin:constantparam in sot..svlNoel Grandin2-3/+1
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin2-8/+8
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04We don't build regmerge when ENABLE_MACOSX_SANDBOXTor Lillqvist1-0/+3
So skip CustomTarget_regcompare_test. But maybe we should build it and just drop it from the app bundle we package? Change-Id: Ibd8556ef686d2e9b7d4004110bf8beb93faf8202
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-1/+1
Change-Id: I015b172ea88eef9af37303fafa4bdf9749f114b0
2016-03-17loplugin:constantparam in registryNoel Grandin5-26/+11
Change-Id: Ic3c60325a722422912d06fe21d072c5f5c4bccb1 Reviewed-on: https://gerrit.libreoffice.org/23322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04Skip some executables in the OS X sandboxed (Mac App Store) caseTor Lillqvist1-2/+4
I doubt end-users will miss gengal.bin, regview, or regmerge. We need the gengal program at build time. But don't bother shipping it on OS X, at least not in the sandboxed (App Store) case. Change-Id: Id73bef1ba71d126c2d2962fe846e9c31963d6c24
2016-02-23new loplugin: commaoperatorNoel Grandin1-3/+6
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-16use consistent #define checks for the Windows platformNoel Grandin1-1/+1
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-12loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I0fb06079ff8a9d0b2f5a2929f31846f91391f5c4 Reviewed-on: https://gerrit.libreoffice.org/22229 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock7-42/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-04Split long command line into multiple shorter onesStephan Bergmann1-62/+124
...maybe that makes Windows more happy Change-Id: I4fe1d73f5638e1efe07162735c94856e0541ae78
2016-02-04[ABI CHANGE] In SDK, replace regcompare with unoidl-checkStephan Bergmann4-2211/+112
...as the latter was the more flexible replacement for the former for LO- internal use already. The only gotcha to watch out for is that unoidl-check cannot be used to check "naked" .urd files, but only ones where the content has been moved to /UCR via regmerge. Leave registry/CustomTarget_regcompare_test.mk around to verify that unoidl-check behaves the same as did regcompare on those old-format .urd/.rdb files. Change-Id: Ic13ede48535bf942126c810d88bac7e4081d984e
2016-02-04Resurrect registry/test/regcompare/Stephan Bergmann3-98/+145
Change-Id: Icf4d3b4137a6b6b70dd543bf4758a79f90e9f57f
2016-02-04loplugin:fpcomparison in registry/Noel Grandin1-2/+3
Change-Id: Ifdc2df9ba51ce8ef2c8793bb51c28a547f22214f Reviewed-on: https://gerrit.libreoffice.org/21866 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18loplugin: unused return valuesNoel Grandin1-2/+2
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-21loplugin:unusedmethodsNoel Grandin2-53/+0
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-11-25loplugin:unusedfields in include/package,include/registryNoel Grandin1-94/+0
Change-Id: Iadba30885ba3bab7aaee58e298a9dc6b22c8b977
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann7-152/+152
Change-Id: Ie5a37a49f1b1c08a20f89e167ca415fc645ed40d
2015-11-06coverity#1338272 Uncaught exceptionCaolán McNamara1-41/+49
Change-Id: I5b2b7044c77de899ce8dc1e44f3673835bd3ce4c
2015-11-06coverity#1338270 Uncaught exceptionCaolán McNamara1-83/+91
Change-Id: I5c6fae963c4aabe15d82a51f5801e62656188051
2015-11-06coverity#1338252 Uncaught exceptionCaolán McNamara1-51/+60
Change-Id: Ia058e42700c7724efd74fd6c5560ccca919fb2e8
2015-10-26remove extra spaces around ::Noel Grandin1-2/+2
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-4/+4
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-2/+2
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07Abstract out repeated code into a lambdaStephan Bergmann1-18/+13
...to silence a clang-analyzer-deadcode.DeadStores on the last update of pBuffer Change-Id: I144b64c330c178f78109fefadacf62fca3765694
2015-10-01loplugin:unusedmethodsNoel Grandin4-657/+0
- improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: I42c0ab2012553e11f8c1372103488ba1d291d5a9 Reviewed-on: https://gerrit.libreoffice.org/18965 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin2-17/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-08-23tdf#39440 cppcheck: redundantAssignmentMichael Weghorn1-4/+2
This addresses some of cppcheck's "redundantAssignment" warnings ("Variable '<varName>' is reassigned a value before the old one has been used"). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-21Force #defined constants to sal_uInt32 to reduce conversion warningsMatteo Casalin1-38/+38
Change-Id: I3968bcd55ab4d0ff6215f76be242acc17cf5ccab
2015-08-20new loplugin automemNoel Grandin2-49/+20
find places where we should be using std::unique_ptr Change-Id: I5b9defe778fdc4738ecea381215396874db59e66
2015-07-23inline a handful of use-once #definesNoel Grandin3-43/+30
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
2015-07-16loplugin:simplifyboolStephan Bergmann1-1/+1
Change-Id: Ic0115e76076e84cc132a9fc9b0ce6a90cd9f639c
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-03Make RegistryTypeWriter non-copyableStephan Bergmann2-33/+3
(and note the operator == vs. = typo) Change-Id: I9c25149967ed9b80f5e8f014de0dfee2e8f485d8
2015-07-03Remove RegistryTypeWriter_Api indirectionStephan Bergmann2-123/+62
Change-Id: I313adfb72272a631299efb3d2464873853a126be
2015-07-03Remove unused functionsStephan Bergmann2-87/+1
Change-Id: Ic4058c133a676646bc0c5d1e52207471bb78a1cb
2015-07-03Make RegistryTypeReader non-copyableStephan Bergmann2-25/+3
(and note the operator == vs. = typo) Change-Id: I4567927f3f702f8e74b168becce4002e84d5c7a0
2015-07-03Remove RegistryTypeReader_Api indirectionStephan Bergmann2-176/+96
Change-Id: I43710d057043a258ec9ab94bca0703434098e6c9
2015-07-03Remove unused functionsStephan Bergmann2-128/+1
Change-Id: Ib615ff7eb12232b0b83664af134744d96754ffd8
2015-07-03No need for a C API hereStephan Bergmann6-22/+14
Change-Id: Ie453a7c97a762932884c5c41b13607a170368107
2015-07-03Move module-private includes from include/registry/ to registry/Stephan Bergmann12-8/+963
Change-Id: I72bdd6627a191a65d5c3b479c100e30442a8bb9e
2015-07-02loplugin:unusedmethods registry,storeNoel Grandin1-3/+0
Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-5/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 14:29:36 +0000