summaryrefslogtreecommitdiff
path: root/qadevOOo/tests
AgeCommit message (Collapse)AuthorFilesLines
2015-01-13css.form.component.{CheckBox,RadioButton} DefaultState property valuesStephan Bergmann2-21/+35
...must be in the range 0--2; avoid setting bad values from generic qadevOOo property set tests, and throw an IllegalArgumentException if bad values do get set. Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
2015-01-13java: move DEFAULT_SHORT_WAIT_MS to util.utilsNoel Grandin1-3/+3
so I can turn PopertyNames into an enum Change-Id: I939a83c0962813302a3653e75976147b2300cb18
2015-01-13java: NO_CWS_ATTACH parameter is unusedNoel Grandin1-14/+9
Change-Id: I3e465987ef3dd502faecaf3c5ce151013a5bf314
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin118-1177/+268
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-12java: no need to instantiate the AccessibilityTools objectNoel Grandin85-171/+2
since all of it's methods and fields are static. Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
2015-01-12java: no need to sleep quite so oftenNoel Grandin1-7/+7
Change-Id: I9746158dfdffafd138160c2491e57b269d04e22b
2015-01-09java: simplify array creationNoel Grandin1-9/+7
and remove the need to worry about keeping indexes correct Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-05java: unnecessary method overridesNoel Grandin18-171/+0
these methods did nothing but call their super implementation. found by CodePro Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
2015-01-05java: simplify if statementNoel Grandin1-5/+1
found by CodePro Change-Id: I5f7e5b75b0345a1d917638e57a7d8ad60efb1475
2015-01-05java: unnecessary importsNoel Grandin1-2/+0
found by CodePro Change-Id: If1b75e43f81d70984422e437147048a491395b66
2015-01-05java: more efficient float parsingNoel Grandin4-5/+9
found by CodePro Change-Id: I01c18ddc842fd89105fa95daaa482fba8fcb7bec
2015-01-05java: avoid octal literalsNoel Grandin1-2/+2
found by CodePro Change-Id: Idf67521a46d73afe2f7656bb1a9f81e755eabbdb
2015-01-05java: use brackets to make difference between concat and plusNoel Grandin1-2/+2
.. more obvious found by CodePro Change-Id: I60b05b01819a756a07d2358e3cfe8b0d7d4436a6
2015-01-05java: remove more dead codeNoel Grandin2-4/+4
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: static fields that should be instance fieldsNoel Grandin1-1/+1
found by FindBugs. Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
2015-01-05java: compare Strings using equals()Noel Grandin1-1/+1
not == Found by FindBugs. Change-Id: I74805f1187bd623433ad097dec1015a3cf5f45ac
2014-12-19java: static fields that should not be staticNoel Grandin7-15/+13
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-19java: unused importsNoel Grandin2-2/+0
Change-Id: I7866959b9ea36c81003259cd387a001e9f34f26a
2014-12-19java: this does not need to be a ThreadNoel Grandin1-2/+1
It is just being used as a Runnable Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
2014-12-15java: remove some unused fields and variablesNoel Grandin7-32/+1
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin44-113/+113
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove comment noiseNoel Grandin1-1/+0
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25java: remove some comment noiseNoel Grandin1-6/+1
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25java: final fields that can be staticNoel Grandin17-18/+18
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin16-21/+14
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18java: make fields final where possibleNoel Grandin55-85/+84
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: rather use @Deprecated annotationNoel Grandin1-1/+0
than an empty @deprecated tag Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa Reviewed-on: https://gerrit.libreoffice.org/12525 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini29-58/+58
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin9-27/+17
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-14/+15
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: dodgy &= operationNoel Grandin1-4/+2
Change-Id: Ia909797e08948a8ad0e6f536ce2af57880dc13ef
2014-10-17java: when rethrowing exceptions, store the originalNoel Grandin2-4/+2
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17java: final fields that can be staticNoel Grandin5-7/+7
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin1-1/+1
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin47-233/+106
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
2014-10-16java: always use braces for while loopsNoel Grandin6-7/+12
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-09typo: proeprty -> propertyAndras Timar3-3/+3
Change-Id: Ib20ca28c2236fc99e1339b6e57e8641a213116c7
2014-10-09typo: Lable -> LabelAndras Timar1-2/+2
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-07java: simplify some for loops to while loopsNoel Grandin1-1/+1
Change-Id: I323ab12c634d3baa4f624b63d7d483112c23192c
2014-10-07java: use equals() to compare Strings, not ==Noel Grandin3-3/+3
Change-Id: Ia41a4899fb82df7b580a020765404c4ef0cddfa2
2014-10-07java: simplify conditions involving logical negationNoel Grandin4-11/+11
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin3-8/+8
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07java: optimise calls to toArrayNoel Grandin1-2/+2
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07java: remove unnecessary adding of empty stringsNoel Grandin4-6/+6
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-10-07java: no need to check for null before calling instanceofNoel Grandin1-1/+1
the instanceof check returns false when passed a null value Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
2014-10-07java: remove useless overriding methodsNoel Grandin1-19/+0
that only call their superclass method Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
2014-10-06fdo#73151 Always open Styles&Formatting dialog in the sidebarSamuel Mehrbrodt1-2/+3
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed Reviewed-on: https://gerrit.libreoffice.org/11648 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin4-4/+4
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet1-1/+1
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin3-5/+0
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909