Age | Commit message (Collapse) | Author | Files | Lines |
|
...must be in the range 0--2; avoid setting bad values from generic qadevOOo
property set tests, and throw an IllegalArgumentException if bad values do
get set.
Change-Id: Ia4a97d0fac326b3ca2ce254946dc4d418e9dd5a7
|
|
so I can turn PopertyNames into an enum
Change-Id: I939a83c0962813302a3653e75976147b2300cb18
|
|
Change-Id: I3e465987ef3dd502faecaf3c5ce151013a5bf314
|
|
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
|
|
since all of it's methods and fields are static.
Change-Id: Ia2b652969489c5a21e01a35cda65c6e84346aac0
|
|
Change-Id: I9746158dfdffafd138160c2491e57b269d04e22b
|
|
and remove the need to worry about keeping indexes correct
Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
|
|
these methods did nothing but call their super implementation.
found by CodePro
Change-Id: Iba40d10ca1db0b4a3b4b971cacc2f299c4d5f389
|
|
found by CodePro
Change-Id: I5f7e5b75b0345a1d917638e57a7d8ad60efb1475
|
|
found by CodePro
Change-Id: If1b75e43f81d70984422e437147048a491395b66
|
|
found by CodePro
Change-Id: I01c18ddc842fd89105fa95daaa482fba8fcb7bec
|
|
found by CodePro
Change-Id: Idf67521a46d73afe2f7656bb1a9f81e755eabbdb
|
|
.. more obvious
found by CodePro
Change-Id: I60b05b01819a756a07d2358e3cfe8b0d7d4436a6
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by FindBugs.
Change-Id: I4f457cd8f6f28f0429fc50529c8d38d80b80c560
|
|
not ==
Found by FindBugs.
Change-Id: I74805f1187bd623433ad097dec1015a3cf5f45ac
|
|
Found by FindBugs.
Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
|
|
Change-Id: I7866959b9ea36c81003259cd387a001e9f34f26a
|
|
It is just being used as a Runnable
Change-Id: I1e652ab0f3b0450d3a85384b9dd513419e2f8046
|
|
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7
Reviewed-on: https://gerrit.libreoffice.org/13477
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6
Reviewed-on: https://gerrit.libreoffice.org/13408
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
|
|
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873
Reviewed-on: https://gerrit.libreoffice.org/13097
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
than an empty @deprecated tag
Change-Id: I1646ce1c0c8823ac5be0153aeb8eb2b830e7ebfa
Reviewed-on: https://gerrit.libreoffice.org/12525
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
by using early return in some methods
Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7
Reviewed-on: https://gerrit.libreoffice.org/12374
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ia909797e08948a8ad0e6f536ce2af57880dc13ef
|
|
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
|
|
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
|
|
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
|
|
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
|
|
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
|
|
Change-Id: Ib20ca28c2236fc99e1339b6e57e8641a213116c7
|
|
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
|
|
Change-Id: I323ab12c634d3baa4f624b63d7d483112c23192c
|
|
Change-Id: Ia41a4899fb82df7b580a020765404c4ef0cddfa2
|
|
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
|
|
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
|
|
passing in a correctly sized array requires one less allocation
Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
|
|
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
|
|
the instanceof check returns false when passed a null value
Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
|
|
that only call their superclass method
Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
|
|
Change-Id: I05b63dc00023945d92fd837bd64042135d3f9aed
Reviewed-on: https://gerrit.libreoffice.org/11648
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
so that we get a nice complete stacktrace when it hits the final
handler
Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
|
|
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
|
|
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
|