summaryrefslogtreecommitdiff
path: root/qadevOOo/runner/convwatch
AgeCommit message (Collapse)AuthorFilesLines
2014-12-12java: remove dead code in qadevOOoNoel Grandin38-8979/+0
found by running UCDetector over the code many times, like peeling an onion Change-Id: I54d5147eb1b5c921ad236331bc4c1f765b13ca83 Reviewed-on: https://gerrit.libreoffice.org/13445 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: remove some unnecessary interfacesNoel Grandin1-19/+6
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin3-5/+5
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove comment noiseNoel Grandin3-3/+0
Change-Id: If6347197ff4436b4edd06e6e62d8e8e6fe1d4db6 Reviewed-on: https://gerrit.libreoffice.org/13408 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some comment noiseNoel Grandin2-2/+2
Change-Id: I51118fecf9de27407b4c5a66cd6577574939e001
2014-11-24java,qadev: remove unused parameters and local varsNoel Grandin6-176/+132
Change-Id: Ifb9f9374051fe88dc4cd5a7a28b2c8c992ced873 Reviewed-on: https://gerrit.libreoffice.org/13097 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18java: make fields final where possibleNoel Grandin8-19/+19
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12java: convert fields to local variables where possibleNoel Grandin2-10/+7
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25java: prevent overflow by using 'long int' arithmetic in multiplicationRobert Antoni Buj i Gelonch2-2/+2
Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998 Reviewed-on: https://gerrit.libreoffice.org/12001 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18java: loss of precissionRobert Antoni Buj i Gelonch1-1/+1
Change-Id: I0563a76b1d2c838e6301bf7a9ed154c77a98c0d9 Reviewed-on: https://gerrit.libreoffice.org/12000 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: no need to call String.valueOf to append to a StringNoel Grandin7-16/+16
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin6-6/+15
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
2014-10-16runner: if .. else if .. elseRobert Antoni Buj i Gelonch1-1/+1
Change-Id: If9c07074b60b14d0f4e947754d4bf34e4f2f9676 Reviewed-on: https://gerrit.libreoffice.org/11990 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16java: always use braces for while loopsNoel Grandin1-1/+2
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-14runner: finally block to ensure that a resource is closed (Prior to Java SE 7)Robert Antoni Buj i Gelonch5-408/+494
http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html Change-Id: I5ecefd3e5bf84fea2a8735a44236ed4c86b440c4 Reviewed-on: https://gerrit.libreoffice.org/11950 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-13runner: Object comparisonRobert Antoni Buj i Gelonch1-1/+1
Change-Id: I41b245f20652187dc36b4639272d0ddbc602afda Reviewed-on: https://gerrit.libreoffice.org/11921 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11It is more efficient to use the integer implementations of String.indexOf()Robert Antoni Buj i Gelonch1-2/+2
Change-Id: Idb1e4945088b8443e9b507826e5289ee758a2bd2 Reviewed-on: https://gerrit.libreoffice.org/11919 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10runner: The if statement is redundantRobert Antoni Buj i Gelonch6-71/+21
Change-Id: Ida40034bdfe6a44a936db1243ad6c71616caada3 Reviewed-on: https://gerrit.libreoffice.org/11895 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07while loop that ends in a return is more accurately an if blockNoel Grandin1-1/+1
Change-Id: I94b74b46b185e1061b6b72acdf3d9dc0c1d122c8
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin5-31/+31
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
2014-10-07java: simplify conditions involving logical negationNoel Grandin2-2/+2
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-09-24fdo#39625 Make existing CppUnittests workTobias Madl1-1/+0
Just removed some useless comment. Change-Id: I3f43e245849b82f8a1257c6ac0bace673d0ca9d6 Reviewed-on: https://gerrit.libreoffice.org/11604 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-11qadevOOo: use String.length()==0 instead of String.equals(empty string)rbuj1-1/+1
Change-Id: I5cdd1fb4fe77c7fc9614f2a6de8995d98d60b551 Reviewed-on: https://gerrit.libreoffice.org/11368 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-10qadevOOo: Number Parsingrbuj1-2/+2
Change-Id: I284a1b2bcb61695b74ec51bb46cbb683abf83449 Reviewed-on: https://gerrit.libreoffice.org/11369 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-10qadevOOo: use a character literalrbuj5-9/+9
Change-Id: I6d3e592de64c63e66bb788b112e188ef217e7bf7 Reviewed-on: https://gerrit.libreoffice.org/11367 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-08qadevOOo: remove import from the same packagerbuj14-42/+0
Change-Id: Id12bece6f1bba0591c3b311553df3fecec40e524 Reviewed-on: https://gerrit.libreoffice.org/11324 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-08qadevOOo: All classes in the java.lang package are imported by defaultrbuj2-3/+0
Change-Id: I10f87af6e8128354bfca3587dbd390e5d41f5ce7 Reviewed-on: https://gerrit.libreoffice.org/11325 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin2-10/+0
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: remove modifiers implied by the contextNoel Grandin2-36/+36
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin9-22/+22
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20java: Avoid naming non-fields with the prefix m_Noel Grandin1-4/+4
found by PMD Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin1-1/+1
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin2-2/+2
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: classes in java.lang package do not need to be fully qualifiedNoel Grandin3-7/+7
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19java: remove unused methodsNoel Grandin2-142/+0
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-14java: remove unused importsNoel Grandin2-3/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin9-48/+2
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13make some java methods privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ic2edbc85194731116aac34064238d11ef1926a98
2014-08-13make some java fields privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13java: remove dead methodsNoel Grandin12-386/+7
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13java: remove unused fieldsNoel Grandin6-18/+7
found by UCDetector Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13java: reduce scope, make some methods privateNoel Grandin19-79/+79
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13java: reduce scope, make fields privateNoel Grandin13-67/+67
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13java: reduce scope, make constructors privateNoel Grandin2-2/+2
found by UCDetector Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-12java: reduce scope, make constants privateNoel Grandin2-12/+12
found by UCDetector Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12java: return value of trim() ignoredNoel Grandin1-1/+0
Change-Id: If4cd3eb3e6db0c095796b0ff018162e855afa38c
2014-08-12java: remove useless javadoc tagsNoel Grandin2-18/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin10-0/+26
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-11java: remove unused parametersNoel Grandin6-12/+12
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11java: remove unused parametersNoel Grandin1-5/+0
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 23:37:14 +0000