summaryrefslogtreecommitdiff
path: root/package
AgeCommit message (Collapse)AuthorFilesLines
2015-08-19Consolidate isFileUrl checksStephan Bergmann1-1/+2
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-18Remove newly unused ucbhelper/fileidentifierconverter.hxxStephan Bergmann1-1/+0
Change-Id: I7c272383ecb115e19699ed96bf5622d979403a01
2015-08-18Simplify ZipPackage::isLocalFile checkStephan Bergmann1-14/+1
(vnd.sun.star.wfs is long gone) Change-Id: I3e25f1728504cbad07bb97187a7bac23b33695dc
2015-08-17avoid possible leak on exceptionCaolán McNamara1-13/+35
Change-Id: Id3c16e5fedc5e57c8daccafa25bdb2fbbd0131b0
2015-08-07Related: tdf#88314 delete temp filesCaolán McNamara3-0/+10
clear to close the inputstream before attempting to delete the temp file, which is plausible as the windows-specific failure in earlier attempts at this Change-Id: I751aa3a098dd960f56b77a5f5fc93783c1060556 Reviewed-on: https://gerrit.libreoffice.org/17531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-05Resolves: tdf#88314 close temp file after each thread completedCaolán McNamara3-19/+65
Change-Id: Ic2eec30cfb5f61c53777eefeeb8bad6f552da2fc Reviewed-on: https://gerrit.libreoffice.org/17355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-26Revert "Resolves: tdf#88314 close temp file after each thread completes"Norbert Thiebaud3-47/+20
This reverts commit 738cf411e9315d17c7eb8be47ded643a00dfe5c5. It brokes windows in https://gerrit.libreoffice.org/#/c/17289/ as per http://ci.libreoffice.org/job/lo_gerrit_master/4465/Gerrit=Gerrit,Platform=Windows/ was pushed despite that.. :-(
2015-07-24Resolves: tdf#88314 close temp file after each thread completesCaolán McNamara3-20/+47
and reopen them when we need their data. That way we don't have as many open files as substreams in the package, so we don't run out of file handles Change-Id: Ic124e275abf15f4578c77ee271d185f40cb844b1 Reviewed-on: https://gerrit.libreoffice.org/17289 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-14loplugin:unusedmethods toolkit,packageNoel Grandin1-15/+0
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd Reviewed-on: https://gerrit.libreoffice.org/17031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07loplugin:unusedmethods packageNoel Grandin8-85/+0
Change-Id: I19d6bbb9288d72b99d1023b4983b1c3fff7570e8 Reviewed-on: https://gerrit.libreoffice.org/16811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510 Reviewed-on: https://gerrit.libreoffice.org/16709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29drop yet another reimplementation of rtl::Reference (SotMutexHolderRef)Noel Grandin15-120/+48
Change-Id: I57f9dff931242405420bd45fae7ec5f13718707f
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-3/+3
Change-Id: Ib9bf6e0919ee0cab02d826859317ea20cb64cabb
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-10/+7
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-13TyposJulien Nabet1-1/+1
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara4-5/+5
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin2-7/+7
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin1-1/+1
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2-4/+4
Change-Id: I1a3766bba2c157f20422d3ffb0c08f631b537724
2015-06-05WaE: unreferenced local variableCaolán McNamara1-1/+1
Change-Id: Ie04966936a406fefbbcd1d96d7d3d299f98a31ae
2015-06-05uncaught exceptions in parallel deflate threads on re-export of HTB23106 odgsCaolán McNamara3-2/+20
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632
2015-06-01loplugin:loopvartoosmallNoel Grandin2-2/+2
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-08Rephrase comparisons between bool and sal_BoolStephan Bergmann1-1/+1
...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
2015-04-24loplugin:simplifyboolStephan Bergmann2-3/+3
Change-Id: Ia4177cf1a4b0c06ef614b54298fd6f9224956afc
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann2-3/+3
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin16-19/+19
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-12unnecessary castCaolán McNamara1-4/+3
Change-Id: I7c040b2539b9f7f923620a02d0a27e8e000fee4a
2015-04-09loplugin:staticmethodsNoel Grandin4-5/+5
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
2015-04-08A UNO Any can't contain an AnyStephan Bergmann1-1/+1
...and css::uno::makeAny<css::uno::Any>() was never meant to be used. Introduce css::uno::toAny for the (template-code) cases that shall return an Any for both Any and non-Any inputs. Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2-2/+2
Change-Id: I6979d9af3a97918593f0596df17c096bd3f4c4ad
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-2/+2
Change-Id: I313d61fc6e7be3a5513da83d3de9202237306739
2015-03-25tdf#90010 Partially revert "package: Do not bother with deflating jpeg images"Matúš Kukan1-1/+2
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when the document is protected by password. Would be nice to fix properly later. Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09
2015-03-24loplugin:constantfunction: variousNoel Grandin1-4/+0
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-19convert SFX_FILTER_ constants to enum classNoel Grandin1-2/+2
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin1-2/+2
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-13V803 decreased performance postfix incrementMichael Stahl1-1/+1
These are pretty silly anyway, but apparently it complains even about integer variables which make this rather a waste of time. Change-Id: I15e847d33d5decd2adcab04e4f1567d3997d28a2
2015-03-12package: PVS-Studio V595 'm_pData' pointer could be nullMichael Stahl1-27/+15
... so convert the last member of StorInternalData_Impl that needs manual cleanup to rtl::Reference Change-Id: Ie1549c1f52d50dc3c63715176c02821b63c7cab1
2015-03-12package: convert StorInternalData_Impl member to std::unique_ptrMichael Stahl1-20/+12
Change-Id: If523dbd4596f4023bda6509c6dc09b8ab3d74874
2015-03-12package: convert OStorage::m_pData to std::unique_ptrMichael Stahl2-6/+5
Change-Id: I875432aeb98072882df1f228d9fcf43c6027e8d5
2015-03-12package: move WSInternalData_Impl out of headerMichael Stahl2-16/+17
Change-Id: Ie7c01b37e9a4eb2221d4b40fc6b13672d9b3a684
2015-03-12package: convert OWriteStream::m_pData to std::unique_ptrMichael Stahl2-16/+12
Change-Id: I9e72325679b2758cd4297d2693cf49fd533f8baa
2015-03-12package: PVS-Studio V595 'm_pData' pointer could be nullMichael Stahl2-23/+18
... just convert its explicitly deleted member to unique_ptr. Change-Id: I826257ff512632a2aedd53a7ce5e4bedf49c3cfe
2015-03-11redundant checkCaolán McNamara1-2/+1
Change-Id: Id6b72a1a3133e47a07ee274f4082dde0e7032894
2015-03-09V801: Decreased performanceCaolán McNamara2-7/+7
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage2-3/+3
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-05Updated all precompiled headers.Ashod Nakashian2-0/+4
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-26Visible function type RTTI for Clang -fsanitize=functionStephan Bergmann1-0/+3
...by adding some further SAL_DLLPUBLIC_RTTI type annotations (cf. b4f6b26b5a1a78fecfa95ec2eb7ac8b80495d8aa "SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVM") and by making sure relevant function types do not use incomplete types in their parameter and return types (which would make the RTTI hidden). Change-Id: Id7aadcbc0704b9759968ae36266fc9ce11a2e340
2015-01-20Some more loplugin:cstylecast: packageStephan Bergmann6-18/+19
Change-Id: Icf7351082cf63aeb70ec47a8562a89d452ae9d8e
2015-01-15remove unnecessary castsNoel Grandin1-20/+20
leftovers from conversion of SvStream operator>> to Write methods Change-Id: Id1d1e60ae42afb689910845a3c6ec75e3388fb56
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 09:47:09 +0000