summaryrefslogtreecommitdiff
path: root/package
AgeCommit message (Collapse)AuthorFilesLines
2015-06-09uncaught exceptions in parallel deflate threads on re-export of HTB23106 odgsCaolán McNamara3-2/+20
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632 (cherry picked from commit 05661623c7e328c536814354bafd8294de0e9ee0) (cherry picked from commit 56b5b8aac8729a37814f82b83ebba0d16f87e407) Reviewed-on: https://gerrit.libreoffice.org/16096 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-25tdf#90010 Partially revert "package: Do not bother with deflating jpeg images"Matúš Kukan1-1/+2
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when the document is protected by password. Would be nice to fix properly later. Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09 (cherry picked from commit ca5ff4559726455d0c8fbdd08cb35af3308492bf) Reviewed-on: https://gerrit.libreoffice.org/15006 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-12-15fdo#87210: Re-enable parallel deflate, which was not the root cause.Kohei Yoshida1-2/+0
With f92183833fa569006602ac7e93c906d2094e0d4d, export no longer crashes, and there is no reason to leave this piece disabled any more. Let's re-enable this. Change-Id: Ibeca8869f152cbcd80f1dcb55f8199110125741d (cherry picked from commit 3fcd2ccb443653740d114b3e4dc371c6b0b6525b)
2014-12-15package: Better to use temporary files for huge memory zip streamsMatúš Kukan3-8/+26
ZipPackageBuffer was holding the whole compressed data stream in one uno::Sequence which seems to be a lot for big documents in some cases. Change-Id: Ib10d00ac54df9674231f4bbf047fab7e9b0a7d45 (cherry picked from commit f92183833fa569006602ac7e93c906d2094e0d4d)
2014-12-15package: Create memory buffer only when we need it - if we use parallelismMatúš Kukan6-15/+33
Otherwise write directly to the resulting zip file. Change-Id: I75097969f0cccf0b45da591c71221e5ae18668cb (cherry picked from commit 43eca2d9f8d87363b5f4bf8c5df92bf06be08c08)
2014-12-10Globally disable threading for these for now.Kohei Yoshida1-0/+2
It doesn't win us much performance-wise (as it turned out), and causes weird crashers with large documents. Change-Id: I0566ce850b8f6656e6f9821c653b7a825a7874a3 (cherry picked from commit e0425f9493e25fa14f11505d9ebc12a2fe78d4b6)
2014-11-19coverity#1242675 Untrusted value as argumentCaolán McNamara1-4/+9
Change-Id: I1d8f32095f297919dc3ccab51093295f8c31707d
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl6-0/+6
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl10-0/+10
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17package: Do not bother with deflating jpeg imagesMatúš Kukan1-1/+8
It takes a lot of time and we can save ~1% of size if at all. Rather store them uncompressed in the zip file. With png, we can save a bit more, although it's still only about 4% - 8%? Change-Id: I43a3e3812882e4ce85e7af9d0aaab454d98c4860
2014-11-17package: Do not deflate small streams in a threadMatúš Kukan1-0/+5
Change-Id: Iae804a34f344aa793a6d5c13315f7bc1eb64c0a2
2014-11-17ZipPackageStream::getRawData can be privateMatúš Kukan1-2/+3
Change-Id: I66cbbfb2aa6abc6c8ebe34d9ea69855436c23edd
2014-11-17Simplify input parameters to just take the sequenceMatúš Kukan10-34/+36
Change-Id: Ic2538ca8b0f7261064e1dfbf3884dd452003c797
2014-11-17package: Add possibility to disable deflating in a threadMatúš Kukan1-13/+30
Change-Id: I4d98b6f8b3315b731206700eb65f08463299dda3
2014-11-17package: Finally implement parallel zip entries deflatingMatúš Kukan7-72/+121
For that: 1, create ZipPackageStream::successfullyWritten to be called after the content is written 2, Do not take mutex when reading from WrapStreamForShare - threads should be using different streams anyway, but there is only one common mutex. :-/ Change-Id: I90303e49206b19454dd4141e24cc8be29c433045
2014-11-17package: Call writeLOC always after putNextEntry explicitlyMatúš Kukan5-38/+39
Preparation step to parallel deflating. Rename putNextEntry to setEntry and make it a static function. We need to call setEntry before starting thread but writeLOC after. Change-Id: I99a9ffa7dc4c18b47c621847b48bf8469bfb789a
2014-11-17package: Do not use hacky bit 1<<4 in ZipEntry::nFlagMatúš Kukan3-34/+11
Change-Id: I504f5c0c9aa9b655ffb53d9820a33677dad6aa08
2014-11-17There is no XZipOutputEntry interfaceMatúš Kukan2-10/+4
Change-Id: Ib8fa3351ba25416a13d6c8bf63bd5fc8e43703c5
2014-11-17package: Use memory stream for compressing zip entriesMatúš Kukan6-20/+26
Change-Id: Ibf81dc3cd8a9a9da3dfd6ee6e587a522c4d56a44
2014-11-17ZipOutputEntry: m_pCurrentEntry is always setMatúš Kukan1-45/+38
Change-Id: Ib6a69a83f4a378df838b2231b9eba7fba49cd9f1
2014-11-17package: Zipping STORED entry is the same as rawWrite and we don't encrypt itMatúš Kukan3-71/+58
Change-Id: Ie3f8ac261a70c9a2b5182fc7d36938d0a46ec045
2014-11-17package: Move most ZipOutputEntry's methods back to ZipOutputStreamMatúš Kukan7-201/+204
We want to use ZipOutputEntry only for deflating (and maybe rename it). ca13a9377e4a36436e4c82bb33648d0f3b6db6f5 was not a good idea because the data still needs to be written sequentially anyway. Otherwise it's hard to get offset positions of individual entries right. Since this commit rawCloseEntry needs to be called always; also when we use write&closeEntry because we don't call writeEXT in closeEntry anymore. Need to rename and add comments later. Change-Id: I03bd48ca6e108e6253a77a137746165909ca3c3d
2014-11-17ZipPackageFolder: releaseUpwardRef only calls clearParent, remove it.Matúš Kukan3-31/+1
Since commit 0c5bb3f42d38b3c16015dc0a45defd1b1dad4f92. Change-Id: I5511f9dc829aca42790f05cb8fb3ebd83b2acad4
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-6/+6
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini3-11/+11
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-04coverity#706578 uncaught exceptionDavid Tardon1-7/+14
Change-Id: I70640f42db49da274118f7336ff072b1b53ac640
2014-10-30coverity#706568 Uncaught exceptionCaolán McNamara1-1/+9
Change-Id: I05a7700b782d63654406139532a775173295ea9f
2014-10-30coverity#706569 Uncaught exceptionCaolán McNamara1-3/+10
Change-Id: I7c1245eacd92b5869e6dab0389ee0ca3cebd98da
2014-10-30OSL_ENSURE->assert when follow by deref of tested pointerCaolán McNamara1-1/+1
Change-Id: Ib703cb24619228c081c156c4ed52bf7b878fbedd
2014-10-30coverity#706582 Uncaught exceptionCaolán McNamara1-2/+10
Change-Id: I82fad3f152fe5a563675686accedb583d07d2b13
2014-10-30coverity#706583 Uncaught exceptionCaolán McNamara1-2/+10
Change-Id: I508eb91d7c32e8604525511c33c39471afd3ffbf
2014-10-30coverity#706584 Uncaught exceptionCaolán McNamara1-2/+15
Change-Id: I9521ed7d75cae1a1e90fd73dd7b8bd822ab4521f
2014-10-27coverity#706590 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I2005b792c74ad5a5f58c831dcc7caa5134280890
2014-10-27cid#1249676 Uninitialized scalar fieldNoel Grandin1-0/+2
Change-Id: I87df4e9c1d3f36afccf13aebfd95d1b4f3bfa655
2014-10-24package: OInputCompStream::m_xStream is never nullMichael Stahl2-39/+6
... as proven by the un-checked dereference in the dispose() method called from the dtor; simplify based on that and assert in ctor. Change-Id: Id369b80bd89fa59d99b209796c33acb39cbb10f3
2014-10-23Remove pointless functions now that saveChild() is ZipPackageStream's memberMatúš Kukan2-40/+22
Change-Id: Id43ec2e7ddb1035d3306170523764bb9a74c03b8
2014-10-23Move ZipPackageStream::saveChild to proper source fileMatúš Kukan2-382/+385
Change-Id: Icd108215874e830e5c9587f7dbb38a7f11ee27c8
2014-10-23package: Add pure virtual ZipPackageEntry::saveChild()Matúš Kukan7-119/+116
..and adapt what needs to be changed. So that, we can kill at least some usages of horrible ContentInfo struct. Change-Id: I32d41f3b8ce2dfb65f0d1df18a540a3f67dcab6d
2014-10-23package: ZipPackageStream: prefix membersMatúš Kukan2-75/+75
Change-Id: I02a1c3189c6b52f4f539b0eaa8878985cae8b321
2014-10-23package: Add ZipOutputEntry to isolate deflating of streams.Matúš Kukan8-415/+504
Preparation commit for deflating streams in parallel. We still use the same single XOutputStream (ByteChucker :-) for sequential writing but this can now be changed more easily. Change-Id: Idf26cc2187461660e31ac2e12c4708e761596fb2
2014-10-23coverity#706585 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic8d2963536b793f0a229901d9e13d8e54842d9b9
2014-10-23coverity#706586 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3ec05ae695428f92b7424295b6f2d3e833c6b162
2014-10-22unusedcode: Remove Deflater::setLevelMatúš Kukan1-61/+16
Which makes bSetParams always false; remove that too, together with nLevel. Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
2014-10-17coverity#706591 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I9b705664c3814aea5c433526ad147a8ab11c2d0f
2014-10-14bff: terminate on SAXException on malformed inputCaolán McNamara1-1/+22
SAXException thrown and not caught Change-Id: I874ffbcd457e102b572f398f4e531f4be30ca3d3
2014-10-10ZipOutputStream: No need to explicitly set default valuesMatúš Kukan3-22/+2
Change-Id: Ia3a20e0692e658d847e1b825fc97e32ac8a1854b
2014-10-10Split ZipPackageFolder::saveChild into two functionsMatúš Kukan2-290/+340
And make them static. Probably would be better to kill ContentInfo and add saveChild as pure virtual into ZipPackageEntry, from which are both ZipPackageFolder and ZipPackageStream inheriting. This will also create a bit more sensible call graph when profiling. Change-Id: If8151332cfa6359e8736c912b7a5633a9162ab36
2014-10-10package: ZipOutputStream: prefix membersMatúš Kukan2-133/+126
Change-Id: I9cc21ba87484560ec0db5424800dd67f80e00540
2014-10-10package: Add some 'const' and prefix membersMatúš Kukan5-34/+34
Change-Id: Id177c99ba8b91586cf61457ab2ef084af9c7f490
2014-09-30package: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: Iac189fef77c930e35cbd20452027662127047e01
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 14:31:36 +0000