summaryrefslogtreecommitdiff
path: root/package
AgeCommit message (Collapse)AuthorFilesLines
2016-05-10tdf#93553 limit parallelism at zip save time to useful amountArmin Le Grand5-29/+108
At ODT export time writing and zipping comtained data packages is nicely parallelized, but not limited to an upper bounds of threads to use. Together with memory consumption this makes ressource usage and runtime behaviour bad to crashing (mostly on 32bit). I have now limited the processing dependent on the number of available cores to get a good processing/ressource ratio. The result uses much less memory, is faster and runs on 32bit systems. Reviewed-on: https://gerrit.libreoffice.org/23305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14) Missing include (cherry picked from commit 3cdc8c27672e7e9253c9ca9abfc611a0f789da9c) Change-Id: I8bd516a9a0cefd644f5d7001214bc717f29770ab Reviewed-on: https://gerrit.libreoffice.org/24807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-08tdf#89236: Don't deflate encrypted document in parallelMatúš Kukan1-1/+2
I see "warn:legacy.osl:22439:1:package/source/zipapi/ZipFile.cxx:583: Can't detect password correctness without digest!" when opening file saved with password. Obviously css::xml::crypto::XDigestContext used in ZipOutputEntry does not work properly when encrypting files in parallel, so don't do that. Change-Id: I4b354535240a4f31a6bc6855cf7f9af527634e7e Reviewed-on: https://gerrit.libreoffice.org/21238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org> (cherry picked from commit eaed822c9cf6b3762f727f1281003dafd300df6d) Reviewed-on: https://gerrit.libreoffice.org/21241 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-11-25loplugin:unusedfields in include/package,include/registryNoel Grandin1-1/+0
Change-Id: Iadba30885ba3bab7aaee58e298a9dc6b22c8b977
2015-11-23loplugin:unusedfields in oox,package,reportdesignNoel Grandin3-199/+147
Change-Id: I83d03dcc76b5f0d54ebb0513ae972acb0db8eef1
2015-11-19use comphelper::containerToSequenceNoel Grandin2-16/+4
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin2-4/+2
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian2-89/+170
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin3-6/+3
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin2-4/+2
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann26-92/+92
Change-Id: I1e5338558bc57afe51db57655550e9b7246f7214
2015-11-05Don't check version field from local ZIP headerJan-Marek Glogowski1-14/+8
Our current Maven based Java toolchain produces JARs, which have a different "version needed to extract" in the ZIP local and central directory header. I had a look at 7zip and unzip and they already ignore the version but compare other data LO already ignores - sig. The "standard" document from PKWARE doesn't help. So just compare the file path and calculate the data offset and otherwise ignore all (duplicated) information from the local index and rely on a correct central directory entry. Various programs produce(d) "broken" ZIP files; even LO at some point (see git log). Change-Id: I8d63abb0d49a1087c7654f401b62355c147c3118 Reviewed-on: https://gerrit.libreoffice.org/19779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2015-11-04use uno::Reference::set method instead of assignmentNoel Grandin11-92/+79
Change-Id: I1c7240fe2e2b5eb825f028ca7502e5ba8793046b
2015-10-23com::sun::star->css in package,pyunoNoel Grandin44-1111/+1086
Change-Id: I7b7b0e7fea2d1a2b9f6f5501ad5e0b8c1b4a17b9
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann27-324/+324
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+3
Change-Id: I823aab2038eb08f4061e353b5fafc12b8e60e671
2015-10-06loplugin:mergeclassesNoel Grandin1-6/+3
in this case, just rename the baseclass so that it matches the other places we do this Change-Id: I21704db7352f72e43636dde9e92c8bef61b7e251
2015-09-30Fix typosAndrea Gelmini2-3/+3
Change-Id: Id27f5a357c1333dec5c24c4f5e0fdaed7a775774 Reviewed-on: https://gerrit.libreoffice.org/18963 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30Fix typosAndrea Gelmini2-2/+2
Change-Id: I013414cf10e25acd5216643855aaa230258a1b5f Reviewed-on: https://gerrit.libreoffice.org/18962 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-18boost->stdCaolán McNamara3-6/+4
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-01comphelper: fix MSVC --enable-mergedlibs build, OFOPXMLHelperMichael Stahl1-0/+1
The OFOPXMLHelper class causes duplicate definition link errors due to its WeakImplHelper base class. It turns out that the OFOPXMLHelper class itself is only used by other exported functions in comphelper itself so just hide the implementation detail. Change-Id: I3ac8c561af703193cc2609e2c799b630a0d43127
2015-08-26package: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe24-47/+46
with the variadic variants. Change-Id: If88e1d741075e86997c91dc2c59eeebe45f67c1f Reviewed-on: https://gerrit.libreoffice.org/17980 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-19Consolidate isFileUrl checksStephan Bergmann1-1/+2
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-18Remove newly unused ucbhelper/fileidentifierconverter.hxxStephan Bergmann1-1/+0
Change-Id: I7c272383ecb115e19699ed96bf5622d979403a01
2015-08-18Simplify ZipPackage::isLocalFile checkStephan Bergmann1-14/+1
(vnd.sun.star.wfs is long gone) Change-Id: I3e25f1728504cbad07bb97187a7bac23b33695dc
2015-08-17avoid possible leak on exceptionCaolán McNamara1-13/+35
Change-Id: Id3c16e5fedc5e57c8daccafa25bdb2fbbd0131b0
2015-08-07Related: tdf#88314 delete temp filesCaolán McNamara3-0/+10
clear to close the inputstream before attempting to delete the temp file, which is plausible as the windows-specific failure in earlier attempts at this Change-Id: I751aa3a098dd960f56b77a5f5fc93783c1060556 Reviewed-on: https://gerrit.libreoffice.org/17531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-05Resolves: tdf#88314 close temp file after each thread completedCaolán McNamara3-19/+65
Change-Id: Ic2eec30cfb5f61c53777eefeeb8bad6f552da2fc Reviewed-on: https://gerrit.libreoffice.org/17355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-26Revert "Resolves: tdf#88314 close temp file after each thread completes"Norbert Thiebaud3-47/+20
This reverts commit 738cf411e9315d17c7eb8be47ded643a00dfe5c5. It brokes windows in https://gerrit.libreoffice.org/#/c/17289/ as per http://ci.libreoffice.org/job/lo_gerrit_master/4465/Gerrit=Gerrit,Platform=Windows/ was pushed despite that.. :-(
2015-07-24Resolves: tdf#88314 close temp file after each thread completesCaolán McNamara3-20/+47
and reopen them when we need their data. That way we don't have as many open files as substreams in the package, so we don't run out of file handles Change-Id: Ic124e275abf15f4578c77ee271d185f40cb844b1 Reviewed-on: https://gerrit.libreoffice.org/17289 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-14loplugin:unusedmethods toolkit,packageNoel Grandin1-15/+0
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd Reviewed-on: https://gerrit.libreoffice.org/17031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-07loplugin:unusedmethods packageNoel Grandin8-85/+0
Change-Id: I19d6bbb9288d72b99d1023b4983b1c3fff7570e8 Reviewed-on: https://gerrit.libreoffice.org/16811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510 Reviewed-on: https://gerrit.libreoffice.org/16709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29drop yet another reimplementation of rtl::Reference (SotMutexHolderRef)Noel Grandin15-120/+48
Change-Id: I57f9dff931242405420bd45fae7ec5f13718707f
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-3/+3
Change-Id: Ib9bf6e0919ee0cab02d826859317ea20cb64cabb
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-10/+7
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-13TyposJulien Nabet1-1/+1
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara4-5/+5
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin2-7/+7
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11convert 'it.begin() == it.end()' to 'it.empty()'Noel Grandin1-1/+1
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145 Reviewed-on: https://gerrit.libreoffice.org/16212 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2-4/+4
Change-Id: I1a3766bba2c157f20422d3ffb0c08f631b537724
2015-06-05WaE: unreferenced local variableCaolán McNamara1-1/+1
Change-Id: Ie04966936a406fefbbcd1d96d7d3d299f98a31ae
2015-06-05uncaught exceptions in parallel deflate threads on re-export of HTB23106 odgsCaolán McNamara3-2/+20
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632
2015-06-01loplugin:loopvartoosmallNoel Grandin2-2/+2
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-08Rephrase comparisons between bool and sal_BoolStephan Bergmann1-1/+1
...to cater for forthcoming loplugin:implicitboolconversion improvements Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
2015-04-24loplugin:simplifyboolStephan Bergmann2-3/+3
Change-Id: Ia4177cf1a4b0c06ef614b54298fd6f9224956afc
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann2-3/+3
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin16-19/+19
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-12unnecessary castCaolán McNamara1-4/+3
Change-Id: I7c040b2539b9f7f923620a02d0a27e8e000fee4a
2015-04-09loplugin:staticmethodsNoel Grandin4-5/+5
Change-Id: Ie348778ea666c24e95e048386547f301083a0017