summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2014-10-28coverity#735309 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I15cbfb15054962998a058da1381a84bb667944ef
2014-10-24-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I2cc9884b23b49eb3e2afd27e5610bf96998a3c7f
2014-10-24coverity#736028 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I3ecb621d124c873556387e3bc5cfd5b9aadd8fc1
2014-10-24coverity#736027 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I099c0562bc52f0625ceac202b34b01025a7fd35d
2014-10-24coverity#736026 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I04bc103120256614fa76310d3ba0a51c560d9393
2014-10-23inline TokenMap::getUtf8TokenNameMatúš Kukan1-7/+0
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
2014-10-23Remove few pointless OUString::number() and one methodMatúš Kukan1-4/+3
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
2014-10-23maTokenNames.size() is constant: use it and be a bit fasterMatúš Kukan1-1/+1
Change-Id: I39a6e2badf0c159e87763e2782bc89f0ee6068ec
2014-10-23loplugin: cstylecastNoel Grandin1-2/+2
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
2014-10-22fix oox build on big endianDavid Tardon1-1/+1
Change-Id: I580266d908e30ef076de0517f41a600f4c9372c1
2014-10-17coverity#1247632 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I8d6df8c6853f0bd2f0b099d14bf0ac246170e7f1
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-2/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15I think this is what was meant, see cf7832d6Adolfo Jayme Barrientos1-2/+2
Change-Id: I626e3a36426958d7ba1fd320cf8e1a3bf2f3595f Reviewed-on: https://gerrit.libreoffice.org/11980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-13oox: refactor embedded media importMichael Stahl4-18/+29
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-11fdo#84647 : Fixed default value for TickLableSkip value.sushil_shinde1-1/+1
1. 'TextCanOverlap' property was stored as false if TickLableSkip is not equal to one. 2. For OOXML charts TickLableSkip can be between 1 to 999999999. 3. We can not apply zero or less than zero value to TickLableSkip. ( As per specification) 4. In axis model default value for TickLableSkip was zero which is incorrect. 5. Added unit test to check 'TextCanOverlap' property for chart. Change-Id: Ib3104b1d932f6e9376c149eabb201c8e9ad23da9 Reviewed-on: https://gerrit.libreoffice.org/11901 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-11fdo#75757: remove inheritance to std::mapTakeshi Abe2-8/+9
from oox::core::Relations. Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6 Reviewed-on: https://gerrit.libreoffice.org/11899 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-10fdo#54361: Chart background in XLSX is transparent instead of white.Muthu Subramanian1-7/+10
Change-Id: I116e7e8c9046009cfcadc04b5367a6fe25f88d96
2014-10-09drawingML export: fix <a:srcRect> if graphic's map mode is pixelsMiklos Vajna1-1/+7
Change-Id: Idbe399648c60e39c61e2be09a77b0648f57d3347
2014-10-08fdo#75757: remove inheritance to std::mapTakeshi Abe2-4/+4
from ItemFormatMap. Change-Id: I956b5797e677d22eb71fe801b650db7c982d6d51 Reviewed-on: https://gerrit.libreoffice.org/11854 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke1-4/+4
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-07oox: fix spurious rebuilds of namespacemap.cxxMichael Stahl1-0/+1
There is a missing dependency on one of the generated header files. Change-Id: Id3fa2ccf2c2a31527b795861afdf557882f56972
2014-10-07-Werror,-WuninitializedStephan Bergmann1-1/+1
Change-Id: I91333f5290c84c6317b85572824be065da9cf64b
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-2/+2
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-03Remove OSL_ASSERT which could fail for allowed XLS_TOKEN(tint)Matúš Kukan1-1/+0
Change-Id: I6e0cc345f6903128ffebe5fb56f6e198ee32da9a
2014-10-02coverity#1242917 Result is not floating-pointCaolán McNamara1-1/+1
Change-Id: I284562585c10a3d68b8545df7b6cb3022001660c
2014-10-01DOCX drawingML import: handle char color from theme for shape textMiklos Vajna2-1/+24
When we import table styles, we apply that as direct formatting, in case there is no real direct formatting, see lcl_ApplyCellProperties() in the sw UNO implementation. We can do the same here: in case there is no other formatting, then apply the char color from the WPS theme, that will give us the expected result. Change-Id: Ic8e6afc09167f7924a11ab0b445351075f16738e
2014-10-01fdo#82577: Handle TimeNoel Grandin2-12/+12
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30Resolves: fdo#79129 Crash in oox::drawingml::LayoutNode::setupShapeCaolán McNamara1-1/+9
Change-Id: I0bafd2c43d29806eea0ff0cb165e67aece53488f
2014-09-30bnc#584721: invisible text because of wrong color (white)Zolnai Tamás1-10/+20
Color::getColor() method uses some caching mechanism which works wrong when the result depend on one of the input parameters. So avoid caching in these cases. Change-Id: Ifa9221e21e685715454de86d5cec09ff6c266307
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin2-3/+3
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-29proper reading of mso-position-(horizontal|vertical)(-relative)Luboš Luňák2-1/+27
Change-Id: I50f537c697f6e73c1fd150f3f03fc65b85ccbeaf
2014-09-29drawingML export: fix remaining rotation / flip combinationsMiklos Vajna1-13/+4
With this, each rotation = 0 / 90 / 180 / 270 and flip = none / horizontal / vertical / horizontal+vertical combination (16 cases) are exported perfectly. Also, this matches what the (binary) [MS-ODRAW] export does, see ImplEESdrWriter::ImplWriteShape(). Change-Id: I04030c8c6819c35c06ce97400eb7e2f1f7389a5f
2014-09-27Use oox::drawingml::EMU_PER_HMMMiklos Vajna1-3/+3
Change-Id: I2034f862b5e15ffaa2ba370ae0249628677c587d
2014-09-26DOCX drawingML import: fix remaining rotation / flip combinationsMiklos Vajna2-3/+14
With this, each rotation = 0 / 90 / 180 / 270 and flip = none / horizontal / vertical / horizontal+vertical combination (16 cases) are imported perfectly. Also adjust a few testcases -- now that in many cases we only set the position in oox, some rounding errors went away. Change-Id: I5567a7d6964775f2caf10a0e539f3eb84d10461e
2014-09-26cleanup GUID/ClsId/CLSID typesNoel Grandin1-13/+5
- rename GUID to SvGUID so we don't need an #ifdef WIN32 - drop ClsId struct, since it is used interchangeably with GUID and has the same structure Change-Id: Idf5c14c82a6861ef585fb57896a9b12cfe40374c
2014-09-26Resolves: fdo#84261 unexpected exception -> clang builds terminateCaolán McNamara1-1/+1
Change-Id: I545ed112b54fb3d81e67b0f42230811cd48de626
2014-09-26bnc#897769: OOXML import: Import border lines using reference too.Matúš Kukan1-22/+33
Do not ignore 'lnRef' element. Also fix typo to apply 'seCell' properties to the right cell (southeast). Change-Id: Ia45f7016f358b70e6db06a232c569335ce9d7051
2014-09-25Fix validation problems pointed out by CppunitTest_sd_export_testsMiklos Vajna1-0/+4
Regression from e8bdd38882522591723097c028ca7a6927ee70c4 (fdo#83751-FILESAVE:Custom Properties dropped while exporting to .pptx, 2014-09-11), there were two problems here: 1) Using the wrong filter when the output is expected to be suitable for validation. 2) Writing empty custom property values, which is not valid. Change-Id: Ic18c789c53bd40cc8aa07385cb5fd0d5c7ada6ab
2014-09-24Remove TokenMap::getUnicodeTokenName()Matúš Kukan5-22/+15
Change-Id: I778dc43085b6afbb6456cbf53fe8c95b624b75b3
2014-09-24fdo#84028 : Preserved all caps property for text.sushil_shinde1-0/+16
1. All capital letters were exported as small letters. 2. Problem was 'cap' property was not exported for 'rPr' in drawingml. Change-Id: I81bfb418f773aa88118b22550eea2b3ec2833ea9 Reviewed-on: https://gerrit.libreoffice.org/11563 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-09-23fdo#84090: Remove maUniName from oox::TokenMapDavid Ostrovsky1-6/+10
Change-Id: I8165def0b6291bfd7bb109e1cdaeb4198ed696b7 Reviewed-on: https://gerrit.libreoffice.org/11560 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2014-09-23Add unit test for oox::TokenMapDavid Ostrovsky4-14/+124
Change-Id: Iced083868a84fd9fbb97ad91dfc0acbf5b69b766 Reviewed-on: https://gerrit.libreoffice.org/11559 Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de> Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>
2014-09-21OOX: Update README with recently made changesDavid Ostrovsky1-5/+5
Change-Id: I2f4db02ede9c15193c21014a297d40a7370a505b
2014-09-21Fix some typosDavid Ostrovsky1-1/+1
Change-Id: I0f2821c87c03f8d3df2e60bab9e09ce6545e2b2c
2014-09-19Remove unused XFastTokenHandler functionsMatúš Kukan2-21/+0
Change-Id: I0d8072f1194aa837932dcffd6dc6a3761bbdc74e
2014-09-17bnc#584721: Import subtitle block to master slidesZolnai Tamás1-6/+3
For some reason subtitle block was skipped for layouts. It seems we can enable it for layout too, it appears well on master slides. Change-Id: I23ec7d4fcce045099bfca9e94a8c9335beaf7468
2014-09-17bnc#584721: Do not add extra title and outliner blocks to master slideZolnai Tamás1-0/+11
There are master slides / layouts imported from PPTX in which there is no title or body layout block, but so far Impress added these by default to the master slides if they were missing. Now they are skipped by the importer code. Change-Id: I256a4e78639ea39d0f87a94e6676422c7dbcde4a
2014-09-17bnc#584721: Right text inside the title area on master pageZolnai Tamás1-0/+1
With setting bClearText to true the default text used inside LO will be removed. Before that change the imported text was appended to the end of the LO default text. Now it contains only the imported text. Change-Id: I9f5eb0e20468a35c64130a433367cd3845ac7e3c
2014-09-15Ensure we export correct label placement value for clustered bar chartsMiklos Vajna1-1/+5
This is similar to 7b8073906adca8dae24c04a23708a3f3d582218f (Ensure we export correct labal placement value for percent/stacked charts., 2014-08-07), in case a clustered bar chart has a top placement ("t" in OOXML), then MSO complains as well. Change-Id: Iffd991127784e0e732f6ae55de956a328a3a53e5
2014-09-14Replace struct EmbeddedWAVAudioFile with simple string.Matúš Kukan9-52/+25
Change-Id: I6659b6e1be865546f380a28e4803fbe593de0803
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-03 16:51:22 +0000