summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2014-12-02Resolves: fdo#70157 fix crash on loadingCaolán McNamara1-3/+7
Change-Id: I0d248a195852c14cd95d4e337823076dd2fbc19d (cherry picked from commit 8302d048653d9ac25d3cb9ab9277df715053ad6a)
2014-11-30PPTX import: fix import of shape line properties defined by themeZolnai Tamás1-1/+4
See also: 81cd386facedfbb15be6dffc10351262abf733f3 (cherry picked from commit 664a56b3c81503bdf199edf1806676f0a35b956f) Change-Id: Ibb21d3e5b52a4d4996202acd4a989910fa223632
2014-11-30bnc#904423: Text(box) is rendered white on white when it is notZolnai Tamás1-1/+6
The problem was that the background color defined by theme was not imported correctly, because the different fill style comes from different sources (master slide, theme, direct formatting) were applied on the shape in wrong order. To solve this we need to store master slide defined fill style in a different variable so theme style can be applied after master slide defined style but before direct formatting. Change-Id: I99ea981858b9fa391915570187c8ddfdf2be1f7a (cherry picked from commit 81cd386facedfbb15be6dffc10351262abf733f3)
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl5-0/+5
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl65-0/+76
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17Add rtl::OUString::toUtf8()Miklos Vajna1-3/+3
There is rtl::OUStringToOString() already to do OUString to OString conversion using UTF-8 encoding on a best effort basis. However multiple modules have code where we assume that such a conversion is perfect. Add a new method that asserts such an expected success instead of duplicating it at multiple places. Change-Id: I0e55b53f558df82b67af6a463c8144655cf0ca74
2014-11-15oox: these are expected to be UTF-8Miklos Vajna1-3/+3
Change-Id: I2e9cb96948d7f990dd8be5f4505f00306fa62f8f
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava8-10/+10
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini4-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11build fixCaolán McNamara1-1/+2
Change-Id: I9d4dc8a165bc042a674eb472162292a486f3761c
2014-11-11coverity#1187643 Unchecked return valueCaolán McNamara1-6/+10
Change-Id: I2ba56fbff1ae05d1185d08d4fbd0285954fed38b
2014-11-10coverity#1130169 Unchecked return valueCaolán McNamara1-4/+4
Change-Id: I62ed42412a0cafa33ddafe536723f5e336c92a7a
2014-11-07Swapping Graphic is a privilage of GraphicObject.Zolnai Tamás1-13/+0
This means more things: * Graphic won't swap out itself, so those classes which uses Graphic without GraphicObject won't need to deal with swapping. * When a Graphic is queried from GraphicObject the caller won't need to deal with swapping, because GraphicObject swaps it in before return. * GraphicObject will swap in the Graphic always when a swapping dependent data is queried (e.g. whole graphic, transformed graphic or AnimationNotifyHdl) Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
2014-11-07MS export: don't need to manually swapout images after swapin themZolnai Tamás1-3/+0
We have some good auto mechanisms for that. Change-Id: I487dbf4a5fc69c7563dfbc5c21f9ebdb05ba6b9e
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-3/+3
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-3/+3
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#85813 drawingML export: fix handling of impress tablesMiklos Vajna1-2/+5
Change-Id: Ia17b14c4b27e808ceab388aa33602875e67433a5
2014-11-05oox: document PPTX export entry pointMiklos Vajna1-1/+4
Change-Id: I8102f31d46257c96837b6c9497e9c49f92ac29b1
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin4-11/+7
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04Actually we shouldn't always set Overlap flag on for all xlsx charts...Kohei Yoshida1-1/+1
The correct fix unfortunately would require making the axis label layout smarter, to avoid overlapping of angled text label objects. Change-Id: I92198dbb90fd4a206ee226307992343d064f733a
2014-11-03typo: geomtery -> geometryAndras Timar1-1/+1
Change-Id: I20263c836dd55e663cdad9fc8283fe8fbf02b1f1
2014-11-02unused includes in RTF filter and related filesMiklos Vajna2-11/+0
Change-Id: Id13e10f2ceed3985c78ccc542e6677eccc0cb1c7
2014-11-01oox: introduce W_TOKEN() macroMiklos Vajna5-82/+83
It was inconsistent that when parsing <a:foo> elements, A_TOKEN(foo) was available, but for <w:foo> elements there was no W_TOKEN() macro. Also, there were two manual variants (NMSP_doc|XML_foo or via OOX_TOKEN(doc, foo)), replace both of them with W_TOKEN() for easier searching. Change-Id: Ic5cd027f07518535b92671ffe3c486016a3f9f0a
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-29constStephan Bergmann1-1/+1
Change-Id: Ia76df719b2f76a993e65e0bf6d55723b1a2f5b93
2014-10-29constStephan Bergmann1-1/+1
Change-Id: I0d89cc99a1d8f7b3c17986b45653dce5e4b436d7
2014-10-28coverity#735309 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I15cbfb15054962998a058da1381a84bb667944ef
2014-10-24-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I2cc9884b23b49eb3e2afd27e5610bf96998a3c7f
2014-10-24coverity#736028 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I3ecb621d124c873556387e3bc5cfd5b9aadd8fc1
2014-10-24coverity#736027 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I099c0562bc52f0625ceac202b34b01025a7fd35d
2014-10-24coverity#736026 Invalid iterator comparisonCaolán McNamara1-2/+3
Change-Id: I04bc103120256614fa76310d3ba0a51c560d9393
2014-10-23inline TokenMap::getUtf8TokenNameMatúš Kukan1-7/+0
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
2014-10-23Remove few pointless OUString::number() and one methodMatúš Kukan1-4/+3
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
2014-10-23maTokenNames.size() is constant: use it and be a bit fasterMatúš Kukan1-1/+1
Change-Id: I39a6e2badf0c159e87763e2782bc89f0ee6068ec
2014-10-23loplugin: cstylecastNoel Grandin1-2/+2
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
2014-10-22fix oox build on big endianDavid Tardon1-1/+1
Change-Id: I580266d908e30ef076de0517f41a600f4c9372c1
2014-10-17coverity#1247632 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I8d6df8c6853f0bd2f0b099d14bf0ac246170e7f1
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-2/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15I think this is what was meant, see cf7832d6Adolfo Jayme Barrientos1-2/+2
Change-Id: I626e3a36426958d7ba1fd320cf8e1a3bf2f3595f Reviewed-on: https://gerrit.libreoffice.org/11980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-13oox: refactor embedded media importMichael Stahl4-18/+29
Currently the oox import creates a temp file and leaks it, and there is no way to clean it up afterwards. Unfortunately it turns out that SdrModel has no way to access the imported OOXML storage, so add a really ugly hack to get the embedded media into the SdrMediaObj by setting both MediaURL and PrivateStream properties (currently oox really wants to set the properties in alphabetical order too...) Change-Id: I5a235fbeb08e7bc17faf066de52b94867e9a79a2
2014-10-11fdo#84647 : Fixed default value for TickLableSkip value.sushil_shinde1-1/+1
1. 'TextCanOverlap' property was stored as false if TickLableSkip is not equal to one. 2. For OOXML charts TickLableSkip can be between 1 to 999999999. 3. We can not apply zero or less than zero value to TickLableSkip. ( As per specification) 4. In axis model default value for TickLableSkip was zero which is incorrect. 5. Added unit test to check 'TextCanOverlap' property for chart. Change-Id: Ib3104b1d932f6e9376c149eabb201c8e9ad23da9 Reviewed-on: https://gerrit.libreoffice.org/11901 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-10-11fdo#75757: remove inheritance to std::mapTakeshi Abe2-8/+9
from oox::core::Relations. Change-Id: If2e0109a2ad6598436177b7638cb6d568fb2d3d6 Reviewed-on: https://gerrit.libreoffice.org/11899 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-10fdo#54361: Chart background in XLSX is transparent instead of white.Muthu Subramanian1-7/+10
Change-Id: I116e7e8c9046009cfcadc04b5367a6fe25f88d96
2014-10-09drawingML export: fix <a:srcRect> if graphic's map mode is pixelsMiklos Vajna1-1/+7
Change-Id: Idbe399648c60e39c61e2be09a77b0648f57d3347
2014-10-08fdo#75757: remove inheritance to std::mapTakeshi Abe2-4/+4
from ItemFormatMap. Change-Id: I956b5797e677d22eb71fe801b650db7c982d6d51 Reviewed-on: https://gerrit.libreoffice.org/11854 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke1-4/+4
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-07oox: fix spurious rebuilds of namespacemap.cxxMichael Stahl1-0/+1
There is a missing dependency on one of the generated header files. Change-Id: Id3fa2ccf2c2a31527b795861afdf557882f56972
2014-10-07-Werror,-WuninitializedStephan Bergmann1-1/+1
Change-Id: I91333f5290c84c6317b85572824be065da9cf64b
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-2/+2
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-03Remove OSL_ASSERT which could fail for allowed XLS_TOKEN(tint)Matúš Kukan1-1/+0
Change-Id: I6e0cc345f6903128ffebe5fb56f6e198ee32da9a
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 17:57:21 +0000