summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2017-04-12tdf#106217: Wrong size and position of a shape inside chartTamás Zolnai1-0/+5
Same code which was added to the method DrawingFragment::onEndElement() in d178d7bef193565a7d6aacbc37a58dfc4bd7b316 A shape's size and position inside a chart object are primarily defined by <cdr:from> and <cdr:to> tags in drawing.xml, but in the same file we also have an <a:xfrm> tag which is used for the same thing (defining size and postion) in general. Testing with MSO it seems it ignores what values are set to <a:xfrm> and uses only the <cdr:from> and <cdr:to> values. The test document showing this problem must be created an earlier version of MSO, becuase <a:xfrm> is set to some random values. Editing the chart and saving it with MSO 2013 the <a:xfrm> values are set consistently with <cdr:from> and <cdr:to> pair. Reviewed-on: https://gerrit.libreoffice.org/35069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit aa204f1c09a760d6753c408376ab7307fb13ad91) Change-Id: Icbaff78e5a6fcea36678c3b3755c97f57976b626 Reviewed-on: https://gerrit.libreoffice.org/35076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-04-12tdf#106304: Fix newline and empty paragraph font size issues in .pptx exportTor Lillqvist2-29/+57
Output <a:br> instead of &#10; for hard newlines. This fixes the problem that the line before the hard newline in the .pptx export is not centred. The fix for the sd_export_tests is a bit hacky, but then so is the code in question. Don't unnecessarily use bogus default char size for a:endParaRPr. Instead use the size last used for an a:rPr below the same WriteText() call. I am not exactly sure about how this hangs together, but this has the desired effect on the exported .pptx. Change-Id: Ie23e0c33e6efb303b183d3b2efce6866d0dda4e8 Reviewed-on: https://gerrit.libreoffice.org/34888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-02tdf#90407: Export Text AutoFit to .pptxTor Lillqvist1-2/+11
Change-Id: I2120f13fff58d4736ab55071236e0c2f80ba2eb0 (cherry picked from commit 7277991e78c264025b4894ae07b40fb12cd57ce6) Reviewed-on: https://gerrit.libreoffice.org/34374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-16tdf#106026: Export paragraph top and bottom margin to DrawingMLTor Lillqvist1-0/+28
Change-Id: I8c60f86a1debe135c9172ff639aa5af93f03b99b (cherry picked from commit d2b014edc0f466370023a35eb46548390ceb7fb2) Reviewed-on: https://gerrit.libreoffice.org/34300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-15Related: tdf#105707 PPTX import: warn on invalid/empty SmartArt fallback relidMiklos Vajna2-1/+16
We already warn when the SmartArt doesn't have a drawingML fallback, but having a reference to a fallback that is not a valid one (so resolves to an empty fragment path) is also unusable. So warn in that case as well. (cherry picked from commit 2d732b498bab244cde6978e9389511a940101995) This second related situation is about when there is drawingML fallback for the SmartArt, but it's ampty shape tree, which is never created with MSO2010+ (those shape trees always have at least one element). This is as bad as the missing drawingML fallback, so warn on it. (cherry picked from commit 8c6776f27cef1e2b7b40957f1801b08707bc3230) Change-Id: I03b2325003b4eb38b1347a88899799c6d5c33606 Reviewed-on: https://gerrit.libreoffice.org/34197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-02-13Related: tdf#105707 PPTX import: decode document name from URLAndras Timar1-1/+1
Change-Id: I7448c48b9376a4b73b8a35034a73353981174823 Reviewed-on: https://gerrit.libreoffice.org/34137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-09tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna3-2/+39
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. (cherry picked from commit ae828495be9c2ac5fdb4c1747ed7bdd51e5d87a7) Conflicts: include/svx/dialogs.hrc oox/source/core/xmlfilterbase.cxx Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-09tdf#31488: Background fill changes its color when saving a PPTX file to ODPTamás Zolnai1-1/+4
For a gradient fill we need to generate a name because ODP export works with this name. In case of shapes it works because when fill attribute changes some internal name generation is triggered. The same thing doesn't work for slide background so generate this name explicitely in oox code. Reviewed-on: https://gerrit.libreoffice.org/33937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit aeece6f198685b96579bdbd1409b3535fb5f09d1) Change-Id: Ic6ebf37ef3d66a9c274747ca04653363b1fe6d02 Reviewed-on: https://gerrit.libreoffice.org/33956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-17tdf#97597: Ensure that each parsing thread has its own buffer.Kohei Yoshida1-2/+2
(cherry picked from commit 4ae705d02df0ddf75b97d0e94add6994626f487e) Change-Id: I93077f954a49b3922930e4fc86c80228be0f4dd2 Reviewed-on: https://gerrit.libreoffice.org/33069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-on: https://gerrit.libreoffice.org/33179 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-01tdf#104539 dir attribute of outerShdw has to be non-negativeAndras Timar1-1/+1
Change-Id: Ic6f1c8555eb8d137ced2f4e87baa866df84c69ac Reviewed-on: https://gerrit.libreoffice.org/32471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-10tdf#104445: PPTX import: Extra bullets are added to placeholder textTamás Zolnai2-2/+4
Reviewed-on: https://gerrit.libreoffice.org/31771 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit cb598029835477326b190bc99abd31a487cc5a91) Change-Id: I25ce98ed391f70292bed6238645b121b9cf50d5e Reviewed-on: https://gerrit.libreoffice.org/31791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-27tdf#104201: PPTX: Group solid fill is not importedTamás Zolnai1-3/+3
Reviewed-on: https://gerrit.libreoffice.org/31263 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 7c5aaa254f444d54b9ebf6574f0ccd37af548ee5) Change-Id: Iec273714108598d7017e73a9e7d384f8410d6ee1 Reviewed-on: https://gerrit.libreoffice.org/31267 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-26tdf#104015: PPTX import: Title shape does not inherit fill propertiesTamás Zolnai1-26/+85
...from slide master. The problem caused by that PPTX files contains not a one-level master slide set, but has two levels: one called slide master, other called slide layout. Slide layout inherit properties from slide master and normal slide inherit propetries from slide layout. Bug appeared because, slide layout inherited properties were not forwarded to the normal slide. Reviewed-on: https://gerrit.libreoffice.org/30969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8d613870b2cd2e3e4396b4fa97dbd8080fda8f52) Conflicts: sd/qa/unit/import-tests.cxx Change-Id: I587582498cf4315087f9a576c1b7fc41ee23e2fd Reviewed-on: https://gerrit.libreoffice.org/30971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-26tdf#103876: PPTX import: Title shape's character properties are wrongTamás Zolnai5-19/+92
Text properties are applied on a shape during text insertion, but if a placeholder shape has no text, then it has a placehodler text which should have the right text properties. Change-Id: I54175d52dd25915ee4d7153298e01ec07c6be1f6 Reviewed-on: https://gerrit.libreoffice.org/30881 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 5c7f3e4a7190bf9821bed102f96a926c9a894e59) Reviewed-on: https://gerrit.libreoffice.org/30940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-11tdf#103792: No placeholder text imported for empty title shapeTamás Zolnai2-2/+1
Change-Id: I95b4358f0d4311e8f427c8de18863049fb718d9b Reviewed-on: https://gerrit.libreoffice.org/30731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit dc024cdd91e3c33eeff8eea22fdef0d90d4dd2c0) Reviewed-on: https://gerrit.libreoffice.org/30762 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-08google docs can generate a pptx with an empty cmLstCaolán McNamara1-9/+12
Change-Id: I2a3dcae5361929c6880b2da1b3107cb2c8141f32 (cherry picked from commit e6157763e9fff300b86f3c17398216f306ba3f32) Reviewed-on: https://gerrit.libreoffice.org/30672 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2016-10-29tdf#63846 assign macros after VBA project fully loaded.Justin Luth1-3/+2
fixes regression caused by d4743045a0b320449d07a957463a76bb8b13f939. see the documentation for VbaMacroAttacherBase, which indicates that the macros are to be attached after all objects are finished loading. Made attachMacros() public so it could be called separately since so many things are inter-dependent in the logic flow. Reviewed-on: https://gerrit.libreoffice.org/30337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Conflicts: oox/source/ole/vbaproject.cxx Change-Id: I11f7f4a1a75d6f77a97e12e3359d6ea8a995f518 Reviewed-on: https://gerrit.libreoffice.org/30371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-26implement CryptoAPI RC4+SHA1 encryption scheme for xls importCaolán McNamara3-66/+37
there might be other variants out there in practice, but this works for default encrypted xls of excel 2013 (cherry picked from commit 1473ce030314027c01c98f513407ed0897328585) contains... be more c++y Change-Id: I673b00e111a734bc626ba3d3f6ecf9692f1ce7db (cherry picked from commit fcf7f503b64b2cf7dbef019fb43dde033e3538e8) hash len is 20 for xls cryptoapi configuration Change-Id: I6e06b8578959b8147043179db57e875b1d98d57d (cherry picked from commit 491884350ce74f36044b3348bd66356ad1c234af) clarify hash lengths a bit more Change-Id: I66cea4b9efb82d29e6c052ac11a6f2eaca823ce0 (cherry picked from commit 8db1b13e721683d0263925c8e0300dd86a022814) hash len isn't going to change depending on who implements it Change-Id: Iee585cba4acad74c11d083085153e2af96c8894f (cherry picked from commit fcc846e8f29839eaace7e1d28746abea8f4b598a) move some useful header information to mscodec for reuse Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87 (cherry picked from commit fc514cbf30be1613fdf4d4b7c12cbd55ca08b9b0) rework things in light of now available documentation Change-Id: If5f75e27191017a8c6a3929e2a70d21840f157c6 (cherry picked from commit 3fabbd0a22219464545f933fc28c869a6fa89546) split MSCodec_Std97 into a baseclass MSCodec97 (cherry picked from commit 06916c839b16866b47235306d2db50850df0ad7c) Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30 Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3 Reviewed-on: https://gerrit.libreoffice.org/30128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-25tdf#103389: Resaving a DOCX document with two canvases leads to a broken file.Tamás Zolnai2-8/+11
Make custom shape export more robust. In case of the test document, WriteCustomGeometry is called, but this call does not export anything, and so we get a shape without any geometry in the DOCX file, which causes problem to MS Word. Reviewed-on: https://gerrit.libreoffice.org/30241 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f7c61b08d526c79ecd1522dff79386059b6125e0) Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport9.cxx Change-Id: Ie7a4e2b8a18bfddaeeb81425ae5f1de04140d43f Reviewed-on: https://gerrit.libreoffice.org/30242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-14tdf#102997 Fix Error in OOXML Transparency Conversion Mathlbenes1-1/+1
This fixes the import logic for tdf#100830 to handle transparencies other than 50%. (cherry picked from commit ade43e6a86e4f864e771f4b3008a428bc10fa55f) Conflicts: oox/source/drawingml/fillproperties.cxx Change-Id: If4e2e369a9674488878bb0a4378d48292ea4e0cb Reviewed-on: https://gerrit.libreoffice.org/29830 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-14tdf#100830 drawingML import: handle <a:alphaModFix>Miklos Vajna2-0/+7
Fill transparency on the UI. Regression from commit 57450afb768c085df0ba2344aa94b5f843060178 (DOCX import: declare wps as a supported feature, 2013-12-03), as the VML import handled this. (cherry picked from commit ecfcee8b05e45ec82dec6ed417e9ac53d4d7b4ff) Change-Id: I654b51d51448d25d400979a4a62189b86126ac01 Reviewed-on: https://gerrit.libreoffice.org/29560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-04tdf#96161, always write the varyColors elementMarkus Mohrhard1-0/+2
The default value changed between MSO 2007 and 2010 so we need to always write the value. Change-Id: I563eafa84baa3df656c83d657ebbb4c381c09957 Reviewed-on: https://gerrit.libreoffice.org/29420 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 74b2cc607448d24146bd3508abb832d6ab42cb56) Reviewed-on: https://gerrit.libreoffice.org/29426 Reviewed-by: Eike Rathke <erack@redhat.com>
2016-09-21tdf#96662, only use the crossBetween="midCat" for line and scatter chartMarkus Mohrhard1-1/+2
Change-Id: Id2be263daf2c5a9f2d69ed50b79ac029143f02ca Reviewed-on: https://gerrit.libreoffice.org/29092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07tdf#93883 don't add space to empty paragraph when bullet is turned off.Mark Hung1-1/+4
Change-Id: Ia1bad61cb5585dae0501e8cd657fc84bfea60ab2 Reviewed-on: https://gerrit.libreoffice.org/25679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 005ae2fa195bddd1073f3d883cf041d9ac80fad1) Reviewed-on: https://gerrit.libreoffice.org/25984
2016-05-25oox: replace boost::array with std::arrayMichael Stahl1-4/+2
Change-Id: Id9a8f7dbbf13890e7c9787d9b0737f1087e4a509
2016-05-20warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bitsNoel Grandin1-1/+1
in VisualStudio reported by Luke Benes Change-Id: I908039750a3e89e4d1b77631f7d309191735c765
2016-05-18clang-tidy modernize-make-sharedNoel Grandin14-35/+34
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13tdf#42949: clean up includes in include/oox/ole with iwyuJorenz Paragas2-0/+6
Change-Id: I9cbdc78b540b0f735c451ac561f0f0ccdaf7efbd Reviewed-on: https://gerrit.libreoffice.org/24911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11tdf#42949: clean up includes in include/oox/mathml with iwyuJorenz Paragas1-0/+2
Change-Id: Iefb4e7184009318c0b8859aa895e0b25fc9d9213 Reviewed-on: https://gerrit.libreoffice.org/24871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas88-5/+150
...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Silence Clang -Wimplicit-fallthrough in gperf-generated codeStephan Bergmann1-3/+2
...in preparation of eventually enabling -Wimplicit-fallthrough for Clang. Change-Id: Idca352d011505e83dbe275cb19626c8b9d8560c8
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann5-6/+25
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann4-0/+4
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10loplugin:rangedforcopyTor Lillqvist1-2/+2
Loop variable passed by value, pass by reference instead. Change-Id: I12d1cb639cbe7a5686a1854168362b85322fa2e5
2016-05-10remove STATIC_ARRAY_END and usagesJochen Nitschke4-93/+93
used in loops, rewrite to range based loop oox/source/drawingml/color.cxx has some mappings in plain arrays make them arrays of pairs which can be used in range based loops Change-Id: Ib6693197d890f595c27ca24b9f9b4e0763747f4c Reviewed-on: https://gerrit.libreoffice.org/24809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl2-26/+24
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-06tdf#42949: clean up includes in include/oox/export with iwyuJorenz Paragas2-0/+3
...and fix the usual compiler errors that occurred as a result. Change-Id: I54781d3f01e9f5a87fd008870c825b2d8154fd59 Reviewed-on: https://gerrit.libreoffice.org/24686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin2-2/+2
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05clang-tidy modernize-loop-convert in oox to saxNoel Grandin5-18/+18
Change-Id: If0d87b6679765fc6d1f9300c6972845cf3742b9c Reviewed-on: https://gerrit.libreoffice.org/24674 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-03tdf#42949: clean up includes in include/oox/drawingml with iwyuJorenz Paragas19-0/+23
Add includes in other files to fix compiler errors. Change-Id: I566e2e081094cb074d20afbe7ceee49f759c725b Reviewed-on: https://gerrit.libreoffice.org/24510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-29tdf#99030: PPTX import: Fixed lost slide background colorMatus Uzak2-2/+4
Regression from commit f3d1ac7 Change-Id: I5cb9fe1bb6c753c34b49e72194a9fbe4c10c1654 Reviewed-on: https://gerrit.libreoffice.org/23930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-29tdf#90736: PPTX import: Improved table border line style supportMatus Uzak1-1/+41
Map preset line dash values from ooxml to the smaller set of LO's predefined table border line styles. Map custom dashing scheme to a simple dashed line style. Change-Id: Ia81d94cb7e20b05f1c2cc0c20c8ad398c5613d6c Reviewed-on: https://gerrit.libreoffice.org/24048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2-5/+5
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27tdf#80999 Canceling password prompt should abort detectionMaxim Monastirsky1-5/+13
... instead of continuing the detection loop and being "detected" as plain text. The detection API will from now return a type based on the file extension only, which is far more useful than "plain text" anyway. Plus the media descriptor has a flag to indicate that the detection wasn't completed, which can be also used by the loading code to abort the loading process. Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946 Reviewed-on: https://gerrit.libreoffice.org/24428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-04-26tdf#42949: clean up includes in include/oox/crypto with iwyuJorenz Paragas5-3/+20
The includes in CryptTools.hxx that are within #if/#endif directives are not altered. iwyu suggested replacing the includes for nss.h, pk11pub.h, and sechash.h with hasht.h, pkcs11t.h, seccomon.h, and secmodt.h. I decided not to because it might make CryptTools.hxx harder to refactor in exchange for little gain. Before creating this commit, I ran 'make check' after passing --with-tls=openssl to ./autogen.sh to ensure that building with either OpenSSL or NSS (the default except on iOS and Android) works. Change-Id: I20260d18f073ffd8077bbcc597e7a8e4954e2ec5 Reviewed-on: https://gerrit.libreoffice.org/24386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin8-39/+39
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: Iaae2c92e011c55f8739ecb7972ef9a3f71300765
2016-04-25tdf#42949: clean up includes in include/oox/core using iwyuJorenz Paragas68-2/+159
This allows the headers in that folder to stand on their own and not depend on any transitively included headers. All changes to other files are needed to fix compiler errors related to missing includes that occurred afterwards. Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4 Reviewed-on: https://gerrit.libreoffice.org/24355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-22Avoid reserved identifiersStephan Bergmann2-3/+3
Change-Id: Ie1664e06dc02f7070e4ef77155e6541c70b2f8e8
2016-04-21new plugin stylepoliceNoel Grandin2-7/+7
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 01:10:34 +0000