summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2016-10-05convert MapUnit to scoped enumNoel Grandin4-6/+6
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-04tdf#100830 drawingML import: handle <a:alphaModFix>Miklos Vajna2-0/+7
Fill transparency on the UI. Regression from commit 57450afb768c085df0ba2344aa94b5f843060178 (DOCX import: declare wps as a supported feature, 2013-12-03), as the VML import handled this. Change-Id: I654b51d51448d25d400979a4a62189b86126ac01 Reviewed-on: https://gerrit.libreoffice.org/29517 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-01tdf#96161, always write the varyColors elementMarkus Mohrhard1-0/+2
The default value changed between MSO 2007 and 2010 so we need to always write the value. Change-Id: I563eafa84baa3df656c83d657ebbb4c381c09957 Reviewed-on: https://gerrit.libreoffice.org/29420 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-30loplugin:constantparamNoel Grandin7-27/+22
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c Reviewed-on: https://gerrit.libreoffice.org/29321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-28oox: use '= default' to define a trivial destructorMiklos Vajna3-9/+3
Change-Id: I67f368c84dee85102c63bb4e3f811454a03c9560 Reviewed-on: https://gerrit.libreoffice.org/29348 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-09-20tdf#96662, only use the crossBetween="midCat" for line and scatter chartMarkus Mohrhard1-1/+2
Change-Id: Id2be263daf2c5a9f2d69ed50b79ac029143f02ca Reviewed-on: https://gerrit.libreoffice.org/29080 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-18loplugin:unusedenumvaluesNoel Grandin1-2/+1
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-18fix missing default ctor for ObjectTypeFormatEntry with MSVCJochen Nitschke1-0/+8
MSVC can't create the default ctor (likely because members are pointers). deleting default ctor will trigger gcc (4.8) fault where aggregate initialization fails. create ctor which does same as aggregate initialization, this also prevents implicit creation of default ctor. Change-Id: Ica79c7404de240f38ad18100e6dbc25f1b427960 Reviewed-on: https://gerrit.libreoffice.org/28981 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Luke Deller <luke@deller.id.au> Tested-by: Luke Deller <luke@deller.id.au>
2016-09-17convert ShapePropertyId to scoped enum and use it for enumarrayJochen Nitschke5-96/+80
new type ShapePropertyIds replaces vector and plain arrays replace END enum member with LAST remove PROP_END_LIST from plain arrays and properties script store ShapepropertyInfo as reference in ObjectTypeFormatEntry store ShapePropertyIds as reference ShapePropertyInfo Change-Id: If273cc9e6c7bbd625dba5dc79f1c4ae0b21bdb3c Reviewed-on: https://gerrit.libreoffice.org/28960 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16fix copy&paste in DownBarFillsJochen Nitschke1-1/+1
Change-Id: Id1e61caa2252c2d27560b8565abd3255faaf684b Reviewed-on: https://gerrit.libreoffice.org/28939 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-16loplogin:singlevalfields in include/Noel Grandin2-13/+2
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl3-9/+9
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann67-139/+139
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert GradientStyle to scoped enumNoel Grandin1-6/+6
Change-Id: Ib740da708612df7a5f4b8c82262b9b1bd436604d
2016-08-30default dtors are fine hereCaolán McNamara2-8/+0
Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (oox)Stephan Bergmann1-1/+1
Change-Id: I1a3190f136b69702615cdf796ff45abfd89155dc
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke2-15/+15
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann12-14/+14
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-19coverity#1371374 Resource leakCaolán McNamara1-10/+10
Change-Id: I6b96ab51c2013577b9d0299a86e545b4a899939a
2016-08-11Convert handles of built-in shapes in Impress when exporting to PPTX.Mark Hung2-1/+237
For those shapes exported as OOXML preset shapes, their AdjustmentValues property was exported as the list of adjustment values ( avLst ) in the exported PPTX file. This works for shapes imported from PPTX, whose AdjustmentValues is exactly the same as avLst of the original PPTX file. For built-in shapes in Impress, avLst and AdjustmentValues would not be the same because the path and the equation created by LibreOffice and OOXML are not the same. This patch convert position of handles to adjustment values according to the shape type case by case. It also adds default values if the built-in shape in Impress has fewer handles then the exported preset shape because Powerpoint seems to be very strict about the number of values in avLst, and deemed the file as corrupted if any of defined adjustment values is missing. Round-rectangular-callouts, rectangular-callout, and round-callouts are added to the blacklist so that they are exported as preset shapes. Change-Id: Icd1284790607e927b6a9a614ac463a96cadedd81 Reviewed-on: https://gerrit.libreoffice.org/26479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in oox..sdNoel Grandin5-6/+6
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01 Reviewed-on: https://gerrit.libreoffice.org/27902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin5-19/+19
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-21oox: avoid pointless multiplication at int precision in WpsContextMiklos Vajna1-1/+1
When the output would be used at long precision anyway. Change-Id: I6eefda0533b8ee70b878f7ce7c6487f8b99a6025 Reviewed-on: https://gerrit.libreoffice.org/27360 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08oox: indentation fixesMiklos Vajna2-2/+2
These files had consistently no space between the "const" and "&", keep it that way. Change-Id: I5463c488d807344d67fb22ad544c049ea749be94
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann7-13/+13
Change-Id: I19eaebdb25db8881d84625a4b9d0df0a588aab4f
2016-06-30tdf#100179 correct cell merging in pptx.Mark Hung1-2/+2
Change-Id: I7a5bc6fb33c64d1ff398986eff5b960fe037df4d Reviewed-on: https://gerrit.libreoffice.org/25791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-06-30RTF export: it's enough to pass these by const ref, no need to copyMiklos Vajna1-1/+1
Change-Id: I6854c3c8e9a2b5c6d478551c5f9bba19e114152c Reviewed-on: https://gerrit.libreoffice.org/26787 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-24warn->info: its just a factCaolán McNamara1-1/+1
Change-Id: Id3f468cc4bb4f6f0b34bcc8486817c3f9c994020
2016-06-23tdf#100153 modify noSmoking shapeZhengqiang Wang3-6/+6
*modify customshapeproperties.cxx fix compile error : make oox dbglevel=2 The define of dumpCode() has been removed by c714b43b0137ad253f51e1c65417c9874b8509e5 *modify presetShapeDefinitions.xml fix noSmoking shape *modfiy oox-drawingml-cs-presets this file is generated by presetShapeDefinitions.xml Change-Id: I383d6b6961b546585035afd8c1a4398385a11914 Reviewed-on: https://gerrit.libreoffice.org/25801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-21simplifyNoel Grandin1-1/+1
Change-Id: I67de532443cbb9e64bed67fe28ee94fef38f5eae
2016-06-18fix indentationMarkus Mohrhard1-10/+10
Change-Id: I3a65eae9a7d55aa42540567a19052d6339ecdbec
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas2-0/+3
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-10Clean up uses of Any::getValue() in ooxStephan Bergmann2-86/+77
Change-Id: I76d83ad472eb0cd44b593a86dac1f8c1ee8c3585
2016-06-10tdf#42949: clean up includes in include/oox/vml with iwyuJorenz Paragas3-0/+3
Change-Id: I753880ce146fef6523561290b8e13310d9f7219c Reviewed-on: https://gerrit.libreoffice.org/26142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09Revert "Slideshow: Add 'Oval' Shape Transition variant"jan iversen2-18/+0
The patch caused problems with the export filter tests, to check that you need to add --with-export-validation to your autopen.input see https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation for more info on how to set it up This reverts commit 248c5ea771255b54e64394458a321ccf829bbd02. Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162 Reviewed-on: https://gerrit.libreoffice.org/26114 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09Slideshow: Add 'Oval' Shape Transition variantMayank Gupta2-0/+18
Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko3-12/+3
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann1-1/+1
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2-6/+6
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-31tdf#93883 don't add space to empty paragraph when bullet is turned off.Mark Hung1-1/+4
Change-Id: Ia1bad61cb5585dae0501e8cd657fc84bfea60ab2 Reviewed-on: https://gerrit.libreoffice.org/25679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin1-9/+9
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin1-2/+2
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin1-2/+2
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#42949: clean up includes in include/oox/ppt with iwyuJorenz Paragas10-1/+11
Change-Id: Ib2cf76418e8406b925113ae7a9e3c5b07ffd2de2 Reviewed-on: https://gerrit.libreoffice.org/25011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin1-2/+1
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25oox: replace boost::array with std::arrayMichael Stahl1-4/+2
Change-Id: Id9a8f7dbbf13890e7c9787d9b0737f1087e4a509
2016-05-20warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bitsNoel Grandin1-1/+1
in VisualStudio reported by Luke Benes Change-Id: I908039750a3e89e4d1b77631f7d309191735c765
2016-05-18clang-tidy modernize-make-sharedNoel Grandin14-35/+34
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13tdf#42949: clean up includes in include/oox/ole with iwyuJorenz Paragas2-0/+6
Change-Id: I9cbdc78b540b0f735c451ac561f0f0ccdaf7efbd Reviewed-on: https://gerrit.libreoffice.org/24911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>