summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2017-02-13Fix typosAndrea Gelmini1-2/+2
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-02-13Related: tdf#105707 PPTX import: decode document name from URLAndras Timar1-1/+1
Change-Id: Ic4825549c6fef1a609a753a10f6224cbcd69b7fc Reviewed-on: https://gerrit.libreoffice.org/34135 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-10Related: tdf#105707 PPTX import: warn on empty SmartArt fallbackMiklos Vajna1-1/+4
This second related situation is about when there is drawingML fallback for the SmartArt, but it's ampty shape tree, which is never created with MSO2010+ (those shape trees always have at least one element). This is as bad as the missing drawingML fallback, so warn on it. Change-Id: I539d05154a4d1fcd5871dfc29616f77eb9945454 Reviewed-on: https://gerrit.libreoffice.org/34131 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10Related: tdf#105707 PPTX import: warn on invalid SmartArt fallback relidMiklos Vajna1-0/+12
We already warn when the SmartArt doesn't have a drawingML fallback, but having a reference to a fallback that is not a valid one (so resolves to an empty fragment path) is also unusable. So warn in that case as well. Change-Id: I03b2325003b4eb38b1347a88899799c6d5c33606 Reviewed-on: https://gerrit.libreoffice.org/34129 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-10coverity#736181 Out-of-bounds readCaolán McNamara1-5/+4
it should be fine, as we rely on there being at least one password char, this is the same as, commit 2d3ed7ebb592401de214eaeee68c656afbefbe05 Author: Michael Meeks <michael.meeks@collabora.com> Date: Tue Feb 25 22:48:48 2014 +0000 cid#736173 - increase default fill chars buffer size. which is another impl of this Change-Id: I5e1e07af37bea0398153ede300beed67d37d5e12
2017-02-08oox, sfx2: can use std::move() hereMiklos Vajna2-3/+3
Change-Id: I0add196f79045e8cb7280b2b7d1d8620e4ec669e Reviewed-on: https://gerrit.libreoffice.org/34013 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-07remove CREATE_OSTRING macroJochen Nitschke1-2/+2
Change-Id: I7d5e1570918adc3b0cf2063d9735414233011a81 Reviewed-on: https://gerrit.libreoffice.org/34009 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-06Add missing #includesStephan Bergmann4-1/+5
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-06loplugin:unusedenumconstants in ooxNoel Grandin1-4/+4
Convert FragmentHandler2::MCE_STATE to scoped enum and drop MCE_UNUSED constant Change-Id: Id0b3a81e61d77af5d3837527b008e196835f57cd Reviewed-on: https://gerrit.libreoffice.org/33954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-05tdf#31488: Background fill changes its color when saving a PPTX file to ODPTamás Zolnai1-1/+4
For a gradient fill we need to generate a name because ODP export works with this name. In case of shapes it works because when fill attribute changes some internal name generation is triggered. The same thing doesn't work for slide background so generate this name explicitely in oox code. Change-Id: Ic6ebf37ef3d66a9c274747ca04653363b1fe6d02 Reviewed-on: https://gerrit.libreoffice.org/33937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-03tdf#105707 PPTX import: warn when SmartArt is missing DrawingML fallbackMiklos Vajna3-2/+39
By the time DiagramGraphicDataContext::onCreateContext() completes, we know if there will be a DrawingML fallback for the SmartArt (called ExtDrawing in the code) or not. Warn about this case once at the end of the import when in interactive mode. Headless mode silently ignores the warning as expected. Change-Id: I2bfeeedcaa244f08d8a0c208167e79d7bb697e6d Reviewed-on: https://gerrit.libreoffice.org/33866 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-02loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I14ac842fa7b8a8ec8c6eb7554d136a68fe727ed7
2017-02-02convert method names in tools::SvRef to be more like our other..Noel Grandin1-2/+2
reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30oox: clean-up crypto classes, use c++11 featuresTomaž Vajngerl5-245/+211
- remove "using namespace std;" - &vector[0] to vector.data() - use nullptr in OPENSSL Change-Id: Ib4067b0256801f94d448bc8d3faf5a2902d694e5 Reviewed-on: https://gerrit.libreoffice.org/33629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin1-1/+1
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann36-384/+233
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor oox..saxNoel Grandin4-19/+0
Change-Id: Ie12bfabc92bce04d702f3e77aa5896366e49245e Reviewed-on: https://gerrit.libreoffice.org/33509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24Move two include files to oox/inc as they are used only in ooxTor Lillqvist35-42/+296
Change-Id: Ie13614c1977f45aa8086f4db65ca86b7d9212735
2017-01-24Drop incorrect "artistic" prefix from some token namesTor Lillqvist2-18/+18
Apparently copy/paste mistakes in the 642a252cf1a2f1d08c4bbfcae15527bb82c7664d and 21d4cfe19e2796ebf89c408e292c4473924b2bc4 commits from 2014; most of the picture effect type tokens added in that commit do have names that start with "artistic" but not all. Does not break any unit test. (Does not fix the bug I am investigating either, though.) Change-Id: I2c3bb7243e1feaa3fa949b58d3acf34825d6987b
2017-01-24use rtl::Reference in FastParserNoel Grandin4-11/+8
instead of storing both a raw pointer and a uno::Reference Change-Id: I6b67a6098a3ccdce7e29ee8d601c743897032eaf
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ooxStephan Bergmann8-15/+59
Change-Id: I83c6995e4f15d6a042e57bac4d71874124402547
2017-01-18update approximate install location in READMECaolán McNamara1-19/+19
Change-Id: I6a139d5be193c968c2bf3373b415baa25dc32595
2017-01-17new loplugin: useuniqueptr: jvmfwk..saxNoel Grandin2-6/+6
Change-Id: I732e2e22c6f953f0982fbc8833453e7c23cf9d49 Reviewed-on: https://gerrit.libreoffice.org/33166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-14tdf#97597: Ensure that each parsing thread has its own buffer.Kohei Yoshida1-2/+2
Change-Id: I93077f954a49b3922930e4fc86c80228be0f4dd2 Reviewed-on: https://gerrit.libreoffice.org/33069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-12add -mlong-jump-table-offsets for m68k also for ooxRene Engelhard1-0/+6
Change-Id: Ibfba6c7c808ca5212884032c17546e95fa16353a
2017-01-12tdf#104414: don't stop on exception from SwXFrame::setPositionMike Kaganski1-2/+10
Change-Id: Ib6d4e398d546d6fe250b9c1efe099ae8eef2d580 Reviewed-on: https://gerrit.libreoffice.org/32978 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-10New loplugin:conststringvar: ooxStephan Bergmann2-6/+6
Change-Id: Id27e8c51fe87cbe7fa45a68cbaa8196767473b93
2017-01-06tdf#105150 PPTX import: try harder to handle <p:sp useBgFill="1">Miklos Vajna1-1/+9
The bugdoc has two shapes. The red rectangle is supposed to be covered by the other shape, but it wasn't as the fill style was set to none. The reason for that was we ignored useBgFill, unless the slide had an explicit fill style. Assume that in that case a white solid fill is the default. Change-Id: Iea20e216e44e13db68887f285c10bc1a8feacf0a Reviewed-on: https://gerrit.libreoffice.org/32786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06tdf#105127 VML import: handle <v:shape style="flip:..." path="...">Miklos Vajna1-0/+22
I don't see an easy way to implement this via UNO, so use the internal API. As to the internal API usage, SdrEditView::MirrorMarkedObjVertical() (for UI) and SvxMSDffManager::ImportShape() (for WW8 import) are example client code. Change-Id: I9bf27788db32fd35d6b56e0f1a240c4b7abc5604
2017-01-05No need to check isEmpty() before clearingStephan Bergmann1-3/+1
Change-Id: Ie32a4ee915d57618d2a6a661febf39fd0d55dd80
2017-01-05getLength -> isEmptyStephan Bergmann1-1/+1
Change-Id: I5a8c2911851d1a798d8c6f3c25b08cb0469f07a0
2017-01-05oox: rename misleadingly prefixed m_pShapeStyleMichael Stahl1-27/+27
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05No need for heap-allocated OUStringBufferStephan Bergmann1-29/+27
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann1-1/+1
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-04replace namespace URL strings with function calls...Rosemary Sebastian6-17/+27
Change-Id: I0b8b265df487aaeb76238013bc93c78e49a9e1a6 Reviewed-on: https://gerrit.libreoffice.org/32723 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-03TyposJulien Nabet1-1/+1
Change-Id: I487db955caff589b9f62c50b83067628bb768d50 Reviewed-on: https://gerrit.libreoffice.org/32460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-01-02OSL_ENSURE->SAL_WARN_IF for progressbar (oox)Julien Nabet1-5/+4
Change-Id: I88f143d823b83cc7db1b0ebde01f416eca84840e Reviewed-on: https://gerrit.libreoffice.org/32642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-28tdf#104539 dir attribute of outerShdw has to be non-negativeAndras Timar1-1/+1
Change-Id: Ic6f1c8555eb8d137ced2f4e87baa866df84c69ac Reviewed-on: https://gerrit.libreoffice.org/32467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-12-26use the existing namespace map for the oox namespace exportMarkus Mohrhard2-1/+17
Change-Id: I7909b08db556c6c65c1547303f2b899c30feaba4 Reviewed-on: https://gerrit.libreoffice.org/32425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-26use uniform initializer syntax to simplify codeMarkus Mohrhard1-14/+2
Change-Id: I617c63c16cc2ba06f88d7101716ab05daf4b30a4 Reviewed-on: https://gerrit.libreoffice.org/32423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-26OSL_ENSURE -> SAL_WARN_IF in oox relationship codeMarkus Mohrhard1-2/+2
Change-Id: Iac742e253c1f96a412a803025bb89578f8d96018 Reviewed-on: https://gerrit.libreoffice.org/32424 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-17Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann1-61/+61
...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-15Phase out support for HAVE_BROKEN_STATIC_INITIALIZER_LISTStephan Bergmann1-8/+2
...I'm pondering a change that would make that a hard requirement, and from the comment in configure.ac it looks like only old Clang < 3.4 were affected. Change-Id: I8ef64f759fed1a45d88f94d0e8a60839ad10b263 Reviewed-on: https://gerrit.libreoffice.org/32029 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin9-29/+29
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin3-4/+1
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in framework..salNoel Grandin18-63/+28
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-09tdf#104445: PPTX import: Extra bullets are added to placeholder textTamás Zolnai2-2/+4
Change-Id: I25ce98ed391f70292bed6238645b121b9cf50d5e Reviewed-on: https://gerrit.libreoffice.org/31771 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-07convert PolyFlags to scoped enumNoel Grandin1-4/+4
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert E_GRAPH_PROV constants to typed_flagsNoel Grandin1-1/+1
and drop the never checked E_GRAPH_PROV_DO_NOT_ROTATE_METAFILES constant Change-Id: Idd2598c209b34bfa4a58a84ce5ee14a7340d59d4 Reviewed-on: https://gerrit.libreoffice.org/31553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02convert some anonymous enums to scopedNoel Grandin3-18/+18
Change-Id: Ia989376c983ff475359e4964abeb1f5a2300ff5b Reviewed-on: https://gerrit.libreoffice.org/31486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 20:17:35 +0000