summaryrefslogtreecommitdiff
path: root/onlineupdate
AgeCommit message (Collapse)AuthorFilesLines
2020-11-19tdf#123936 Formatting files in module onlineupdate with clang-formatPhilipp Hofer7-59/+37
Change-Id: I17aba4fbf7c2e914e64c62e9370695e20d7c14d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105693 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-09-29Fix typo in codeAndrea Gelmini2-3/+3
It passed "make check" on Linux Change-Id: Id08fb3de62c55ab24f585b1bd1b9f719c78f91b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103464 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-12comparison operators should be constNoel Grandin1-1/+1
Change-Id: Ifa76e004128223460945d58d1c59c4e23db0f108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-16Proper error check for fwrite in updater.cxxMuhammet Kara1-2/+3
A less-than-zero check for an unsigned value of type size_t doesn't make sense, and: If the return value of fwrite differs from the count parameter, it means that a writing error prevented the function from completing. In this case, the error indicator (ferror) will be set for the stream. Change-Id: I344e608b2bc03a4a117fc5cca1acb8e26eda247a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88817 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-10Fix accidental variable shadowingMuhammet Kara1-1/+1
Was causing the if-check after the loop evaluating to false always, thus never running inside the if-block. It was probably never catched because the initial value of the outer variable applicationRunningError is always WAIT_TIMEOUT. This was also causing error codes other than ERROR_SUCCESS and WAIT_TIMEOUT never being returned from this method. Change-Id: I068f96cd4d5afd63fe7017062e5ad6af171dcca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88353 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-25tdf#130137 Replace remaining uses of WNT define checks with _WIN32A_GAN3-5/+5
Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-30drop gtk2 supportCaolán McNamara3-12/+15
Change-Id: Ie838cabfecfef7e3225c1555536d5c9cf3b43f15 Reviewed-on: https://gerrit.libreoffice.org/77405 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-19Fix typosAndrea Gelmini1-1/+1
Change-Id: I33a99be34f41c3583fc6684fc68ba6b76ef2f056 Reviewed-on: https://gerrit.libreoffice.org/77682 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-19Fix typosAndrea Gelmini1-1/+1
Change-Id: Ida64346bc11053bf43fd1208914407b3b2f1338e Reviewed-on: https://gerrit.libreoffice.org/77681 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini3-10/+10
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e Reviewed-on: https://gerrit.libreoffice.org/77256 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-23Fix typosAndrea Gelmini1-1/+1
Change-Id: Iea3bd498b1c8934f37085bdf6df71b073e4a871c Reviewed-on: https://gerrit.libreoffice.org/76203 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-04-25Cut down on -pthread/-lpthread proliferationStephan Bergmann2-2/+0
Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-04Drop UNICODE/_UNICODE definesMike Kaganski8-24/+1
The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-15work around Werror=format-truncation in onlineupdate for nowMarkus Mohrhard1-5/+10
Change-Id: I6230cc8c76313b5d180ef3fbebec4bc20b794150 Reviewed-on: https://gerrit.libreoffice.org/67879 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek1-3/+3
Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-11-18fix off by one errorMarkus Mohrhard1-1/+1
BLRG-PT-18-004 Change-Id: I9cd2582aebf2b33d40f23254047c35c8dee90f4b Reviewed-on: https://gerrit.libreoffice.org/63508 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-10Rename online updater functions and strcmp relpathJan-Marek Glogowski1-32/+33
Try to be more explicit about the newly allocated absolute path and the relative offset and actually compare the relative part. -get_full_path(const NS_tchar *relpath) +new_absolute_path(const NS_tchar *relpath) -get_relative_path(const NS_tchar *fullpath) +get_relative_offset(const NS_tchar *abs_path) Change-Id: I02abd722fc89a1688502b9c5cd375954f9f0bc05 Reviewed-on: https://gerrit.libreoffice.org/60168 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-07Fix some std::unique_ptr array allocsJan-Marek Glogowski1-16/+16
Found by reviewing the output of and the code around git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]" The onlineupdater code needs a little bit more attention. Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0 Reviewed-on: https://gerrit.libreoffice.org/60162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20updater: Tone down the geekiness in user-facing stringsAdolfo Jayme Barrientos2-8/+8
Pro tip: The user doesn’t have to know that the updater is a separate program. Change-Id: I04c447a16a322b7f4139e69f6cababc797148bb1
2018-01-17Blind fixStephan Bergmann1-1/+1
...in --enable-online-update=mar code, after 7d8e94444d989d0ac4a4055b207726708e9ec0da "convert a<b?a:b to std::min(a,b)" Change-Id: I8d03b2fc785595267c855c8ac9953d35782c7718
2018-01-16Fix typosAndrea Gelmini2-2/+2
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2 Reviewed-on: https://gerrit.libreoffice.org/47858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Missing includeStephan Bergmann1-0/+1
Change-Id: Id5c7ff8b9d342b557bc87b1ac6f3e2fbc8437d69
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin1-1/+1
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-30Updater Icon: Shrink svg fileandreas kainz2-649/+1
Change-Id: I8a45d4e620b1865dda28eb56a89207226eeac9b2 Reviewed-on: https://gerrit.libreoffice.org/47202 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2017-11-19Fix typosAndrea Gelmini1-1/+1
Change-Id: I964528cf4f3b81230c683011e1878b28378b0014 Reviewed-on: https://gerrit.libreoffice.org/44915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23chmod 0755 -> 0644 for some source filesStephan Bergmann1-0/+0
Change-Id: Ibe5b5e03374419c2c23cd6559ab213d2dc2fcc66
2017-09-13onlineupdate: work around GCC7 -Werror=implicit-fallthroughMichael Stahl2-1/+2
This is pretty stupid, but oh well... Change-Id: I1e605b2858a917f61922df757809a2aceb14a914
2017-08-29update the gtk updater icon with the new updater iconMarkus Mohrhard1-254/+200
Change-Id: I658a1ec54e74fe57efcaec873991d66be7ba31c1
2017-08-28update updater iconandreas kainz3-0/+649
Change-Id: Ie4f38a51e87f29c322ba5aac2a2ad705bae42e71 Reviewed-on: https://gerrit.libreoffice.org/41660 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-22updater: store the updater GUI icon on linux in the codeMarkus Mohrhard2-3/+261
The content can be created through convert from the png version. Change-Id: Icc07a118dfa139f270232a1e708e6907ad02ddea
2017-08-22updater: get the updater GUI working on LinuxMarkus Mohrhard4-4/+12
Change-Id: I3e7edb5319ab2e2ec316204b917a7e29c1791b5b
2017-08-22updater: fix error in linux part of updater makefilesMarkus Mohrhard1-1/+1
Change-Id: I2d32159364d34fb4154b7f88590045dc3a442bc3
2017-08-21updater: add a way to test the dialog code of the updaterMarkus Mohrhard3-0/+107
Change-Id: I7436edc85f87d1f68b50d39bf29564ff498c9ab9
2017-08-21updater: always show the updater UIMarkus Mohrhard1-3/+8
Change-Id: I0e1dc86673779966ff247b81852fb2f29655d2b9
2017-08-21updater: set executable type GUI for updater.exeMarkus Mohrhard1-2/+8
Change-Id: I795cbd8634a3afe219db033ce40f833af0eee44a
2017-08-14updater: reference the correct new static library nameMarkus Mohrhard1-1/+1
Change-Id: Ib5920b27429f8414db761387645713498a60904f Reviewed-on: https://gerrit.libreoffice.org/41142 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-08updater: move the windows process starting code to comphelperMarkus Mohrhard6-322/+3
Change-Id: I1a499f57d01ee28afdb2c4f85dc976f2e6837dfd Reviewed-on: https://gerrit.libreoffice.org/40837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-08updater: add include guard for windows process start codeMarkus Mohrhard1-0/+5
Change-Id: If021a92163381f2221faa1c7121f6c4af2d51dcf Reviewed-on: https://gerrit.libreoffice.org/40836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-08updater: use the correct define checkMarkus Mohrhard1-3/+1
Change-Id: I79f47da401732e39bbce778d5b3971d6024a7935 Reviewed-on: https://gerrit.libreoffice.org/40835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-02updater: disable the special handling of the user profileMarkus Mohrhard1-0/+3
This should be unnecessary for the one step updating strategy. Change-Id: I8dddeae4fb4a560a1c261c0c2e84183d72fc638c Reviewed-on: https://gerrit.libreoffice.org/40656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-01make it easier to debug the generation of certificate dataMarkus Mohrhard1-2/+12
Change-Id: I86e3c3254cef297c46a8ca377b5ceb36b348e2b3 Reviewed-on: https://gerrit.libreoffice.org/40607 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-31updater: get the signature verification working on WindowsMarkus Mohrhard8-30/+77
The updater itself does not link to NSS on Windows and instead uses the Windows-internal crypto libraries. However the mar executable needs to link against NSS, so we need to split the code a bit. Change-Id: Iea61c716aa507a876fdb444eb28ad828bdea18bd Reviewed-on: https://gerrit.libreoffice.org/40608 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-31updater: fix windows build, string issuesMarkus Mohrhard1-2/+2
Change-Id: I79ff08534dc522ede50cd0c5771576d825977b7c Reviewed-on: https://gerrit.libreoffice.org/40606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-31updater: fix include and exception support for updater serviceMarkus Mohrhard1-1/+2
Change-Id: Ia0c7a62779bb8e870e8d5e458b81b5d2a09300d0 Reviewed-on: https://gerrit.libreoffice.org/40605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-31fix updater code on windowsMarkus Mohrhard3-5/+199
Change-Id: Ic1e39bc8f4ef6afe8781ce62997201acba56680a Reviewed-on: https://gerrit.libreoffice.org/40604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-28updater: remove unnecessary mozilla makefileMarkus Mohrhard1-9/+0
Change-Id: Ia0162482841854cc4cb5c2b004bc978809bdf4c2 Reviewed-on: https://gerrit.libreoffice.org/40534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-26updater: make it more difficult to misuse the APIMarkus Mohrhard1-29/+19
Change-Id: Ief5b2e37f289d6bfa92a909701c331d50509b0a3
2017-06-26updater: reduce scope of ArchiveReader and pass by referenceMarkus Mohrhard1-53/+48
Change-Id: Ifbcfa5b612cb0a8670bf3dd0be6e74708cc969c1
2017-06-26updater: subclasses need to pass the archiveReader parameter to their parentsMarkus Mohrhard1-11/+26
Change-Id: I1d69d592a05908e4e2a2e832a5b6ef9d13fc2e2c
2017-06-26tdf#108563 Transform global variable gArchiveReader to local variableChristian Barth1-23/+46
Change-Id: I0830f00bce19bc4b77d8e9e0cb5684338a4c9e5d Signed-off-by: Christian Barth <Christian.Barth@zoho.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 16:14:28 +0000