summaryrefslogtreecommitdiff
path: root/officecfg
AgeCommit message (Collapse)AuthorFilesLines
2020-04-03tdf#125268 officecfg: export LO character background as MSO shading by defaultMiklos Vajna1-1/+1
This restores commit 701238ea7d8a06fe7a90de15b7660b7c6d854f09 (tdf#125268: Export LO character background as MSO shading by default., 2020-03-23). As per ESC discussion, see <https://lists.freedesktop.org/archives/libreoffice/2020-April/084813.html> for the details. Summary: the benefit is that this way we don't loose data, and the cost is that LO's highlighting is called shading in MSO now. The minutes has several good ideas how to improve this further in follow-up commits. Change-Id: I12c76a7c273178d284b84c6c23e9348feb316127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91611 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-31Revert "tdf#125268: Export LO character background as MSO shading by default."Tamás Zolnai1-1/+1
This reverts commit 701238ea7d8a06fe7a90de15b7660b7c6d854f09. Reason for revert: <INSERT REASONING HERE> Change-Id: I56facce4191644a4aaf565e572abab400e2b61a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91388 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-30tdf#101652 Add config option to prevent disabling readonly modeSamuel Mehrbrodt1-0/+6
There are various cases where people don't want users to be able to turn off readonly mode, so add a config option for it. Setting this option will remove the "Edit document" button from the readonly infobar and also disable the "Edit mode" menu entry. Change-Id: I7988da5b181455f778a6ab148e6bf32182c72618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91144 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-30tdf#124686 HideWhiteSpace should be positive Show Whitespaceshameempk1-0/+8
"Hide Whitespace" under View menu changes to "Show Whitespace". Functions and associated strings are renamed accordingly. Change-Id: Id0c91ecf5c59a8c0cd5d00574f3ce0f38d6dd6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90324 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-30Fix indentationSamuel Mehrbrodt1-1/+1
Change-Id: Ic53ea0f324be1d0441922cff7113465bf199bbf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91143 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski1-0/+25
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-24Sukapura: Add more 32px and independent iconsRizal Muttaqin2-0/+12
- Update Impress's hover image - Fix for wrong named icon - etc Change-Id: I1ad1f74a1b6ee4658b55fdb25d85d08e42e9a138 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90933 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-23tdf#125268: Export LO character background as MSO shading by default.Tamás Zolnai1-1/+1
Change-Id: I139f7b0795a12bbf0f54a0031883c2f05bf644cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90909 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-22Sukapura: Add Fill Cell iconsRizal Muttaqin1-0/+21
- Update hide related icons, etc Change-Id: I053a628f58f9a3eeb2690b74ea50ce4c5320b64c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90867 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-21Casual users don’t care about Unicode code pointsAdolfo Jayme Barrientos1-1/+1
It was too geeky to include this detail in the first place, but the bigger problem was that no other options do. Besides, the capitalization used here was wrong (menus are title case). Change-Id: Ia103850709739aedf43fda2b905143b991a9d43c
2020-03-21tdf#128276 Font names are not localized on macOS CatalinaTomofumi Yagi1-8/+8
1. We would like to call CTFontDescriptorCopyLocalizedAttribute function simply. We don't need to compare language settings of LibreOffice UI to OS lang- uage settings. This comparison was a way to save users from confusion, but it was bad idea. Because CTFontDescriptorCopyLocalizedAttribute function before macOS Catalina returns RFC 3066 bis as a language tag, but LibreOffice and macOS Catalina uses BCP 47 as a language tag. CTFontDescriptorCopyLocalizedAttribute function use the language setting for the operating system, therefore Users will change it if needed. 2. Fix font aliases on macOS Catalina I added some entries because I notice that those doesn't working with a Hiragino Sans font alias. Change-Id: Ie05a96f45cba13a19fcc1b855bd908f397e585a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/81145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-16Add option to disallow opening files locked by other usersSamuel Mehrbrodt1-0/+6
Change-Id: I316b80a56b0d6dcb257fbc805fbac3afc93472ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90425 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-12tdf#95854 Same shortcut for insert and edit commentMaxim Monastirsky1-122/+17
But at the same time keep them as two separate commands for tdf#84153. The idea is to define a global shortcut for the insert command (it's the same shortcut in all modules anyway), and then override it as a Calc-specific shortcut for the edit command. As a result, both menu (or context menu) items will show the same shortcut, but what will be actually executed by the shortcut is the edit command (as module specific commands have higher priority). This would work, as both commands share the same execution code. The only problem is that the edit command is disabled when the cell doesn't have a comment, and so can't be executed. Solve that by setting the FastCall sdi property on it (and reuse this general solution for the lok case too). Change-Id: I8a7280edb2aad7016ca31c63ca778b98fef85365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90354 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-03-11tdf#125440 Allow raising text import dialog for pasteSamuel Mehrbrodt1-0/+11
This adds an entry to the "Paste special" dialog to raise the Text Import Dialog. This way, users can correctly import CSV/TSV, even when pasting just one line of formatted input. Change-Id: Ic09d7d60a05b14906f166668b38ec0eb8ead2d19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-03-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I581d853b056a2335521de1f556b909bdf5a6c6eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90143 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-28enable Skia by default on Windows, instead of OpenGLLuboš Luňák1-0/+5
Change-Id: I653dbff412944fb77fb9faebc3d127459dfe34cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89549 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-27tdf#92484 UI: lock toolbar by defaultA_GAN1-1/+1
Change-Id: I29f283fcc3a55e535c01efe36e19db74244cef02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89603 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-26tdf#130886 add ... to Edit Macros in Tools - Macros menuSeth Chaiklin1-1/+1
Change-Id: I04c0987b0b0c8a26ec4ce5517b9be4302b7920ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89506 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-02-23Make shortcut of .uno:TraceChangeMode preferredMaxim Monastirsky1-6/+6
So it will show in menus and toolbar tooltips. Change-Id: Ieea3231416784141d2fa9c55c9b18a49f27eac75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89291 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-23Same grid layout in all apps for better arrangement and presetsandreas kainz4-8/+8
Change-Id: I566dfe6e40228fb7b0ff9c55a6a3596c1fdbbaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89264 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann1-2/+2
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-18tdf#130519 Add "More options" button to Lists sectionRoman Kuznetsov1-0/+3
on Impress Sidebar Change-Id: I839cfe98e7d7ce8656f07977fe1ee4824d7f27ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88255 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-17Add menu entries for field/bookmark protectionSamuel Mehrbrodt1-0/+8
Change-Id: I5e0a194698a85e81089a929a0979e2b4022555e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88612 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák1-0/+4
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-14Fix typoAndrea Gelmini1-1/+1
Change-Id: Id300274f334b13b54d792ed5f9813522c5ca6018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88668 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14Add tooltips for protect bookmark/field commandsSamuel Mehrbrodt1-0/+6
Change-Id: I54954c20766bae2112571d92ad760f71d3bf2060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88611 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13Add uno cmd to protect bookmarks in a documentSamuel Mehrbrodt1-0/+8
Change-Id: I7cc0dfa2b129d69d49b555495d77c2c710689e94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88586 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13Add uno cmd to protect fields in a documentSamuel Mehrbrodt1-0/+8
Change-Id: Ifb9f757111a6fcbb283d2350ed2ccd42de19d5df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88585 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-11make Base install via packagekit also confgurable (like fonts/langpacks)Rene Engelhard2-0/+9
Change-Id: I72f98e89d1c8e92f10da8e3843956658d035528d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87907 Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-10reportdesign: Hide some internal commands from customizationMaxim Monastirsky1-0/+8
In addition: - .uno:BackColor was unused, and internally mapped to the same id as .uno:DBBackgroundColor which is used and has a label. So remove the former, and make the latter visible in the customization dialog instead. - .uno:DSBEditDoc is mapped to SID_EDITDOC, and handled by the code, but has no label. On the other hand, the toolbar has an .uno:EditDoc item, which has no mapping in reportdesign, but happens to be mapped to SID_EDITDOC elsewhere. So assume this was a mistake, and .uno:DSBEditDoc should be used instead of .uno:EditDoc. Change-Id: I9da2ed36167571627b32a4055b734847c3ea1e64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88342 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10in case of Skia problems force raster mode, don't disable it allLuboš Luňák1-0/+8
Skia's CPU-based raster mode should be safe (at least from driver problems), so it should be enough to make the failsafe mechanism just disable Vulkan use. Also add UI option controlling forced raster rendering. Change-Id: I6be1745782816e5468e55635ae5613b6a6afded6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-06GenericCommands: fix Fontwork tooltipsJustin Luth1-4/+4
These were terribly confusing. .uno:Fontwork does NOT insert fontwork text, despite the tooltip name. It opens up the old fontwork dialog that modifies contour properties so that the text can flow along the contour. The UIname is Fontwork, so lets have an automatic tooltip for that. .uno:FontworkGalleryFloater has a UIname of "Fontwork Style", but the auto-generated tooltip was "Fontwork". (Notice that this conflicts with the UIname of the other one. So when you add "Fontwork" to your toolbar, and chose the icon with the tooltip "Fontwork" you get a different item.) Since this one actually inserts text, and doesn't actually modify any existing style (that's the function of Fontwork Shape), lets give this one the tooltip "Insert Fontwork Text". Therefore, this patch effectively switches the two tooltip names around, which much better matches their function, and their UIname. I expect that this was the original 2016 intention anyway... At the end, I decided to also change the UIname to "Insert Fontwork", since the gallery is normally added to insert menus... The unit test I had to modify just looked like a functionality test and had nothing to do specifically with the label's string. (It was last changed for tdf#91781 which made no specific reference to fontwork.) This might help documentation bug tdf#118336 a bit too. Change-Id: I152596781def2d8dba47f53e345976543e3131bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88101 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-04Allow opt-out from document events checkSamuel Mehrbrodt1-0/+6
Commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627 added a warning on load when a document binds events to a macro. This adds an option to restore the old behavior, so that the warning only appears when a document actually has Macros. Change-Id: I5ad398d3d503a0954a746f4cba150f68630b820c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87961 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-04deb#949754: unotools,officecfg: don't ODF export using ODFVER_UNKNOWNMichael Stahl1-0/+5
The problem was that commit ef39938dea14666a5835b6ae85091c1010f8ae8d temporarily added ODF 1.3 version strings to the optsavepage.ui, just to get translations for them; unfortunately the dialog itself was not adapted to the new values, so when you select them the result is 0, or ODFVER_UNKNOWN... fortunately this was reverted before 6.4.0.3. The value ODFVER_UNKNOWN is very dubious and without an obvious purpose; http://specs.openoffice.org/appwide/odf/odf_1-2_migration.odt mentions it but provides no details. Hence let's interpret it the same as ODFVER_LATEST for export purposes. Also add the value ODFVER_012_EXT_COMPAT to the configuration, because this is actually used. Also fix a copypasta in SvtSaveOptions_Impl::IsReadOnly(), where the wrong flag is checked for OdfDefaultVersion. Change-Id: Ie276f0ef3cead3ffa016ba939aede74581fb0257 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87900 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-03Styles > Text Body menu didn't work in non-English UIMaxim Monastirsky1-1/+1
Capitalization of "Body" present only in the UI name of the style, but that might be something completely different in other languages. We need to reference the style using its programmatic name instead. Change-Id: I2d980a225d6f5346d378947621ace3a17e0a8f81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87842 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-31tdf#45589 offapi,officecfg,sw: add option to toggle bookmark displayMichael Stahl1-0/+8
Create specific option to toggle display of the bookmark positions instead of relying on generic IsViewMetaChars(). Add a Bookmarks checkbox to Writer->Formatting Aids page in Options. Add property ShowBookmarks to com::sun::star::text::ViewSettings. Add config setting: org/openoffice/Office/Writer/Content/NonprintingCharacter/Bookmarks Change-Id: I998ecdc16d8e4a5baeeb1bbcff0bf5f1f5636692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-25Resolves: tdf#130159 hide writedirection unless CTL is enabledCaolán McNamara1-0/+88
rework as ToolboxControllers registered in Controller.xcu Change-Id: I3e7fea09fe83d1ed6400218c41384f82b38b07a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-22rework line style to be a wide toolbar buttonCaolán McNamara1-0/+11
involves converting SvxLineStyleToolBoxControl to a PopupWindowController because chart is doing interesting things in its panel there needs to be a non-standard way to report/detect the selected line style, which is then reused to disable/enable the arrows when none is selected/deselected in non-chart sidebars SvxLineBox becomes a toolbar dropdown instead of a combobox itemwindow linectrl.cxx split into linewidthctrl.cxx and linewidthctrl because SvxLineBox is now needed in svxcore Change-Id: Icf0ef5e612b894a43d389af8a2908138c2e9c580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-21remove unused GSOC 2005 "Tabbed Document Windows for OOo"Caolán McNamara2-41/+0
this was #i54847# Change-Id: I312e3ea9b123976e9929f6601a931ff8a108d7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87113 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-19Remove misused hyphensAdolfo Jayme Barrientos1-2/+2
Change-Id: I17553952476ec46861df5ac353187c2a4b5f57fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87035 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-15rework SvxUndoRedoControl to be a PopupWindowControllerCaolán McNamara1-0/+22
Change-Id: I78b4e03c76bc3aa8479013ae157a9e1316dcfecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-15rework SvxColumnsToolBoxControl to be a PopupWindowControllerCaolán McNamara1-0/+33
and weld it, convert it and TableWindow to use two CustomWidgetController for the content widgets. Change the ColumnsWindow from an auto-grow width element to something with a fixed width and add a spinbutton to handle the overflow cases that don't fit in the fixed width Change-Id: I046a21dfd2a7c23828c4e2945b42c30db362b049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework SfxEmojiControl to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: Ia3262e5b54257d5556c500f440806ac2df9886cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageOrientationPopup to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: I5930d6e16b99754a60e3bb22a70fadfc5d673aa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageMarginPopup to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: I60a66b9be14f79cd2968f4bd3d91740137ee9d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework SvxTableToolBoxControl as PopupWindowControllerCaolán McNamara1-0/+22
and refactor its drawing into a DrawingArea widget Change-Id: Iecaef02fcfaa04b3096d80c3fc2648690a190bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageColumnPopup to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: I00d0ce6001f2eb3076c699bca7c64a72b94716c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework PageSizePopup to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: Ib8a0acbceca607b0820437d66e18c7cd8c16904e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-14rework SfxCharmapCtrl to be a PopupWindowControllerCaolán McNamara1-0/+11
With MSVC, the changes to include/sfx2/charmappopup.hxx would cause spurious > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual class com::sun::star::uno::Any __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::queryInterface(class com::sun::star::uno::Type const &)" (?queryInterface@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAA?AVAny@uno@star@sun@com@@ABVType@4567@@Z) already defined in classificationcontroller.o > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual void __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::acquire(void)" (?acquire@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAAXXZ) already defined in classificationcontroller.o > isvt.lib(svtlo.dll) : error LNK2005: "public: virtual void __cdecl cppu::ImplInheritanceHelper<class svt::ToolboxController,class com::sun::star::lang::XServiceInfo>::release(void)" (?release@?$ImplInheritanceHelper@VToolboxController@svt@@VXServiceInfo@lang@star@sun@com@@@cppu@@UAAXXZ) already defined in classificationcontroller.o when linking Library_sfx (and which appears to be unrelated to the (implicit) /INCREMENTAL since 9739c37d8ad7c6fca269709674a6975fa7ebd191 "enable incremental linking on windows"), which requires the HACK in include/svtools/popupwindowcontroller.hxx. Change-Id: I74c4318e6216001f18d0cf5ed63e78ba2ab13cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-13rework TextUnderlinePopup to be a PopupWindowControllerCaolán McNamara1-0/+11
Change-Id: I149777b827dd00e00e62b461836122861864f829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>