summaryrefslogtreecommitdiff
path: root/o3tl/qa
AgeCommit message (Collapse)AuthorFilesLines
2017-10-26Add test for o3tl::saturating_addStephan Bergmann1-0/+119
Change-Id: I19bb1d566bd80f859810b4023d965c8fd80b98f2
2017-10-25improve o3tl::enumarray const-nessNoel Grandin1-0/+48
Change-Id: I7b0d10b024edf604a7dea0e3b1399073f4bcba92 Reviewed-on: https://gerrit.libreoffice.org/43773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: o3tlStephan Bergmann6-18/+18
Change-Id: I3cf4cda744148c966d0686310fef5dab6d3a3b35
2017-09-06const correctness in o3tl::array_viewNoel Grandin1-3/+9
Change-Id: I44c1ace97ae44069c5a0c6a247aa8a0b49896ad3 Reviewed-on: https://gerrit.libreoffice.org/41985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin1-3/+3
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17create o3tl::array_viewNoel Grandin1-0/+79
A very basic implementation of the proposed std::array_view, similar to clang's llvm::ArrayRef. Mostly cribbed from the string_view implementation :-) Use it for the SfxDispatcher::setSlotFilter function Change-Id: Ife7e4971741b41827e145787899872c9b2bea82b Reviewed-on: https://gerrit.libreoffice.org/38817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock1-0/+1
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-07Introduce o3tl::string_view.hxx approximation of C++17 <string_view>Stephan Bergmann1-0/+212
...and use it in configmgr/source/writemodfile.hxx Change-Id: Ie683dc21010ed45cc454ff89bea0376994b351f2 Reviewed-on: https://gerrit.libreoffice.org/36270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I14dca0d55c09187690dc1d94936c40b890ca5cea Reviewed-on: https://gerrit.libreoffice.org/35637 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-14fix typo: alreay --> already dennisroczek1-2/+2
Change-Id: Iabb8588a2547c925c2c959f3b4831c89935a9529 Reviewed-on: https://gerrit.libreoffice.org/35133 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01loplugin:useuniqueptr extend to check local varsNoel Grandin1-84/+66
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-24coverity#1399266 Uncaught exceptionCaolán McNamara1-9/+5
Change-Id: I1066fda2258e6acbbbad23256f815975564e5e61
2016-09-12coverity#1371178 Missing move assignment operatorCaolán McNamara2-0/+28
Change-Id: Ib7df699269bcacd5dbf64662c47b538aee9235a5
2016-06-03CppunitTest_sal_osl_file: fix loplugin:cppunitassertequals warningsMiklos Vajna1-9/+9
Change-Id: Ib0594ba236284aa69d180fb72ce60435b679ea05 Reviewed-on: https://gerrit.libreoffice.org/25852 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-02CppunitTest_o3tl_tests: fix loplugin:cppunitassertequals warnings in ...Miklos Vajna1-56/+56
... sorted_vector Change-Id: Ie6c5f0e187228e2cf7769c62c86ff3cba80ab6ce Reviewed-on: https://gerrit.libreoffice.org/25804 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-27CppunitTest_o3tl_tests: fix loplugin:cppunitassertequals warnings in ...Miklos Vajna3-27/+36
... cow_wrapper and vector_pool Change-Id: I1f224a6bd933592dcb34defd5ad5c480d82346cb Reviewed-on: https://gerrit.libreoffice.org/25531 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-02-09Remove excess newlinesChris Sherlock2-3/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29remove unused o3tl::rangeDavid Tardon1-226/+0
Change-Id: I080f4f2cb15d25ecf5545300da422957f24e3f9b
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-09-15Fix binary ops with two o3tl::type_flags<E>::Wrap paramsStephan Bergmann1-0/+4
(the original ones would never have been picked due to how template argument deduction works) Change-Id: I5a08c763d721d8e11b5a10af2344a6a24bb0b9b2 Reviewed-on: https://gerrit.libreoffice.org/18583 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-01coverity#1321598 Resource leak in objectCaolán McNamara1-3/+2
and coverity#1321597 Resource leak in object Change-Id: I6e9e517a394bea60c1f0550b17bacd653eee5cbc
2015-08-30loplugin:implicitboolconversionStephan Bergmann3-17/+17
Change-Id: Id4561abb96ee8244d4c0b0c9dfce0e2cab1d8b85
2015-08-29o3tl: add another unit test to cow_wrapperDaniel Robertson3-0/+190
Add unit tests to cow_wrapper for the move ctor and move assignment. Change-Id: I82a5886ca7ae110985c7202125699cf95b6466d8 Reviewed-on: https://gerrit.libreoffice.org/18108 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-26Revert "create a macro to tidy up the declaration sites of ↵Noel Grandin1-1/+4
o3tl::typed_flags_set" sberg did not like this macro, let's see if I can find a better solution. This reverts commit e51fa143587d018b75db08e60cf27ff932b1cf8d.
2015-07-24LRU map (cache) implementation to o3tl + testsTomaž Vajngerl1-0/+239
Change-Id: I6b1a39918e6c8c67712be2c8e9907266dcfefedb
2015-07-15create a macro to tidy up the declaration sites of o3tl::typed_flags_setNoel Grandin1-4/+1
Change-Id: Ifb8fd4fd5128188420f1dfda6b6f695160d5e77a Reviewed-on: https://gerrit.libreoffice.org/15865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-06-11cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann1-1/+1
Change-Id: Ic29f424f5eb579ab95907c110529cdc9002443e1
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-2/+0
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07bug in typed flagsNoel Grandin1-0/+3
/home/noel/libo2/o3tl/qa/test-typed_flags.cxx:50:52: error: invalid argument type 'typename o3tl::typed_flags<ConfigurationChangedHint>::Wrap' to unary expression ConfigurationChangedHint nHint2 = nHint & ~(ConfigurationChangedHint::ONE | ConfigurationChangedHint::TWO); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Change-Id: Ia03e1e7d6afff0bdbb87e82ec076d5ffb820afb2
2014-10-14need explicit bool conversions hereNoel Grandin1-2/+2
to make some tinderboxes happy Change-Id: I136895674cec8eda874acda0bf5c7a96b3a22778
2014-10-14fixes and tests for o3tl::typed_flagsNoel Grandin1-0/+63
create test suite for typed_flags template. fix the operator&= and operator|= definitions Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: include/o3tl/typed_flags_set.hxx Change-Id: I1df9ae197889af98a2fd76ff2bc07756c7b14ced
2014-09-24Remove o3tl/heap_ptr.hxx, use std::unique_ptr insteadStephan Bergmann1-157/+0
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
2014-09-15Mark o3tl::heap_ptr as SAL_WARN_UNUSEDStephan Bergmann1-0/+1
...to make it more straightforward to fix blunder as in a88b2d841856026ea1a0539d670e07fafd296c6e "Resolves: fdo#81039 crash on adding new macro library." Conceivably, instances of heap_ptr could legitimately be created only for ctor/ dtor effect, but then again uses of heap_ptr should arguably be replaced with std::unique_ptr anyway. Change-Id: I9c765b8d265f3c26d459ec276e335eeebc8fee91
2014-05-22Fix memory leaks in test codeStephan Bergmann1-0/+11
Change-Id: I0dbb2546f1e776ebf95b61c16ebedbce0ead4c7f
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold1-3/+3
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-02coverity#1209778 & coverity#1209777 Resource leakChris Sherlock1-0/+2
Have testBasics_FindPtr() cleanup after itself by deleting p2 and p4. Change-Id: I88b5efd25941d135b743f759a8f27c1cdbcb43c0
2014-05-02coverity#1209779 & coverity#1209780 Resource leakChris Sherlock1-0/+2
Have the testBasics() function clean up after itself - delete p2 and p4 at the end of the function. Change-Id: Ib0c732e1962da94fde0e0da307f610dd36f49eda
2014-02-25Remove visual noise from o3tlAlexander Wilms2-2/+2
Change-Id: I15bd49dfa24b5eb260d442f15947788b41d000d1 Reviewed-on: https://gerrit.libreoffice.org/8284 Reviewed-by: Thorsten Behrens <thb@documentfoundation.org> Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2014-02-23Remove unneccessary commentsAlexander Wilms4-5/+5
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-05-08coverity#983036/37/38: Resource leakJulien Nabet1-0/+3
Change-Id: I8a2c079a60cc06ca82d9f516cf009359a0c083a7 Reviewed-on: https://gerrit.libreoffice.org/3819 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-23Validate cow_wrapper static default pattern.Thorsten Behrens3-0/+97
A bunch of objects use the optimization to assign one single, unique default object to default-ctored instances, and decide on whether any given object is in 'default' state by ptr-comparing against this one unique instance. Simulating that pattern here. Change-Id: I88f7d8488d81bcf1a01ab6b63121e003b8f0ade9
2012-08-02Revert "Revert "sorted_vector: turn Find parameter into template""Michael Stahl1-4/+2
This reverts commit 8291d41667b1a63d35bf818aaf9d75529e1f12f0. Un-revert that, with a tweak: with the bizarre name lookup semantics in C++, the proper way to refer to a template (as opposed to a template instance) is by prefixing the name with its namespace, which does seem to work with MSVC2008 & GCC 4.7; thanks to Stephan Bergmann for the hint. Change-Id: Id9cccbe68fb3ce2dd070c4b3dbd21782c92170ca
2012-08-01Revert "sorted_vector: turn Find parameter into template"Michael Stahl1-2/+4
This reverts commit 3e3acee762fac71f7356ed1305a64e0278278081. It was a nice idea, but C++ is not yet ready for it; with the travesty of parametric polymorphism in C++ the find_unique inside the definition of find_unique actually refers to find_unique<Value, Compare>, so there is no way to actually refer to template<Value, Compare> find_unique inside its definition. Thanks to Luboš Luňák for explaining the problem to me. Somehow this does work in GCC 4.7 even with -std=c++98, likely by accident.
2012-08-01sorted_vector: turn Find parameter into templateMichael Stahl1-4/+2
Enforces same type parameters for sorted_vector and Find, and makes it easier to use. Change-Id: Ide456a48f015cb0a9dea7a0bf2bcf2ccad527fd1
2012-07-31sorted_vector: add an additional template parameter:Michael Stahl1-0/+114
The Find parameter allows to implement sorted_vector that uses the obvious std::less-like semantics, and also allows for a different semantics where the array is sorted like std::less but duplicate values (according to std::less) are allowed except if they're actually the same object (pointer equality). Change-Id: Id54871c336ddbc2d0a2272bcc81c56914943b449
2012-07-17Add erase(size_t) method to o3tl::sorted_vectorNoel Grandin1-0/+31
I can't add a regular erase(iterator) method because we only hand out const_iterator's Change-Id: Ia3bdecb0f909d0712138c7ee48da268951e2733b
2012-07-17Improvements to sorted_vectorNoel Grandin1-0/+40
Implement suggestionss from David Tardon, mostly around prohibiting access that could result in the vector becoming unsorted. Add front() and back() accessors. Add lower_bound() method. Add optimised insert() method. Change-Id: Icbb3597277f3e5963573b57d4f6d3cb740e896e6
2012-07-12Create a template container class for sorted vectorNoel Grandin1-0/+80
We use this kind of container a lot, so creating a single implementation makes sense. Change-Id: I67ead58becd7d2a287812145c11d93ab1c593c0f
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 14:44:40 +0000