summaryrefslogtreecommitdiff
path: root/nlpsolver
AgeCommit message (Collapse)AuthorFilesLines
2016-01-21coverity#1326449 Dereference null return valueCaolán McNamara1-12/+8
and coverity#1326448 Dereference null return value Change-Id: I8e26c9c57264b654a5a7c3dc56c658f23291e357
2016-01-10Fix typosAndrea Gelmini1-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-04coverity#1327027 SIC: Inner class could be made staticCaolán McNamara1-1/+1
Change-Id: I9c36aa362e58de724c63b9d23334eabfc973ee42
2015-10-21More plausible fixStephan Bergmann1-2/+4
...for 7c465e7f9e8b5c34a4926fb0de84de70aee8f37d "coverity#1326260 Explicit null dereferenced" Change-Id: I3b7fb8195c29b7e447fbe31f823cd00d7a820e95
2015-10-15coverity#1326260 Explicit null dereferencedCaolán McNamara1-1/+1
Change-Id: I75b9cb661a7a45304bf32395ad980f83621f4612
2015-10-15cid#1327023 to cid#1327077 SIC: Inner class could be made staticNoel Grandin2-2/+2
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-14cid#1326608,cid#1326609 CN: Bad implementation of cloneable idiomNoel Grandin1-1/+1
Change-Id: Iac74be96b47720ab105f862e7d1a69f909214294
2015-10-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I4452d4a4a4a61f39cd9c2b5a441c6c2017f15ce8 Reviewed-on: https://gerrit.libreoffice.org/19073 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-01Fix typosAndrea Gelmini3-3/+3
Change-Id: I04d1bc3a9f38ff7871d3192563cd1f649fdc6cea Reviewed-on: https://gerrit.libreoffice.org/18960 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-18Fix typosAndrea Gelmini1-1/+1
Change-Id: I021589aeca9ef6bceb1c828c2197f5ff58f85b09 Reviewed-on: https://gerrit.libreoffice.org/18707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-30Fix typosAndrea Gelmini1-1/+1
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin1-1/+1
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin1-3/+3
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-17tdf#87074 null-ref error from NLPSolver in BasicLeMoyne Castle3-17/+13
Initialize java class member objects exposed as XSolver properties: no default construction in java. Fixes issue for both DEPS and SCO solvers. Also removed info level console prints. Change-Id: I6762c5cca978072ce20b1f69a6b523f53364107d Reviewed-on: https://gerrit.libreoffice.org/14499 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-05java: remove dead codeNoel Grandin19-664/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: nlpsolver: getPropertyByName was checking the wrong datastructureNoel Grandin1-1/+1
Found by PMD Change-Id: I76d38d71a3379416fe7e5078ef8b121915b26b6b
2014-12-11java: reduce visibility of fields and methodsNoel Grandin1-2/+2
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-05java: remove some unused local variablesNoel Grandin1-1/+0
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05java: remove some unused fieldsNoel Grandin1-20/+15
Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
2014-11-25java: final fields that can be staticNoel Grandin4-10/+10
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: make fields final where possibleNoel Grandin11-48/+48
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18java: fix some javadoc errorsNoel Grandin30-65/+41
Eclipse was flagging this text as "invalid javadoc tags" Change-Id: I09e090c6cc49366191f96d34bd51f6ba68cf18aa Reviewed-on: https://gerrit.libreoffice.org/12524 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin7-68/+40
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-56/+58
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-16java: always use braces for while loopsNoel Grandin1-1/+2
Change-Id: Iff896b0cace8b8305528b3b0140004ea856169ce
2014-10-13nlpsolver: ensure that the stream is cleaned up before the method returnsRobert Antoni Buj i Gelonch1-9/+20
Change-Id: I081194d802bd835285bdc37fbef55f229f1185dc Reviewed-on: https://gerrit.libreoffice.org/11940 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-02nlpsolver: fix javadoc error: bad use of '>'rbuj1-3/+4
Change-Id: Ibfaeef155982ce6eeefe8ef51eea9c2bddb12c46 Reviewed-on: https://gerrit.libreoffice.org/11244 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20remove more unnecessary constructor declarationsNoel Grandin1-2/+0
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20java: remove unnecessary constructor declarationsNoel Grandin1-5/+0
in the absence of any other constructors, the compiler will automatically generate a public no-arg constructor Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20java: remove modifiers implied by the contextNoel Grandin6-22/+22
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin2-5/+5
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin3-3/+3
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19java: remove unused methodsNoel Grandin4-115/+0
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-14java: remove unused importsNoel Grandin1-1/+0
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14java: remove commented out codeNoel Grandin2-6/+0
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-13remove dead java constantsNoel Grandin1-1/+0
found by UCDetector Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13make some java fields privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13java: remove dead methodsNoel Grandin11-177/+23
found by UCDetector Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13fix makefileNoel Grandin1-1/+0
after my commit cc6bd12 "java: remove unused enum values" Change-Id: I9f2f151c0c9a40f39fc235fa65b8324b9cb40027
2014-08-13java: remove unused enum valuesNoel Grandin3-50/+1
found by UCDetector Change-Id: Ic07be7e34204b5d838a722e1ce6038506a771144
2014-08-13java: remove unused fieldsNoel Grandin3-26/+24
found by UCDetector Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13java: reduce scope, make some methods privateNoel Grandin10-24/+24
found by UCDetector Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13java: reduce scope, make member classes privateNoel Grandin2-3/+3
found by UCDetector Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13java: reduce scope, make fields privateNoel Grandin11-54/+54
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13java: reduce scope, make constructors privateNoel Grandin3-5/+5
found by UCDetector Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-12java: reduce scope, make constants privateNoel Grandin1-1/+1
found by UCDetector Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12java: fix broken javadoc tagsNoel Grandin1-1/+1
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin3-0/+10
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-08java: remove exceptions from throws clauses that are notNoel Grandin1-1/+1
.. actually thrown Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10