summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2016-06-29move #includes to top of fileNoel Grandin4-7/+6
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-26lwp: pass numbers by valueJochen Nitschke2-8/+8
and add const to LtTm refenrence Change-Id: I3515db0fa1b79ce73592de6cba0ec79c39a9e9f4 Reviewed-on: https://gerrit.libreoffice.org/26315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-11coverity#1362681 Untrusted loop boundCaolán McNamara1-5/+17
and coverity#1362682 Untrusted loop bound Change-Id: I97eacad09abed4f91744b36f572761e43a3477fb
2016-06-09remove "read request longer than buffer" warningNoel Grandin1-1/+0
code is actually relying on this clamping behaviour Change-Id: I7f85679929b2c163dbabe01fc7bb8f1fe2327679
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2-8/+8
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl8-23/+23
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06lotuswordpro: fix some endian issuesMichael Stahl2-14/+14
Change-Id: I224c2d894071d6ec7d0afd5e2780a42b842aa32e
2016-06-02loplugin:unusedfieldsNoel Grandin2-2/+0
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25remove (un-)definitions of NDEBUG from source filesMichael Stahl1-7/+1
The build system already defines NDEBUG only if OSL_DEBUG_LEVEL=0 AND ASSERT_ALWAYS_ABORT=FALSE so the C++ code shouldn't override that. Change-Id: Ie67a576646cc7e18c3ffac67a3c81b80747ea438
2016-05-19loplugin:unusedmethods in l10ntools to lotuswordproNoel Grandin11-161/+0
Change-Id: Ibda82734821f3faa9388f7508e6a3e39e5b5007d Reviewed-on: https://gerrit.libreoffice.org/25106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09fftester: subtable is a subtable of itselfCaolán McNamara3-0/+9
Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
2016-05-08fftester: fail on double parse of the same tableCaolán McNamara2-7/+10
Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin4-10/+10
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05fftester: double use of XFTable, ref this upCaolán McNamara5-19/+18
Change-Id: I8e0c2319b2f43b66686fbce372c5df63c75b343a
2016-05-01Fix typos in codeAndrea Gelmini2-3/+3
Change-Id: I408f630732a10567a3352e0c96f1289a1cf6ca81 Reviewed-on: https://gerrit.libreoffice.org/24534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-29use initialization list in lotuswordproJochen Nitschke23-207/+156
this exposes 3 unused private members, detete them. reorder some initialization to match declaration order. remove a broken and redundant member initialization and destruction in xfindex.cxx (starts loop at 1 and default ctor/dtor do the same) simplify default ctor in xfframe.cxx Change-Id: Iaada8849e030d494a9bc7f7b0c3f8f1da3828290 Reviewed-on: https://gerrit.libreoffice.org/24466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28clang-tidy modernize-loop-convert in h-l/*Noel Grandin5-22/+18
Change-Id: I843528327b25d18476f8959cabba16371213a48a Reviewed-on: https://gerrit.libreoffice.org/24460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-4/+4
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifiersStephan Bergmann1-7/+7
Change-Id: I48654972e66b9a298940d800b2e04018cfd5bef8
2016-04-21new plugin stylepoliceNoel Grandin2-20/+20
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-5/+5
Change-Id: Ic81341bfb5d2271993451c3bdcf6e94222ac6ec2
2016-04-14loplugin:passstuffbyref in lotuswordproNoel Grandin32-63/+59
Change-Id: I2bca01e1ac3585674804b94d1cd65c18c41998ac
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-09pCont can be nullCaolán McNamara2-1/+1
Change-Id: I7af6c5f4a14e330924a1ea12ebb6328884b8a565
2016-04-08foundry may be nullCaolán McNamara2-1/+2
Change-Id: I39359389a42e35e0131db1d0451fbd5531843f75
2016-04-05UBSan: Restrict BorderWidthType values to valid range on inputStephan Bergmann1-4/+19
...lotuswordpro/qa/cppunit/data/fail/null-1.lwp would read 15 into m_eBelowType Change-Id: Icedcb4c8e2e6309b2e1bd82025feb02bad1ab7da
2016-04-04currentlayout may be nullCaolán McNamara2-4/+4
Change-Id: I1e53482e722b82f052434f45e37a2fbdb2ea6ffc
2016-04-04hold bullet para by referenceCaolán McNamara3-15/+11
Change-Id: I58025ea906426a7db4079042fa38954f1a3d076b
2016-04-03subtable corruption is possibleCaolán McNamara2-3/+2
Change-Id: Ifbf4312df583724a22328491bea3b6e05b82418f
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann1-1/+1
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-23loplugin:constantparam in lotuswordproNoel Grandin16-51/+50
Change-Id: I09c2301adb674fbed68a2659f828c7501a90b0c6
2016-03-16ubsan: load of value 768, which is not a valid value for typeCaolán McNamara1-1/+3
Change-Id: Ief0b70f19630d8d8cc925145848c7a2c8a2813ad
2016-03-15recurse protection for XFConvertCaolán McNamara9-14/+25
Change-Id: Ib6008d4b07159acad26c7baeb775702119c12e3b
2016-03-11tweat ExtMargins with same recurse protection as MarginsCaolán McNamara3-5/+16
Change-Id: I24640971ea6ca89878043966293492a991f01008
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann1-1/+1
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-09loplugin:constantparam in lotuswordproNoel Grandin5-7/+7
Change-Id: I8f8efa6b01fa0bcab074ac54029d95778cb388ab
2016-03-08need stdexceptCaolán McNamara1-0/+1
Change-Id: I008591c9d64a99939237e267b9ef6f28b2ef7964
2016-03-08avoid infinite regress in busted documentsCaolán McNamara4-7/+21
Change-Id: I639617e41cd9a9a51a3dd3efa32ac1cf2991b9d2
2016-03-07lwp: fix infinite recurseCaolán McNamara2-1/+2
Change-Id: Ibd17c0f68a9bac92e591fd2c998de45a84b372aa
2016-03-07improve defaultparams lopluginNoel Grandin1-2/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-02loplugin:unuseddefaultparam in lotuswordproNoel Grandin10-60/+40
Change-Id: I60a7a6d1b576411bea63f1616f2103ec6f126915
2016-02-22loplugin:write only fieldsNoel Grandin4-5/+1
Change-Id: I45895e9845a9037da207f001fece427452ed499f
2016-02-09Remove excess newlinesChris Sherlock4-5/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock1-1/+1
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-22lotuswordpro: Clean after we use constructor featureMatúš Kukan3-46/+16
18f1eb7b0c3536817572eeb481591418a7eab3da was pushed sooner, so just few more additions. Change-Id: If8e8082959fc049947986ca6faf329ea9436062a
2016-01-21Clean upStephan Bergmann3-38/+7
after ea6fdbaeeb51ad695f1c3754b796b7273eb4baad "tdf#74608 lotuswordpro: Constructor feature for LotusWordProImportFilter" Change-Id: I24179fd670bbaa92713cb69bd306930e90a8e698
2016-01-21cppcheck: silence unusedPrivateFunctionCaolán McNamara12-77/+77
somewhat odd this-> syntax here Change-Id: Ic69e72e15a9f90741e9422e14eb9a6d4784c7aa9
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-23 07:28:53 +0000