summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2018-03-01ofz#6640 avoid recurse to deathCaolán McNamara2-5/+16
Change-Id: Ia798636a5b4013753a268fff68915ec56c384e5f
2018-03-01ofz: infinite loopCaolán McNamara1-0/+4
Change-Id: I88b3d8bef0c522e4aa5e16ea8d45f7ea79337300 Reviewed-on: https://gerrit.libreoffice.org/50559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01ofz: infinite loopCaolán McNamara1-1/+5
Change-Id: I2c0ac101ccdd3f5359a885d976275fa6e63a3f67 Reviewed-on: https://gerrit.libreoffice.org/50558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01ofz: infinite loopCaolán McNamara1-20/+5
Change-Id: I15a0cbc5d4896e5390f5d422fb993325f22eedee Reviewed-on: https://gerrit.libreoffice.org/50557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28ofz#6602 infinite recursionCaolán McNamara2-2/+15
Change-Id: I358708f606655bcd0df948fd2e01725c706880c7
2018-02-19ofz: infinite loopCaolán McNamara1-0/+11
Change-Id: I2230a3fdd602063e66f56d23c15f79d6d4de4c8a Reviewed-on: https://gerrit.libreoffice.org/50000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz: infinite loopCaolán McNamara2-3/+17
Change-Id: Ie515421f484c63d07f10e8551464c7dc11facb73 Reviewed-on: https://gerrit.libreoffice.org/50001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6448 infinite-regressCaolán McNamara2-14/+16
Change-Id: Ie0c082a4b43355e935594f2dda694edfc9cdf315 Reviewed-on: https://gerrit.libreoffice.org/49950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17ofz: infinite loopCaolán McNamara1-0/+5
Change-Id: Ie54c22c65ccd962862cade77e3502a264164c2b2 Reviewed-on: https://gerrit.libreoffice.org/49912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17ofz: infinite loopCaolán McNamara1-0/+4
Change-Id: Icbc19a6761a9972d61db45b779dab56361bf6db8 Reviewed-on: https://gerrit.libreoffice.org/49915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15ofz#6372 fix bitmap decoding of pattern in LwpBackgroundStuffNoel Grandin2-6/+6
after commit b90e098a354323b635bab3ee8f9c79deb1e734fe use BitmapEx in LwpBackgroundStuff <caolan> maybe the lotuswordpro original stride is really 4 after all (as a common stride), with the first byte on each line containing the 8bits for each row The original code in GetPattern() looked pretty dodgy since it was copying 32-bytes into an 8 byte buffer. Assume that the reversing part is right, and that the format is really a 1bit packed 8x8 image. Also fix the decoding of such a image in CreateFromData to assume packed format, which is more predictable. Also fix the bug in createDefaultCross_3x3 which changing the assert revealed. Change-Id: I7196ae601429bbe0f842399df61c8b858e022d3e Reviewed-on: https://gerrit.libreoffice.org/49808 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14use BitmapEx in LwpBackgroundStuffNoel Grandin1-6/+2
part of making Bitmap an implementation detail of vcl/ Change-Id: I847a2371cd630637b11aed0fad7263809143c706 Reviewed-on: https://gerrit.libreoffice.org/49705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-13Null dereferenceCaolán McNamara1-4/+4
Change-Id: Ifda10738a4d4d97ba62ae3fc8804638621b24686 Reviewed-on: https://gerrit.libreoffice.org/49638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-13ofz: better loop detectionCaolán McNamara1-5/+4
Change-Id: I285358064ab9c02b5818bc0452ae3c35962778c6 Reviewed-on: https://gerrit.libreoffice.org/49630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12ofz#6208 Indirect-leakCaolán McNamara3-3/+9
Change-Id: I8d6761bd951cc1ddd4a45eabb26428bc40c2271a Reviewed-on: https://gerrit.libreoffice.org/49600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12replace m_pFoundry with m_xOwnedFoundryCaolán McNamara2-17/+16
Change-Id: I360d16ff3a61f85b9936582ea30e512e5a011c64 Reviewed-on: https://gerrit.libreoffice.org/49594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12potential leaksCaolán McNamara6-92/+56
Change-Id: I06bb0791a8598fab847853083fc3b767a904df0e Reviewed-on: https://gerrit.libreoffice.org/49593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia01f85e87706b02ffb816b3385765e2729dafa02 Reviewed-on: https://gerrit.libreoffice.org/49585 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-12various leaksCaolán McNamara2-43/+42
Change-Id: Id7b1c8847f3052ea6942bf6e479fd7b8b72326a9 Reviewed-on: https://gerrit.libreoffice.org/49574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-11ofz: leakCaolán McNamara2-15/+14
Change-Id: I15789e62c9fcdf518906a7e11e133fdd5d8ee62c Reviewed-on: https://gerrit.libreoffice.org/49563 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-11ofz: Infinite-loopCaolán McNamara1-0/+6
Change-Id: Id745e6525728661c8ee536044f0a08c0f94445b7 Reviewed-on: https://gerrit.libreoffice.org/49564 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-11ofz#6225 Infinite recursionCaolán McNamara2-16/+27
Change-Id: I5d5a3ac668baa78aed77d199b65e817975e68928 Reviewed-on: https://gerrit.libreoffice.org/49562 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10ofz: Infinite loopCaolán McNamara1-0/+5
Change-Id: I9344cb70aab0fbaa194d431928eba9806d76f115 Reviewed-on: https://gerrit.libreoffice.org/49504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10ofz: time-outCaolán McNamara1-0/+4
Change-Id: I89a1166f78938d7e36435bfeecb4a4f3f2ba9ad2 Reviewed-on: https://gerrit.libreoffice.org/49503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08infinite regressCaolán McNamara2-10/+15
Change-Id: I7f716d2273115284769d580165fbfa21c1db541b Reviewed-on: https://gerrit.libreoffice.org/49422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08ofz#6104 guard against self recursive GetShadowCaolán McNamara2-6/+15
Change-Id: If1cf0ef365f78665cc5b9f5f1ea53e82b531f9b0
2018-02-07ofz#6092 Null-dereferenceCaolán McNamara1-3/+2
Change-Id: Ic9a31b4819c07e82f6b90c4db1903ec5e27044be Reviewed-on: https://gerrit.libreoffice.org/49364 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-07ofz#6088 Null-dereferenceCaolán McNamara1-0/+3
Change-Id: I5854e27b4322f4e9b3dd8c976d619e98cc0ee3cc Reviewed-on: https://gerrit.libreoffice.org/49351 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-05ofz#6024 Direct-leakCaolán McNamara1-10/+10
Change-Id: I43959dea19860bc0d34c4623fc86ccb3ce069189
2018-02-01loplugin:datamembershadow in XFCellStyleNoel Grandin2-3/+0
looks like the subclass member is never written to, so I'm going to assume this was a bug Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514 Reviewed-on: https://gerrit.libreoffice.org/49001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-31ofz: Infinite loopCaolán McNamara1-12/+4
Change-Id: I9f7170023dd31c11ef6e02a6901bb5ea18f5fa81
2018-01-31loplugin:datamembershadow in lotuswordproNoel Grandin5-21/+21
Change-Id: I50f37e09df6c4c7cbe697e3419731e637c980807 Reviewed-on: https://gerrit.libreoffice.org/49000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-30ofz: loop detectCaolán McNamara1-1/+5
Change-Id: Ie0b54686e1406c5114148f9fe9a0bacfb5b607e8 Reviewed-on: https://gerrit.libreoffice.org/48899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-30ofz#5313 TimeoutCaolán McNamara1-0/+5
Change-Id: I5a51bf241d1a3c3c04b4f46cd26d2afab518787c Reviewed-on: https://gerrit.libreoffice.org/48854 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-26ofz: null derefCaolán McNamara1-1/+1
Change-Id: I3304656aa057df47ec9afeddb4caa297be88e137
2018-01-23ofz: better loop detectCaolán McNamara1-1/+5
Change-Id: I7c33d2a64a6b4968e8a83f53f5c893eb5ba268b7 Reviewed-on: https://gerrit.libreoffice.org/48415 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23ofz: Direct leakCaolán McNamara3-27/+17
Change-Id: Ide16aad0cadd393ce28425ed54c5e77f93d61317 Reviewed-on: https://gerrit.libreoffice.org/48412 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21ofz#5508 Out of memoryCaolán McNamara1-7/+26
Change-Id: If46b4f98849d75164956e68c181b1c501a72fae0 Reviewed-on: https://gerrit.libreoffice.org/48266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21rework to remove intermediate streamCaolán McNamara3-30/+15
Change-Id: I6ff66cf6ea6ac38f7c36da7668b612b2062e4852 Reviewed-on: https://gerrit.libreoffice.org/48257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21just return a vectorCaolán McNamara3-30/+13
Change-Id: Id6a75dee04c836ca28299dc6b3ab0b93361684c4 Reviewed-on: https://gerrit.libreoffice.org/48256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21just return SvMemoryStream*Caolán McNamara3-18/+9
Change-Id: I5c577984055e01f49c4e04685dc4df6672c8fc87 Reviewed-on: https://gerrit.libreoffice.org/48255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21use correct typesCaolán McNamara1-7/+7
Change-Id: I350f826f88bda85d3ea861ce7b05680900b850cf Reviewed-on: https://gerrit.libreoffice.org/48254 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-21align typesCaolán McNamara7-39/+34
Change-Id: I6080d92ec26f9ee9bf3eb4319a36c10ae38caca2 Reviewed-on: https://gerrit.libreoffice.org/48253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-20ofz#5514 Direct-leakCaolán McNamara1-9/+9
Change-Id: I9d77f102ed74ac901fffeac3054a57d172fd9dc0
2018-01-20loplugin:unusedmethodsNoel Grandin2-5/+0
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986 Reviewed-on: https://gerrit.libreoffice.org/48185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin2-3/+2
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19new loplugin:emptyifNoel Grandin1-3/+1
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42 Reviewed-on: https://gerrit.libreoffice.org/48128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-19ofz#5468 Integer-overflowCaolán McNamara1-2/+2
Change-Id: Ie2792b7dffaffe939778a1546653424ac03ea30e Reviewed-on: https://gerrit.libreoffice.org/48105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-18ofz#5462 Direct-leakCaolán McNamara2-21/+18
Change-Id: Ic2b7d139ebb6e88fac5cf9f4cf8dbec26905bcdc Reviewed-on: https://gerrit.libreoffice.org/48097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17Fix typosAndrea Gelmini3-3/+3
Change-Id: Id1c7ddf6c49ec709e38947a82731fe31a64aad04 Reviewed-on: https://gerrit.libreoffice.org/48076 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>