summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2018-01-12More loplugin:cstylecast: lotuswordproStephan Bergmann26-192/+192
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Idd6bd4f316b916877629579bf187d0f05251263d
2018-01-12ofz#5254 Bad-castCaolán McNamara3-1/+23
Change-Id: I318d441d841dd4c783f87ac2f3f699852e8b1039 Reviewed-on: https://gerrit.libreoffice.org/47796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-11ofz#5234 Direct-leakCaolán McNamara1-16/+13
Change-Id: I0a4f70423be3c7cc4ccdc593f743102922f9c284 Reviewed-on: https://gerrit.libreoffice.org/47743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09ofz#5157 Direct-leakCaolán McNamara1-0/+1
Change-Id: I3a058bd6d42975d7029c36416b27d31ff2165c03 Reviewed-on: https://gerrit.libreoffice.org/47663 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09ofz: avoid loopCaolán McNamara1-1/+4
Change-Id: Ie97f06188e7f824f5c5fc8968efedc231a8b9418 Reviewed-on: https://gerrit.libreoffice.org/47658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-08ofz#5028 Direct-leakCaolán McNamara1-8/+8
Change-Id: I5d168e4e30a6c76002399ad002a278c6c583210a Reviewed-on: https://gerrit.libreoffice.org/47577 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-08ofz#5025 Direct-leakCaolán McNamara2-27/+28
Change-Id: I2eb3e93f99f63f842378ab1839c79db2c781147a Reviewed-on: https://gerrit.libreoffice.org/47569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-07ofz#5012 Direct-leakCaolán McNamara1-9/+9
Change-Id: Ic4d5d9086c64559a2c8c06f20a8b6f461b84d440 Reviewed-on: https://gerrit.libreoffice.org/47535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-07ofz#4979 Divide-by-zeroCaolán McNamara1-2/+6
Change-Id: I0ac848950bdab54a8cc2659206758f1b13e32757 Reviewed-on: https://gerrit.libreoffice.org/47536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-06ofz#4976 Integer-overflowCaolán McNamara2-3/+10
Change-Id: Iefba0ea6122bd9b1dde59f33c0c67077fecb7eca
2018-01-06ofz#4999 Divide-by-zeroCaolán McNamara1-0/+2
Change-Id: I80b4d8a4d2abdfb54fe60a880555ea1ff62af987 Reviewed-on: https://gerrit.libreoffice.org/47503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-06ofz#4990 Direct-leakCaolán McNamara1-33/+33
Change-Id: I697edeacd286f1786d55ec53a781e53122acbdbe Reviewed-on: https://gerrit.libreoffice.org/47502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-05ofz#4879 Divide-by-zeroCaolán McNamara1-2/+7
Change-Id: I0df4bc2c8d9c5d5f95141b585826fc773a1fde3e Reviewed-on: https://gerrit.libreoffice.org/47484 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-05ofz#4976 Integer-overflowCaolán McNamara1-1/+2
Change-Id: I6929fc192e0e602c06edf89cf70e256797f7543a Reviewed-on: https://gerrit.libreoffice.org/47476 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-05ofz#4966 loop in text stylesCaolán McNamara1-0/+2
Change-Id: If94e32689c6742b2080c213796e27d49ebe6df74 Reviewed-on: https://gerrit.libreoffice.org/47458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04ofz#4950 Direct-leakCaolán McNamara1-6/+6
Change-Id: I231da98d9e7f9fefc25a454cb9c8e1f95215c364 Reviewed-on: https://gerrit.libreoffice.org/47382 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04ofz#4923 Divide-by-zeroCaolán McNamara2-3/+11
Change-Id: I0e3420dd908443b570e668b3a2b2ce189f6a14fd Reviewed-on: https://gerrit.libreoffice.org/47389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04ofz#4949 Direct-leakCaolán McNamara1-8/+8
Change-Id: I7fbae09caff3b7bae2f921cbd89dee0f5b892c78 Reviewed-on: https://gerrit.libreoffice.org/47381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-04ofz#4946 keep nPos within boundsCaolán McNamara1-1/+3
Change-Id: Ib5dc37b489b7b2101cf852a46f48fff1b7447a30 Reviewed-on: https://gerrit.libreoffice.org/47376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4917 Direct-leakCaolán McNamara1-7/+7
Change-Id: Ia8fdd63e1944055a264549b1ff2272b02f32ef42 Reviewed-on: https://gerrit.libreoffice.org/47327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4923 Divide-by-zeroCaolán McNamara1-1/+1
Change-Id: I141884930c4f148f4d29a9a679642ab4b898bbc1 Reviewed-on: https://gerrit.libreoffice.org/47324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4909 Direct-leakCaolán McNamara1-10/+10
Change-Id: I16f2fd93bbc416a5677f8bbe02e22b4615599eaa Reviewed-on: https://gerrit.libreoffice.org/47323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4920 Direct-leakCaolán McNamara1-5/+5
Change-Id: I2d4dea7936b1b8bae81bf08362a7d8c1081fdf8e Reviewed-on: https://gerrit.libreoffice.org/47325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4919 Direct-leakCaolán McNamara1-8/+8
Change-Id: I476a8760578e2ee9b564903ef2f6a2ed5e702cff Reviewed-on: https://gerrit.libreoffice.org/47326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-03ofz#4901 Divide-by-zeroCaolán McNamara1-1/+1
Change-Id: Ifc38234b4a99b205681b18b0d0bd2ec2a65dc515 Reviewed-on: https://gerrit.libreoffice.org/47317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-31loplugin:passstuffbyref improved return in lotuswordproNoel Grandin13-21/+21
Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682 Reviewed-on: https://gerrit.libreoffice.org/47222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin1-2/+2
Change-Id: I8128aa4b5fc60efd1dbf5971cdde11e588f5f64b Reviewed-on: https://gerrit.libreoffice.org/47167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19ofz#4689 avoid recurse to deathCaolán McNamara2-5/+12
Change-Id: Ie578a767cd8646c4e67c302a67b46ce1f1637122 Reviewed-on: https://gerrit.libreoffice.org/46772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-19Explicitly qualify ICU types with icu:: namespaceEike Rathke1-1/+1
It will be required by ICU 61 anyway, see https://ssl.icu-project.org/repos/icu/trunk/icu4c/readme.html#RecBuild Change-Id: If7f1330550981fd28eb7eea6329f21e116291cca Reviewed-on: https://gerrit.libreoffice.org/46740 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-12ofz#4600 avoid recurse to deathCaolán McNamara2-4/+11
Change-Id: I3cdced8294b30df5936bf7e167ca8a4950dde652 Reviewed-on: https://gerrit.libreoffice.org/46284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin1-2/+2
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07ofz#4548 infinite regress in GetUsePrinterSettingsCaolán McNamara2-3/+13
Change-Id: Id4505f9a4ddc47f2eb45cb86d46fdd050b007c26 Reviewed-on: https://gerrit.libreoffice.org/46009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07Revert "ofz#4548 infinite regress in GetUsePrinterSettings"Thorsten Behrens2-13/+3
This breaks a unit test: filters-test.cxx:145:Assertion Test name: (anonymous namespace)::LotusWordProTest::test equality assertion failed - Expected: 1 - Actual : 0 This reverts commit d38674f3b5b6c97be5f8822f52301e29d677ed1e.
2017-12-06ofz#4548 infinite regress in GetUsePrinterSettingsCaolán McNamara2-3/+13
Change-Id: Iebd51c8724eebb942af45f3be24718a7a1278183 Reviewed-on: https://gerrit.libreoffice.org/45991 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin2-2/+2
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30loplugin:unusedmethodsNoel Grandin2-49/+0
Change-Id: I9188f4579900d7eec375754aa94d21ac4e8456e2 Reviewed-on: https://gerrit.libreoffice.org/45504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-29loplugin:unusedmethodsNoel Grandin6-65/+0
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1 Reviewed-on: https://gerrit.libreoffice.org/45386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27loplugin:unnecessaryparen check for (f1()).f2Noel Grandin3-5/+5
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3 Reviewed-on: https://gerrit.libreoffice.org/45218 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22replace check of eof and GetError with goodCaolán McNamara1-1/+1
Change-Id: I7d9f04262ab5420e9a14813fa1274bb9d01e3291 Reviewed-on: https://gerrit.libreoffice.org/45076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-22drop duplicate methodCaolán McNamara1-1/+1
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12 Reviewed-on: https://gerrit.libreoffice.org/45075 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-06loplugin:constparams in various(2)Noel Grandin11-13/+13
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c Reviewed-on: https://gerrit.libreoffice.org/44313 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-01loplugin:finalclasses in lotuswordproNoel Grandin29-243/+167
Change-Id: I09a570741f5801980ae07fb90835e543519df046 Reviewed-on: https://gerrit.libreoffice.org/44135 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26More loplugin:unnecessaryparenStephan Bergmann1-1/+1
81892b2037453108b9bde1512a500cf3b2ce438a "loplugin:unnecessaryparen when compiling as C++17, so the ParenExpr is no longer hidden behind ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in loplugin:unnecessaryparen. However, that would still not look through implicit CXXConstructExpr, so would still not have found the occurrences in 81892b2037453108b9bde1512a500cf3b2ce438a when compiling in pre-C++17 mode. Therefore, let ignoreAllImplicit also look through CXXConstructExpr. (I am not entirely sure in which situations non-implicit CXXConstructExpr---that should thus not be ignored---would occur, but assume they would be underneath something like a CXXFunctionalCastExpr, which is not ignored.) Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
2017-10-24ofz#3745 Bad-castCaolán McNamara2-3/+2
Change-Id: I063646c8cce8ad5d62dc327e86e98942e57fc3f7 Reviewed-on: https://gerrit.libreoffice.org/43754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-23loplugin:includeform: lotuswordproStephan Bergmann289-844/+844
Change-Id: I1ff35dd6242accf0a8e71086a14a72e85eef1c5a
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin1-1/+1
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Make include files found through -Ilotuswordpro/incStephan Bergmann20-24/+24
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I4a666e8cd1cd3b1bf67af697be02879217dbc83a Reviewed-on: https://gerrit.libreoffice.org/43560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19use std::unique_ptr in lotuswordproNoel Grandin2-48/+30
Change-Id: I9f3e8de3284899376c7db55c3ea6f16023acc40f Reviewed-on: https://gerrit.libreoffice.org/43526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-17Move lotuswordpro include files to common include directoryStephan Bergmann185-561/+566
...that are included from both lotuswordpro/source/filter and lotuswordpro/source/filter/xfilter. Change done in preparation of loplugin:includeform. Change-Id: I7b65d3232e164af662b7de5bb49d59597803d41c Reviewed-on: https://gerrit.libreoffice.org/43453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>