summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2022-02-03read of width/height uses wrong record sizezhutyra1-2/+6
this initially went wrong at: commit b4fb7a437bb0ce987702b12008737756623618ac Date: Mon May 23 21:38:40 2011 +0100 fix up some more endian LIBREOFFICE-SBQ5TJRS Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129258 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-03ensure bounds checkingzhutyra1-50/+15
LIBREOFFICE-SBQ5TJRS Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129260 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-31ofz#43577 valid reclen must be >= 20Caolán McNamara1-3/+10
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 444477a07bcaf59181dbbc719b913566091deadc) ofz: Use-of-uninitialized-value Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7b37a1a5144a3a4c8b0803b7e2da81e9e108bf66) ofz: Undefined-Shift Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e863b90a0e5fc90c3b824e4b0012f9389b87a3ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129182 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-27ofz#44080 throw exception on a negative lengthCaolán McNamara1-0/+3
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128955 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-18ofz: Use-of-uninitialized-valueCaolán McNamara1-1/+2
Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128438 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-17ofz: Use-of-uninitialized-valueCaolán McNamara1-8/+12
Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128435 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-13ofz: Use-of-unintialized-valueCaolán McNamara1-3/+3
Change-Id: I6c9a1a22240defbc8d9fa262ad087770445ffc4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b4c56c0fd917623bbc0982eb53276e6ca64e7f42) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128334 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-12ofz#43551 Use-of-uninitialized-valueCaolán McNamara1-0/+2
Change-Id: I2eb139f3bff296cff7d8f0e9a05f19df56b27ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128327 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-01-12ofz#43446 Undefined-shiftCaolán McNamara1-0/+23
Change-Id: Ibe3485983ecf764ca8b8e667b470c6b210b6d2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 27e9de358b4afc6a89b09c173316cee0abfb471d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128233 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-12ofz#43509 use std::vector and at()Caolán McNamara2-26/+18
Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128237 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-11ofz#43458 avoid OOMCaolán McNamara1-0/+2
Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e28f4b6bccafb2b9f3c44dfabf36d1b822d85f84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128235 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10ofz#43818 delete of uninitialized pointerCaolán McNamara1-0/+12
Change-Id: I91509915c18c3e9b54cb3047462b9dd9a8c7a46b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128086 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-07ofz#43376 Null-dereferenceCaolán McNamara1-2/+5
Change-Id: I57f67465e4f8ca6fc6bd47d7b095e9b470d9d2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128072 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-23Remove unused header file lwpresource.hxxHossein1-66/+0
* Removed unused header file lwpresource.hxx which contained symbolic constants of type 'const char[]' that were no longer in use - STR_WORDPRO - STR_IMPLEMENTATION_NAME - STR_SERVICE_NAME - STR_WRITER_IMPORTER_NAME Change-Id: I4f1293a83c4058d7d01a98454a673ac88bd35b9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125701 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-11-14Use M_PI instead of defined value; use rad2deg()Hossein3-3/+5
* Replace defined values of PI with M_PI defined in <cmath> * Use M_PI_2 instead of PI / 2.0 * Instances could be found with: git grep 3.14 *.cxx *.hxx|grep define * One instance is ignored: sc/source/core/opencl/opinlinefun_statistical.cxx * Replace *(180 / PI) with basegfx::rad2deg() * Replace 2*PI/360 with basegfx::deg2rad() * Use atan2 instead of atan where it was more appropriate + atan2() handles all 4 quadrants + Extra conditions for different quadrants are removed Change-Id: I083ee2e1427cd36ba0b8c38e4fe5f782d6486075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-11-07forward decls go after #includeNoel Grandin2-4/+4
Change-Id: I54c33508639044092356eed5144720261b4f65db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-30Prepare for removal of non-const operator[] from Sequence in lotuswordproMike Kaganski1-3/+5
Change-Id: Id71f7a16d5ba0b47676d11136ef327205c370aab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124375 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17just do one lookup for loop detectionCaolán McNamara9-83/+82
Change-Id: I2b20c15f2e3ec3c4a23d78f6fab85db763fce033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16ofz#40004 TimeoutCaolán McNamara1-0/+7
Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-11loplugin:moveparam in lotuswordproNoel Grandin2-4/+4
Change-Id: I122fc96930021dd3127d9c991e7dac3140b612f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-11In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann1-1/+1
...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-05ofz: detect infinite loopCaolán McNamara1-0/+5
Change-Id: Ifc3134401c4ed7c4b17faf282d191ad2bb778746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-27ofz#39374: avoid infinite loopCaolán McNamara1-0/+7
Change-Id: I0aec664279dea99df865761f34f64aa4fa3d9e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122725 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-25Fix typosAndrea Gelmini1-2/+2
Change-Id: I40b4efb228176891678b8560a7ee4e37e77495e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122596 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: lotuswordproStephan Bergmann2-3/+5
Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-19ofz: avoid TimeoutCaolán McNamara1-3/+7
Change-Id: I8c5d1e7aaf256e182c2f5dd92bb8fd4ad9bff42a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18ofz#37911 Avoid timeout when fuzzingCaolán McNamara1-1/+1
Change-Id: I30bdcb3c267ee7e3ee0920df03ee8507d118d009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08ofz#27296 limit row span when fuzzingCaolán McNamara2-2/+5
Change-Id: I3069875f64acaf394cfef7f6478abc974022d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05cid#1490901 silence Out-of-bounds readCaolán McNamara1-1/+2
Change-Id: I9a2c1fe10fc696d5392cd6c95cff11124b5fdb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04cid#1490901 silence Out-of-bounds readCaolán McNamara1-1/+1
Change-Id: I4757413c80f6dc71d40c5c5525c484a54b71f676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-0/+2
Change-Id: If1db8debe4f3b3dc6a8890b03ee8d2d70cc63a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121572 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02cid#1490900 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: I22ab45d8e7bc72c3cf8cf8bb8ddbefef4250fdad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin3-3/+0
Change-Id: I78339f1df1f0c55c7edaa552940b07d1ada3aeb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-31ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara4-5/+10
Change-Id: I4298dfeafab0fe296a970fce024cc25572e3a2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-30ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-3/+1
Change-Id: I8a0a8f0bd9f55c4d0b20281205cf12f2bbcc564f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-29ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-0/+1
Change-Id: Ib1bed182b1b49076a47c7bc2bf29b9a45a21fbbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-28ofz#26357 Infinite loopCaolán McNamara2-1/+1
Change-Id: I914d5c8e53e226567f48b084b1cdb55721a58359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121182 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27Related: ofz#27296 OOM std::map->std::vectorCaolán McNamara2-11/+13
dbgutil massif peak of 3.1G -> 2.7G GB 3.117^ # | :::::::::::::::::::::::# | ::::: # | :@::::: #: | :::@::::: #: | :::::@::::: #: | :::::::@::::: #:: | :::::::::@::::: #:@ | ::::::::::@::::: #:@: | :::::::::::::@::::: #:@: | :::::::::::::::@::::: #:@:: | :::::::::::::::::@::::: #:@:: | ::::::::::::::::::@::::: #:@:: | ::::::::::::::::::::@::::: #:@::@ | @:::::::::::::::::::::@::::: #:@::@ | @::@:::::::::::::::::::::@::::: #:@::@: | ::@::@:::::::::::::::::::::@::::: #:@::@: | @:::@::@:::::::::::::::::::::@::::: #:@::@: | ::@:::@::@:::::::::::::::::::::@::::: #:@::@:: | ::::@:::@::@:::::::::::::::::::::@::::: #:@::@:: 0 +----------------------------------------------------------------------->Gi 0 116.7 ---> GB 2.718^ : | @######: | @@@# ::: | @@@@# :::: | @@@@@@@# ::::: | @@@ @@@@# :::::: | :@@@@ @@@@# ::::::: | @::@@@@ @@@@# :::::::@: | @@@::@@@@ @@@@# :::::::@:: | @@@@::@@@@ @@@@# :::::::@::: | @@@@@@::@@@@ @@@@# :::::::@:::: | ::@@@@@@::@@@@ @@@@# :::::::@:::::: | @::@@@@@@::@@@@ @@@@# :::::::@:::::@: | @@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:: | @@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::: | @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@:::: | @@@@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::: | @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@ | :@@@ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@: | @@:@ @ @@@@@@@::@@@@@@::@@@@ @@@@# :::::::@:::::@::::::@:: 0 +----------------------------------------------------------------------->Gi 0 34.29 Change-Id: Id56615e554d07a76a6a87476a40cc6190c0555da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27we are going to remove the entire row anywayCaolán McNamara2-16/+3
so don't iterate over the cells explicitly dropping them Change-Id: If0de504ac9711d1e6a757cdd15574f15585ca928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121180 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-27ofz#37660: searching in wrong parent for tableCaolán McNamara2-1/+1
Change-Id: Ifa1b70fa0ccc706cec52b318cdfba59f5da2b4d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26ofz#35646 Indirect-leakCaolán McNamara4-2/+34
Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie4809d5367d15dc155033db034d86aaa75cb5abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I8babf7975eb3b8f3e43f72572e75cbf46f510b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin1-9/+9
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-02no need to allocate these on the heapNoel Grandin3-14/+14
Change-Id: Ie7b8a5ee280da5dfcb15d217a4daccaf485cfbe1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:stringadd improvement for appending numbersNoel Grandin3-3/+3
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin1-7/+3
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin1-1/+1
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-26Revert "ofz#27296 Out-of-memory and ofz#27384 Indirect-leak"Caolán McNamara5-18/+48
This reverts commit c80c8ac4eb58812c1b72aa0b0cef01ebb5337359. it seems blameless after all Change-Id: If0f95da5ee7f91fde0b679c9314e3da07f7779f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-22no need to create temporaries when appending number to O[U]StringBufferNoel Grandin3-3/+3
Change-Id: I36d82423b5f75010552696a66cec7e53ee265ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114395 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 21:41:11 +0000