summaryrefslogtreecommitdiff
path: root/lotuswordpro
AgeCommit message (Collapse)AuthorFilesLines
2016-10-05convert MapUnit to scoped enumNoel Grandin1-1/+1
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-22loplugin:unusedmethods in chart2..svxNoel Grandin3-7/+2
Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I8200bd0fa2480cbca71305027963fa1cd9106a91
2016-09-15loplugin:singlevalfields in l10ntools..saxNoel Grandin38-185/+35
and ignore URE headers in the plugin Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl2-4/+4
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann93-211/+211
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13coverity#1372879 Integer overflowed argumentCaolán McNamara1-3/+9
Change-Id: I9e5115a00781d07c9c57e39854d6e1482bd02795
2016-09-12loplugin:constantparam in extensions..lotuswordproNoel Grandin4-12/+7
Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30loplugin:countusersofdefaultparamsNoel Grandin4-5/+5
Change-Id: I69f55593e6101906e0e97565f2cfc818852258dd Reviewed-on: https://gerrit.libreoffice.org/28486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-28silence coverity#1371316 operator= is equal to default, so unnecessaryCaolán McNamara2-10/+0
Change-Id: I9b301b6f661732ce4f6e9010324aa0a828736b50
2016-08-18convert XBitmapType to scoped enumNoel Grandin1-1/+1
Change-Id: I749831dfb78c10f3f7b9ebed6a5ee296ba6b2886
2016-08-05loplugin:countusersofdefaultparams in framework..lotuswordproNoel Grandin19-34/+34
Change-Id: I9833d85eb6543e996b0f357657c53b1c076ecde4 Reviewed-on: https://gerrit.libreoffice.org/27898 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05use std::move in a few placesNoel Grandin1-1/+1
found by git grep -n '.reset.*.release' Change-Id: I498709bd32b21d9dbbaa73603ce21d21c274f8dc Reviewed-on: https://gerrit.libreoffice.org/27863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin4-4/+4
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25new loplugin overrideparamNoel Grandin1-1/+1
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-29move #includes to top of fileNoel Grandin4-7/+6
instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-26lwp: pass numbers by valueJochen Nitschke2-8/+8
and add const to LtTm refenrence Change-Id: I3515db0fa1b79ce73592de6cba0ec79c39a9e9f4 Reviewed-on: https://gerrit.libreoffice.org/26315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-11coverity#1362681 Untrusted loop boundCaolán McNamara1-5/+17
and coverity#1362682 Untrusted loop bound Change-Id: I97eacad09abed4f91744b36f572761e43a3477fb
2016-06-09remove "read request longer than buffer" warningNoel Grandin1-1/+0
code is actually relying on this clamping behaviour Change-Id: I7f85679929b2c163dbabe01fc7bb8f1fe2327679
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2-8/+8
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl8-23/+23
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06lotuswordpro: fix some endian issuesMichael Stahl2-14/+14
Change-Id: I224c2d894071d6ec7d0afd5e2780a42b842aa32e
2016-06-02loplugin:unusedfieldsNoel Grandin2-2/+0
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25remove (un-)definitions of NDEBUG from source filesMichael Stahl1-7/+1
The build system already defines NDEBUG only if OSL_DEBUG_LEVEL=0 AND ASSERT_ALWAYS_ABORT=FALSE so the C++ code shouldn't override that. Change-Id: Ie67a576646cc7e18c3ffac67a3c81b80747ea438
2016-05-19loplugin:unusedmethods in l10ntools to lotuswordproNoel Grandin11-161/+0
Change-Id: Ibda82734821f3faa9388f7508e6a3e39e5b5007d Reviewed-on: https://gerrit.libreoffice.org/25106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09fftester: subtable is a subtable of itselfCaolán McNamara3-0/+9
Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
2016-05-08fftester: fail on double parse of the same tableCaolán McNamara2-7/+10
Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin4-10/+10
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05fftester: double use of XFTable, ref this upCaolán McNamara5-19/+18
Change-Id: I8e0c2319b2f43b66686fbce372c5df63c75b343a
2016-05-01Fix typos in codeAndrea Gelmini2-3/+3
Change-Id: I408f630732a10567a3352e0c96f1289a1cf6ca81 Reviewed-on: https://gerrit.libreoffice.org/24534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-29use initialization list in lotuswordproJochen Nitschke23-207/+156
this exposes 3 unused private members, detete them. reorder some initialization to match declaration order. remove a broken and redundant member initialization and destruction in xfindex.cxx (starts loop at 1 and default ctor/dtor do the same) simplify default ctor in xfframe.cxx Change-Id: Iaada8849e030d494a9bc7f7b0c3f8f1da3828290 Reviewed-on: https://gerrit.libreoffice.org/24466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28clang-tidy modernize-loop-convert in h-l/*Noel Grandin5-22/+18
Change-Id: I843528327b25d18476f8959cabba16371213a48a Reviewed-on: https://gerrit.libreoffice.org/24460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-4/+4
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifiersStephan Bergmann1-7/+7
Change-Id: I48654972e66b9a298940d800b2e04018cfd5bef8
2016-04-21new plugin stylepoliceNoel Grandin2-20/+20
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-5/+5
Change-Id: Ic81341bfb5d2271993451c3bdcf6e94222ac6ec2
2016-04-14loplugin:passstuffbyref in lotuswordproNoel Grandin32-63/+59
Change-Id: I2bca01e1ac3585674804b94d1cd65c18c41998ac
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-09pCont can be nullCaolán McNamara2-1/+1
Change-Id: I7af6c5f4a14e330924a1ea12ebb6328884b8a565
2016-04-08foundry may be nullCaolán McNamara2-1/+2
Change-Id: I39359389a42e35e0131db1d0451fbd5531843f75
2016-04-05UBSan: Restrict BorderWidthType values to valid range on inputStephan Bergmann1-4/+19
...lotuswordpro/qa/cppunit/data/fail/null-1.lwp would read 15 into m_eBelowType Change-Id: Icedcb4c8e2e6309b2e1bd82025feb02bad1ab7da
2016-04-04currentlayout may be nullCaolán McNamara2-4/+4
Change-Id: I1e53482e722b82f052434f45e37a2fbdb2ea6ffc
2016-04-04hold bullet para by referenceCaolán McNamara3-15/+11
Change-Id: I58025ea906426a7db4079042fa38954f1a3d076b
2016-04-03subtable corruption is possibleCaolán McNamara2-3/+2
Change-Id: Ifbf4312df583724a22328491bea3b6e05b82418f
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann1-1/+1
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-23loplugin:constantparam in lotuswordproNoel Grandin16-51/+50
Change-Id: I09c2301adb674fbed68a2659f828c7501a90b0c6
2016-03-16ubsan: load of value 768, which is not a valid value for typeCaolán McNamara1-1/+3
Change-Id: Ief0b70f19630d8d8cc925145848c7a2c8a2813ad
2016-03-15recurse protection for XFConvertCaolán McNamara9-14/+25
Change-Id: Ib6008d4b07159acad26c7baeb775702119c12e3b
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 15:53:52 +0000