summaryrefslogtreecommitdiff
path: root/libreofficekit
AgeCommit message (Collapse)AuthorFilesLines
2017-04-11CppunitTest_libreofficekit_tiledrendering: add more processEventsToIdle callsMiklos Vajna1-0/+2
With this the test passes for me 10 times in a row, while previously it failed from time to time, hopefully this fixes the false negatives. Change-Id: I233276ddfe4e9d8c86557f7f1c29d997f2fb51f6 Reviewed-on: https://gerrit.libreoffice.org/36420 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-06lokit: compile-test a plain C versionThorsten Behrens3-0/+43
Change-Id: Ibe2108984df8f4fef9ed681941d517ca9ad9479c Reviewed-on: https://gerrit.libreoffice.org/36177 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-28Use symbolic names for keys from css::awt::KeyTor Lillqvist2-12/+18
Change-Id: Iee2f4540cddeb05fcf0ae2ecadf7de8fbb4e3a0d
2017-03-25Fix typosAndrea Gelmini2-2/+2
Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky2-0/+89
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-21lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky1-0/+32
Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e Reviewed-on: https://gerrit.libreoffice.org/35494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-03-12lok: start describing UNO commands used through LOKTomaž Vajngerl1-0/+15
Change-Id: I44ce5a8a7ef939cbe48f6164284fae88a090a724
2017-03-06libreofficekit: GTK 3.22 deprecates gtk_show_uriMichael Stahl1-1/+8
Avoid -Werror=deprecated-declaration and use gtk_show_uri_on_window instead, which needs a GtkWindow. Change-Id: Ia77978348809c8d88cb2823a1549cbdeffcc6c97 Reviewed-on: https://gerrit.libreoffice.org/34926 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-03-03tdf#106287 Remove outdated remarkAdolfo Jayme Barrientos1-2/+1
Change-Id: Ia26123f469cc92f91682d05e16d761d4dca5dfca
2017-02-24libreofficekit: adapt README to realityMiklos Vajna1-4/+3
Change-Id: I7098e5c304a0fa945e3d3ba794be2b7932788c74
2017-02-23Better make the zero-initialization more explicitStephan Bergmann1-1/+3
...if initializing these members is necessary at all; a bit hard to tell from the code. Change-Id: I384fbeedb3a5b0690a80cabdd13ca13d07e8d627
2017-02-22loplugin:unusedfieldsNoel Grandin2-10/+4
Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20gtktiledviewer: Different reply uno command for impressPranav Kant1-1/+6
Change-Id: I9dcd32a7e64198ca4772f263ed89a458e298c53b
2017-02-20gtktiledviewer: Id param is string nowPranav Kant1-3/+3
It was changed in ce96c5957c38384f8911d6307605c502eca0c644 Change-Id: I4cc1f90d85e31044306ab36eaeac9d4424d965c0
2017-02-20gtktiledviewer: Adjust for different delete uno cmd for impressPranav Kant1-14/+21
Change-Id: I7fa82096298a8a7c9f586a1d3c06aa5852e6842e
2017-02-20gtktiledviewer: enable comment sidebar for all doctypesPranav Kant1-3/+1
Impress was the only doctype remaining which didn't have comments api yet, but now it does Change-Id: I4e287301e879dff1c29c26880305505466ceaba4
2017-02-16gtktiledviewer: Different UNO command for calcPranav Kant1-1/+1
Change-Id: I229451bac7cf4c223efd3fa18c177d650d3f9954 Reviewed-on: https://gerrit.libreoffice.org/34327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-02-16gtktiledviewer: This is a better place to change doc-specific controlsPranav Kant1-5/+8
Change-Id: Id8fbebe2f6e339120741ed3744b18f50941c995e
2017-02-16gtktiledviewer: Kill CommentsSidebar's docConfigurePranav Kant1-49/+41
Move this code to initWindow too Change-Id: I057d9b8f60b9da2c20b28901ab958f9fc2095df3
2017-02-16gtktiledviewer: Kill signalSize; move its code to initWindowPranav Kant1-14/+5
Change-Id: I8aa0a00768e074b016ea20680c67884f19fe26df
2017-02-16gtktiledviewer: Factor out per view code to separate functionPranav Kant1-12/+24
This code (populating part selector, part mode selector etc.) is something that needs to be executed for each view, not just the view that makes open_document call. Put all such code in initWindow function from now. Change-Id: Ibf9b12adb156258aa3cfdf959fffb541a88da529
2017-02-16gtktiledviewer: Store author name of each viewPranav Kant1-4/+6
Change-Id: I9a5be9050f3bedd14b6b5602b51bf40da0a11175
2017-02-16gtktiledviewer: comment id can be a string too nowPranav Kant1-13/+12
Change-Id: Ia94041884b7fde5f6c104a41c77c6a3aa96b7be1
2017-02-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-31gtktiledviewer: gtk version checksPranav Kant1-2/+12
There is no major harm in excluding these lines of code on platforms with older gtk. Change-Id: Ica3f1e2b4f60f0bab55254632663ace7b4c61d4d
2017-01-30gtktiledviewer: Handle comment callback with Modify flagPranav Kant1-18/+29
Change-Id: I8333876cc4b540c385e316ce8dcbc5f7bd1f7902
2017-01-30gtktiledviewer: Unused variablePranav Kant1-2/+1
Change-Id: I1bf8833041cf0e0a42aca1b6d851f6f4ca28d68f
2017-01-30gtktiledviewer: Mark reply comments with lightgreen backgroundPranav Kant1-0/+13
Change-Id: Ic6623ebc05f1a09d5fc1b6bae5fab149d98724ab
2017-01-30gtktiledviewer: Can edit comment from comment sidebar nowPranav Kant1-2/+27
TODO: Ideal would be to replace these buttons with a popover menu containing all the actions that can be taken on a comment Change-Id: Iec19e6c4a934394f84bcf4bb20cc14f207ef95be
2017-01-28coverity#1351757 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: Ieeae560fc6b6c82ef92ad5331cc6cddacb893a19
2017-01-27gtktiledviewer: Can reply, delete comments from sidebarPranav Kant1-13/+81
... and put the sidebar in a scrolled window Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c
2017-01-27gtktiledviewer: factor out user prompt entry dialogPranav Kant1-36/+48
Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5
2017-01-27lokdocview: 'comment' signal for comment callbacksPranav Kant2-16/+98
Change-Id: I82040893added83ff13395db3917b230ef6b01d5
2017-01-27gtktiledviewer: Comment dialog when tiled annotations are offPranav Kant1-1/+44
Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c
2017-01-27lokdocview: Separate gobject property for turning off commentsPranav Kant2-8/+42
Pass --enable-tiled-annotations to gtktiledviewer on command line to turn comments on again, by default they are turned off now. Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e Reviewed-on: https://gerrit.libreoffice.org/33622 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27gtktiledviewer: Comments sidebarPranav Kant1-2/+96
Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41 Reviewed-on: https://gerrit.libreoffice.org/33621 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lok: Implement new callbacks for comment notificationsPranav Kant1-0/+4
Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3 Reviewed-on: https://gerrit.libreoffice.org/33469 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27lokdocview: Turn off annotations rendering herePranav Kant1-0/+1
Change-Id: Ia1ee4f54a05ab3daca62a78fe335e731e4cfc02d Reviewed-on: https://gerrit.libreoffice.org/33465 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-27CppunitTest_libreofficekit_tiledrendering: fix cppunitassertequals warningsMiklos Vajna1-8/+8
Change-Id: I0fce00d4c794918e5b14b2c4f3f9f36231f28718 Reviewed-on: https://gerrit.libreoffice.org/33604 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-24loplugin: unnecessary destructor jvmfwk..lotuswordproNoel Grandin1-2/+0
Change-Id: Iaa4f9b178ab265342255066af7fff09f5b33ab37 Reviewed-on: https://gerrit.libreoffice.org/33496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23gtktiledviewer: Make edit mode the default onePranav Kant1-0/+2
This is a testing tool, most of the time developers want to do something with the document to test some functionality, lets keep edit mode on by default and save them a second. Change-Id: I61bbd2b85054b7ebdd14e69ca170674e260368e5
2017-01-23lokdocview: Handle keypad enterPranav Kant1-0/+1
Change-Id: Ia892c346d4a3c0a5439c7977963cc502d287e6f7 Reviewed-on: https://gerrit.libreoffice.org/33445 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-23lok: Listen for state change events for cell alignment commandsPranav Kant1-12/+5
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-09New loplugin:externvar: libreofficekitStephan Bergmann1-1/+1
Change-Id: Ib2a19249e1dd8d187b1fdc5559a9b4b9c2825e8c
2017-01-06gtktiledviewer: Lets avoid using manual buffer sizesPranav Kant1-14/+8
Change-Id: I76e70ccb5b1f40193a1eda1cbca19b3444168dae
2017-01-06gtktiledviewer: Override alignment buttons uno commands for calcPranav Kant1-0/+19
Use .uno:HorizontalAlignment instead of .uno:XXXPara for calc Change-Id: I5af4fe62dc3075af4ba779499d062e6d91f21ecf Reviewed-on: https://gerrit.libreoffice.org/32773 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-06gtktiledviewer: Support for posting arguments to uno commandsPranav Kant1-9/+12
Change-Id: I5db217b525d0f976ef6a7840e370f8f6a21d60cb Reviewed-on: https://gerrit.libreoffice.org/32772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-01-06lokdocview: Handle insert keyPranav Kant1-0/+3
Change-Id: Idb5ad17a3a94b9a6fba1113a759207c59acfb7bd
2017-01-02Fix inefficient usage of string::find() in condition (CWE597)Muhammet Kara1-1/+1
string::compare() will be faster when string::find's result is compared with 0, because it will not scan the whole string. Change-Id: I78596a6d796fe9779f88b7c7b91da09aa27b7035 Reviewed-on: https://gerrit.libreoffice.org/32430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-10re-apply "use material style selection handles""Christian Lohmaier1-1/+1
and account for the libreofficekit changes This reverts commit 50e9065cbbb2c62fa925cf5b561a85c715a0eb1e. that did in turn revert 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3. Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01