summaryrefslogtreecommitdiff
path: root/libreofficekit
AgeCommit message (Collapse)AuthorFilesLines
2018-01-05lokdocview: use std::string where possiblePranav Kant1-22/+20
This also prevents an invalid memory access: we were storing the pointer to a temporary in the struct and then using it after temporary was gone. Change-Id: I2b6d9df16bc24b222095ccbf45c9f0bd9c86ed65 (cherry picked from commit 9d2e0d60c0381a4bb23fada14c80e032b68bf2a8) Reviewed-on: https://gerrit.libreoffice.org/46949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-22lokdocview: Handle INVALIDATE_HEADER cbPranav Kant1-0/+39
With this calc gtktiledviewer or any other lok client shouldn't crash anymore when a new view is opened. And while at it, update documentation of callbacks. Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b (cherry picked from commit 71cd37fad9792038279969c82e0cb209df06f024) Reviewed-on: https://gerrit.libreoffice.org/46950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-22rhbz#1527945 segv on failed open of password protected doc in gnome-documentsCaolán McNamara1-1/+1
Change-Id: I1bec502ae20d03214c673d8911792c89669c0fe9 Reviewed-on: https://gerrit.libreoffice.org/46922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-21Revert the incomplete dialog tunneling, the API has changed completely.Jan Holesovsky12-331/+31
Change-Id: I50fb8c83365cefb8c8e76096fe257d31970a68b4 Reviewed-on: https://gerrit.libreoffice.org/46927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-11-14gtktiledviewer downgrade min gtk+ to 3.16Ashod Nakashian1-1/+1
Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5 Reviewed-on: https://gerrit.libreoffice.org/44724 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Move getting dialog information in separate LOK callPranav Kant1-2/+4
Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant5-10/+56
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I51351518d4df9fbe44f70cbcea92b360f1acc94a Reviewed-on: https://gerrit.libreoffice.org/44060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-28lokdialog: Tunnel dialog title to lokclient as outparamPranav Kant1-5/+10
Change-Id: I1beb5ab3f06debdca7ebf999af7ac879a41ea47e Reviewed-on: https://gerrit.libreoffice.org/43959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Clear the pointer after destroyingPranav Kant1-0/+3
Change-Id: Iebbe3fab6f6144f0cf1de9a1c45a0b2a62b07e0b Reviewed-on: https://gerrit.libreoffice.org/43958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant1-12/+20
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-24fix build errorDavid Tardon1-4/+2
Change-Id: I1e65f075a0519db86836b3aa09848178796a020b
2017-10-23loplugin:includeform: libreofficekitStephan Bergmann12-42/+42
Change-Id: I58a78a6339a0c8ef1b509604e8b79a339497cf8f
2017-10-20tdf#113311 disable CppunitTest_libreofficekit_tiledrendering for nowMichael Stahl1-1/+2
Change-Id: I0f6e284d232388019bfa33f07a4afc864e0040a9
2017-10-02Fix typosAndrea Gelmini2-2/+2
Change-Id: I325141f90104496c62af8704d75568df3418952a Reviewed-on: https://gerrit.libreoffice.org/43050 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-02lokdialog: Smoother mouse move on floating windowsPranav Kant1-28/+30
Do away with an early hack to create the floating window with every invalidate. This gets rid of persistent blinking when moving the mouse over a listbox, for example. Change-Id: Ida9367156605edc9835529f83529363ad97beaee
2017-10-02lokdialog: button press type debug infoPranav Kant1-3/+17
Change-Id: I193e0ab82e998905b670f7de73daae784de3ef00
2017-10-02lokdialog: Emit dialog close callback upon dialog closePranav Kant2-34/+51
Change-Id: I4ccef76cc3b2926dd8916f825671bb732e101027
2017-10-02Change CB_DIALOG_INVALIDATE to CB_DIALOGPranav Kant4-16/+21
We can specify whether it is an invalidation or something else in the payload. Change-Id: I95c5fc0a0a88b5277eaa93c8d1f9b937bddce7b3
2017-10-02lokdialog: Mouse events for dialog floating child windowsPranav Kant1-0/+127
Change-Id: I06a081835d246f752e57f8cc289162ed31fc91d4
2017-10-02lokdialog: drawing area needs to have focus to capture key eventsPranav Kant1-3/+5
With this, key events successfully work now. Change-Id: I6dc6aff91dea08fcbc7ab840a77e2542ab9048ce
2017-10-02lokdialog: Move the floating window to its actual positionPranav Kant3-5/+26
gtk_window_move them to the position broadcasted to us by vcl Change-Id: Id27b52a24e721b51d7a153cc7c0e03197a99ee2f
2017-10-02lokdialog: Support for rendering floating window dialog widgetsPranav Kant6-2/+132
Now gtktiledviewer can show floating window dialog widgets when user clicks any of such widget in the dialog. Change-Id: I13d756f236379bc8b2041ed41cb7b502f7fd9b24
2017-10-02lokdialog: gtv: Forward key events on dialog to corePranav Kant1-4/+122
Change-Id: Icfc210b08c7f1d8ebaf9c731ed64bb128cfc4356
2017-10-02lokdocview: Remove unnecessary codePranav Kant1-30/+11
Change-Id: I1d744c91f01eb098e9273d2459b63a5444558f39
2017-10-02lokdialog: Trigger repaint on all opened dialog with invalidatePranav Kant4-3/+26
For now, temporarily trigger paints for all the opened dialogs whenever a dialog invalidation callback is emitted. This solves the problem for some of the dialogs where hard coded uno command, which we are using as dialog IDs in GTV, doesn't match with the dialog id contained in the payload of the invalidation callback. With this SearchDialog, AcceptChangeTracking and few others are responding well to mouse clicks and invalidate instantaneously while to invalidate and repaint some other dialogs, one needs to refocus them. Change-Id: Iac2acbda60c8e2d0eabe65440f3fbda3ef271d7a
2017-10-02lokdialog: Forward mouse events to vcl; enable mouse movePranav Kant1-8/+40
The current implementation works well - the mouse events are properly handled by the opened dialog changing the dialog states. However, since the uno commands (dialog IDs) are different from what is returned by LOK_CALLBACK_DIALOG_INVALIDATE, the invalidation doesn't instantaneously, so one have to make the dialog window out-of-focus and then again back to focus to trigger the paint and see the updated dialog state. The mouse coordinates are forwarded in pixels as of now. Enable mouse GDK Motion mask too for mouse move operation. Change-Id: Ia915f734e8cbf4586da2b70da5840fe1568b39bd
2017-10-02lokdialog: Set up intial posting mouse events to dialogsPranav Kant2-0/+120
Events from the dialog in GTV are forwarded correctly, but the events are still not processed by the dialog in core. Change-Id: Ib95ac0a3cd23f6cc2763c21425a67402b15f2de2
2017-10-02lokdialog: Queue a redraw on invalidation in gtktiledviewerPranav Kant8-4/+109
Change-Id: I081508674a71c3beb89175e4f8ac3256e6bc6c6a
2017-10-02lokdialog: this is a stringPranav Kant1-1/+1
Change-Id: I7cb320a740cdb21da5a654cf99c887f5c7a8979d
2017-10-02lokdialog: Dialog invalidation supportPranav Kant1-0/+4
For now, just invalidate the whole dialog whenever any of the controls in the dialog get invalidated. Since during dialog painting, many such invalidations are triggered, don't listen to them when we are painting. Change-Id: Ia8fc12cf9469691d60e91ef770d687e5ff01a7ef
2017-10-02gtktiledviewer: Implement modeless dialog renderingPranav Kant8-1/+269
Hardcode modeless dialogs available in writer (very few) as of now in the combobox. Change-Id: I82d1442fbc71776dd64640ad048a0375ca041a67
2017-09-22Fix gtktiledviewer crash: this should be a null terminated listTamás Zolnai1-1/+2
Change-Id: I06e0923980b98b37b06ab45d8db68424b01d4f71 Reviewed-on: https://gerrit.libreoffice.org/42645 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-09-11clang-tidy modernize-use-emplace in hwpfilter..lotuswordproNoel Grandin1-16/+16
Change-Id: Ic11634ca28396fd156390c511087bae03bd5fb70 Reviewed-on: https://gerrit.libreoffice.org/42156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17implementing callback for ruler invalidationAditya Dewan5-0/+41
adding commands to fetch and changee ruler state '.uno:RulerState' and '.uno:RulerStateChange' Change-Id: I66107039a7ae5893691feb45c8ab2e4aa476ea76 Reviewed-on: https://gerrit.libreoffice.org/40727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin1-1/+1
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21migrate to boost::gettextCaolán McNamara1-1/+0
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-18Fix typosAndrea Gelmini1-1/+1
Change-Id: If6023dfa1d90f79185197622a738373a189ea6af Reviewed-on: https://gerrit.libreoffice.org/40118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-18gtv: G_OPTION_FLAG_NONE is available since 2.42 onlyPranav Kant1-7/+7
Change-Id: Ic3aacb79a3e828e59fede437213f2b7298e49bc1
2017-07-17Fix typosAndrea Gelmini3-3/+3
Change-Id: I0fec2abc1bed9c0cfcd78d1b0f6daebc335831be Reviewed-on: https://gerrit.libreoffice.org/39982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-15libreofficekit: Update the README to match realityPranav Kant1-2/+2
Change-Id: Ifb7bf759e87cb654401005914ed8906ef9456fdd
2017-07-14gtktiledviewer: Typo; these should be classesPranav Kant2-2/+2
Change-Id: Iba449fc66423959340c7967c64bc422a28fc75dd
2017-07-14Modernize gtktiledviewer; use GApplicationPranav Kant20-2299/+3617
Put all the UI content in UI XML file. Unfortunately, lots of boilerplate code because G_DECLARE_* macros are available only since glib 2.44 Change-Id: Idc74ba8565d482c28abd00b6f6f75646ab3d40b9 Reviewed-on: https://gerrit.libreoffice.org/39913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-07-13libreofficekit: Merge add_libs block into onePranav Kant1-7/+4
Change-Id: I0c4c2f3389cae243dbbfd16667d44d3ab8851860 Reviewed-on: https://gerrit.libreoffice.org/39914 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin1-1/+1
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-29loplugin:oncevar variousNoel Grandin1-2/+1
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6 Reviewed-on: https://gerrit.libreoffice.org/38766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23loplugin:unusedfields in jvmfwk..mysqlcNoel Grandin2-7/+0
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08 Reviewed-on: https://gerrit.libreoffice.org/39099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-18Fix typosAndrea Gelmini1-1/+1
Change-Id: Iba6b13871222d591bce49d04990e7c85ff154cce Reviewed-on: https://gerrit.libreoffice.org/38915 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-16Resolves: rhbz#1454693 segv if tiled rendering is interruptedCaolán McNamara1-0/+15
Change-Id: I1131f246c43806adb8a83f6eeafca2b734851a0e Reviewed-on: https://gerrit.libreoffice.org/38888 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-15Related: rhbz#1444437 check if m_nTimeoutId is validCaolán McNamara1-1/+2
Change-Id: I80d850d23ab0e95bb4b105efa5a1ae1e59933a95
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 00:11:37 +0000