summaryrefslogtreecommitdiff
path: root/libreofficekit
AgeCommit message (Collapse)AuthorFilesLines
2018-05-17loplugin:redundantcast improvements for floating-integer conversionsStephan Bergmann1-2/+2
Change-Id: I63dbf18f144a792ae775fe6706da81657f790016 Reviewed-on: https://gerrit.libreoffice.org/54416 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-05Fix typosAndrea Gelmini1-1/+1
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-17cppcheck - fix variableScope in some filesGökhan Gurbetoğlu1-6/+6
Reduced the scope of some variables in source. Change-Id: Ib3b521ca5df8b9b254b51eab5f1d7040d6cfd846 Reviewed-on: https://gerrit.libreoffice.org/52974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai1-2/+15
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-03-25Use for-range loops in some modulesJulien Nabet1-3/+2
jvmaccess, jvmfwk, l10ntools, libreofficekit and linguistic Change-Id: I9d290d1098b25ccb3aee19d2df18c18f4aa65105 Reviewed-on: https://gerrit.libreoffice.org/51495 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-21lok: be informative and exit when tilebench fails to initializeAshod Nakashian1-0/+6
Change-Id: I11078e36aafc715b7103998a17e0cb01926b8e97 Reviewed-on: https://gerrit.libreoffice.org/51618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-15move Bitmap::ScopedWriteAccess inside vclNoel Grandin1-1/+1
would have liked to make the AcquireWriteAccess methods DLLPRIVATE, but they are needed by the workbench and testing code Change-Id: I22497788eb68dfb84b7e542e5ef53322892a5274 Reviewed-on: https://gerrit.libreoffice.org/51310 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14lokdialog: debug red-colored boundary for last painted regionPranav Kant1-0/+6
Easier to see what's going on inside the LOK dialog. Change-Id: I59974200af3d2356b7c27eb3dd4032a59c00dbed Reviewed-on: https://gerrit.libreoffice.org/51263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-13lokdocview: new property 'is-initialized'; fix gtktiledviewer for calcPranav Kant2-0/+31
there's no lokdocview property to tell if the doc has been completely initialized (initializeForRendering() has been called, etc.). This new property takes care of that which we now use to ignore configure event fired before document is initialized for rendering. Configure event handler queries document for row/col header which asserts because some values hasn't been initialized yet. Change-Id: I58385b2cb56bf317fe20ecf0570b7095f7260174 Reviewed-on: https://gerrit.libreoffice.org/51156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara1-1/+1
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02delete colordata.hxxNoel Grandin1-1/+1
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27Fix build, for real this timePranav Kant1-0/+1
Add a few missing processEventsToIdle()'s in the tests. Let's disable one of the assertion until I figure out what's going on. Change-Id: I82cbe443b4013d4402151ddae4b06044dfb394bd
2018-01-15convert a<b?a:b to std::min(a,b)Noel Grandin1-1/+1
with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053 Reviewed-on: https://gerrit.libreoffice.org/47856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12More loplugin:cstylecast: libreofficekitStephan Bergmann3-32/+32
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Iaa166a248f5c1e9fcf62834f65475265403e4322
2018-01-10Fix typoAndrea Gelmini1-1/+1
Change-Id: I2261578d54e4b986871eab9c309884eb903aa3c6 Reviewed-on: https://gerrit.libreoffice.org/47614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-08lokdocview: Make g-ir-compiler, scanner happyPranav Kant1-8/+14
Silence their warnings Change-Id: Id397745bbf7fe6687b60eeca60d5a0b67da421b1
2017-12-23LOK: support tile-dumping in tilebenchAshod Nakashian1-11/+60
And other improvements. (cherry picked from commit b7d893d8a1ecb24290c4470e12d71caba2b85216) Reviewed-on: https://gerrit.libreoffice.org/46678 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 0e7ccbdd559df3a446e73c367b12824c6c143579) Change-Id: I5a27d6d2df5f946a708dd3b0b4fef8159da86e5c Reviewed-on: https://gerrit.libreoffice.org/46985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-23LOK: tilebench improvementsAshod Nakashian3-35/+73
* Arguments for max number of parts and tiles to render (optional). + Automatic estimation of maximum tiles to render based on max parts for Writer docs, since there is only 1 part, this caps the number of pages to render, similar to other doc types. * Fixed rendering of Writer documents over and over (as many times as pages). + Writer has a single part, unlike other doc types. + No point in rendering the whole document in writer to a single tile, since that's completely unrealistic and impractical (it takes forever for large docs and artificially spikes the memory). * Rendering starts at the current part and not the first. + This gives the spreadsheet of interest priority (if saved as visible). * The tile size is now more realistic as we use the same dimensions as the Online client does. * When rendering tiles at scale, we use the same dimensions as the Online client rather than splitting the width by 4, for realism. * Rendering of tiles is done rows-first, rather than columns-first, which is similar to what the Online client does, which is more cache friendly, therefore more realistic. * Enabled compiling of tilebench when GTK3 is disabled, which was erroneous, since tilebench doesn't have any dependency on GTK. + Now it's possible to compile with local Cairo/Pixman libs. Reviewed-on: https://gerrit.libreoffice.org/44936 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7db98521548de9eab955ee25a5aacaaef42df323) Change-Id: I6ad2e97f39572778dd7d0c12d14550841c1d6963 Reviewed-on: https://gerrit.libreoffice.org/46984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-22rhbz#1527945 segv on failed open of password protected doc in gnome-documentsCaolán McNamara1-1/+1
Change-Id: I1bec502ae20d03214c673d8911792c89669c0fe9 Reviewed-on: https://gerrit.libreoffice.org/46921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I5c6e252072089a06f0be4292d51aed020cbc67fe Reviewed-on: https://gerrit.libreoffice.org/46888 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-21lokdocview: Handle INVALIDATE_HEADER cbPranav Kant1-3/+65
With this calc gtktiledviewer or any other lok client shouldn't crash anymore when a new view is opened. And while at it, update documentation of callbacks. Change-Id: I436c3b424dd4e2e6b8c312b0d3ba43d7006e944b
2017-12-21lokdocview: use std::string where possiblePranav Kant1-22/+20
This also prevents an invalid memory access: we were storing the pointer to a temporary in the struct and then using it after temporary was gone. Change-Id: I2b6d9df16bc24b222095ccbf45c9f0bd9c86ed65
2017-12-15lokdialog: If we already have the title, emit it during creationPranav Kant1-0/+4
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 (cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
2017-12-15lokdialog: gtv: Set dialog title on callbackPranav Kant1-0/+5
Change-Id: I6d96a9e2287afdcaad2f770e4b4c73d3671fc76b (cherry picked from commit f0a6fd58575ff6b9ebbfb0835aa8694923ddbffd)
2017-12-04lokdialog: multiview: Do not mix one view with otherPranav Kant3-21/+13
In GTV, use correct application window object to fetch the dialog object. Use correct view shell to notify window (dialogs, etc.) callbacks. Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb
2017-12-04lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant1-27/+27
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
2017-12-04lokdialog: Rename postDialogKeyEvent -> postWindowKeyEventPranav Kant1-1/+1
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175
2017-12-04lokdialog: Simplify; make the LOK dialog API more genericPranav Kant7-193/+157
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2017-12-04lokdialog: Do not underestimate the dialog sizePranav Kant1-2/+2
Some of them like, EditStyle, can be much bigger. Change-Id: Iaad02fadba18846976b959369f06e2020feffc6f
2017-12-04lokdialog: Allow closing a dialog from LOK clientPranav Kant2-1/+7
... and rename paintDialog -> paintWindow before it's too late. We not only render dialogs now but also popups. Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850
2017-12-04gtv: Width, height properties should not be construct onlyPranav Kant1-2/+0
Change-Id: I2d1b29f52c1fe0449cf9afe47c509ef6250804a8
2017-12-04gtv: Remember recently executed UNO commandsPranav Kant8-31/+170
Saves the recently executed UNO commands in a temp file and make it accessible to user in a combo box. Useful when debugging. Change-Id: Ic66961a388cc59dee3f65cb8d4de3c29a8a75eaa Reviewed-on: https://gerrit.libreoffice.org/45540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-12-02require at least gtk3 3.12.0 to build gtk3 bitsCaolán McNamara1-2/+0
Change-Id: I608fa4075eadd0b3ed038c26aba5d9383a99b314 Reviewed-on: https://gerrit.libreoffice.org/45669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02require at least gtk3 3.10.0 to build gtk vclplugCaolán McNamara2-10/+0
Change-Id: I4ca34184237d05b999c92648494c306a1f1371cd Reviewed-on: https://gerrit.libreoffice.org/45668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29lokdialog: Remove getDialogInfo + update gtktiledviewer accordingly.Pranav Kant2-12/+28
Change-Id: I6f810c97f2fadd3b1ea602a97e24c8b42f4a84b9
2017-11-29gtv: Kill dialog selector combo boxPranav Kant2-38/+1
Change-Id: I2cd27dff95f2bc49a15ab395b8282b5496e1e229
2017-11-29lokdialog: Make vcl::DialogID an integerPranav Kant3-49/+35
This will help launching multiple instances of dialog from multiple views. The earlier approach of using the UNO command strings as dialog id would not have been useful for multi-view case. Change-Id: I01cfb3c8b204d5654df2417efdac6b50dc920f0e
2017-11-29lokdialog: Create dialog when callback is receivedPranav Kant4-40/+34
With this, we do away with initial approach of rendering the dialog on a large surface. We now create the cairo surface with dimensions of the dialog. Change-Id: Icb034693c7f1c656b7daae7f5c711b5bd4d8e880
2017-11-29lokdialog: gtv: Add width and height props to Dialog GObjectPranav Kant3-5/+43
Change-Id: I488a94d9c6cefd37624f755c6308f0b75595df84
2017-11-14gtktiledviewer downgrade min gtk+ to 3.16Ashod Nakashian1-1/+1
Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5 Reviewed-on: https://gerrit.libreoffice.org/44724 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Move getting dialog information in separate LOK callPranav Kant1-2/+4
Using outparameters to get the dialog information with the paintDialog call was quite confusing. Change-Id: Ief331b251dc66e66084b827ce5b025ba6c9ce7d2 Reviewed-on: https://gerrit.libreoffice.org/44473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-09lokdialog: Support painting parts of the dialogPranav Kant5-10/+56
Pass the dimensions of the region to the paintDialog call to paint only that much of the region in the dialog. The DIALOG_INVALIDATE callback also returns a 'rectangle' field now in the payload that tells the region of the dialog invalidated. It can be used in combination with the new paintDialog call then to paint only the invalidated region in the dialog. Change-Id: Iebb228865c71684e0f75dd01271b71ae41a0f906 Reviewed-on: https://gerrit.libreoffice.org/44472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-30Fix typoAndrea Gelmini1-1/+1
Change-Id: I51351518d4df9fbe44f70cbcea92b360f1acc94a Reviewed-on: https://gerrit.libreoffice.org/44060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-28lokdialog: Tunnel dialog title to lokclient as outparamPranav Kant1-5/+10
Change-Id: I1beb5ab3f06debdca7ebf999af7ac879a41ea47e Reviewed-on: https://gerrit.libreoffice.org/43959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Clear the pointer after destroyingPranav Kant1-0/+3
Change-Id: Iebbe3fab6f6144f0cf1de9a1c45a0b2a62b07e0b Reviewed-on: https://gerrit.libreoffice.org/43958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-28lokdialog: Use UNO name as dialog id when invoking lok callbacksPranav Kant1-12/+20
... not the frame id from the .ui file Remove temporary hacks introduced earlier in GTV also. Change-Id: I71290a5fac6547a5584094da21e2301ef8fbce0c Reviewed-on: https://gerrit.libreoffice.org/43957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-10-24fix build errorDavid Tardon1-4/+2
Change-Id: I1e65f075a0519db86836b3aa09848178796a020b
2017-10-23loplugin:includeform: libreofficekitStephan Bergmann12-42/+42
Change-Id: I58a78a6339a0c8ef1b509604e8b79a339497cf8f
2017-10-20tdf#113311 disable CppunitTest_libreofficekit_tiledrendering for nowMichael Stahl1-1/+2
Change-Id: I0f6e284d232388019bfa33f07a4afc864e0040a9
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 23:56:02 +0000