summaryrefslogtreecommitdiff
path: root/libreofficekit/qa
AgeCommit message (Collapse)AuthorFilesLines
2016-09-23gtktiledviewer: Wrap dialogs in a GtkScrolledWindowPranav Kant1-2/+8
Change-Id: I33be18779ea680f7a9c20814ca3c3d94d206900b
2016-09-19sw: emit LOK_CALLBACK_STATE_CHANGED when cursor enters/leaves a redlineMiklos Vajna1-2/+16
For now only care about the start of the cursor, which can be only at a single redline. Add matching testcase + expose it in the gtktiledviewer status bar for interactive manual testing. Change-Id: Ib61757412d6b54bef64361d4a8563795ca0bab6c
2016-09-15sw: allow select of redline by indexMiklos Vajna1-2/+7
Previously .uno:NextTrackedChange always worked by cursor position, but redlines are stored in the redline table, so they have a unique index. Allow specifying that index when invoking the command, and in that case ignore the cursor position. Change-Id: I7dbe8044feca8fcc48635482a22317b024f40ffa
2016-08-30gtktiledviewer: don't crash on unimplemented tracked change listMiklos Vajna1-0/+3
As it's currently implemented only for Writer. Change-Id: I8c281b2294564472f2c2c5b7de5dd3f86a11a94a
2016-08-29sw: use SwModule::GetRedlineAuthor() in SwTextShell::ExecField()Miklos Vajna1-17/+2
This avoids some code duplication, and also means that the redline author set by SwDocShell::SetView() affects the inserted Writer comments as well, while those were 'Unknown Author' in the LOK case. Change-Id: Ib51183302ee6904fdf69fb16f27ecfe6df39e6cb
2016-08-19sw redlines: expose description as part of the UNO/LOK APIMiklos Vajna1-3/+4
A redline can have a manual comment and also an autogenerated description, like "Insert 'abc'". Expose this later property as well, as it provides useful additional information, especially when the comment property is empty. Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
2016-08-19tdf#101592 sw: track changes state is doc-specific, not view-specificMiklos Vajna1-0/+12
So update the bindings of all views after changing it. Change-Id: I5355f40ba27be521dcdf343b08305f3736979bbb Reviewed-on: https://gerrit.libreoffice.org/28233 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18gtktiledviewer: specify author name when calling initializeForRendering()Miklos Vajna1-4/+30
Open two views, and type into both of them when a Writer doc with redlining enabled is open: the manage changes dialog now shows how the correct author is used when creating the redline items. Change-Id: I48fb90301bfcc04b06d5be5544324ca76fe7b3d7
2016-08-17sw: allow accept/reject of redline by indexMiklos Vajna1-4/+37
Previously .uno:AcceptTrackedChange / .uno:RejectTrackedChange always worked by cursor position, but redlines are stored in the redline table, so they have a unique index. Allow specifying that index when invoking the command, and in that case ignore the cursor position. The index is not stable after an insertion / deletion. Change-Id: I493a22e84800ded224fb6b9c61261744dc0fb64f Reviewed-on: https://gerrit.libreoffice.org/28192 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-17lok::Document::getCommandValues: expose redline infoMiklos Vajna1-1/+67
Index is added as a property for each item, so that later changes can be identified by the index when they are accepted/rejected. Change-Id: I9362d208fdbed1f46d64558d44498d2b19150c81
2016-08-10sw undo: add a Repair argument to the .uno:Undo/Redo commandsMiklos Vajna1-0/+5
Undo/redo is limited to undo actions created by the same view in the LOK case, this argument removes this limit. This can be used by a client for "document repair" purposes, where undo/redo of others' changes is intentional. The sfx command dispatch has support for FASTCALL slots (a state function is not called, the command is always enabled) and also has support for state functions, but those functions only get the ID of the slots, not its parameters. What is needed here is a command that's disabled by default, but in case a Repair argument is used, then it's unconditionally enabled. So handle that case in the sfx dispatcher directly for now. Change-Id: I96c1130bf51abcdd722684b1fa4a8277f92fd555
2016-08-09gtktiledviewer: fix incorrect undo/redo stateMiklos Vajna1-16/+31
Edit state = false disabled undo, then edit state = true enabled the undo button, even the last LOK callback was '.uno:Undo=disabled'. Fix this by storing the LOK state in a map, and using it when edit is enabled. With this, clicking on the Edit button right after loading a document results disabled undo/redo buttons as expected. Change-Id: Id6023f976f135555a43486f71603c823e59d8d60 Reviewed-on: https://gerrit.libreoffice.org/28003 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-05gtktiledviewer: expose undo/redo info in a repair document dialogMiklos Vajna1-1/+107
This shows the full undo and redo stack, with all the metadata available via the LOK API. Also fix SfxUndoManager::GetRedoActionsInfo(), so it's easy to show the undo/redo stack in linear time; and fix a use-after-free in lokdocview. Change-Id: I66625ed453efa61b5738d99d7d1ad8f468908240 Reviewed-on: https://gerrit.libreoffice.org/27913 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-28gtktiledviewer: quit after the last view is destroyedMiklos Vajna1-1/+16
To allow debugging crash-on-exit problems. Change-Id: Ie54a8391e721c3ba8034b4618dd30733bac97a27 Reviewed-on: https://gerrit.libreoffice.org/27605 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-22gtktiledviewer: align to top/left for CalcMiklos Vajna1-1/+11
Otherwise when zooming out enough that not all available space is used, the default horizontal/vertical centering happens, and the row/column headers and the tiles become out of sync. Also revert to the previous default window size, I'm not sure why that was necessary. Currently checking the mentioned situation (empty Writer document with comments only) does not require this larger size, and testing two views is easier with the smaller size. Change-Id: Ia92a591387f62655a671e2d09f5053827fde5045 Reviewed-on: https://gerrit.libreoffice.org/27427 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-15gtktiledviewer: allow testing of destroyView()Miklos Vajna1-1/+1
By calling it when we're not the last window. Change-Id: I6fd4763243fc088ccfe015b6c03b6b3f25146fac
2016-07-06clang-tidy performance-faster-string-findStephan Bergmann1-1/+1
Change-Id: Ia645dd9c5301d93abea90646ad32e94b8cb8ce17
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen1-1/+1
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-17comphelper lok: remove the g_bViewCallback globalMiklos Vajna1-9/+7
Its purpose was to allow incrementally migrate all callers of SdrModel::libreOfficeKitCallback() to use SfxViewShell::libreOfficeKitViewCallback() (which allows notifying only the currently active or all views) instead. That is done by now, so it can go. Change-Id: I521bbbe5c638dfd844ebf025153459a37362d3c3 Reviewed-on: https://gerrit.libreoffice.org/26413 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-16comphelper: enable LibreOfficeKit::isViewCallback() by defaultMiklos Vajna1-1/+1
This requires porting the sw/sd/sc_tiledrendering test code to the new internal API, as only the public LOK API is unchanged. Change-Id: Ic6a2f96421da4a16bdee7d0cbb3f6e35bc6ddff9 Reviewed-on: https://gerrit.libreoffice.org/26379 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-15gtktiledviewer: add a UNO command debuggerPranav Kant1-0/+113
... to fire desired UNO commands from a dialog. Helpful when you need to check some arbitrary UNO commands not supported via UI yet. Change-Id: I55df75ef235f5eb6922c50619610caf1c88241fb
2016-06-15gtktiledviewer: Fix runtime gtk warningsPranav Kant1-4/+5
Not all buttons are toggle buttons. Change-Id: I6cddc619f3f760e447ea3ffea07f776e03cdaab9
2016-06-13gtktiledviewer: fix the per-view part selectorMiklos Vajna1-3/+18
Need to populate it & register handlers for the non-first windows as well. Change-Id: I27231027c3f33fb081768c51ecc291b9f2a7e99b Reviewed-on: https://gerrit.libreoffice.org/26225 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10gtktiledviewer: fix runtime warnings caused by .uno:InsertAnnotation buttonMiklos Vajna1-5/+8
It's a GtkToolButton, but not a GtkToggleToolButton, so don't cast command buttons down unconditionally. Change-Id: Ie7c9bdf6fa8725363e40c1544f4e1e835a559f3a Reviewed-on: https://gerrit.libreoffice.org/26171 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-19In lok_init_2, allow vnd.sun.star.pathname user_profile_urlStephan Bergmann1-1/+2
...which takes a raw filesystem pathname that is internally converted to a file URL (similarly to what is supported for the INIFILENAME and URE_BOOTSTRAP bootstrap variables in rtl::Bootstrap). That way, the gtktiledviewer executable doesn't need to try convert a pathname into a URL. Also adapted various parameter names to make it obvious that URLs get passed, not pathnames. Change-Id: I33ab31fe142d94ee47885033ef48278ef5ff55a2 Reviewed-on: https://gerrit.libreoffice.org/24241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-19tdf#99314 lokdocview: add new userprofileurl propertyMiklos Vajna1-1/+10
So that users of the widget can use a custom user profile, allowing running widgets users and LibreOffice in parallel. Change-Id: I1bd0a8e53aa3216adc721052cf30f0dd174327bd Reviewed-on: https://gerrit.libreoffice.org/24237 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-03-08New LOK_LOADLIB_GLOBAL to let clients control dlopen(RTLD_GLOBAL)Stephan Bergmann1-1/+7
...in LibreOfficeKintInit.h's lok_loadlib, now that RTLD_GLOBAL isn't only needed for UBSan (62b124b2704adf11a63681164d05a8eb49dfb105 "Ensure RTTI symbol visibility for Linux Clang -fsanitize=function,vptr") but also for -stdlib=libc++ on Linux (see <https://whatofhow.wordpress.com/2016/03/01/libclibcabi-on-linux/>). Change-Id: I24ed6612c3d922eba695423d46af5635c77f7077
2016-03-01gtktiledviewer: log .uno:ViewRowColumnHeaders command resultMiklos Vajna1-0/+1
Change-Id: I6d71071371ef54f70613246162c893daa56b7bb9
2016-02-09vcl, libreofficekit: gtk_clipboard_wait_for_contents() may return nullMichael Stahl1-0/+4
Don't crash then. Change-Id: I4980fe4ea56e023cbf303fa43d1e6b383d983d2e
2016-02-04coverity#1351757 Uninitialized pointer fieldCaolán McNamara1-0/+5
Change-Id: I996dc17ba0c01bf23283687dffb563b0eac3a31a
2016-02-04gtktiledviewer: cid#1351757 uninitialized membersMiklos Vajna1-0/+2
Change-Id: Ifb48dc528e95519097477faf79b10e3e7637869d
2016-02-02lokdocview: Handle password protected documentsPranav Kant1-0/+50
Change-Id: I606a1112c8eb4c1cc4596d6947ce1223543cc87c Reviewed-on: https://gerrit.libreoffice.org/21861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-02lokdocview: add a set_visible_area()Miklos Vajna1-0/+3
Change-Id: Ib63959ad64fe52b648e0c0d3fe6d49fb282d57ee
2016-01-28Missing includeStephan Bergmann1-0/+1
Change-Id: I4930837c2a5bd78c16a83dcccde34843d3026618
2016-01-21gtktiledviewer: support pasting PNG imagesMiklos Vajna1-4/+22
Change-Id: Ifaf96dee8b6554282f6a19ac6d6e0d14318aa1f4
2016-01-21gtktiledviewer: Set buttons insensitive in view-only modePranav Kant1-45/+98
These buttons, such as, bold, italic, underline, paste, doesn't make any sense in view-only mode. Lets make them insensitive in view-only mode. Change-Id: I194f6a4d707b72d1d6aa3967aa526092445f0926 Reviewed-on: https://gerrit.libreoffice.org/21642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-01-08gtktiledviewer: hide new view button when it's not supposed to workMiklos Vajna1-5/+9
Change-Id: I91003540f994eeaab78bc66ed6e0df9e9f59ee4b
2016-01-08lool - page border shadow can be disabledMarco Cecchetti1-7/+14
Support for text documents and presentations. Added a command line option for gtktiledviewer: --hide-page-shadow. Reviewed on: https://gerrit.libreoffice.org/21210 Change-Id: I1e427693d7af40cb5731d1730ac5b7c486d45c29
2015-12-17lokdocview: Return if no document is setPranav Kant1-0/+3
For example, when document has been destroyed using lok_doc_view_destroy_document() Change-Id: I531b85018ffa25bcf88fb101c912b9f11b489a97 Reviewed-on: https://gerrit.libreoffice.org/20779 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann1-37/+37
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-09tdf#96317: Add API for copy/paste from/to the widgetPranav Kant1-5/+3
Change-Id: Iac869ddb65cbdd2227f96d047d83159ca7819f11 Reviewed-on: https://gerrit.libreoffice.org/20534 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-12-09tdf#96318: Add searching APIPranav Kant1-33/+13
Clients should now use these APIs to search for text in the widget, rather than executing UNO commands directly on the widget. This allows searching for text in the widget in view-only mode too. Change-Id: I013b6f96e69a634ec33367394d39c0f645a4994d Reviewed-on: https://gerrit.libreoffice.org/20488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-07Let LIBO_INTERNAL_ONLY imply LOK_USE_UNSTABLE_APIMiklos Vajna3-4/+0
Change-Id: Ifbed5e534ba79d32b7188bb7fb7108338b6e124d
2015-11-26cid#1340232 uncaught exceptionMiklos Vajna1-6/+13
Change-Id: Idb80a055aca67a3fb90aef597ace932f47af8e05
2015-11-26cid#1340231 uncaught exceptionMiklos Vajna1-6/+13
Change-Id: I69f2078093c2c23ae0a02a6a292e51fdbdde9ed4
2015-11-24cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-20-Werror,-Wdeprecated-declarationsStephan Bergmann1-0/+4
Change-Id: I7c7d3dda02a3745128a5a125b4b6952e087cdcda
2015-11-19gtktiledviewer: allow setting custom background colorMiklos Vajna1-1/+9
E.g. it helps testing the semi-transparent shadow around Writer pages to append "--background-color yellow" to the commandline arguments. Change-Id: Ib94750e936abe3f41e4982534431fd5115e2c543
2015-11-18gtktiledviewer: allow passing initializeForRendering() argumentsMiklos Vajna1-4/+21
Change-Id: Ic7b52764cf2fedbf73d4dcaaf36d1055b8ee22f2
2015-11-17gtktiledviewer: set author name when inserting a commentMiklos Vajna1-1/+16
Change-Id: Iee66687ce813ff801f29e4568329ed2a39f905ba
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-21 04:53:04 +0000