summaryrefslogtreecommitdiff
path: root/javaunohelper
AgeCommit message (Collapse)AuthorFilesLines
2015-11-24cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann2-3/+3
Change-Id: I083a33e71d1bb9fcef3b287e1db15910779312ab
2015-11-11coverity#1338592 Explicit null dereferencedCaolán McNamara1-4/+2
Change-Id: Ief5c2effbddebe29fc7a4d38ed0af4fed72de40e
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann3-21/+21
Change-Id: I89aa17e66c502e81089f42578b45097f44de4ea9
2015-11-09new loplugin: oncevarNoel Grandin1-8/+4
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin4-12/+10
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: combine nested if statementsNoel Grandin2-18/+11
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-11-05java:no need to explicitly create these constructorsNoel Grandin1-4/+0
the compiler will do it for you Change-Id: I770670e70a43664a87ce28b48fc822d891d8fb41
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin1-2/+2
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23com::sun::star->css in lingucomponentNoel Grandin1-2/+2
Change-Id: Iceef10c51db88b3e85f118a366de45f0f70bbf21
2015-10-15coverity#1326731 Dm: Dubious method usedCaolán McNamara1-2/+6
and coverity#1326732 Dm: Dubious method used coverity#1326734 Dm: Dubious method used coverity#1326735 Dm: Dubious method used coverity#1326739 Dm: Dubious method used Change-Id: Id9d39decf7442b503079ebcfe8c881f0f2fe3eb3
2015-10-15cid#1326115 Unchecked return valueNoel Grandin1-13/+2
and drop some truly bizarre and unnecessary code Change-Id: I105ba8784b6c4179a3cd7ad5bf9a250fd680d64a
2015-10-14cid#1326733 Dm: Dubious method usedNoel Grandin1-29/+25
there is no point in re-decoding a Java String object, it is already UTF-16 Change-Id: Iedc59d457422d32b306782f24cac9b6c2f6b04fe
2015-10-14use early returns to make method easier to readNoel Grandin1-74/+73
Change-Id: Iabaedbd51d3832eff8e7470fd586132c38e1d039
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-3/+3
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-09-30Fix typosAndrea Gelmini1-2/+2
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7 Reviewed-on: https://gerrit.libreoffice.org/18959 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe1-2/+2
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-1/+1
Change-Id: I3561a665cffbdf063c5a8de1225f4ddefd71718f
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin4-18/+18
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09java:Non-synchronized method should not override a synchronized methodNoel Grandin1-2/+2
Change-Id: I46307828757ee1142747c14d2942515340083605
2015-05-08jboolean-related clean-upStephan Bergmann1-3/+3
Change-Id: Iecd03d0343b9b7c3a8b23b5a1e9654148b94d44c
2015-04-27More loplugin:simplifyboolStephan Bergmann1-1/+1
Change-Id: I4749145f12a8f22bc8cd13722ad38096a2c4720e
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann1-1/+1
Change-Id: Ib1b59e56a32c5675fc728624584fb16b79f03469
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann2-4/+4
Change-Id: Ieb830d8216badd75899666f4db565a83e37d11fc
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin2-9/+9
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-20Some more loplugin:cstylecast: javaunohelperStephan Bergmann3-15/+15
Change-Id: If0728af19ba48896678cc3196c922185e403a885
2015-01-09java: simplify array creationNoel Grandin1-7/+7
and remove the need to worry about keeping indexes correct Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-09fix indexesCaolán McNamara1-3/+3
Change-Id: I99d3a715cce203eb2303c76da3b20e6d853a9d23
2015-01-07drop crashrep unused since start of LibreOfficeCaolán McNamara1-1/+0
Change-Id: I3df1216054c133314b2317849744a0a37e9fbc8f Reviewed-on: https://gerrit.libreoffice.org/13733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07javaunohelper: missing includeMiklos Vajna1-0/+1
Change-Id: Ie8427e9ad7a2a03d6698ee95ce0f11fb458c00e3
2015-01-07WaE: -Werror=unused-variable with #define DISABLE_DYNLOADINGCaolán McNamara1-8/+7
and also a leak in that mode with a missing ReleaseStringChars after GetStringChars in one use, and a use after free in the other use where ReleaseStringChars is called Change-Id: I2da0310429daf8519554fd7aaf47bba9f6f0e85c
2015-01-05java: remove more dead codeNoel Grandin1-2/+2
found by looking for unused parameters (in Eclipse) Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05java: remove dead codeNoel Grandin3-8/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-16java: remove OOoRunnerLightNoel Grandin1-1/+1
and just use OOoRunner, there is no point in having a stripped down jar, the cost of firing up the Java VM completely dwarfs any benefit of having a smaller jar. Change-Id: Ibcc3c5bd6e9b9c918041142dd32db0ea5dddc25b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-12-15java: remove some unused fields and variablesNoel Grandin3-3/+3
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15silence coverity#705667 Resource leakCaolán McNamara1-9/+7
still leaks on usual success case of course Change-Id: Ia6e0f61b5a08271c03690bbb1c0af59081bea663
2014-12-15stronger checks when creating Java UNO componentsNoel Grandin1-9/+41
check the visibility of construction method at load time for Java UNO components. This means that we get more informative errors at startup, instead of failures much later on when we actually create the component. Change-Id: I08cd16875cf53cfeeef7e8954ecd0d3177d70eb5 Reviewed-on: https://gerrit.libreoffice.org/13446 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: remove some unnecessary interfacesNoel Grandin1-4/+1
Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8 Reviewed-on: https://gerrit.libreoffice.org/13435 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11java: reduce visibility of fields and methodsNoel Grandin1-2/+2
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: improve use of WrappedTargetException to set cause properlyNoel Grandin2-6/+6
since we introduced the new constructors that pass the cause all the way up to java.lang.Throwable. Also simplify some exeception printing sites, because Throwable will correctly print out child exceptions for us. Change-Id: Ibbecce3c6f971fbc80d6de2052ab4f33a4503c0a
2014-12-03Fold URE: WindowsStephan Bergmann1-2/+1
...assuming the delayLoadHook in cli_ure/source/native/native_bootstrap.cxx is no longer necessary and loading of cppuhelper from the program dir cannot fail regardless in whatever scenario the cli_cppuhelper library itself is loaded. Change-Id: I13f32b327bca4cce9780864f5e57cdad3860afe5
2014-11-28Fold URE: Linux ure/share/java/* -> program/classes/Stephan Bergmann1-1/+1
Change-Id: I86864f832c0377d307cfa0b2c137f452e43797eb
2014-11-28Fold URE: Linux ure/lib/* -> program/Stephan Bergmann1-1/+6
The ../../../program/ links in the URE jar Class-Paths are a temporary kludge (and juh.jar had lacked adaption for Mac OS X). Change-Id: I2542d8a582866485dd61c05df3fc6b4b39a8403d
2014-11-25java: remove some comment noiseNoel Grandin2-14/+0
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25java: final fields that can be staticNoel Grandin1-1/+1
found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18java: remove some unnecessary castsNoel Grandin1-38/+38
Change-Id: I30f316ee87bd8fe4bc56f6e928fb36d3ab0c8e94
2014-11-18java: make fields final where possibleNoel Grandin8-16/+16
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: reduce excessive code indentation levelsNoel Grandin1-92/+93
by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>