summaryrefslogtreecommitdiff
path: root/io/source/acceptor
AgeCommit message (Collapse)AuthorFilesLines
2018-01-11loplugin:useuniqueptr cppu,idlc,io,ucbhelperNoel Grandin1-11/+9
Change-Id: I6d8c24fabd52b39c66ce0b88b547df7ec85dad76 Reviewed-on: https://gerrit.libreoffice.org/47725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin1-3/+1
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall fix functionsNoel Grandin1-1/+1
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: ioStephan Bergmann2-4/+4
Change-Id: I68e0ebc5a1585d2f55a4061edd8ab197f437b6a2
2017-09-22loplugin:flatten in framework..packageNoel Grandin1-20/+17
Change-Id: Ide8a97eae6e2fdc7d2dcccba1480ac55a9b555bc Reviewed-on: https://gerrit.libreoffice.org/42593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-31loplugin:oncevarNoel Grandin1-6/+2
extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-22loplugin:unusedfields in ioNoel Grandin1-2/+3
Change-Id: I8be28fa2ed1e005c76eafc60746620338c8a49ac Reviewed-on: https://gerrit.libreoffice.org/40291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12clang-tidy readability-delete-null-pointerNoel Grandin1-8/+2
which in turn triggered some loplugin:useuniqueptr Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64 Reviewed-on: https://gerrit.libreoffice.org/38281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert cppuhelper and io from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: I56d49e1ce9f1c070fedcabb8f1637d17dee1083b
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin1-2/+2
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I1488e2147fa0cd4a821eb5bfe172a58a4e396ace Reviewed-on: https://gerrit.libreoffice.org/35224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-06Add missing #includesStephan Bergmann3-1/+5
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-02unnecessary use of OUStringBuffer in throwing exceptionsNoel Grandin1-16/+11
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f Reviewed-on: https://gerrit.libreoffice.org/33788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann3-70/+24
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ioStephan Bergmann1-0/+1
Change-Id: I2d8b69454217bbbc9542cced8ce85269e3872662
2016-12-13OSL_TRACE->SAL in framework..salNoel Grandin1-9/+0
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05loplugin:unnecessaryoverride (dtors) in ioStephan Bergmann2-10/+0
Change-Id: I5c787d70fb3388e649e751d2b801765d567249c7
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann3-3/+3
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin1-4/+4
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07clean upStephan Bergmann1-2/+2
Change-Id: Ibf0df59d2773a3356b21e1b4c70889511b373e56
2016-04-07Revert "reduce unnecessary realloc'ing"Stephan Bergmann1-6/+4
This reverts commit 9f6e6fabcd5718e0b65437c5ce398e520f47aae1, which is wrong, as it would cause the functions to now try to read aReadBytes.getLength() bytes if that is initially larger than nBytesToRead.
2016-04-01reduce unnecessary realloc'ingNoel Grandin1-4/+6
Change-Id: Ic597814706573576a0ba330a69a7a38aa97e5224 Reviewed-on: https://gerrit.libreoffice.org/23694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock1-1/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-24cppcheck: noExplicitConstructorCaolán McNamara3-4/+4
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin1-2/+1
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10Replaced for_each and algorithm include by range based loop and exception.Mario J. Rugiero1-2/+3
Since the only thing used from algorithm was std::for_each, and std::exception was being used without including it. Change-Id: Ida415bfbcae2b14811183a6afa46b6f6e1ac6ab2 Reviewed-on: https://gerrit.libreoffice.org/19864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-4/+4
Change-Id: I04ceb5b1514a1d0bf123a1cded5e1aac3e8dde2f
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann1-5/+5
Change-Id: Ifcfb6792138802f4150ccb966927818fbd3f64e3
2015-11-04use uno::Reference::set method instead of assignmentNoel Grandin1-2/+1
Change-Id: I11822c50fa66d038a3d6f38054ab35c2e613f077
2015-10-23com::sun::star->css in ioNoel Grandin3-52/+52
Change-Id: I4a0cd4b29db91584c23148d659846c71b90b0d65
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann3-17/+17
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann1-10/+10
Change-Id: I3adb8d5664ecd8fafccc7bae0656f15100484422
2015-08-19io: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe3-6/+6
with the variadic variants. Change-Id: Iad03db6b729a785ab8b29a69943fa45f5a36b21b Reviewed-on: https://gerrit.libreoffice.org/17849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-14loplugin: defaultparamsNoel Grandin2-4/+2
Change-Id: I320eb6149793689c496b14090e8e0243397d01ba
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann3-3/+3
Change-Id: Ia282c33c70977e3c9e8f1c6fd86bee2fa6eca5c3
2015-05-08Clean up passing Boolean value to osl::Socket::setOptionStephan Bergmann1-1/+1
Change-Id: I6757f2bc7e8b4ff9d7b3ebda88da35a5d7b93655
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-2/+2
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-29Clean up template-parameter-dependent C-style castsStephan Bergmann1-1/+1
Change-Id: Ia1ab134a0afbeeb3ae40264bd4233a47df26b734
2015-01-20enable tcpNoDelay for loopback connections automaticallyNoel Grandin1-1/+5
it can make a significant speed difference for applications talking to the office binary via UNO Change-Id: If6e901908fe6a6119ac1fd0bf8feebabe5602ff7 Reviewed-on: https://gerrit.libreoffice.org/13856 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara1-2/+2
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl3-0/+3
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin3-3/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-30fdo#68849: Add header guards to all include filesJens Carl1-0/+5
Added header guard to files in directories i18npool/, include/, and io/ Change-Id: I7ba5b5f0ffdf5dedb8fd40e8efa06936e7c23591 Reviewed-on: https://gerrit.libreoffice.org/9558 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin1-4/+4
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin3-14/+10
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-04-23io: sal_Bool->boolNoel Grandin4-24/+24
Change-Id: I136c98cbe15d1c6629028392a9573066320b3a04
2014-04-18Typo: s/shure/sureTor Lillqvist1-1/+1
Change-Id: I1c55d3ee8be06deb6d48a6ad5cd30d170c8b9dbb