summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2017-01-10loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ibe11923601760ded53a277c48631e4893606b2d6 Reviewed-on: https://gerrit.libreoffice.org/32875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10defaults are good enoughCaolán McNamara1-1/+0
Change-Id: I4520e00b8c48938a4ff1ed89e3c61948d886972c Reviewed-on: https://gerrit.libreoffice.org/32889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09second arg of deformed copy ctor isn't usedCaolán McNamara1-1/+1
except in the qa test Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526 Reviewed-on: https://gerrit.libreoffice.org/32890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09New loplugin:externvar: i18npoolStephan Bergmann1-2/+2
Change-Id: Id38d1fde0e0f6e08899e83697f586d513b635aad
2017-01-09New loplugin:externvar: salStephan Bergmann5-0/+22
Change-Id: Iefc33784f21e7a0b88c8d6308618926e38ab8554
2017-01-09defaults are good enoughCaolán McNamara1-8/+3
and protected isn't necessary Change-Id: I6219632fe1da36d484864c2500e9ac14978f2cb8
2017-01-09Related: coverity#1371305 unnecessary inheritenceCaolán McNamara4-18/+6
SvDataCopyStream used to do extra Load/Save things that are long gone, so there is no reason for the common base anymore Change-Id: Ib321021002adb480bb96298f199141dc3fe2ec2b Reviewed-on: https://gerrit.libreoffice.org/32851 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09coverity#1371227 Missing move assignment operatorCaolán McNamara2-0/+24
Change-Id: I2de6b5e2910ff570c08e662769d5e6ee188825a7 Reviewed-on: https://gerrit.libreoffice.org/32843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht2-2/+5
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-08XSubToolbarController is only used by SvxColorToolBoxControlMaxim Monastirsky2-11/+5
Change-Id: I10c31aa9c773649c99b52c2d34cb648a37bf42ac
2017-01-08There is no SfxToolbox classMaxim Monastirsky1-1/+0
Change-Id: I30dd797921420a4009455841052f5c5436f4a93b
2017-01-07default copy ctor and assignment operator are good enoughCaolán McNamara4-38/+0
and block default move equivalents Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
2017-01-07Typo: Acess->AccessJulien Nabet2-3/+3
Found thanks to Buovjaga Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3 Reviewed-on: https://gerrit.libreoffice.org/32810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07lok: refill font list if emptyHenry Castro1-0/+1
After preinit stage the font list is empty when creating documents. Reviewed-on: https://gerrit.libreoffice.org/32108 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: sd/source/ui/docshell/docshel4.cxx svtools/source/control/ctrltool.cxx Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415 Reviewed-on: https://gerrit.libreoffice.org/32796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-01-07coverity#1398371 Useless callCaolán McNamara1-4/+0
Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
2017-01-05check "#ERRxxx!" constants for accepted error values, tdf#105024 follow-upEike Rathke1-0/+67
Change-Id: I9a11695710baa2f4e022c8e07f01b962cfabe2e7
2017-01-05finish moving ImageList to frameworkCaolán McNamara1-42/+0
Change-Id: I9d9f292066321174af8b0bcd96c58de5fc7566b8
2017-01-05move ImageList to frameworkCaolán McNamara1-1/+1
this can probably be replaced by a std::*map<Image> Change-Id: Ic36c5f406f5ea51cb9ff135858e319e0877179c7
2017-01-05move CommandImageResolver out of vcl and beside its only userCaolán McNamara1-58/+0
Change-Id: I2bd70d87bb12d5750d8427b8a8fe786cfce8961b
2017-01-05move ImageType enum out of CommandImageResolver.hxxCaolán McNamara3-10/+12
Change-Id: I0b4da9a4edff8d0f9016fbd79cb205bdf2b35268
2017-01-05oox: rename misleadingly prefixed m_pShapeStyleMichael Stahl1-1/+1
Change-Id: I07fdc4fff2dd05b57d1a0635d0bed8d1afd6dc58
2017-01-05No need for heap-allocated OUStringBufferStephan Bergmann1-1/+1
Change-Id: Id2dbe3ecce9eba2eefab90f43b9a2a6894839cfb
2017-01-05ImageList doesn't need to be a friend of ImageCaolán McNamara1-1/+0
Change-Id: I3bfe3b6fcd033f1cab503934cf4442adb0143939
2017-01-05Clean up a usage of OUStringBufferStephan Bergmann1-1/+1
Change-Id: I8435865f1a67a3a6d889c1b8a3d30e632ffc61fd
2017-01-05drop newly unused InsertFromHorizontalBitmapCaolán McNamara1-5/+0
Change-Id: Ia0b0032bf261712be30ac23c8e5ce993011b2e5c
2017-01-05unwind RID_SVXBMP_FRMSEL_ARROWS imagelistCaolán McNamara1-3/+18
Change-Id: Id74ebd81b3688383271b581b69734fecfe3eb079
2017-01-05flatten and simplify this resource hierarchyCaolán McNamara1-2/+4
Change-Id: I622dae5f36b44c08e597d94fe8184ad92504d038
2017-01-05Replace side-effect--only uses of makeStringAndClear() with setLength(0)Stephan Bergmann2-2/+2
Change-Id: Iaf8011f1bd6a10b324653899b7f51458f7d0b68a
2017-01-05tdf#102059 NotebookBar accessible using F6 keySzymon Kłos1-0/+6
Change-Id: I873c49d8c0557eb3702de921fb5d2281acfed526 Reviewed-on: https://gerrit.libreoffice.org/32459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-01-05Don't exclude a var from loplugin:salbool merely because of use in >>=Stephan Bergmann1-3/+3
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-05Base SvxLineEndWindow on ToolbarPopupMaxim Monastirsky1-56/+0
Fixes size and position issues under gtk3/wayland Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
2017-01-05Prefix SvxLineEndWindow membersMaxim Monastirsky1-5/+5
Change-Id: I0cfe88c65cc75757938a9f8004c219fbe39f88dd
2017-01-05Get rid of SvxLineEndWindow resizingMaxim Monastirsky1-6/+0
Change-Id: I0135f084f64b9709688f0f9205940baf193c5d83
2017-01-05Use command labels for the color popup titleMaxim Monastirsky1-10/+0
Change-Id: I2f61e25ef4451775320f8fa1761a951ab94af7d5
2017-01-04last bitmaps that pMaskColor arg was used on converted to true transparencyCaolán McNamara1-1/+0
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04drop unused SplitWindow::ImplDrawButtonRectCaolán McNamara1-1/+0
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04all users of InsertFromHorizontalBitmap use all argsCaolán McNamara1-4/+4
Change-Id: I458036b084645af509d64a78f5389415dfc4115a
2017-01-04follow up remove unused autohide leftoversCaolán McNamara1-4/+0
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04drop AutoHide codeCaolán McNamara1-5/+0
only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04tdf#105093 sd PDF export: handle embedded videosMiklos Vajna2-1/+5
In practie embedded files always have a temp file URL, so from the PDF export's point of view they are still URLs, just at the end the contents of the URL is embedded to the PDF, not just the URL itself. So add a SetScreenStream() that's similar to SetScreenURL(), but it's for embedded, not linked videos. Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781 Reviewed-on: https://gerrit.libreoffice.org/32727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04tdf#97228 Moved class ControlCacheKey in a seperate include file.Huzaifa Iftikhar1-53/+0
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used only by vcl therefore it is moved to a seperate include file named ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx. This header file contains the definition of the the class ControlCacheKey. Since this class uses an object of another class named Size which is defined in gen.hxx therefore this is included in ControlCacheKey.hxx. All the files that references the class ControlCacheKey includes ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx" Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd Reviewed-on: https://gerrit.libreoffice.org/32422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04Related: tdf#104841 sw PDF export: handle linked videos on non-first pagesMiklos Vajna1-1/+1
Be explicit about the page number, this way a video on the second page doesn't end up as an annotation for the first page. (In the Impress case each slide is exported separately, so there this wasn't a problem.) Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6 Reviewed-on: https://gerrit.libreoffice.org/32696 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-03tdf#39674: translated German to English in svdtrans.cxxkerem1-2/+2
Change-Id: Ic46e747a9dbec99e6037c6b35e175ce5b1efdd82 Reviewed-on: https://gerrit.libreoffice.org/32594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-03SetPin and IsPinned are in an always-false circular isolated relationshipCaolán McNamara2-6/+0
Change-Id: I4fb3aaa8a5e8c62091fbc542deae6af3a113a608
2017-01-03WB_PINABLE isn't set anywhereCaolán McNamara1-1/+0
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03Mark [Scoped]VclPtrInstance as SAL_WARN_UNUSEDStephan Bergmann1-2/+2
Stack-allocated instances of the non-Instance [Scoped]VclPtr variants are occasionally used merely for the side-effect of holding objects alive (like css::uno::Reference and rtl::Reference, which are also not SAL_WARN_UNUSED for that reason). Change-Id: I37ebfaf028a646cb2777c0baf0d99992057a22bd
2017-01-03Hold SfxInfoBarWindow by VclPtrStephan Bergmann2-4/+4
In SfxInfoBarContainerWindow::removeInfoBar, disposeAndClear is already called on the removed member (once found), so the ScopedVclPtr (also calling disposeAndClear when going out of scope) should not be necessary. Change-Id: Ibf4d19ebd5f1a6217e1d18ef0458c9b865667898
2017-01-03default copy ctor and assignment operator are good enoughCaolán McNamara8-128/+0
and block default move equivalents Change-Id: I360860512d2c88f8688685f4e751ded6335549da Reviewed-on: https://gerrit.libreoffice.org/32656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-03Move documentation for parameter of SfxObjectShell::GetTitle() to include fileTor Lillqvist1-0/+39
A re-design of this API would be a good idea. Is this function ever called with some specific max length that would not be one of the magic values? Probably the sanest would be to turn the magic value constants into a normal (scoped) enum, and have two separate functions: One that takes no parameter and returns the whole title (and then let the caller take care of truncating as necessary), and one that takes such an enum and returns a correspondingly mangled title. The less magic and defaulted parameters the better. Change-Id: I9e3aa95fae981c5ed48300b753556fa9074c1166
2017-01-02coverity#1371220 Missing move assignment operatorCaolán McNamara1-4/+6
Change-Id: Ie2947ea621da7ffc6c9530f007e1acdd4efb50cb Reviewed-on: https://gerrit.libreoffice.org/32650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>