summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2021-03-11register navigator individually in each module that it exists inCaolán McNamara1-17/+11
instead of globally. This makes the navigators the same as everything else and easier to deal with. Change-Id: I882612e73d36485b84161a2d3fbc1188f734c0fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112244 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use SharedPanelContainer typedefCaolán McNamara1-1/+1
Change-Id: I7ecd7d275dbff31654aabae326be175928dfe84d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112279 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11allow throwing away size cache of hosted containerCaolán McNamara1-0/+1
Change-Id: I9d6eb1af80526c4853d695af3e269187569a538c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112271 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fetch/set/clear primary selection without intermediate vcl::WindowCaolán McNamara2-4/+3
the intermediate layer doesn't do anything useful Change-Id: I00564f43db8914445ea4013c6f387c7d7c783427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09Drop "32" from names of SbxArray methods taking 32-bit indicesMike Kaganski1-19/+19
... a leftover from times when there were methods for 16-bit as well as for 32-bit indices. 16-bit indices were removed in commit 62f3f3d92aa204eaaa063b30d7ade44df501b997. Change-Id: Idf8b1160e68e8b303cf75ea79dd7dbb3bd00275d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09Missing "template" (clang-cl)Stephan Bergmann1-1/+1
> In file included from C:/lo-clang/core/vcl/win/dtrans/FmtFilter.cxx:37: > C:/lo-clang/core/include\systools/win32/comtools.hxx(72,30): error: use 'template' keyword to treat 'QueryInterface' as a dependent template name [-Werror] > : COMReference(p.QueryInterface<T>(t)) > ^ > template Not sure why this only started to show up now with my clang-cl build on Windows. (The Clang warning itself is available ever since <https://github.com/llvm/ llvm-project/commit/4e7a2c09b22bb04819702ac6b8ea8b59ca396fa5> "Improve recovery (error + fix-it) when parsing type dependent template name without the 'template' keyword" from 2011; its "Also the error is downgraded to an ExtWarn in Microsoft mode." implies that not requiring the "template" here is a non- standard MSVC extension.) Change-Id: I4f8e9d6fa80871fdd212417c1b935d76ffde34c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112192 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-09defer getting toplevel for color picker until we need itCaolán McNamara3-8/+14
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-09fontwork: insert in the center of LOK viewSzymon Kłos1-0/+2
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112163 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-08tdf#140796: Wrong English string for U+2060 characterJulien Nabet1-1/+1
Rename "No-width No ~Break" to "Word ~Joiner" + replace pattern "ZWNBSP" variable names by "WJ" Change-Id: I95a874a9d2d20a30d2c4c3add6041adbe72d872c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112055 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-07move queue_resize to baseclassCaolán McNamara1-1/+2
Change-Id: I7f34037fc2c48168a56918c83ac7323febfe7486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-07ref-count SdrPageNoel8-20/+17
which simplifies ownership handling, particularly with regard to undo/redo Change-Id: Ie8f300ebfdae6db3c06f78a87e35a07497d6b825 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06drop StyleSettings::GetColorValueSetMaximumRowCountNoel Grandin2-5/+3
pull it into the only place it is used. Change-Id: I5923f1599e033d893cebea606138c53ab2cd02fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-06Related tdf#128469 - Customization of tab dialog buttonsHeiko Tietze1-1/+3
Change-Id: Ib7d4bbc6d78ac93510835e061640bfcd99248195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111987 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-05use container_focus_changed instead of toplevel_focus_changedCaolán McNamara2-8/+3
seeing as its the same thing, but available one level of inheritance down Change-Id: Ieedbf2bc8cea09cdafff1514eac5c35b85c2fdd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112023 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-05add a callback for when a container gains or loses focusCaolán McNamara1-0/+11
Change-Id: Id8e8e59547280297db9140a840228f62b75593ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...apparently ever since introduced in d2cd1fad73b97e62443a215c84b7b5d5ee74a818 "split and move MenuBar BubbleWindowManager to vcl" Change-Id: I479612969e9307daaa45b75d006d3929342b72aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04SidebarPanelBase is always created with a PanelLayoutCaolán McNamara1-5/+4
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04allow slide transition panel to be narrowerCaolán McNamara1-0/+1
Change-Id: Ib1fc71fe189b199fef6feb4f5f72f4513dfded97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111965 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-04jsdialog: single activation property for treeviewSzymon Kłos1-0/+1
Change-Id: Iaaeab7f14f1a05c38f41c4beb774a0980844fdb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110621 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111959 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-03-04Improve unit test accuracyMike Kaganski1-8/+4
I didn't take clock resolution into account when created the test, and it failed for me occasionally because the value was slightly less than expected. The typical system tick resolution is documented at https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/high-resolution-timers Change-Id: Ie48b10d15b14f9ac7d292a2cc9916bcbfff44b6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111946 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-04Related tdf#140762 Add texts for "Border style" toolbar itemMichael Weghorn1-0/+2
Make 'GetLineStyleName' a static method of 'SvtLineListBox' and use it to retrieve and set the names for the items used in the "Border Style" dropdown button in Calc's formatting toolbar. This ensures that the corresponding names are available as tooltips and for screen readers. Change-Id: I6b775e1bcd62deefd8a8a6a778dcee426bf3a1f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111905 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-04tdf#140762 Set texts for items in "Borders" dropdown buttonMichael Weghorn1-0/+5
Associate textual descriptions with the images for the items in the "Borders" dropdown button in Calc's formatting toolbar. This e.g. makes them show up as tooltips when hovering over the images with the mouse and makes them accessible to screen readers (e.g. Orca with the gtk3 VCL plugin now says those texts instead of just saying "item 1", "item 2",...). This also adds the strings for the items where no corresponding ones exist yet. Change-Id: I02ce8abfa4aa59e06ca1ab45aff0685a19c323f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111871 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-04tdf#140762 Move RIDs related to borders to include/svxMichael Weghorn1-0/+15
They'll be reused for the items in the "Borders" dropdown button in Calc's formatting toolbar in a subsequent step. Change-Id: I895d787d185a69f7aa7d3db3c490271184152ddb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111870 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-03-03lok: add batch mode option to load the documentHenry Castro1-0/+1
When the LibreOffice Kit is active by default is set to headless mode, with the flag "DialogCancelMode::Silent", according to the documentation it should close the dialog, but it was changed for dialog tunneling. However the dialog tunneling is being deprecated, and in order to not produce any regression, it will be used temporary a new state "DialogCancelMode::LOKSilent", to disable any dialog interactivity. Change-Id: I3b6cce38c37f75dc1b24dda352f6caec19438ff1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111087 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5f3fbb019bd79bd57eed94e01bd2202efd9a0c06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111319 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-03-03make all these headers pragma onceCaolán McNamara15-48/+16
Change-Id: Ic7968abf807c080636ef37a690990a962f702d35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111815 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03vcl/floatwin.hxx can be toolkit only nowCaolán McNamara1-4/+5
Change-Id: Ifd8f58771ea6f9212a0dca7d4550c86ebecd9333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111814 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03xmlsecurity: improve handling of multiple certificates per X509DataMichael Stahl1-1/+12
It turns out that an X509Data element can contain an arbitrary number of each of its child elements. How exactly certificates of an issuer chain may or should be distributed across multiple X509Data elements isn't terribly obvious. One thing that is clear is that any element that refers to or contains one particular certificate has to be a child of the same X509Data element, although in no particular order, so try to match the 2 such elements that the parser supports in XSecController::setX509Data(). Presumably the only way it makes sense to have multiple signing certificates is if they all contain the same key but are signed by different CAs. This case isn't handled currently; CheckX509Data() will complain there's not a single chain and validation of the certificates will fail. Change-Id: I9633a980b0c18d58dfce24fc59396a833498a77d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111500 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-03xmlsecurity: improve handling of multiple X509Data elementsMichael Stahl1-8/+13
Combine everything related to a certificate in a new struct X509Data. The CertDigest is not actually written in the X509Data element but in xades:Cert, so try to find the matching entry in XSecController::setX509CertDigest(). There was a confusing interaction with PGP signatures, where ouGpgKeyID was used for import, but export wrote the value from ouCertDigest instead - this needed fixing. The main point of this is enforcing a constraint from xmldsig-core 4.5.4: All certificates appearing in an X509Data element MUST relate to the validation key by either containing it or being part of a certification chain that terminates in a certificate containing the validation key. Change-Id: I5254aa393f8e7172da59709923e4bbcd625ec713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111254 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-03xmlsecurity: remove XSecController::setPropertyId()Michael Stahl1-2/+3
Change-Id: Iab5a59af73048765ead718fe941d6dec933a7060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111252 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-03xmlsecurity: XSecParser confused about multiple timestampsMichael Stahl1-0/+2
LO writes timestamp both to dc:date and xades:SigningTime elements. The parser tries to avoid reading multiple dc:date, preferring the first one, but doesn't care about multiple xades:SigningTime, for undocumented reasons. Ideally something should check all read values for consistency. Change-Id: Ic018ee89797a1c8a4f870ae102af48006de930ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111160 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-03xmlsecurity: replace XSecParser implementationMichael Stahl3-1/+25
Implement Namespaces in XML and follow xmldsig-core and XAdES schemas. Change-Id: I03537b51bb757ecbfa63a826b38de543c70ba032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110833 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-03tdf#116983 tdf#136175: retry if failedMike Kaganski1-0/+42
Debugging the test case from the latter bug report shows that indeed the call to OleGetClipboard may fail first time, as jasonkres had suspected in the former bug. So follow the suggestion in tdf#116983, and retry the failing calls several times in case of failure. Many thanks to Telesto for preparing a clear bug report with reliable test case. Co-authored-by: jasonkres Change-Id: Ib3c497da830bc5faac586bcfe1eededa54bfa117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111825 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-03move ImplDockingWindowWrapper out of public headerCaolán McNamara1-104/+1
and down to where it is needed Change-Id: Ieded4a1b5d10ab7f9a57c2694a4684bdecc77fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03bubblewindow.hxx can be a private vcl headerCaolán McNamara1-49/+25
Change-Id: Iaf79521e812ec32f6e0b9276ad778fe7abc836a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03split and move MenuBar BubbleWindowManager to vclCaolán McNamara1-0/+58
Change-Id: I1d0f4b7d56845a77e979199917c5d9c849b76c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03move BubbleWindow to vclCaolán McNamara1-0/+55
Change-Id: I2481a9882dc66337b35b758fb4f73978df5af541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03keep ImplDockingWindowWrapper DLL_PRIVATE and use DockingManagerCaolán McNamara1-1/+2
to get the FloatingWindow instead Change-Id: Ifedfe3cc9b024069eef5ea9b7952f2dc2f58b645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111819 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-03drop TransparentType::Color usageNoel Grandin1-6/+3
which is dead code, since we convert to TransparentType::Bitmask in the constructor of BitmapEx Change-Id: I047b7d25317c4be4d17a8b0db9a90ec101875c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02Related tdf#128469 - Change label of Standard buttonHeiko Tietze1-0/+1
Change-Id: I1bfc7cbfa71cf76d1cd76db83d8a7f951535e47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-03-01loplugin:refcounting in sfx2Noel4-16/+19
Change-Id: Iba7b1be688f1a7c1b0947c2423cc1965362386b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01loplugin:refcounting in svxNoel1-1/+1
Change-Id: I87b1d0684e6e8921b222f76a13a36706c0eb8c87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111750 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-01Added .uno:MoveShapeHandle uno commandmert1-1/+4
This is now only available for Draw/Presentation It will allow interactive dragging/resizing operations via the command. Later it will be implemented for other modules too. Change-Id: Iaed7d25cf4035591083e779c13a6f0227a3b564f Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111508 Tested-by: Jenkins
2021-03-01IPrioritable.hxx can move into private headersCaolán McNamara1-54/+0
Change-Id: I3046d91d18363e61fd4c94a94291ad8b2e97fd70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-01NotebookbarPopup.hxx can move into private headersCaolán McNamara1-57/+0
Change-Id: I5c887863ded85e68003ed935cb64c4540ce13117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-01tdf#116136 don't show statusbar selection mode control tooltipJim Raykowski1-0/+1
in print preview. This patch also sets the control image disabled when in print preview. Change-Id: I497af2a50621ed6611a31f9b17b682caa82fa260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111294 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-02-28devtools: on demand create the content of tab pagesTomaž Vajngerl2-1/+6
Until now all the tree views in each tab page were populated at once when the object was inspected. With this change, the tree views are filled on demand when the user enters a tab page, and is cleaned when the user leaves a tab page. Change-Id: I7f2ff89ab4c09412563b71e6524d4529318dee85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111533 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-28devtools: object inspector toolbar and object stackTomaž Vajngerl2-2/+20
This change adds a toolbar to the object inspector with buttons for inspect (which just links to the same action added to the context menu) and back. Back uses the newly added object stack to return to the previously inspected object. Only the objects which we used the "inspect" command in the object inspector tree are added to the object stack. Change-Id: Icb5b6e841200d6e0e41e260092a195fc84729d0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111532 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-27hide some FloatingWindow detailsCaolán McNamara4-6/+6
Change-Id: I1dc8cb7adc9a26efb74634353b9d75286e31ebb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-27drop unneeded SetPosSizePixelCaolán McNamara1-1/+1
unneeded since one of the multiple Window::SetPosSizePixels was renamed to setPosSizePixel Change-Id: Ib86229f5f195cb38d06fc7c12c107a354b8685f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111662 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-27loplugin:refcounting in accessibilityNoel1-1/+1
Change-Id: I0a17e149487cf05fb5e6d004a6402a2a5215a79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111632 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 08:09:02 +0000