summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2018-07-05tdf#117901 Write signature line images as emf to ooxmlSamuel Mehrbrodt2-1/+7
Change-Id: Idbf60be3cef2d9dde454da0279d2810488b1e157 Reviewed-on: https://gerrit.libreoffice.org/56871 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-07-04Make brittle SortedAutoCompleteStrings ownership handling more explicitStephan Bergmann1-1/+19
Change-Id: Ieaf2231a84d97528bb1b9a410c4ee0c38966dd27 Reviewed-on: https://gerrit.libreoffice.org/56950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-04sw HTML export: use PNG fallback + RTF native data for all images for ReqIFMiklos Vajna1-0/+3
ReqIF says the image should be either PNG or has a PNG fallback and then it can be something else. We used to convert images to PNG to avoid writing any native data, but results in data loss. So instead: 1) Write the original image as an RTF fragment, so it's not lost. 2) Some ReqIF parsers expect an RTF fragment even for PNG, so make sure we always write the RTF fragment, even if that means a small duplication. Change-Id: Ida0fcaa58d56b9e11f81992307505599807353b5 Reviewed-on: https://gerrit.libreoffice.org/55430 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-04Notebookbar:Context for printpreview is now workingKshitij Pathania2-1/+4
Also the context stuff is now working well even after print preview is set Change-Id: Ia43f512394cf4d162b4019257c039aecb664df22 Reviewed-on: https://gerrit.libreoffice.org/56740 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-04lok: sc: ctrl-clicking links doesn't workMarco Cecchetti1-1/+1
I think there is no reason for not execuring the code below if ((bDouble || bIsTiledRendering) && .... ) { ... } for both desktop and online. So since the code for open the clicked URL is below such if clause, I changed the code so that we return only when it's really a double click event. Moreover I reverted back the code for executing the list validation pop-up to its original place, since there is no more the need to have it executed in two places. Change-Id: Idbec2e6e45cd7ee8282005169e1132a11d4cac33 Reviewed-on: https://gerrit.libreoffice.org/54151 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-07-04Make ThreadPool::pushTask take param by std::unique_ptrNoel Grandin1-5/+6
And fix leak in XclExpRowBuffer::Finalize, was not freeing the synchronous task it creates Change-Id: Id1e9ddb5d968e6b95d9d2b5ca0c9e50774580182 Reviewed-on: https://gerrit.libreoffice.org/56874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03no need to switch models in the SvTreeListBoxNoel Grandin1-2/+0
since we're replacing it completely anyhow. which means we can remove DisconnectFromModel Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087 Reviewed-on: https://gerrit.libreoffice.org/56849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03Fix typosAndrea Gelmini1-2/+2
Change-Id: Ieacea4f6f53a0e55876a8b84d0dfeea8e308035d Reviewed-on: https://gerrit.libreoffice.org/56712 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03use std::unique_ptr for CreateObjectSpecificViewContactNoel Grandin23-23/+23
Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523 Reviewed-on: https://gerrit.libreoffice.org/56823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03return by std::unique_ptr from CreateViewDataNoel Grandin2-2/+2
Change-Id: I83572646fb2ebe8afe8cff581e574375798e74f7 Reviewed-on: https://gerrit.libreoffice.org/56818 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin3-5/+4
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02Export data transformations to odfVikas1-0/+8
Change-Id: Ie36aef4a4ee550a1bb5407305f13726d55eeea58 Reviewed-on: https://gerrit.libreoffice.org/56665 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-02tdf106792 Get rid of SvxShapePolyPolygonBezierArmin Le Grand3-90/+25
SvxShapePolyPolygonBezier was an implementation for the UNO Shape group of polygons with bezier parts (filled/unfilled/ closed/open), e.g. com.sun.star.drawing.OpenBezierShape. It was differing from SvxShapePolyPolygon just by supporting drawing::PolyPolygonBezierCoords instead of the simple drawing::PointSequenceSequence and some details. This leads to problems - the ShapeType *does change* e.g. when you edit a non-bezier Shape in Draw/Impress and change parts to curve (also when closing, see ShapeTypes above). This is why SvxShape::getShapeType() already detects this identifier by using thze internal ShapePolyType (e.g. OBJ_PATHLINE). So there is no reason to have two separate UNO API imple- mentations for sthe same type of SvxShape at all. Get rid of the extra one and unify this implementation detail. Also cleaned up double basegfx tooling for conversions of UNO API Poly/bezier data and B2DPolygon. Adapted test for "tdf113946.docx", see comment there. Adapted test for "tdf90097.rtf", see comment there. Also needed to use the Linux values, also check comment there. Adapted test for "tdf105127.docx", see comment there. Adapted test for "tdf85232.docx", see comment there. Had to fic a problem with test for "tdf96674.docx"- the adaption of the RotateAngle for line objects goes havoc together with the UNO API when scaling is involved. That old aGeo rotate stuff just kills the existing rotation due to numerical inprecise stuff. The UNP API - in trying not just to apply a rptation, but manipulate the existing one then goes wrong in not re-getting the current rotation value anymore. ARGH! This is the original reason for the ols tdf#96674 task - i doubt that the additional code to make a line not exactly hor/ver is needed. Checked and it is not needed, thus removed the change from tdf#96674 in shape.cxx. Change-Id: I2bb8d4cfe33fee3671f3dad60e5c18609a394f9d Reviewed-on: https://gerrit.libreoffice.org/56614 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-02loplugin:constantparamNoel Grandin3-4/+2
Change-Id: I9fbfa6163c1d4650c52b00dc911972f07fe7c0e5 Reviewed-on: https://gerrit.libreoffice.org/56778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I1c32a6e7e517acc2e8bb3e7898329cb38ed4accb
2018-07-02-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I27512b518bada81c607c5dd73c6e5155ec1b19d8
2018-07-02loplugin:unusedmethodsNoel Grandin10-93/+0
Change-Id: I92665f577bfe39497905063da517a05b8008c3cc Reviewed-on: https://gerrit.libreoffice.org/56743 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02pass OutlinerParaObject around by std::unique_ptrNoel Grandin9-19/+20
SdrText::SetOutlinerParaObject was modified to not check for self-assign, and instead assert because the existing check was no longer possible. Fix bug in SdrUndoObjSetText::Undo(), where it was calling SdrText::SetOutlinerParaObject unnecessarily, because NbcSetOutlinerParaObjectForText already does that. Optimise Outliner::GetEmptyParaObject by creating a new constructor for OutlinerParaObject, so we don't need to copy the new object we get back from GetEmptyTextObject, unnecessarily. Change-Id: I57c475583d6c31658c154e24992b3d587bad9841 Reviewed-on: https://gerrit.libreoffice.org/56730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin3-7/+0
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29test: invoke ODF validator with custom schemasMichael Stahl2-7/+7
This requires a new validator jar for the -m flag to specify MathML schema. Change-Id: If99cf70f386a16a90ba676f8f5ff65a537c9ce56 Reviewed-on: https://gerrit.libreoffice.org/56487 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-06-29tdf#45904 Move _XDocumentAuditing Java test to C++Jens Carl1-0/+47
Change-Id: Ic03e42c9c2ff27579b442dc8d1408deaea839ec4 Reviewed-on: https://gerrit.libreoffice.org/56644 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-06-28Curious inconsistency of SvxPageModelItem copy functionsStephan Bergmann1-7/+0
...where the implicitly-defined copy ctor will copy the bAuto member while the user-provided copy assignment op does not. The code is like that ever since at least c779feb1dfa340d61902dcd9d0b754046ffd8e5b "INTEGRATION: CWS hedaburemove01". The bAuto member is only used in Put/QueryValue with MID_AUTO, but MID_AUTO appears to be effectively unused? So lets assume that the user-provided copy assignment op is like that due to a (presumably harmless?) accident, and make it implicit, too. (Avoids -Wdeprecated-copy with GCC trunk towards GCC 9.) Change-Id: I4e3156305e2b9862d337074105edc4317538af1f Reviewed-on: https://gerrit.libreoffice.org/56592 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-28tdf#107690 OOXML import/export of setting "Open as read-only"László Németh1-1/+1
Import custom document property _MarkAsFinal as LoadReadonly setting, export LoadReadonly as _MarkAsFinal in DOCX, XLSX and PPTX documents. Before this fix, LibreOffice opened read-only OOXML documents as editable, also saved and exported _MarkAsFinal=true silently, resulting unintented read-only warning info bar in MSO. This commit improves interoperability a lot, because this is a basic document protection of MSO, recommended on its UI. Note: LoadReadonly (on File->Properties...->Security, property "Open file read-only") doesn't show "Edit read-only" info bar from commit 630186ff4e0eba7317e542f8c3eca39ebd068721, but it's still possible to switch on editing by Edit->Edit Mode. MSO shows info bar for _MarkAsFinal. (There is an advantage to hide the info bar in LibreOffice in a mixed environment, to avoid overwriting of press-ready MSO files by LibreOffice.) Note 2: Other differences of LoadReadonly in LO and _MarkAsFinal in MSO: (1) Switching on editing doesn't remove the LoadReadonly property automatically in LO. (2) Saving with LoadReadonly doesn't switch off editing of the actual (still opened) document in LO. Change-Id: Ie279c0670090d075103384cfa44ff1c2a2898216 Reviewed-on: https://gerrit.libreoffice.org/56180 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-28tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk1-1/+2
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-28tdf#42949 Fix IWYU warnings in include/osl/*hGabor Kelemen5-8/+12
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib2301526d7aa6982af6c8c79ed7e9a4c34b7bbf7 Reviewed-on: https://gerrit.libreoffice.org/56491 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-27xmloff: prevent embedding same font files with checksummingTomaž Vajngerl1-1/+4
When embedding fonts to ODF documents we can get into a situation where the same font is embedded multiple times and this wastes space. To prevent this we calculate the checksum of the font first and track the fonts that are embedded. When the font has the same checksum, the path to already embedded font is returned. Change-Id: I087c42d9a63b1697b9b4ea985dbce2fda760a996 Reviewed-on: https://gerrit.libreoffice.org/56507 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-27salhelper::SingletonRef copy ctor is broken, mark as deletedStephan Bergmann1-1/+4
If that (implicitly defined) ctor had ever been used, it would have failed to increment m_nRef, so could have caused m_pInstance to be deleted too early. So better mark it as deleted. (LO itself apparently didn't call it. If 3rd party code would want to call it after all, it could be changed from deleted to properly user-provided, incrementing m_nRef, in the future.) The implicitly defined copy assignment op happens to already do the right thing, and /is/ used, e.g., during > m_aNode = _rhs.m_aNode; in DriversConfig::operator= (connectivity/source/commontools/DriversConfig.cxx). Mark it as defaulted to avoid -Wdeprecated-copy with GCC trunk towards GCC 9. Change-Id: I527123d9de837c311d30a270feb09dc173d9f411 Reviewed-on: https://gerrit.libreoffice.org/56512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-27tdf#114845 sd: only shift rotated group itemsJustin Luth1-0/+2
fixes 6.0 commit 9ae1e094d5a8a5b4432c88ebea0ca9fc1c79f602 > PPTX export: correct position of rotated groups However, there was nothing excluding the re-positioning to only group items. Change-Id: I62e36b46c0d2ac3e41f8d7d4ed82df11e6eb1ee5 Reviewed-on: https://gerrit.libreoffice.org/56386 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-06-27fix thread-unsafe return of a reference to a staticLuboš Luňák1-2/+2
The Mapping struct is small, so there's no need to reuse it. Without this, sc/qa/.../sumif_wildcards.fods sometimes fails with calc threading. Change-Id: If1f370bebe8e1afa14f8645d843a056b6f0dbdea Reviewed-on: https://gerrit.libreoffice.org/56449 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-06-26More Implicit intersection computationDennis Francis1-3/+13
Do implicit intersection computation for for single parameter functions while generating RPN token array when the argument is a doubleref with relative row references. This optimization is not done when under forced array mode or matrix formula mode. The computation logic was already present in ScInterpreter, so factored it out and reused. This also adds unit tests to ensure correctness of II computation for various cases. Change-Id: I509c3f6f811aa036b1dc3296e8f68904b26c3c49 Reviewed-on: https://gerrit.libreoffice.org/53885 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-26tdf#117620 Localize the temporary IgnoreAllList dictionarys nameGabor Kelemen1-1/+1
Also give it a human readable original name Change-Id: I86060badac145e7b60cf7dc2e67e16e7c84c2837 Reviewed-on: https://gerrit.libreoffice.org/56143 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-06-26tdf#114227: Add support for PAC to ucbhelper::InternetProxyDecider on WindowsMike Kaganski1-2/+2
Change-Id: I62c76efb354949699615a44d9482df24e3eaa314 Reviewed-on: https://gerrit.libreoffice.org/56433 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-25weld SwWatermarkDialogCaolán McNamara8-27/+166
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-25loplugin:useuniqueptr in SvxLineTabPageNoel Grandin1-5/+0
and move SvxBmpItemInfo inside cui/ since it is only used there. Change-Id: Ic80a8cace9e4664af18baddce3398e826e4c4851 Reviewed-on: https://gerrit.libreoffice.org/56323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25Kill the useless PaletteManager "last color" thingMaxim Monastirsky1-4/+0
Change-Id: Iafd4677460bf6ee2cc5bb7cd3f67c2719865a151 Reviewed-on: https://gerrit.libreoffice.org/56360 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-25tdf#117987 tdf#118138 Compare with the currently used colorMaxim Monastirsky1-1/+0
... when deciding whether to toggle highlighting. Had to move the whole thing into sw, as otherwise there is no way to correctly handle the "brush" mode (as the toolbox controller in svx has no way to know in advance which text will be selected by the user). Change-Id: Id2dec4c3647332e82260d12da1311b249f5b9c12 Reviewed-on: https://gerrit.libreoffice.org/56358 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-24vcl: treat description of cv** & ss** font features speciallyTomaž Vajngerl1-1/+3
To avoid adding descriptions for each of font features cv** and ss**, where ** is a number between 00-99, process them separately and just use one description for each. This simplifies translation as we don't need to add 99 copy-paste translations but add a bit more complexity when looking up the descriptions. Change-Id: Ia6e9554af20355c90c73afeec33fd18c694865b9 Reviewed-on: https://gerrit.libreoffice.org/56317 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-22oox: encryption/decryption test for Standard2007EngineTomaž Vajngerl2-4/+5
Change-Id: I8de25182c40004edffad4452179f191a75f130d9 Reviewed-on: https://gerrit.libreoffice.org/56300 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-22Fix typosAndrea Gelmini1-1/+1
Change-Id: Ia3590ef4fd38f1a71badefb867117a1c08a591c6 Reviewed-on: https://gerrit.libreoffice.org/54569 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-06-22teach useuniqueptr loplugin about calling delete on a paramNoel Grandin2-7/+5
which is often a useful indicator that the callers can be made to use std::unique_ptr Change-Id: Idb1745d1f58dbcf389c9f60f1a5728d7d092ade5 Reviewed-on: https://gerrit.libreoffice.org/56238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-22Resolves: tdf#118251 decide what parent colorpicker should have...Caolán McNamara1-0/+6
depending on if launched from a listbox within a dialog, or from a (potentially) ephemeral toolbar Change-Id: I5d3b5cc6dd501490b99b46250e2729fb8bc2a2e2 Reviewed-on: https://gerrit.libreoffice.org/56297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-22Resolves: tdf#115816 simpler fix for masterCaolán McNamara1-2/+1
Change-Id: Ibafd041728624e781b5da44a0b484206f760d4d0 Reviewed-on: https://gerrit.libreoffice.org/56248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-22tdf#42949 Fix IWYU warnings in include/sal/Gabor Kelemen2-2/+10
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I62758fd7c9d932c5a390739774b112356006a937 Reviewed-on: https://gerrit.libreoffice.org/56062 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-21Resolves: tdf#115816 second 'Insert' menu is pasteCaolán McNamara1-1/+2
reuse existing translation to be backportable wrt no new translations Change-Id: I1fb94f66d696f836e8f6a10ba2d6933f69cfac95 Reviewed-on: https://gerrit.libreoffice.org/56225 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21ofz#9023 Undefined-shiftCaolán McNamara1-1/+2
Change-Id: I167461e51bdc1fd68120a9d482ca7b08205a93f2 Reviewed-on: https://gerrit.libreoffice.org/56226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21take the surface directly from the SvpSalVirtualDeviceCaolán McNamara1-1/+2
Change-Id: I5e0d46fa863a9a74063063cc3d22ea15d2544d8b Reviewed-on: https://gerrit.libreoffice.org/56208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21now unused fieldCaolán McNamara1-3/+1
Change-Id: I96b3492d2bba0721076546192e3037699354441a Reviewed-on: https://gerrit.libreoffice.org/56209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21merge GenericSolarMutex and SolarMutexNoel Grandin1-45/+18
Since nothing else is implementing the SolarMutex abstract class. Change-Id: I2a41254af3e9c7534033cdd0bece9dd8e0258b9d Reviewed-on: https://gerrit.libreoffice.org/56153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin1-1/+0
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara3-5/+5
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>