summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2020-02-21Drop o3tl::optional wrapperStephan Bergmann34-171/+125
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:unusedmethodsNoel Grandin11-20/+0
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:unusedfieldsNoel Grandin1-2/+0
Change-Id: Ic036265f4e0b41108c5b72f0142b0aaf88d10713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89118 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:unnecessaryvirtualNoel Grandin3-4/+4
Change-Id: I47f0bfe8b1968ea33b0c20b06ef7d3eea3f29a61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:singlevalfieldsNoel Grandin1-1/+0
Change-Id: I9ff752b06facfbb04c10c8f9b46b650143b02ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19sw table cell borders: add optional Word-compatible border collapsingMiklos Vajna1-1/+6
We always compared border width and other aspects only after that, Word works with border weight according to their implementer notes. So extend svx::frame::Style to be able to collapse borders using weights and opt in for that from sw/ in case a compat mode (which is related to tables, off by default and is set by the DOC/DOCX import) is set. Change-Id: I1f682789302c88a0d326c6c0263ad3007441cb24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-19can avoid including svtools/ctrlbox.hxxCaolán McNamara1-5/+4
Change-Id: I953089dd1416cd24721241fff3a6d21354211a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19Resolves: tdf#130762 honour "wrap" in FormattedFieldCaolán McNamara1-0/+1
Change-Id: Iefd9a537aa358eab179cf6f0eeb6f80a9a77284a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19drop newly unused methodsCaolán McNamara1-2/+0
Change-Id: I390134b3cd0187f0adcced3625ad0a3a26f8fe28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19move svtabbx.hxx to vcl/toolkitCaolán McNamara13-17/+17
Change-Id: Id4cf566f896b15b8d4e4cafbb92a990cedb447e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19weld WatchWindow panelCaolán McNamara2-0/+3
Change-Id: Idb43d7bd168ce37fce8694946be6c7de7ca5a2c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88930 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-19use FILE_ATTRIBUTE_TEMPORARY on Windows for temp filesNoel Grandin1-1/+2
which acts as a hint to the OS that these files do not need persistent storage. If there is sufficient system RAM, these files will never even hit disk. Change-Id: I25b83aad67fda58ec39cead8bd1eb038892d3cde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18Resolves: tdf#130757 Add Minangkabau [min-ID] to language listEike Rathke1-0/+1
Change-Id: I901e64c223723bf2eac908dda80796a7a2799147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88985 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18tdf#80194 UI: revert subscript DFLT_ESC_SUB to 8% (from 33%)Justin Luth1-2/+2
Originally this was at 8%, but long ago for some reason that I couldn't find, it was changed to match superscript's 33%. This primarily affects UI for editeng. 33% was completely wrong. It puts the subscript WAY too low. The font's descent is only 20% of the total font height, so to lower the character by 33% pushes it below the line instead of towards the bottom of the line. Many export fixes that match the formula which calculated the values for DFLT_ESC_AUTO_* were made to LO6.4 for tdf#127316. Changing this default suprisingly has almost no effect. Import and export do not depend on a specific escapement to determine whether to treat it as automatic or not. That is generally handled with special keywords, or in the case of RTF with a +1 on the nPROP value. Writerfilter's use is in a never-to-be-encountered failsafe edge-case. HTML's import is affected, but for the good, so I made it into a unit test. Primarily it affects the UI dialog - suggesting 8% when automatic checkbox is cleared, and the biggest impact comes with the toolbar button for Draw/Impress which don't set "automatic" mode, so they just take the DFLT_ESC_SUB value. Looks much better now. And that was the heart of the bug report - that editeng defaults for subscript were way off. Change-Id: I6769072d483467e86fea82dfc534eb5e04802491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88910 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-02-18rename XML_OLD_NAMESPACE_ constantsNoel Grandin1-12/+12
so I can use them with the XML_ELEMENT macro, which expects them to start with "XML_NAMESPACE" Change-Id: If8098448f451675aaff8ca2dcf9544e765cda965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88928 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-18move svmedit.hxx internal to svtoolsCaolán McNamara1-39/+0
Change-Id: I52469e2029f292e7d5e9002cb9d098c14576a00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara1-2/+2
Change-Id: Id3e20d4eebb02f0022b138dfcd835ea70f1417f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara1-3/+3
Change-Id: Ibacffee0520d7525d552820713f3d4d620e1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move SVTXFormattedField, SVTXCurrencyField, SVTXNumericField to toolkitCaolán McNamara1-0/+125
Change-Id: If22200a4f342d4d779c612dbace61a4cf99471ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move NumericBox to vcl/toolkitCaolán McNamara2-21/+20
Change-Id: I3f51e917eb1979bf93f2233ec54abc31af8ef51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara2-2/+6
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Resolves tdf#129032 - Missing warning when renaming pageHeiko Tietze1-0/+1
Edit field has type normal or error now Edit field and okay button return feedback per tooltip Change-Id: Ib2caf3280227cb00af25889ed111503745b471dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85101 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-17inline some acquire/release callsNoel Grandin8-56/+80
because these are all on the hot path, and in the best case, with enough inlining, the compiler can skip the call altogether and just do a locked CMPXHG instruction Change-Id: I099d6385f602e40e1767f9f1002b7514ecf436e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-16use fwd decls of StatusBarCaolán McNamara2-3/+3
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16use fwd declsCaolán McNamara2-2/+4
Change-Id: I06a4049d84d3ef755b713c045f686361782bdfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88807 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16move some headers inside sfx2/Noel Grandin31-1936/+0
Change-Id: I806735926661ae4a666725f970ee86f0cb816a49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88562 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-15allow workben tests to use theseCaolán McNamara11-11/+11
Change-Id: I01c69617c828dd50d00af35f38da465d9d4dd261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-15convert XML_STYLE_FAMILY to scoped enumNoel Grandin13-94/+102
Change-Id: I5335b0190a2f5a8111993c0c9c224c8a6a8f0cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14Fix typoAndrea Gelmini1-1/+1
Change-Id: I314345471928d61b11cc88858f84146534c74d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88746 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14remove recently unused functionsCaolán McNamara1-5/+0
Change-Id: Ie7645d7f9b8350d3a993c40541747dc8ac817ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara1-3/+3
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#130655 callback interface for 3D and secure dashArmin Le Grand2-3/+11
Added same interface for 3D but just for lines, it uses no gaps. Added the security mechanism mentioned in the task in comment (2) to 2D and 3D Change-Id: I5da303c01562088682d95ee4f294c99e1f17bf6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88728 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-14convert XMLEventsImportContext to fastparserNoel Grandin3-7/+12
for now, it supports both fast and non-fast methods, since it is constructed by both contexts Change-Id: I925c50be161b95ecebd951cb7038a938c848a15d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#130655 added callback interface to ::applyLineDashingArmin Le Grand (Collabora)1-1/+23
This version of the tooling method allows to avoid collecting line snippets in a return value PolyPolygon. Instead, offer lambda functions to get callbacks for created snippets. The original method using a B2DPolyPolygon return value is adapted to already use this, so serves as example of usage and ensures that only one identical algorithm is used. Change-Id: Ie306968a895ad280fc2425fb40b3244769216ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88684 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara2-3/+8
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara3-31/+72
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara3-5/+11
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara1-4/+10
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move dialog.hxx to vcl/include/toolkitCaolán McNamara2-1/+5
Change-Id: Ia3877f58b6e5ccc4fb1621e6b928638e0c850e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move VCLXFileControl to toolkitCaolán McNamara3-2/+49
Change-Id: I39bb417fe7e033a8f368fa04d4a30b2388bcddfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#130573 labels exchanged in export to BMPNoel Grandin2-0/+29
In the commit below, I removed the 1-bit dithered output, so restore it. regression from commit b5699cd01b6a52906880c107bac6f3802ea7353d Date: Wed Feb 8 16:18:32 2017 +0200 convert BmpConversion to scoped enum Note that this bug has been around since LO5.4 which means that anyone who has adjusted their setting in officecfg/registry/schema/org/openoffice/Office/Common.xcs with key BMP runs the risk of having that setting now revert to its prior (documented) meaning. Change-Id: Ibbda8aefbac261ff37ffab7223714f5d0343c692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13Restore simple undo and redo buttons for the basctl moduleMaxim Monastirsky1-14/+0
Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module. These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo. This commit removes the unused controller, and restores the previous behavior with the other controller. Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13weld FindTextFieldControlCaolán McNamara1-0/+2
Change-Id: Ib5861855d37c72d2be2b11b77173a141db90444e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13extract NaturalSortCompare from ListBoxCaolán McNamara2-2/+19
Change-Id: I260c83778aea06eba9ae774739c6dc31fe5366d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Fix typoAndrea Gelmini1-1/+1
Change-Id: I63e1634114ca436d7fb4f8afe4cb7a0ac7824209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88624 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-13factor out dialog hacksCaolán McNamara2-1/+29
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13use TopLevelWindowLocker for the lock other windows problemCaolán McNamara1-3/+0
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13make OpenGL blacklist file code generic and use it for Skia/VulkanLuboš Luňák1-0/+1
Change-Id: Icc150b853f5d2d06afedcb7878f6a031aff57c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt1-0/+2
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara1-0/+1
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 22:35:39 +0000