summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2017-12-08GetMarkableObjCount() is only compared against 1Matteo Casalin1-1/+2
Change-Id: I390b260fe481c7db73a065dd271c78a5df188ccc
2017-12-08Remove unneeded data memberMatteo Casalin1-1/+0
Change-Id: I9d007f67e5f6024b1eaea10669a915ffd33d7c29
2017-12-08Data members to enumsMatteo Casalin1-7/+9
After 1d852b32d7ad89b2317c04958060f366f8922ca4 these data members were initialized only in constructor and never changed afterwards, behaving de-facto as constants. Convert them to an enum and take the chance to change their type from sal_uIntPtr to size_t. Change-Id: Ief33b7d3cfd3e181837f77c5b8a51812e314121d
2017-12-08gpg4libre: add error string for failed/untrusted encryptionThorsten Behrens1-0/+1
There's one rather common failure mode with gpg, in that untrusted keys are not accepted by gpgme for encryption. A user can override that with --trust-model config or cmd line params, but we can't do much from the gpgme client side: https://www.gnupg.org/documentation/manuals/gnupg/GPG-Configuration-Options.html Change-Id: Ia140a7fd25bd3f428aa11a7ceb0b7bdc47b2c900 Reviewed-on: https://gerrit.libreoffice.org/46060 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin1-3/+3
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08use std::unique_ptr in SvNumberFormatterNoel Grandin1-1/+2
Change-Id: I78f83c427c3df16e26fbe3d8a3e00a1279e5ed2d Reviewed-on: https://gerrit.libreoffice.org/46028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-08tdf#45904 Move _XDataPilotField Java test to C++Jens Carl1-0/+34
Change-Id: I5ba1733a8e675048366651aa5f3affc9c249622c Reviewed-on: https://gerrit.libreoffice.org/46066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08tdf#45904 Move _XDataPilotTables Java tests to C++Jens Carl1-0/+35
Change-Id: I5a452f10799f78a6f83136bec4e1346c4ec8edf8 Reviewed-on: https://gerrit.libreoffice.org/46063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08tdf#68759 PPTX: Export IsMirroredPaul Trojahn1-1/+1
Change-Id: I6bab00f79f1cb122344e4bb9fd62eb4c48a1838b Reviewed-on: https://gerrit.libreoffice.org/45808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-07lokit: add .uno:DocumentRepair commandHenry Castro4-3/+15
Change-Id: I5b13ea6f4785bc91c29111fa63c4a1b0ea9b2660 Reviewed-on: https://gerrit.libreoffice.org/38908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-07gpg4libre: permit multi-select encrypt certThorsten Behrens1-0/+1
And pass down all necessary parameters everywhere Change-Id: I152b9d84c0e35be9e5193a9a6f67de9fb86133b0
2017-12-07SwFrameBorder: Use enhanced FrameBorders for CharacterArmin Le Grand1-0/+35
Adapted PaintCharacterBorder to also use new, enhanced FrameBorders. Adapted some places, cleaned up old code, enhanced tooling method CreateBorderLinePrimitivesForRectangle, tested including PDF, Pint, PrintPreview. Change-Id: If7b793b6520e899bde6f4211c993847af21ce7b9
2017-12-07lokdialog: Make hyperlink dialog workPranav Kant1-0/+1
Change-Id: Ifd8c721b001b09ddab8d4fe06ae6818980d6ee76
2017-12-07loplugin:salcall handle static methodsNoel Grandin11-41/+41
Change-Id: Id6820abec4b8ca8bee26d62b333fd30b42a14aec Reviewed-on: https://gerrit.libreoffice.org/46007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:constparamsNoel Grandin2-2/+2
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:countusersofdefaultparams in basctl..basegfxNoel Grandin3-9/+9
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241 Reviewed-on: https://gerrit.libreoffice.org/45957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:countusersofdefaultparams in comphelperNoel Grandin2-2/+2
Change-Id: Idb704adbe78a42bf2f2aaf7f6110698d5559e836 Reviewed-on: https://gerrit.libreoffice.org/45936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:countusersofdefaultparams in connectivityNoel Grandin5-9/+9
Change-Id: Ia613257f2de1395c6629c1c37026ed48d4b927c8 Reviewed-on: https://gerrit.libreoffice.org/45854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07tdf#45904 Move _XDataPilotTablesSupplier Java test to C++Jens Carl1-0/+34
Change-Id: Iaea5b7abc0a289035c7a230c0034d2422cc4ae5f Reviewed-on: https://gerrit.libreoffice.org/46001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-06tdf#114122 - Double click in special character dialog inserts a characterMark Vecsernyes1-0/+2
Change-Id: I8f8db851363344091294e2af43aba289ac160d98 Reviewed-on: https://gerrit.libreoffice.org/45952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann7-2/+10
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06unotools: remove not needed UcbStreamHelper inheritanceMiklos Vajna1-1/+1
This class only has static member functions, nothing requires that inheritance. Change-Id: I31db802d0a9dcda01772b1e09a68af770868358d Reviewed-on: https://gerrit.libreoffice.org/45924 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-06lokdialog: Window* -> VclPtr<Window>, and a small simplification.Jan Holesovsky1-2/+4
Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195 Reviewed-on: https://gerrit.libreoffice.org/45900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-06coverity#1401328 Uncaught exceptionCaolán McNamara1-1/+2
Change-Id: I358b3c410bc7871c7184da4959b24b9f52b4a4d7 Reviewed-on: https://gerrit.libreoffice.org/45892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06loplugin:salcall handle virtual methodsNoel Grandin2-2/+2
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42 Reviewed-on: https://gerrit.libreoffice.org/45851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05tdf#45904 Move _XFunctionDescriptions Java test to C++Jens Carl1-0/+34
Change-Id: Ie2c8e55cabd6adcd523baf2f75c5f2decaf8fe87 Reviewed-on: https://gerrit.libreoffice.org/45772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-05tdf#45904 Move _XRecentFunctions Java tests to C++Jens Carl1-0/+36
Fix for #i84761. Change-Id: I3ea608ce60ecc274bc2af9eb1d8117372b663a6f Reviewed-on: https://gerrit.libreoffice.org/45637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin22-86/+86
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:countusersofdefaultparams in editeng..packageNoel Grandin2-6/+6
Change-Id: I4c20235a04d9ab5ea5edbb6b1b2413677b18a305 Reviewed-on: https://gerrit.libreoffice.org/45795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05remove some unused definesNoel Grandin3-16/+0
and move the script to python Change-Id: I97bca04053d9d38b59c74fcf61caafbc2c137cc9 Reviewed-on: https://gerrit.libreoffice.org/45776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04Add Plautdietsch [pdt-CA] to language listboxEike Rathke1-0/+1
Change-Id: Icf2307649858721a7cde38e8fa892fc3cb1ff08c
2017-12-04tdf#83877 ODF extension to write signature linesSamuel Mehrbrodt1-0/+1
This adds a <loext:signatureline> element to draw:image if the image is a signatureline. Example: <draw:image xlink:href="..."> <loext:signatureline loext:id="..." loext:suggested-signer-name="..." loext:suggested-signer-title="..." loext:suggested-signer-email="..." loext:signing-instructions="..." loext:show-sign-date="true" loext:can-add-comment="false"/> </draw:image> Change-Id: I4d77acec528175fba66556661ab74462f5bd875f Reviewed-on: https://gerrit.libreoffice.org/45153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-04lokdialog: multiview: Do not mix one view with otherPranav Kant1-1/+2
In GTV, use correct application window object to fetch the dialog object. Use correct view shell to notify window (dialogs, etc.) callbacks. Change-Id: I7d82b39d4522a4b4904e156757a032c342c71efb
2017-12-04lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant3-42/+12
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
2017-12-04lokdialog: Rename postDialogKeyEvent -> postWindowKeyEventPranav Kant2-4/+4
Change-Id: I78b434106fbef153adde255d4fcc8f74a7169175
2017-12-04lokdialog: Simplify; make the LOK dialog API more genericPranav Kant9-52/+5
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2017-12-04lokdialog: Kill some code; use already existing method to paintPranav Kant2-4/+0
This is not require now in the new approach where the dialog is already created by the time paint request call for dialog happens. Layouting is already complete by that time. Change-Id: I610b050a268e61e8d4036aa7eb5766cf0c8b37e0
2017-12-04lokdialog: Allow closing a dialog from LOK clientPranav Kant3-8/+25
... and rename paintDialog -> paintWindow before it's too late. We not only render dialogs now but also popups. Change-Id: I6b1253c4d9be0c79199b683df4413658a461f850
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin1-3/+3
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-02Replace list by vector in xmlexp (xmloff/sw)Julien Nabet1-1/+2
Use for-range loop with "auto" to modernize a bit Change-Id: I9efd7ad2d60eac6a6ce0f79af6ccb02ec235c35d Reviewed-on: https://gerrit.libreoffice.org/45711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-02Get rid of the css::util::NumberFormat::TEXT abuse as "special" "key"Eike Rathke1-0/+4
It is a bit, not a key, which demanded special treatment at all places, and a key with the same value could not be handled at all. Abusing the css::util::NumberFormat::TEXT flag as number format key to signal the "special" meaning, having a number format key equal to that value would had resulted in undesired behaviour. The bit value is 256 and a key 256 means 156 user defined number formats in the default locale, rarely in the wild but can happen. Change-Id: Idfd5b07d524c222df3491d201095ef65ad4a46c9 Reviewed-on: https://gerrit.libreoffice.org/45705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-02Revert "tdf#105000, related tdf#87538: Make new color names translatable"Yousuf Philips1-23/+0
No need for this if we will be removing tango and we shouldnt have translators waste time translating it if so. https://bugs.documentfoundation.org/show_bug.cgi?id=113858 This reverts commit 6999bafb8675461a7f1400880eabd2daffe96ba4. Change-Id: I7b6fe1fc84530bdbc002fcb2857942ddf268c88e Reviewed-on: https://gerrit.libreoffice.org/44837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-01tdf#102160 make 'Other CMIS' string localizableAndras Timar1-0/+1
Change-Id: I58cf9eea05f15223e32ff1542b946c5962041e6c Reviewed-on: https://gerrit.libreoffice.org/45577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-12-01tdf#45904 Move _XMultipleOperation Java tests to C++Jens Carl1-0/+39
Change-Id: I102b726e673f69bfe64eff7e28e380dd6f15f1f8 Reviewed-on: https://gerrit.libreoffice.org/45629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-01Prepare for translated new AutoFormat Table Styles, tdf#101349Eike Rathke1-0/+12
Stored in file are resource IDs for predefined style names, user defined styles are stored with ID 0xffff and display the given name. The 16 old styles have IDs 0..15, so add strings for the 10 new styles and append those to the already existing IDs assigning them the range 16..25 Once the final autotbl.fmt file with only new styles will be available, patch that to change the 0xffff user defined to those 16..25 (0x10 to 0x19) IDs, it is the uint16 immediately following the style name (Little Endian). Order of styles should match the one in this change, if not, change the change.. Also, this eliminates the duplicated translation entries in sw/inc/strings.hrc and instead in sw/source/core/doc/DocumentStylePoolManager.cxx pulls the translations from include/svx/strings.hrc Change-Id: I7827ae22ab05901e6580ff1b9cd812db55f94f7f Reviewed-on: https://gerrit.libreoffice.org/45544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-01loplugin:unusedfieldsNoel Grandin1-4/+2
The mnRequestedLength fields in formula/ were introduced in commit 6ef6dd0122b8e44d8547ec31f40def42173e4e41 Author: Kohei Yoshida <kohei.yoshida@collabora.com> Date: Wed Feb 26 14:32:57 2014 -0500 Store the length of originally requested array size prior to trimming. but then partially removed in commit d7f1f91b194da1cb96e66268ce7ef38602aa5754 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 3 13:29:43 2014 +0200 remove unused code in formula/vectortoken Change-Id: Ic56b6e42682131ee45df7838867145f980f3d601 Reviewed-on: https://gerrit.libreoffice.org/45571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-01lok: calc: set outline stateMarco Cecchetti3-13/+30
use a specific message from the client for set the visibility state of a group instead of hijacking the update row/column header message Change-Id: I9634c24bbffaddc916c8ad716ac6d5d31e735a55 Reviewed-on: https://gerrit.libreoffice.org/45445 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-11-30xmloff: turn SvXMLImportContext into a no-op base classMichael Stahl1-1/+3
Fix the non-obvious and potentially dangerous recursion that is implicit in xmloff's context code. SvXMLImportContext::CreateChildContext() now always creates a SvXMLImportContext, does not delegate to SvXMLImport. Rename CreateContext to CreateDocumentContext, to make its purpose of creating only the top-level context more obvious. With the previous changes to CreateContext overrides in sw, reportdesign and dbaccess, this hopefully shouldn't break anything. Change-Id: I9e147bf6297bbac9e8470454881da73f6e39db0a
2017-11-30tdf#114124 Translate 'PNG Bitmap' string in Calc Paste dropdownGabor Kelemen1-0/+1
Change-Id: I8356f241d0742276cf32aa301c35055a7f3c5898 Reviewed-on: https://gerrit.libreoffice.org/45447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30silence various coverity warningsCaolán McNamara1-1/+2
Change-Id: I9ac4c179c30efa9d5950aa2106639d3781dd0308 Reviewed-on: https://gerrit.libreoffice.org/45583 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 17:48:06 +0000