summaryrefslogtreecommitdiff
path: root/include
AgeCommit message (Collapse)AuthorFilesLines
2017-04-28loplugin:salunicodeliteral: basicStephan Bergmann1-1/+1
Change-Id: I479666b439f1d6324f07253d65181983b7c2c3ea
2017-04-28loplugin:salunicodeliteral: comphelperStephan Bergmann1-1/+1
Change-Id: I0642d85d92152414d1d110b88a8194363ff4d618
2017-04-28loplugin:salunicodeliteral: editengStephan Bergmann1-2/+2
Change-Id: I5db29ba3505d914ec05826128713d7e25091ed11
2017-04-28loplugin:salunicodeliteral: svlStephan Bergmann2-5/+5
Change-Id: Iaa5b97267b6487c37744bd08d21c82015da9d522
2017-04-28loplugin:salunicodeliteral: svxStephan Bergmann1-1/+1
Change-Id: Ida6122d53ed5debc4da6b1649f61607df852af23
2017-04-28loplugin:salunicodeliteral: vclStephan Bergmann2-2/+2
Change-Id: I4a982da10ad76f8ae05355cec9629b906c95afdb
2017-04-28loplugin:salunicodeliteral: xmloffStephan Bergmann1-1/+1
Change-Id: I751006fd054882a9ceab424675ac0505a9ddfd8b
2017-04-28move builder attributes from OString to OUStringCaolán McNamara14-58/+68
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28Adapt documentation to realityEike Rathke1-4/+4
Change-Id: Ic76cdff3c95e68e91700ca7143e8aa8c908ed56e
2017-04-28Printing of some more basegfx typesStephan Bergmann2-0/+29
...as will be needed by some upcoming replacements of CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL Change-Id: I24ede3cc287bcc3b5e73eb400e4044c469657659
2017-04-28Make some basegfx operator << found by ADLStephan Bergmann5-54/+54
...as will be needed by some upcoming replacements of CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL Change-Id: I7c861f1cb81de4540e88d89dbf095acc61a56503
2017-04-28LIBO_INTERNAL_ONLY: printing of css::uno::Reference/TypeStephan Bergmann2-0/+27
...as will be needed by some upcoming replacements of CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL Change-Id: Ie2b2b982b02f2bf48e2e8be7ba642198029c8698
2017-04-28loplugin:checkunusedparams in accessibility and avmediaNoel Grandin1-2/+1
Change-Id: I94df9a65578792fb06f3b3259603f70ca1e0b3db Reviewed-on: https://gerrit.libreoffice.org/37059 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28another name for a nonlocalized string is a stringCaolán McNamara1-2/+0
Change-Id: I165d74c59d1cccba295072a3df7b9f54dfb60449
2017-04-28loplugin:unusedfieldsNoel Grandin1-1/+0
Change-Id: I67a0372d6982648717651f736c51e447d0b7d6a2 Reviewed-on: https://gerrit.libreoffice.org/37047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#107020: Reintroduce uses of I32S, I64SStephan Bergmann1-0/+6
...that had been removed with 4b788a12380518e31a9064d5839f4880d3f36874 "There should be no need to distinguish between I32S and I64S" (which this commit effectively reverts). I had erroneously assumed that the arguments to I32S and I64S would only be of (signed) integer types, and that it would be irrelevant that they are truncated to sal_Int32 resp. sal_Int64. However, at least oox/source/export/drawingml.cxx called I32S with double values (for which there is an OUString::number overload too), so the resulting strings could be rather different. Change-Id: Ib3887269fad0764740bc9ed3be91f67696a23b55 Reviewed-on: https://gerrit.libreoffice.org/37040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-27remove ResourceBasedEventLogger in favor of its base EventLoggerCaolán McNamara1-117/+8
because there are no resources in use anymore Change-Id: I37e4a100aabbf6214533738da3e528ed2f434eae
2017-04-27drop unused comphelper::EventLogger::logpCaolán McNamara1-80/+0
Change-Id: I833210f036356c09d6c2f9f72dde7012064b01ef
2017-04-27drop writeonly unused structCaolán McNamara1-4/+0
Change-Id: I6a7d58899991109264d86059a16b4a3a540f1491
2017-04-27the only use of this argument is sdbcl which is a deleted resource fileCaolán McNamara1-5/+0
Change-Id: I31c140dcab9a291c4ede62e56d296a224dcd47c8
2017-04-27un-default argumentCaolán McNamara1-1/+1
Change-Id: I5d60998b4c30f58ee9c734b37d3f97118db8d7cf
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara1-29/+26
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-27no bitmaps in .src files anymoreCaolán McNamara4-5/+0
Change-Id: I0228cae8590366be5d5f0d431cf655942bbb891c
2017-04-27loadFromResource is now unusedCaolán McNamara1-2/+0
Change-Id: Ibea3defdf8d2642c4ba523db7f4fc8fbc2473488
2017-04-27remove svx bitmaps from .src filesCaolán McNamara5-181/+5
Change-Id: Ie3795870484648e62dea483f9976af31cd1be167 Reviewed-on: https://gerrit.libreoffice.org/37006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock18-19/+19
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: change pImpl class names to fit with existing conventionChris Sherlock1-6/+6
Change-Id: Iec6ce77f922df222d48240be09a817f5289a6662 Reviewed-on: https://gerrit.libreoffice.org/36861 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: move doxygen comment to headerChris Sherlock1-0/+15
Change-Id: I486843fc4b9da3fc5fc161e90768b0443530071a Reviewed-on: https://gerrit.libreoffice.org/36859 Tested-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: lUserId -> nUserIdChris Sherlock1-32/+34
Change-Id: I7617b25b1d63fc2926c1b500830ba3c1ddc8105c Reviewed-on: https://gerrit.libreoffice.org/36857 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: minor whitespace cleanup in errinf.hxxChris Sherlock1-6/+6
Change-Id: I00e2fc57f4d277ed03fd3f02614eb6372d272551 Reviewed-on: https://gerrit.libreoffice.org/36856 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: rearrange functions in errinf.hxxChris Sherlock1-37/+39
Change-Id: I55100d90d342c657db7aed34dcf1a40440955381 Reviewed-on: https://gerrit.libreoffice.org/36855 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: move RegisterDisplay() from ErrorHandler to ErrorRegistryChris Sherlock1-5/+42
It is the error registry that should register the display, not the error handler. Move this function to the class that is responsible for it. Change-Id: I95ca1662b907a7f38a42a39ec729b35fd530bb79 Reviewed-on: https://gerrit.libreoffice.org/36853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: ErrorHandler_Impl renamed to ErrorStringFactoryChris Sherlock1-2/+2
This isn't just a pImpl class, it's actually a factory used to determine which error handler should create the error strings. Change-Id: I2901a45d7c1e16608b3fbe39e9c5cd9d5cb9627b Reviewed-on: https://gerrit.libreoffice.org/36852 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26tdf#107392 ODF import: fix z-order sorting of SVG imagesMiklos Vajna2-1/+4
The problem was that in case the document has shapes where the order does not match the z-index order, so sorting is needed, then sorting failed to take the multi-image feature into account. E.g. SVG images have a PNG fallback, but at the end of the shape import the PNG fallback is removed, which means the "actual" (not the "wished") z-index of the shapes after the SVG image has to be adjusted. Without this happening SvxDrawPage::getByIndex() (or in case of Writer, SwTextBoxHelper::getByIndex()) will throw when the importer calls getByIndex(3) but we only have 3 shapes. This results in not honoring the z-index request of the remaining shapes. Regression from commit 44cfc7cb6533d827fd2d6e586d92c61d7d7f7a70 (re-base on ALv2 code. Includes (at least) relevant parts of:, 2012-10-09), from the Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement http://svn.apache.org/viewvc?view=revision&revision=1220836 part. Change-Id: Ibe880e5c6c74b728b4a760498720ee31f052b726 Reviewed-on: https://gerrit.libreoffice.org/36998 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-04-26Clean up uses of SAL_U/SAL_W: comphelperStephan Bergmann1-7/+2
Change-Id: I56976f91647c3969d5709e5f691f860bb97ed548
2017-04-26vcl: refactor ErrorHandler functionsChris Sherlock1-8/+4
Current, HandleError_Impl is called on by GetErrorString, and HandleError_Impl also creates the error string. However, when you look at what each function does, HandleError_Impl has been imbued with some extraneous parameters: 1. bJustCreateString, and 2. rError bJustCreateString is unnecessary, in fact it just mutates HandleError to create the string, which is not really the core purpose of this function. In fact, the string should be created when we get the string from the error ID (GetErrorString), and in fact the error handler function should call on GetErrorString and not the other way around! This has the happy side effect of vastly simplifying this code, and allows each of the functions only do the thing they are meant to do, and we no longer need these extraneous parameters which just cause problems for code readibility. On to of this, by simplifying the HandleError_Impl function, we just move the code into the public HandleError function because these parameters aren't necessary any more. Change-Id: I4a727b5bbc6d3cdb0519f49b48dc52f8a8976629 Reviewed-on: https://gerrit.libreoffice.org/36849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26loplugin:unusedmethodsNoel Grandin3-16/+0
Change-Id: If2e1241bbe8a3d17859e3ca076b0f55f25c48ea5 Reviewed-on: https://gerrit.libreoffice.org/36983 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26remove sfx2 bitmaps from .src filesCaolán McNamara1-13/+0
Change-Id: Ibc4261af5f479badd281211e467d2c7b524af3f3
2017-04-26Translate German comments (leftovers in include/svx/)Johnny_M16-22/+22
Change-Id: I1f4238525962d57956fd08c93e7c4d3bc52e4dc5 Reviewed-on: https://gerrit.libreoffice.org/36808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-26remove svtools bitmaps from .src filesCaolán McNamara1-113/+0
Change-Id: I13280315c2af2277d5c8d31c079075337b2c8f82
2017-04-26extend unit test for INetMIME::scanContentTypeJochen Nitschke1-1/+20
This reverts parts of commit 631b67952909a73ba1851417bd2edbe02ad7be5a and commit abc6071b7a8af354a56c91e4caecd8afc79f55cc. some of the removed fields are usefull, m_bConverted should be checked by callers fixed 2 bugs and added test cases: * extended attributes with more than 2 sections were not parsed * extended attributes with more than 1 section were not parsed if there was an other attribute Change-Id: I61ab2af7c5151ef1bcd80cc159fa2b99559374a8 Reviewed-on: https://gerrit.libreoffice.org/36913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-26use strong_int for LanguageTypeNoel Grandin18-635/+658
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock1-11/+11
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25FOOTERL and FOOTERR are write-onlyNoel Grandin1-2/+0
Change-Id: I65ed01d0bf10409282d9fe5087f5ea84cb084ddc Reviewed-on: https://gerrit.libreoffice.org/36932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tdf#75280: convert sal_uIntPtr to sal_uInt32 for ErrorInfo memberChris Sherlock2-13/+13
Change-Id: I97f3b18604f17b0ccc9fd1bbb0221ff5e11fe826 Reviewed-on: https://gerrit.libreoffice.org/36840 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock3-12/+11
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin2-4/+4
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock105-1/+106
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25loplugin:checkunusedparams in vclNoel Grandin15-33/+28
Change-Id: I26661684e634aa15a18f78442de15c9db832f319 Reviewed-on: https://gerrit.libreoffice.org/36886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24loplugin:checkunusedparams in i18nlangtag and l10ntoolsNoel Grandin2-16/+1
Change-Id: If7c7404b1cc1cf9445a2af8106f7326b76524388 Reviewed-on: https://gerrit.libreoffice.org/36883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>